| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:4d75f6c4-874b-9627-2a13-5f97e3ae06af |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DEDE:1531FB:D5A541:12C4FE7:696A6554 |
| html-safe-nonce | 62d78a5623ee2fef1407ca0fce358f8de3b5db8ad2fcfec701fc45a5cc26a466 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERURFOjE1MzFGQjpENUE1NDE6MTJDNEZFNzo2OTZBNjU1NCIsInZpc2l0b3JfaWQiOiIyODc1Njg1NjM5NTg5MzU2ODg0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c29cddd78f4c6ef60be374665930651a201c664f7b7772a8a4eb9f7f325c6cef |
| hovercard-subject-tag | pull_request:487012627 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/35202 |
| twitter:image | https://opengraph.githubassets.com/fdb033ba040e283ea6420ef04e6a2fb675f30bc4c7d08e774a2e854657c82f9c/nodejs/node/pull/35202 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/fdb033ba040e283ea6420ef04e6a2fb675f30bc4c7d08e774a2e854657c82f9c/nodejs/node/pull/35202 |
| og:image:alt | This commit provides coverage for __wasi_fd_readdir().
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cjihrig |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35202#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35202 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35202 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35202 |
| Reload | https://github.com/nodejs/node/pull/35202 |
| Reload | https://github.com/nodejs/node/pull/35202 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35202#issue-comment-box |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:readdir | https://github.com/cjihrig/node/tree/readdir |
|
test: add wasi readdir() test
| https://github.com/nodejs/node/pull/35202#top |
| cjihrig | https://github.com/cjihrig |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| cjihrig:readdir | https://github.com/cjihrig/node/tree/readdir |
|
Conversation
3
| https://github.com/nodejs/node/pull/35202 |
|
Commits
1
| https://github.com/nodejs/node/pull/35202/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35202/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35202/files |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| Sep 15, 2020 | https://github.com/nodejs/node/pull/35202#issue-701583707 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
|
| https://github.com/cjihrig |
| test: add wasi readdir() test | https://github.com/nodejs/node/pull/35202/commits/3f040fc83e1a963b2b4d113cea9885df1312432a |
| 3f040fc | https://github.com/nodejs/node/pull/35202/commits/3f040fc83e1a963b2b4d113cea9885df1312432a |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 15, 2020 | https://github.com/nodejs/node/pull/35202#issuecomment-692445917 |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Sep 15, 2020 | https://github.com/nodejs/node/pull/35202#event-3766258349 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Sep 15, 2020
| https://github.com/nodejs/node/pull/35202#pullrequestreview-488303782 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Sep 15, 2020
| https://github.com/nodejs/node/pull/35202#pullrequestreview-488778663 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
wasi
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35202#event-3770857375 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/35202#pullrequestreview-489199505 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35202#event-3770859909 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35202#event-3770894368 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35202#issuecomment-693109296 |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
| https://ci.nodejs.org/job/node-test-pull-request/33146/ | https://ci.nodejs.org/job/node-test-pull-request/33146/ |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35202#event-3771071245 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Sep 17, 2020 | https://github.com/nodejs/node/pull/35202#event-3779458052 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 17, 2020 | https://github.com/nodejs/node/pull/35202#issuecomment-694434236 |
| c314c04 | https://github.com/nodejs/node/commit/c314c04079bbf93d786a5855d0eaaed30d36820e |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/35202#ref-commit-c314c04 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
| test: add wasi readdir() test | https://github.com/nodejs/node/commit/c314c04079bbf93d786a5855d0eaaed30d36820e |
| c314c04 | https://github.com/nodejs/node/commit/c314c04079bbf93d786a5855d0eaaed30d36820e |
| #35202 | https://github.com/nodejs/node/pull/35202 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Sep 17, 2020 | https://github.com/nodejs/node/pull/35202#event-3779458565 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
| September 17, 2020 19:02 | https://github.com/nodejs/node/pull/35202#event-3779475119 |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/35202#ref-commit-8357b56 |
|
| https://github.com/cjihrig |
|
| https://github.com/ruyadorno |
| test: add wasi readdir() test | https://github.com/nodejs/node/commit/8357b56984729f59031a4584b41284fd1b3b8173 |
| 8357b56 | https://github.com/nodejs/node/commit/8357b56984729f59031a4584b41284fd1b3b8173 |
| #35202 | https://github.com/nodejs/node/pull/35202 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Sep 21, 2020
| https://github.com/nodejs/node/pull/35202#ref-pullrequest-705877178 |
|
V14.12.0 proposal
#35285
| https://github.com/nodejs/node/pull/35285 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35202#ref-commit-eb33501 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: add wasi readdir() test | https://github.com/nodejs/node/commit/eb3350180f2f24431e33895d142eef49e7a1c149 |
| eb33501 | https://github.com/nodejs/node/commit/eb3350180f2f24431e33895d142eef49e7a1c149 |
| #35202 | https://github.com/nodejs/node/pull/35202 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/35202#ref-pullrequest-735694919 |
|
v12.20.0 proposal
#35950
| https://github.com/nodejs/node/pull/35950 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/35202#ref-commit-c3e1bf7 |
|
| https://github.com/cjihrig |
|
| https://github.com/MylesBorins |
| test: add wasi readdir() test | https://github.com/nodejs/node/commit/c3e1bf78c430d3a716ba5c90b422653abe2d1d51 |
| c3e1bf7 | https://github.com/nodejs/node/commit/c3e1bf78c430d3a716ba5c90b422653abe2d1d51 |
| #35202 | https://github.com/nodejs/node/pull/35202 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/35202#ref-commit-6fa7864 |
|
| https://github.com/cjihrig |
|
| https://github.com/joesepi |
| test: add wasi readdir() test | https://github.com/joesepi/node/commit/6fa78646586a926c74bc29dcadca2479698eba18 |
| 6fa7864 | https://github.com/joesepi/node/commit/6fa78646586a926c74bc29dcadca2479698eba18 |
| nodejs#35202 | https://github.com/nodejs/node/pull/35202 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35202 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/35202/files/3f040fc83e1a963b2b4d113cea9885df1312432a |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
wasi
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Awasi |
| Please reload this page | https://github.com/nodejs/node/pull/35202 |
|
| https://github.com/cjihrig |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/gengjiawen |
|
| https://github.com/devsnek |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |