| route-pattern | /:user_id/:repository/pull/*id(.:format) |
| route-controller | pull_requests |
| route-action | show |
| fetch-nonce | v2:0980a42e-fd46-42a3-beac-f157f16076ab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A944:E8423:2825002:34FF6AD:696B23E3 |
| html-safe-nonce | 4923e990d9016b4731014a95c89a9ec5275de34fea15fb86c267f83371db7182 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTQ0OkU4NDIzOjI4MjUwMDI6MzRGRjZBRDo2OTZCMjNFMyIsInZpc2l0b3JfaWQiOiI0NzA4OTQ2NzY1Nzk0NzE0NTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0ed2473c5a59a4e3b1f8027a4b09e8fd661990cc564234d8675d6c0d584f4467 |
| hovercard-subject-tag | pull_request:486694538 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/nodejs/node/pull/35191 |
| twitter:image | https://opengraph.githubassets.com/245c3b7eeb9189ab3ac7a27a3d1065185fa419cecb2112610eb6c3c0ee0435ae/nodejs/node/pull/35191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/245c3b7eeb9189ab3ac7a27a3d1065185fa419cecb2112610eb6c3c0ee0435ae/nodejs/node/pull/35191 |
| og:image:alt | This helps catch broken links as part of the test suite. This also
improves the user experience when browsing the markdown files.
Fixes: #35189
This is currently blocked by #35182.
Checklist
do... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/35191#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35191 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35191 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/35191 |
| Reload | https://github.com/nodejs/node/pull/35191 |
| Reload | https://github.com/nodejs/node/pull/35191 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
691
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/35191#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:use-md-extension | https://github.com/aduh95/node/tree/use-md-extension |
|
doc: use .md extension for internal links
| https://github.com/nodejs/node/pull/35191#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:use-md-extension | https://github.com/aduh95/node/tree/use-md-extension |
|
Conversation
35
| https://github.com/nodejs/node/pull/35191 |
|
Commits
3
| https://github.com/nodejs/node/pull/35191/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/35191/checks |
|
Files changed
| https://github.com/nodejs/node/pull/35191/files |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 14, 2020 | https://github.com/nodejs/node/pull/35191#issue-701196227 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| #35189 | https://github.com/nodejs/node/issues/35189 |
| #35182 | https://github.com/nodejs/node/pull/35182 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Sep 14, 2020 | https://github.com/nodejs/node/pull/35191#event-3763966567 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 14, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-692126166 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Sep 14, 2020
| https://github.com/nodejs/node/pull/35191#ref-issue-701100798 |
|
doc,tools: checkLinks.js does not cover api
#35189
| https://github.com/nodejs/node/issues/35189 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/00dc8496c507af535d66515a81fc31d80725d795..53a8ef3c3fb2c4d3ceec0eb310af7a936e17d7dc |
| 00dc849 | https://github.com/nodejs/node/commit/00dc8496c507af535d66515a81fc31d80725d795 |
| 53a8ef3 | https://github.com/nodejs/node/commit/53a8ef3c3fb2c4d3ceec0eb310af7a936e17d7dc |
|
Compare
| https://github.com/nodejs/node/compare/00dc8496c507af535d66515a81fc31d80725d795..53a8ef3c3fb2c4d3ceec0eb310af7a936e17d7dc |
| September 14, 2020 16:13 | https://github.com/nodejs/node/pull/35191#event-3764237792 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Sep 14, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-488027881 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| doc/api/crypto.md | https://github.com/nodejs/node/pull/35191/files#diff-52a58775d8a5519e232893c0d176d1a7461037007ac2c8f25a2aa803b8304454 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/35191/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/5c545c2db3c140244260939aea8802e98e9531ad..a9ad53112fb25a5176713d76cd81ad3244d2a365 |
| 5c545c2 | https://github.com/nodejs/node/commit/5c545c2db3c140244260939aea8802e98e9531ad |
| a9ad531 | https://github.com/nodejs/node/commit/a9ad53112fb25a5176713d76cd81ad3244d2a365 |
|
Compare
| https://github.com/nodejs/node/compare/5c545c2db3c140244260939aea8802e98e9531ad..a9ad53112fb25a5176713d76cd81ad3244d2a365 |
| September 14, 2020 20:36 | https://github.com/nodejs/node/pull/35191#event-3765238938 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| September 14, 2020 20:38 | https://github.com/nodejs/node/pull/35191#event-3765248339 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| code owners | https://github.com/nodejs/node/blob/6eb15ce8a3bebeda605b88972ae007bafb3a1133/.github/CODEOWNERS#L70 |
| September 14, 2020 20:38 | https://github.com/nodejs/node/pull/35191#event-3765248356 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| September 14, 2020 20:38 | https://github.com/nodejs/node/pull/35191#event-3765248363 |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-489512549 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-693358204 |
| @DerekNonGeneric | https://github.com/DerekNonGeneric |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-693363671 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-489596486 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-693387569 |
| @aduh95 | https://github.com/aduh95 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-489606150 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/gengjiawen |
| gengjiawen | https://github.com/gengjiawen |
| richardlau | https://github.com/richardlau |
| September 16, 2020 13:11 | https://github.com/nodejs/node/pull/35191#event-3773124700 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/a9ad53112fb25a5176713d76cd81ad3244d2a365..8d27d130cc6b7c87ef3de21970e51866963fabb1 |
| a9ad531 | https://github.com/nodejs/node/commit/a9ad53112fb25a5176713d76cd81ad3244d2a365 |
| 8d27d13 | https://github.com/nodejs/node/commit/8d27d130cc6b7c87ef3de21970e51866963fabb1 |
|
Compare
| https://github.com/nodejs/node/compare/a9ad53112fb25a5176713d76cd81ad3244d2a365..8d27d130cc6b7c87ef3de21970e51866963fabb1 |
| September 16, 2020 13:22 | https://github.com/nodejs/node/pull/35191#event-3773172886 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-693402138 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Sep 16, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-693403531 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-490350130 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/aymen94 |
| aymen94 | https://github.com/aymen94 |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-490356452 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/3c37b95992c4ec4303aab016c3d60ddd70be77b5..0677bbdbfc3f5025cc54dae95c99ed81556678be |
| 3c37b95 | https://github.com/nodejs/node/commit/3c37b95992c4ec4303aab016c3d60ddd70be77b5 |
| 0677bbd | https://github.com/nodejs/node/commit/0677bbdbfc3f5025cc54dae95c99ed81556678be |
|
Compare
| https://github.com/nodejs/node/compare/3c37b95992c4ec4303aab016c3d60ddd70be77b5..0677bbdbfc3f5025cc54dae95c99ed81556678be |
| September 17, 2020 15:17 | https://github.com/nodejs/node/pull/35191#event-3778557988 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 17, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-491060857 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/35191#pullrequestreview-491060857 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/5445507/93538752-cf598980-f946-11ea-8d4a-edeed44d955a.png |
| https://user-images.githubusercontent.com/5445507/93539370-77bc1d80-f948-11ea-9a52-f0b00e6e640e.png |
| https://user-images.githubusercontent.com/5445507/93538936-48f17780-f947-11ea-8f2c-f101ed3fa31f.png |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| richardlau | https://github.com/richardlau |
| September 18, 2020 07:41 | https://github.com/nodejs/node/pull/35191#event-3781352357 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 18, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-491346901 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 18, 2020 | https://github.com/nodejs/node/pull/35191#event-3782017621 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 18, 2020 | https://github.com/nodejs/node/pull/35191#event-3782041100 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/35191#ref-pullrequest-705877178 |
|
V14.12.0 proposal
#35285
| https://github.com/nodejs/node/pull/35285 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/93ae3d237431ebf8c6e7018885ab1ed2f9d414fb..ccbda32d56767de388b0eb978e2889573c2e986d |
| 93ae3d2 | https://github.com/nodejs/node/commit/93ae3d237431ebf8c6e7018885ab1ed2f9d414fb |
| ccbda32 | https://github.com/nodejs/node/commit/ccbda32d56767de388b0eb978e2889573c2e986d |
|
Compare
| https://github.com/nodejs/node/compare/93ae3d237431ebf8c6e7018885ab1ed2f9d414fb..ccbda32d56767de388b0eb978e2889573c2e986d |
| September 22, 2020 18:33 | https://github.com/nodejs/node/pull/35191#event-3794644242 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 22, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-696904215 |
| #35224 | https://github.com/nodejs/node/pull/35224 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/45e287de2639fe773f575ccb5327e103be62fcd7..c8d000b56c6b202b50b4301130fd28354f551112 |
| 45e287d | https://github.com/nodejs/node/commit/45e287de2639fe773f575ccb5327e103be62fcd7 |
| c8d000b | https://github.com/nodejs/node/commit/c8d000b56c6b202b50b4301130fd28354f551112 |
|
Compare
| https://github.com/nodejs/node/compare/45e287de2639fe773f575ccb5327e103be62fcd7..c8d000b56c6b202b50b4301130fd28354f551112 |
| September 26, 2020 12:10 | https://github.com/nodejs/node/pull/35191#event-3810725638 |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
|
Sep 26, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-497036150 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| https://github.com/nodejs/node/pull/35191#pullrequestreview-497036150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 26, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495503522 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| aduh95 | https://github.com/aduh95 |
| Sep 27, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495551248 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 28, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r496258118 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| unist-util-visit | https://www.npmjs.com/package/unist-util-visit |
| Universal Syntax Tree | https://github.com/syntax-tree/unist |
| @wooorm | https://github.com/wooorm |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| wooorm | https://github.com/wooorm |
| Sep 29, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r496677702 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| some recipes on the website of unified | https://unifiedjs.com/learn/recipe/ |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| test/doctool/test-local-md-file-reference-regex.js | https://github.com/nodejs/node/pull/35191/files#diff-fdb4e73be5354b2fa5ef8e40d3bf65a3fd193a803c878317ab6986b96cff95d9 |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 26, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495503949 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| aduh95 | https://github.com/aduh95 |
| Sep 27, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495551626 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| node/Makefile | https://github.com/nodejs/node/blob/73900983f0180f563b9a6959fee378789db6854c/Makefile#L606 |
| 7390098 | https://github.com/nodejs/node/commit/73900983f0180f563b9a6959fee378789db6854c |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/html.js | https://github.com/nodejs/node/pull/35191/files#diff-55254552ad384f461c2d30801ccf911060301b22751baeea57dba5916f3d24e6 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/html.js | https://github.com/nodejs/node/pull/35191/files#diff-55254552ad384f461c2d30801ccf911060301b22751baeea57dba5916f3d24e6 |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 26, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495504040 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| aduh95 | https://github.com/aduh95 |
| Sep 27, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495551737 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| tools/doc/markdown.js | https://github.com/nodejs/node/pull/35191/files#diff-6dfa17281cd3b606ee879cfdbfb37681fda3030f2b821b83c2b153a4d43e481f |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
| Sep 26, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495504325 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| aduh95 | https://github.com/aduh95 |
| Sep 27, 2020 | https://github.com/nodejs/node/pull/35191#discussion_r495552074 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/6388632c461d8cbf7deb7f1f1c382917bc3bbe20..844ed1b73e5e88cef81af0ba05c14f1d42370e89 |
| 6388632 | https://github.com/nodejs/node/commit/6388632c461d8cbf7deb7f1f1c382917bc3bbe20 |
| 844ed1b | https://github.com/nodejs/node/commit/844ed1b73e5e88cef81af0ba05c14f1d42370e89 |
|
Compare
| https://github.com/nodejs/node/compare/6388632c461d8cbf7deb7f1f1c382917bc3bbe20..844ed1b73e5e88cef81af0ba05c14f1d42370e89 |
| September 29, 2020 08:15 | https://github.com/nodejs/node/pull/35191#event-3818121118 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 29, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-700533986 |
| @DerekNonGeneric | https://github.com/DerekNonGeneric |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/844ed1b73e5e88cef81af0ba05c14f1d42370e89..4605a10e13b2300474d200026dc06bba3e9064f1 |
| 844ed1b | https://github.com/nodejs/node/commit/844ed1b73e5e88cef81af0ba05c14f1d42370e89 |
| 4605a10 | https://github.com/nodejs/node/commit/4605a10e13b2300474d200026dc06bba3e9064f1 |
|
Compare
| https://github.com/nodejs/node/compare/844ed1b73e5e88cef81af0ba05c14f1d42370e89..4605a10e13b2300474d200026dc06bba3e9064f1 |
| September 29, 2020 15:57 | https://github.com/nodejs/node/pull/35191#event-3820411581 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Sep 30, 2020
| https://github.com/nodejs/node/pull/35191#ref-pullrequest-712115812 |
|
feat: lint YAML comments in md files
nodejs/remark-preset-lint-node#139
| https://github.com/nodejs/remark-preset-lint-node/pull/139 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Sep 30, 2020
| https://github.com/nodejs/node/pull/35191#pullrequestreview-499819318 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/35191/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 30, 2020 | https://github.com/nodejs/node/pull/35191#event-3826499021 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 30, 2020 | https://github.com/nodejs/node/pull/35191#event-3826506233 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 30, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-701653345 |
| https://ci.nodejs.org/job/node-test-pull-request/33310/ | https://ci.nodejs.org/job/node-test-pull-request/33310/ |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Sep 30, 2020
| https://github.com/nodejs/node/pull/35191#ref-issue-712294272 |
|
Rule for ordering reference links
nodejs/remark-preset-lint-node#140
| https://github.com/nodejs/remark-preset-lint-node/issues/140 |
| aduh95 | https://github.com/aduh95 |
| October 1, 2020 06:19 | https://github.com/nodejs/node/pull/35191#commits-pushed-ecf5060 |
|
| https://github.com/aduh95 |
|
| https://github.com/Trott |
| doc: use .md extension for internal links | https://github.com/nodejs/node/pull/35191/commits/ecf5060a42a5cd073ed4200e80afae1a79178bba |
| ecf5060 | https://github.com/nodejs/node/pull/35191/commits/ecf5060a42a5cd073ed4200e80afae1a79178bba |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
|
| https://github.com/aduh95 |
|
| https://github.com/Trott |
| doc: sort md references in ASCII order | https://github.com/nodejs/node/pull/35191/commits/57f1e3224e522f9a6795e42e0332fc36f8befb2a |
| 57f1e32 | https://github.com/nodejs/node/pull/35191/commits/57f1e3224e522f9a6795e42e0332fc36f8befb2a |
| nodejs#35244 | https://github.com/nodejs/node/pull/35244 |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
|
| https://github.com/aduh95 |
|
| https://github.com/Trott |
| tools: check links in api docs | https://github.com/nodejs/node/pull/35191/commits/91837e9fbbd27fce37719b2decaf3a3196a31171 |
| 91837e9 | https://github.com/nodejs/node/pull/35191/commits/91837e9fbbd27fce37719b2decaf3a3196a31171 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/4605a10e13b2300474d200026dc06bba3e9064f1..91837e9fbbd27fce37719b2decaf3a3196a31171 |
| 4605a10 | https://github.com/nodejs/node/commit/4605a10e13b2300474d200026dc06bba3e9064f1 |
| 91837e9 | https://github.com/nodejs/node/commit/91837e9fbbd27fce37719b2decaf3a3196a31171 |
|
Compare
| https://github.com/nodejs/node/compare/4605a10e13b2300474d200026dc06bba3e9064f1..91837e9fbbd27fce37719b2decaf3a3196a31171 |
| October 1, 2020 13:25 | https://github.com/nodejs/node/pull/35191#event-3829471779 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Oct 1, 2020 | https://github.com/nodejs/node/pull/35191#issuecomment-702133294 |
| 726143e...91837e9 | https://github.com/nodejs/node/compare/726143e683738b0e60580bdc247e6cfa60a0783a...91837e9fbbd27fce37719b2decaf3a3196a31171 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 91837e9 | https://github.com/nodejs/node/commit/91837e9fbbd27fce37719b2decaf3a3196a31171 |
| Oct 1, 2020 | https://github.com/nodejs/node/pull/35191#event-3829477249 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| October 1, 2020 13:38 | https://github.com/nodejs/node/pull/35191#event-3829541765 |
| danielleadams | https://github.com/danielleadams |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35191#ref-commit-ce789f1 |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| doc: use .md extension for internal links | https://github.com/nodejs/node/commit/ce789f1ca40289213fa14d024e8f71aa4058353d |
| ce789f1 | https://github.com/nodejs/node/commit/ce789f1ca40289213fa14d024e8f71aa4058353d |
| #35191 | https://github.com/nodejs/node/pull/35191 |
| #35189 | https://github.com/nodejs/node/issues/35189 |
| danielleadams | https://github.com/danielleadams |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35191#ref-commit-5a730b5 |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| doc: sort md references in ASCII order | https://github.com/nodejs/node/commit/5a730b5def92105cb417bca3bb72fa25394c54e8 |
| 5a730b5 | https://github.com/nodejs/node/commit/5a730b5def92105cb417bca3bb72fa25394c54e8 |
| #35244 | https://github.com/nodejs/node/pull/35244 |
| #35191 | https://github.com/nodejs/node/pull/35191 |
| #35189 | https://github.com/nodejs/node/issues/35189 |
| danielleadams | https://github.com/danielleadams |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35191#ref-commit-166f14a |
|
| https://github.com/aduh95 |
|
| https://github.com/danielleadams |
| tools: check links in api docs | https://github.com/nodejs/node/commit/166f14ac989c7f56423859c7b252fff154bc2c4e |
| 166f14a | https://github.com/nodejs/node/commit/166f14ac989c7f56423859c7b252fff154bc2c4e |
| #35189 | https://github.com/nodejs/node/issues/35189 |
| #35191 | https://github.com/nodejs/node/pull/35191 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Oct 6, 2020
| https://github.com/nodejs/node/pull/35191#ref-pullrequest-715898141 |
|
V14.13.1 proposal
#35525
| https://github.com/nodejs/node/pull/35525 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/35191#ref-commit-8117e86 |
|
| https://github.com/aduh95 |
|
| https://github.com/joesepi |
| doc: use .md extension for internal links | https://github.com/joesepi/node/commit/8117e86a4dad6e2137a0ec26f20ee3cd20ab7043 |
| 8117e86 | https://github.com/joesepi/node/commit/8117e86a4dad6e2137a0ec26f20ee3cd20ab7043 |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/35191#ref-commit-639eb24 |
|
| https://github.com/aduh95 |
|
| https://github.com/joesepi |
| doc: sort md references in ASCII order | https://github.com/joesepi/node/commit/639eb24a3562dcf389f2f3a1a644d2198a9b8823 |
| 639eb24 | https://github.com/joesepi/node/commit/639eb24a3562dcf389f2f3a1a644d2198a9b8823 |
| nodejs#35244 | https://github.com/nodejs/node/pull/35244 |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
| joesepi | https://github.com/joesepi |
|
Jan 8, 2021
| https://github.com/nodejs/node/pull/35191#ref-commit-ab22657 |
|
| https://github.com/aduh95 |
|
| https://github.com/joesepi |
| tools: check links in api docs | https://github.com/joesepi/node/commit/ab226570f08fcd7bda7a38b3b8090420d8b5ee89 |
| ab22657 | https://github.com/joesepi/node/commit/ab226570f08fcd7bda7a38b3b8090420d8b5ee89 |
| nodejs#35189 | https://github.com/nodejs/node/issues/35189 |
| nodejs#35191 | https://github.com/nodejs/node/pull/35191 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35191 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/35191/files/4605a10e13b2300474d200026dc06bba3e9064f1 |
|
| https://github.com/gengjiawen |
|
gengjiawen
| https://github.com/gengjiawen |
|
| https://github.com/nodejs/node/pull/35191/files/a9ad53112fb25a5176713d76cd81ad3244d2a365 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/35191/files/3db2df16e21018a794d42d5d3ed420de29aaa959 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/35191/files/8d27d130cc6b7c87ef3de21970e51866963fabb1 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/wooorm |
|
wooorm
| https://github.com/wooorm |
|
| https://github.com/nodejs/node/pull/35191/files/844ed1b73e5e88cef81af0ba05c14f1d42370e89 |
|
| https://github.com/DerekNonGeneric |
|
DerekNonGeneric
| https://github.com/DerekNonGeneric |
|
| https://github.com/nodejs/node/pull/35191/files/c8d000b56c6b202b50b4301130fd28354f551112 |
|
| https://github.com/aymen94 |
|
aymen94
| https://github.com/aymen94 |
|
| https://github.com/nodejs/node/pull/35191/files/8d27d130cc6b7c87ef3de21970e51866963fabb1 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
|
doc,tools: checkLinks.js does not cover api
| https://github.com/nodejs/node/issues/35189 |
| Please reload this page | https://github.com/nodejs/node/pull/35191 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/DerekNonGeneric |
|
| https://github.com/gengjiawen |
|
| https://github.com/Trott |
|
| https://github.com/wooorm |
|
| https://github.com/lpinca |
|
| https://github.com/richardlau |
|
| https://github.com/aymen94 |
|
| https://github.com/trivikr |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |