René's URL Explorer Experiment


Title: crypto: simplify KeyObject constructor by Trott · Pull Request #35064 · nodejs/node · GitHub

Open Graph Title: crypto: simplify KeyObject constructor by Trott · Pull Request #35064 · nodejs/node

X Title: crypto: simplify KeyObject constructor by Trott · Pull Request #35064 · nodejs/node

Description: Inline a function that only gets called in the constructor. Make call to super() more straightforward in the process by removing conditional involving the function as it only ever returns undefined...

Open Graph Description: Inline a function that only gets called in the constructor. Make call to super() more straightforward in the process by removing conditional involving the function as it only ever returns undefined...

X Description: Inline a function that only gets called in the constructor. Make call to super() more straightforward in the process by removing conditional involving the function as it only ever returns undefined...

Opengraph URL: https://github.com/nodejs/node/pull/35064

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:946ba375-658f-d1d7-8693-23f930d8877c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8844:2EC266:83261D:B4D03D:696A75ED
html-safe-nonce5f1ebd063bfca7a5bdbe8205b6e5850fc250ed630d11ce435d0b9efc772e68c1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODQ0OjJFQzI2Njo4MzI2MUQ6QjREMDNEOjY5NkE3NUVEIiwidmlzaXRvcl9pZCI6Ijc3NzE3MTYzMzQzMDYwOTY2MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0de32815435f959b6cbfbe2e23d705e0b8c54f95b529e48f15470bf7dc8b1082
hovercard-subject-tagpull_request:480454373
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35064/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/571a93fc654de33e2bb8c7b69d58aa68ca5c619ec67c3704a89f74c3808bc1ad/nodejs/node/pull/35064
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/571a93fc654de33e2bb8c7b69d58aa68ca5c619ec67c3704a89f74c3808bc1ad/nodejs/node/pull/35064
og:image:altInline a function that only gets called in the constructor. Make call to super() more straightforward in the process by removing conditional involving the function as it only ever returns undefined...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35064#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35064
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35064
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35064
Reloadhttps://github.com/nodejs/node/pull/35064
Reloadhttps://github.com/nodejs/node/pull/35064
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35064
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35064
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35064#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:crypto-inlinehttps://github.com/Trott/io.js/tree/crypto-inline
crypto: simplify KeyObject constructor https://github.com/nodejs/node/pull/35064#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:crypto-inlinehttps://github.com/Trott/io.js/tree/crypto-inline
Conversation 5 https://github.com/nodejs/node/pull/35064
Commits 1 https://github.com/nodejs/node/pull/35064/commits
Checks 0 https://github.com/nodejs/node/pull/35064/checks
Files changed https://github.com/nodejs/node/pull/35064/files
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 5, 2020https://github.com/nodejs/node/pull/35064#issue-694001683
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2020https://github.com/nodejs/node/pull/35064#issuecomment-687555020
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Sep 5, 2020https://github.com/nodejs/node/pull/35064#event-3732616574
https://github.com/Trott
Trotthttps://github.com/Trott
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 5, 2020https://github.com/nodejs/node/pull/35064#event-3732616788
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 5, 2020https://github.com/nodejs/node/pull/35064#event-3732627636
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2020https://github.com/nodejs/node/pull/35064#issuecomment-687556540
https://ci.nodejs.org/job/node-test-pull-request/33061/https://ci.nodejs.org/job/node-test-pull-request/33061/
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Sep 5, 2020 https://github.com/nodejs/node/pull/35064#pullrequestreview-483043797
View reviewed changes https://github.com/nodejs/node/pull/35064/files
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 5, 2020https://github.com/nodejs/node/pull/35064#event-3732771064
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 5, 2020https://github.com/nodejs/node/pull/35064#event-3732781100
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2020https://github.com/nodejs/node/pull/35064#issuecomment-687580704
https://ci.nodejs.org/job/node-test-pull-request/33064/https://ci.nodejs.org/job/node-test-pull-request/33064/
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/targos
targoshttps://github.com/targos
Sep 5, 2020 https://github.com/nodejs/node/pull/35064#pullrequestreview-483053358
View reviewed changes https://github.com/nodejs/node/pull/35064/files
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Sep 5, 2020 https://github.com/nodejs/node/pull/35064#pullrequestreview-483054363
View reviewed changes https://github.com/nodejs/node/pull/35064/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 5, 2020https://github.com/nodejs/node/pull/35064#issuecomment-687613581
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://ci.nodejs.org/job/node-test-pull-request/33070/https://ci.nodejs.org/job/node-test-pull-request/33070/
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Sep 5, 2020 https://github.com/nodejs/node/pull/35064#pullrequestreview-483067245
View reviewed changes https://github.com/nodejs/node/pull/35064/files
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/efe6340341142aa973b3ac1b293f1da44f8b630a..ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
efe6340https://github.com/nodejs/node/commit/efe6340341142aa973b3ac1b293f1da44f8b630a
ac6ba6bhttps://github.com/nodejs/node/commit/ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
Compare https://github.com/nodejs/node/compare/efe6340341142aa973b3ac1b293f1da44f8b630a..ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
September 7, 2020 15:00https://github.com/nodejs/node/pull/35064#event-3737570854
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 7, 2020https://github.com/nodejs/node/pull/35064#issuecomment-688378579
ac6ba6bhttps://github.com/nodejs/node/commit/ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/Trott
Trotthttps://github.com/Trott
ac6ba6bhttps://github.com/nodejs/node/commit/ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
Sep 7, 2020https://github.com/nodejs/node/pull/35064#event-3737572059
https://github.com/Trott
Trotthttps://github.com/Trott
September 7, 2020 15:00https://github.com/nodejs/node/pull/35064#event-3737572409
https://github.com/Trott
crypto: simplify KeyObject constructorhttps://github.com/nodejs/node/pull/35064/commits/ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
ac6ba6bhttps://github.com/nodejs/node/pull/35064/commits/ac6ba6b625c5a60754e7e1ee187dbbec070d45d4
nodejs#35064https://github.com/nodejs/node/pull/35064
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35064#ref-commit-a70cbf0
https://github.com/Trott
https://github.com/richardlau
crypto: simplify KeyObject constructorhttps://github.com/nodejs/node/commit/a70cbf0ee45d39eaa28596375b72ad34eb8d2c30
a70cbf0https://github.com/nodejs/node/commit/a70cbf0ee45d39eaa28596375b72ad34eb8d2c30
#35064https://github.com/nodejs/node/pull/35064
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35064#ref-pullrequest-691140213
v14.10.0 proposal #35023 https://github.com/nodejs/node/pull/35023
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35064#ref-commit-178a740
https://github.com/Trott
https://github.com/richardlau
crypto: simplify KeyObject constructorhttps://github.com/nodejs/node/commit/178a740caf68144a8ec226fc1583ff24a789035d
178a740https://github.com/nodejs/node/commit/178a740caf68144a8ec226fc1583ff24a789035d
#35064https://github.com/nodejs/node/pull/35064
addaleaxhttps://github.com/addaleax
Sep 27, 2020 https://github.com/nodejs/node/pull/35064#ref-commit-f9420c7
https://github.com/Trott
https://github.com/addaleax
crypto: simplify KeyObject constructorhttps://github.com/nodejs/node/commit/f9420c792d847c68a7cc3bb51b8b01b7ba2317a2
f9420c7https://github.com/nodejs/node/commit/f9420c792d847c68a7cc3bb51b8b01b7ba2317a2
#35064https://github.com/nodejs/node/pull/35064
addaleaxhttps://github.com/addaleax
Sep 28, 2020 https://github.com/nodejs/node/pull/35064#ref-commit-ed72d83
https://github.com/Trott
https://github.com/addaleax
crypto: simplify KeyObject constructorhttps://github.com/nodejs/node/commit/ed72d838021f4dfe53529c661420a9cf8c5c7ac2
ed72d83https://github.com/nodejs/node/commit/ed72d838021f4dfe53529c661420a9cf8c5c7ac2
#35064https://github.com/nodejs/node/pull/35064
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/35064#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35064#ref-commit-f9405e9
https://github.com/Trott
https://github.com/joesepi
crypto: simplify KeyObject constructorhttps://github.com/joesepi/node/commit/f9405e9bca30e119a1bd9b2ebed0a0c908775a50
f9405e9https://github.com/joesepi/node/commit/f9405e9bca30e119a1bd9b2ebed0a0c908775a50
nodejs#35064https://github.com/nodejs/node/pull/35064
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35064
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/35064/files/efe6340341142aa973b3ac1b293f1da44f8b630a
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/35064/files/efe6340341142aa973b3ac1b293f1da44f8b630a
https://github.com/tniessen
tniessen https://github.com/tniessen
https://github.com/nodejs/node/pull/35064/files/efe6340341142aa973b3ac1b293f1da44f8b630a
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/35064/files/efe6340341142aa973b3ac1b293f1da44f8b630a
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/35064
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/targos
https://github.com/tniessen
https://github.com/lundibundi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.