René's URL Explorer Experiment


Title: querystring: manage percent character at unescape by watilde · Pull Request #35013 · nodejs/node · GitHub

Open Graph Title: querystring: manage percent character at unescape by watilde · Pull Request #35013 · nodejs/node

X Title: querystring: manage percent character at unescape by watilde · Pull Request #35013 · nodejs/node

Description: Related: #33892 Fixes: #35012 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Open Graph Description: Related: #33892 Fixes: #35012 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Related: #33892 Fixes: #35012 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/35013

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:96474e74-1d5d-4199-db4b-aeffbdd0e879
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA454:30E6E5:D7136D:1267772:696A916B
html-safe-noncec5e4cc04e28ec8b5628af912e688033d0b0099d4742d738893ca5587e71b8a0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDU0OjMwRTZFNTpENzEzNkQ6MTI2Nzc3Mjo2OTZBOTE2QiIsInZpc2l0b3JfaWQiOiI1MjE0MDczNzk3ODQ4MjQwNDkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4f9792ebf56275f042000cb73f8a655c4eb167cfb81b15b4ccc1f60e7eb80932
hovercard-subject-tagpull_request:477261128
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/35013/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/14efc543b32c787b8546fbfed2b8546f94779f04a26cf042ef6df0a51922d234/nodejs/node/pull/35013
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14efc543b32c787b8546fbfed2b8546f94779f04a26cf042ef6df0a51922d234/nodejs/node/pull/35013
og:image:altRelated: #33892 Fixes: #35012 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewatilde
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/35013#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35013
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35013
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/35013
Reloadhttps://github.com/nodejs/node/pull/35013
Reloadhttps://github.com/nodejs/node/pull/35013
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/35013
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/35013
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/35013#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:fixes-35012https://github.com/watilde/node/tree/fixes-35012
querystring: manage percent character at unescape https://github.com/nodejs/node/pull/35013#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
watilde:fixes-35012https://github.com/watilde/node/tree/fixes-35012
Conversation 4 https://github.com/nodejs/node/pull/35013
Commits 1 https://github.com/nodejs/node/pull/35013/commits
Checks 0 https://github.com/nodejs/node/pull/35013/checks
Files changed https://github.com/nodejs/node/pull/35013/files
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/watilde
watildehttps://github.com/watilde
Sep 1, 2020https://github.com/nodejs/node/pull/35013#issue-690360240
#33892https://github.com/nodejs/node/issues/33892
#35012https://github.com/nodejs/node/issues/35012
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.com/watilde
watildehttps://github.com/watilde
querystring https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring
Sep 1, 2020https://github.com/nodejs/node/pull/35013#event-3716319590
https://github.com/watilde
watildehttps://github.com/watilde
Sep 2, 2020 https://github.com/nodejs/node/pull/35013#ref-issue-638964233
Different query parsing behavior between node and browsers for URLSearchParams #33892 https://github.com/nodejs/node/issues/33892
https://github.com/watilde
watildehttps://github.com/watilde
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 2, 2020https://github.com/nodejs/node/pull/35013#event-3717708454
https://github.com/watilde
watildehttps://github.com/watilde
jasnellhttps://github.com/jasnell
lundibundihttps://github.com/lundibundi
September 2, 2020 03:46https://github.com/nodejs/node/pull/35013#event-3717708976
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 2, 2020https://github.com/nodejs/node/pull/35013#event-3717712445
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 2, 2020https://github.com/nodejs/node/pull/35013#issuecomment-685274729
https://ci.nodejs.org/job/node-test-pull-request/32997/https://ci.nodejs.org/job/node-test-pull-request/32997/
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.com/watilde
watildehttps://github.com/watilde
joyeecheunghttps://github.com/joyeecheung
September 2, 2020 07:57https://github.com/nodejs/node/pull/35013#event-3718394941
https://github.com/joyeecheung
joyeecheunghttps://github.com/joyeecheung
Sep 2, 2020 https://github.com/nodejs/node/pull/35013#pullrequestreview-481218920
View reviewed changes https://github.com/nodejs/node/pull/35013/files
https://github.com/yashLadha
yashLadhahttps://github.com/yashLadha
Sep 3, 2020 https://github.com/nodejs/node/pull/35013#pullrequestreview-481676470
View reviewed changes https://github.com/nodejs/node/pull/35013/files
https://github.com/Leko
Lekohttps://github.com/Leko
Sep 3, 2020 https://github.com/nodejs/node/pull/35013#pullrequestreview-482022165
View reviewed changes https://github.com/nodejs/node/pull/35013/files
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 4, 2020https://github.com/nodejs/node/pull/35013#issuecomment-686871304
https://ci.nodejs.org/job/node-test-pull-request/33045/https://ci.nodejs.org/job/node-test-pull-request/33045/
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 4, 2020 https://github.com/nodejs/node/pull/35013#pullrequestreview-482336102
View reviewed changes https://github.com/nodejs/node/pull/35013/files
https://github.com/watilde
https://github.com/Trott
querystring: manage percent character at unescapehttps://github.com/nodejs/node/pull/35013/commits/3b925219c341062a9fc648049e217fea79f0ea3d
3b92521https://github.com/nodejs/node/pull/35013/commits/3b925219c341062a9fc648049e217fea79f0ea3d
nodejs#33892https://github.com/nodejs/node/issues/33892
nodejs#35012https://github.com/nodejs/node/issues/35012
nodejs#35013https://github.com/nodejs/node/pull/35013
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/f727dadfb5183ed69661d66c21ca245015da29e5..3b925219c341062a9fc648049e217fea79f0ea3d
f727dadhttps://github.com/nodejs/node/commit/f727dadfb5183ed69661d66c21ca245015da29e5
3b92521https://github.com/nodejs/node/commit/3b925219c341062a9fc648049e217fea79f0ea3d
Compare https://github.com/nodejs/node/compare/f727dadfb5183ed69661d66c21ca245015da29e5..3b925219c341062a9fc648049e217fea79f0ea3d
September 4, 2020 03:44https://github.com/nodejs/node/pull/35013#event-3727731639
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 4, 2020https://github.com/nodejs/node/pull/35013#issuecomment-686885203
3b92521https://github.com/nodejs/node/commit/3b925219c341062a9fc648049e217fea79f0ea3d
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.com/Trott
Trotthttps://github.com/Trott
3b92521https://github.com/nodejs/node/commit/3b925219c341062a9fc648049e217fea79f0ea3d
Sep 4, 2020https://github.com/nodejs/node/pull/35013#event-3727732260
https://github.com/watilde
watildehttps://github.com/watilde
September 4, 2020 03:58https://github.com/nodejs/node/pull/35013#event-3727761084
https://github.com/watilde
watildehttps://github.com/watilde
Sep 4, 2020https://github.com/nodejs/node/pull/35013#issuecomment-686888944
Please reload this pagehttps://github.com/nodejs/node/pull/35013
watildehttps://github.com/watilde
Sep 4, 2020 https://github.com/nodejs/node/pull/35013#ref-commit-73eb5e1
https://github.com/watilde
test: update WPT tests of URL for URLSearchParams parsing %https://github.com/watilde/node/commit/73eb5e13c0f7e35564ab948def3190ff71c795a7
73eb5e1https://github.com/watilde/node/commit/73eb5e13c0f7e35564ab948def3190ff71c795a7
web-platform-tests/wpt#24152https://github.com/web-platform-tests/wpt/pull/24152
nodejs#35013https://github.com/nodejs/node/pull/35013
nodejs#33892https://github.com/nodejs/node/issues/33892
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35013#ref-commit-3367613
https://github.com/watilde
https://github.com/richardlau
querystring: manage percent character at unescapehttps://github.com/nodejs/node/commit/336761389029672eab715d1b5f314e61f28eb4cc
3367613https://github.com/nodejs/node/commit/336761389029672eab715d1b5f314e61f28eb4cc
#33892https://github.com/nodejs/node/issues/33892
#35012https://github.com/nodejs/node/issues/35012
#35013https://github.com/nodejs/node/pull/35013
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35013#ref-pullrequest-691140213
v14.10.0 proposal #35023 https://github.com/nodejs/node/pull/35023
richardlauhttps://github.com/richardlau
Sep 7, 2020 https://github.com/nodejs/node/pull/35013#ref-commit-1bf5d1a
https://github.com/watilde
https://github.com/richardlau
querystring: manage percent character at unescapehttps://github.com/nodejs/node/commit/1bf5d1a39b974720fd5749534941a3b2693b69e5
1bf5d1ahttps://github.com/nodejs/node/commit/1bf5d1a39b974720fd5749534941a3b2693b69e5
#33892https://github.com/nodejs/node/issues/33892
#35012https://github.com/nodejs/node/issues/35012
#35013https://github.com/nodejs/node/pull/35013
https://github.com/watilde
watildehttps://github.com/watilde
Sep 8, 2020 https://github.com/nodejs/node/pull/35013#ref-pullrequest-632358986
test: update WPT harness #33770 https://github.com/nodejs/node/pull/33770
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/35013#ref-commit-bde9fb8
https://github.com/watilde
https://github.com/addaleax
querystring: manage percent character at unescapehttps://github.com/nodejs/node/commit/bde9fb86c7634e3faba8283bce2b181202410b8a
bde9fb8https://github.com/nodejs/node/commit/bde9fb86c7634e3faba8283bce2b181202410b8a
#33892https://github.com/nodejs/node/issues/33892
#35012https://github.com/nodejs/node/issues/35012
#35013https://github.com/nodejs/node/pull/35013
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/35013#ref-commit-6ccacdf
https://github.com/watilde
https://github.com/addaleax
querystring: manage percent character at unescapehttps://github.com/nodejs/node/commit/6ccacdfddb2ea972df516cc1bbca1c51b91650f3
6ccacdfhttps://github.com/nodejs/node/commit/6ccacdfddb2ea972df516cc1bbca1c51b91650f3
#33892https://github.com/nodejs/node/issues/33892
#35012https://github.com/nodejs/node/issues/35012
#35013https://github.com/nodejs/node/pull/35013
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/35013#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/35013#ref-commit-5366a2c
https://github.com/watilde
https://github.com/joesepi
querystring: manage percent character at unescapehttps://github.com/joesepi/node/commit/5366a2c6d60894adc1127bfd686fb84d6b9f15b1
5366a2chttps://github.com/joesepi/node/commit/5366a2c6d60894adc1127bfd686fb84d6b9f15b1
nodejs#33892https://github.com/nodejs/node/issues/33892
nodejs#35012https://github.com/nodejs/node/issues/35012
nodejs#35013https://github.com/nodejs/node/pull/35013
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F35013
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/35013/files/f727dadfb5183ed69661d66c21ca245015da29e5
https://github.com/joyeecheung
joyeecheung https://github.com/joyeecheung
https://github.com/nodejs/node/pull/35013/files/f727dadfb5183ed69661d66c21ca245015da29e5
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/Leko
Leko https://github.com/Leko
https://github.com/nodejs/node/pull/35013/files/f727dadfb5183ed69661d66c21ca245015da29e5
https://github.com/yashLadha
yashLadha https://github.com/yashLadha
https://github.com/nodejs/node/pull/35013/files/f727dadfb5183ed69661d66c21ca245015da29e5
querystring https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aquerystring
querystring.unescape does not correctly unescape percent characters https://github.com/nodejs/node/issues/35012
Please reload this pagehttps://github.com/nodejs/node/pull/35013
https://github.com/watilde
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/Leko
https://github.com/joyeecheung
https://github.com/yashLadha
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.