René's URL Explorer Experiment


Title: stream: allow using `.push()`/`.unshift()` during `once('data')` by addaleax · Pull Request #34957 · nodejs/node · GitHub

Open Graph Title: stream: allow using `.push()`/`.unshift()` during `once('data')` by addaleax · Pull Request #34957 · nodejs/node

X Title: stream: allow using `.push()`/`.unshift()` during `once('data')` by addaleax · Pull Request #34957 · nodejs/node

Description: Previously, the .push() or .unshift() call would just have jumped straight to emitting a 'data' event, even if there were no listeners, effectively just silently dropping the chunk. Checklist m...

Open Graph Description: Previously, the .push() or .unshift() call would just have jumped straight to emitting a 'data' event, even if there were no listeners, effectively just silently dropping the chunk. Checkl...

X Description: Previously, the .push() or .unshift() call would just have jumped straight to emitting a 'data' event, even if there were no listeners, effectively just silently dropping the chunk....

Opengraph URL: https://github.com/nodejs/node/pull/34957

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:423dbbc2-6a47-1e7b-6d3b-c8f33ea955f3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE2C:220088:5383B1:747FB2:696A761D
html-safe-noncec166f79eafe8b8b76184134179436601a7c836fee62b45e00ef0062cf6238478
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTJDOjIyMDA4ODo1MzgzQjE6NzQ3RkIyOjY5NkE3NjFEIiwidmlzaXRvcl9pZCI6IjY3NTcxNjU4NDk5NDE0MTcyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbbe9ed93349eba00a41c88b8da056edbdeb4c0032fd28194cf2734410014cbd0
hovercard-subject-tagpull_request:475465412
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34957/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0bf4c3fed970e7eb0e38ca696f106e024bec64fdb6c2e2149512b6558a9aa453/nodejs/node/pull/34957
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0bf4c3fed970e7eb0e38ca696f106e024bec64fdb6c2e2149512b6558a9aa453/nodejs/node/pull/34957
og:image:altPreviously, the .push() or .unshift() call would just have jumped straight to emitting a 'data' event, even if there were no listeners, effectively just silently dropping the chunk. Checkl...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34957#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34957
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34957
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34957
Reloadhttps://github.com/nodejs/node/pull/34957
Reloadhttps://github.com/nodejs/node/pull/34957
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34957
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34957
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34957#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stream-add-chunk-during-datahttps://github.com/addaleax/node/tree/stream-add-chunk-during-data
stream: allow using .push()/.unshift() during once('data') https://github.com/nodejs/node/pull/34957#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:stream-add-chunk-during-datahttps://github.com/addaleax/node/tree/stream-add-chunk-during-data
Conversation 9 https://github.com/nodejs/node/pull/34957
Commits 1 https://github.com/nodejs/node/pull/34957/commits
Checks 0 https://github.com/nodejs/node/pull/34957/checks
Files changed https://github.com/nodejs/node/pull/34957/files
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2020https://github.com/nodejs/node/pull/34957#issue-688147270
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/addaleax
stream: allow using .push()/.unshift() during once('data')https://github.com/nodejs/node/pull/34957/commits/d21c4099b496b7de06bc6c38f0a890a7269e9368
d21c409https://github.com/nodejs/node/pull/34957/commits/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 28, 2020https://github.com/nodejs/node/pull/34957#event-3704405800
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2020 https://github.com/nodejs/node/pull/34957#ref-pullrequest-688147958
http2,tls: account for buffered data before creating socket wraps #34958 https://github.com/nodejs/node/pull/34958
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 28, 2020https://github.com/nodejs/node/pull/34957#event-3704427838
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2020https://github.com/nodejs/node/pull/34957#issuecomment-682700969
https://ci.nodejs.org/job/node-test-pull-request/32964/https://ci.nodejs.org/job/node-test-pull-request/32964/
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 28, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-477883553
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
benjamingrhttps://github.com/benjamingr
https://github.com/nodejs/node/pull/34957#pullrequestreview-477883553
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 28, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-477939273
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/cjihrig
cjihrighttps://github.com/cjihrig
Aug 28, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-477940999
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683057008
https://ci.nodejs.org/job/node-test-pull-request/32970/https://ci.nodejs.org/job/node-test-pull-request/32970/
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/Trott
Trotthttps://github.com/Trott
ronaghttps://github.com/ronag
August 28, 2020 18:54https://github.com/nodejs/node/pull/34957#event-3705260461
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 28, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-477956738
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 28, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683142657
https://ci.nodejs.org/job/node-test-pull-request/32971/https://ci.nodejs.org/job/node-test-pull-request/32971/
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 28, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683143315
@mcollinahttps://github.com/mcollina
#34958https://github.com/nodejs/node/pull/34958
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/662/https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/662/
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 29, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683266862
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 29, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-478115250
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 29, 2020https://github.com/nodejs/node/pull/34957#event-3706361803
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 29, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683267070
https://ci.nodejs.org/job/node-test-pull-request/32975/https://ci.nodejs.org/job/node-test-pull-request/32975/
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/ronag
ronaghttps://github.com/ronag
Aug 29, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-478115509
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
ronaghttps://github.com/ronag
https://github.com/nodejs/node/pull/34957#pullrequestreview-478115509
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Aug 30, 2020 https://github.com/nodejs/node/pull/34957#pullrequestreview-478212124
View reviewed changes https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
Trotthttps://github.com/Trott
Aug 30, 2020 https://github.com/nodejs/node/pull/34957#ref-commit-c1ef122
https://github.com/addaleax
https://github.com/Trott
stream: allow using .push()/.unshift() during once('data')https://github.com/nodejs/node/commit/c1ef122e9805d965fd606a3c2808d938ecc20ff5
c1ef122https://github.com/nodejs/node/commit/c1ef122e9805d965fd606a3c2808d938ecc20ff5
#34957https://github.com/nodejs/node/pull/34957
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 30, 2020https://github.com/nodejs/node/pull/34957#issuecomment-683435784
c1ef122https://github.com/nodejs/node/commit/c1ef122e9805d965fd606a3c2808d938ecc20ff5
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 30, 2020https://github.com/nodejs/node/pull/34957#event-3707406510
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
August 30, 2020 18:52https://github.com/nodejs/node/pull/34957#event-3707538191
richardlauhttps://github.com/richardlau
Sep 1, 2020 https://github.com/nodejs/node/pull/34957#ref-commit-f537c86
https://github.com/addaleax
https://github.com/richardlau
stream: allow using .push()/.unshift() during once('data')https://github.com/nodejs/node/commit/f537c868b942c8a77e8ef20e9217c17679fa86f6
f537c86https://github.com/nodejs/node/commit/f537c868b942c8a77e8ef20e9217c17679fa86f6
#34957https://github.com/nodejs/node/pull/34957
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 2, 2020 https://github.com/nodejs/node/pull/34957#ref-pullrequest-691140213
v14.10.0 proposal #35023 https://github.com/nodejs/node/pull/35023
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34957#ref-commit-bcc6b4f
https://github.com/addaleax
stream: allow using .push()/.unshift() during once('data')https://github.com/nodejs/node/commit/bcc6b4f7794fbcac774d652087ed0ceceb8bf329
bcc6b4fhttps://github.com/nodejs/node/commit/bcc6b4f7794fbcac774d652087ed0ceceb8bf329
#34957https://github.com/nodejs/node/pull/34957
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34957#ref-commit-d44b05b
https://github.com/addaleax
stream: allow using .push()/.unshift() during once('data')https://github.com/nodejs/node/commit/d44b05b18cc24ef022e472753fc8edcc3acf6f40
d44b05bhttps://github.com/nodejs/node/commit/d44b05b18cc24ef022e472753fc8edcc3acf6f40
#34957https://github.com/nodejs/node/pull/34957
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34957#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34957
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/cjihrig
cjihrig https://github.com/cjihrig
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/nodejs/node/pull/34957/files/d21c4099b496b7de06bc6c38f0a890a7269e9368
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/34957
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/lundibundi
https://github.com/Trott
https://github.com/benjamingr
https://github.com/lpinca
https://github.com/cjihrig
https://github.com/ronag
https://github.com/rickyes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.