| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:184fb09b-d893-fbcd-e22e-0630e39395d8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F6E:CF40E:4D999F:6C56C8:696A7532 |
| html-safe-nonce | 08e03a9e6ce3f38ba246ab8a11e341ec728314c1ea3a7a0b8b2b01710d28ff75 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjZFOkNGNDBFOjREOTk5Rjo2QzU2Qzg6Njk2QTc1MzIiLCJ2aXNpdG9yX2lkIjoiMTQxNjA2MjI4NTYwNjcxMjYyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4ed022f4d2ff6121cff556c6714f8b677d05f3b827e5531a75da07fe15bf9985 |
| hovercard-subject-tag | pull_request:475082227 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34953/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2fc9b804f16efaafe893ad88b3fb8cbe8eba82a6e6af3653932a0ffe7ed743c5/nodejs/node/pull/34953 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2fc9b804f16efaafe893ad88b3fb8cbe8eba82a6e6af3653932a0ffe7ed743c5/nodejs/node/pull/34953 |
| og:image:alt | Start up a TLS server on localhost rather than using example.org.
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34953#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34953 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34953 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34953 |
| Reload | https://github.com/nodejs/node/pull/34953 |
| Reload | https://github.com/nodejs/node/pull/34953 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34953#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:internet-tls | https://github.com/Trott/io.js/tree/internet-tls |
|
test: make test-tls-reuse-host-from-socket pass without internet
| https://github.com/nodejs/node/pull/34953#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:internet-tls | https://github.com/Trott/io.js/tree/internet-tls |
|
Conversation
3
| https://github.com/nodejs/node/pull/34953 |
|
Commits
1
| https://github.com/nodejs/node/pull/34953/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34953/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34953/files |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 28, 2020 | https://github.com/nodejs/node/pull/34953#issue-687703541 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 28, 2020 | https://github.com/nodejs/node/pull/34953#event-3702304716 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 28, 2020 | https://github.com/nodejs/node/pull/34953#event-3702306057 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 28, 2020 | https://github.com/nodejs/node/pull/34953#event-3702310221 |
| https://github.com/nodejs-github-bot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34953 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 28, 2020
| https://github.com/nodejs/node/pull/34953#pullrequestreview-477822311 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34953/files |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 28, 2020 | https://github.com/nodejs/node/pull/34953#issuecomment-682754049 |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
| https://ci.nodejs.org/job/node-test-pull-request/32966/ | https://ci.nodejs.org/job/node-test-pull-request/32966/ |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
| https://github.com/benjamingr |
| benjamingr | https://github.com/benjamingr |
|
Aug 28, 2020
| https://github.com/nodejs/node/pull/34953#pullrequestreview-477883816 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34953/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 28, 2020
| https://github.com/nodejs/node/pull/34953#pullrequestreview-477942584 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34953/files |
|
| https://github.com/Trott |
| test: make test-tls-reuse-host-from-socket pass without internet | https://github.com/nodejs/node/pull/34953/commits/4fa439c5feafd31b26e083ce9f6642faf51c981e |
| 4fa439c | https://github.com/nodejs/node/pull/34953/commits/4fa439c5feafd31b26e083ce9f6642faf51c981e |
| nodejs#34953 | https://github.com/nodejs/node/pull/34953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/6a625b88cda4ada77a575763ac8c5189d708ef61..4fa439c5feafd31b26e083ce9f6642faf51c981e |
| 6a625b8 | https://github.com/nodejs/node/commit/6a625b88cda4ada77a575763ac8c5189d708ef61 |
| 4fa439c | https://github.com/nodejs/node/commit/4fa439c5feafd31b26e083ce9f6642faf51c981e |
|
Compare
| https://github.com/nodejs/node/compare/6a625b88cda4ada77a575763ac8c5189d708ef61..4fa439c5feafd31b26e083ce9f6642faf51c981e |
| August 30, 2020 05:41 | https://github.com/nodejs/node/pull/34953#event-3707038968 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| 4fa439c | https://github.com/nodejs/node/commit/4fa439c5feafd31b26e083ce9f6642faf51c981e |
| Aug 30, 2020 | https://github.com/nodejs/node/pull/34953#event-3707039094 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 30, 2020 | https://github.com/nodejs/node/pull/34953#issuecomment-683379410 |
| 4fa439c | https://github.com/nodejs/node/commit/4fa439c5feafd31b26e083ce9f6642faf51c981e |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 30, 2020 05:42 | https://github.com/nodejs/node/pull/34953#event-3707039152 |
| richardlau | https://github.com/richardlau |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/34953#ref-commit-75d1612 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| test: make test-tls-reuse-host-from-socket pass without internet | https://github.com/nodejs/node/commit/75d16125e120e9ace37c9e59d6575a7b58949504 |
| 75d1612 | https://github.com/nodejs/node/commit/75d16125e120e9ace37c9e59d6575a7b58949504 |
| #34953 | https://github.com/nodejs/node/pull/34953 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 2, 2020
| https://github.com/nodejs/node/pull/34953#ref-pullrequest-691140213 |
|
v14.10.0 proposal
#35023
| https://github.com/nodejs/node/pull/35023 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34953#ref-commit-e19e195 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: make test-tls-reuse-host-from-socket pass without internet | https://github.com/nodejs/node/commit/e19e195d210b6de3e1f9927d8db13815124c8c4e |
| e19e195 | https://github.com/nodejs/node/commit/e19e195d210b6de3e1f9927d8db13815124c8c4e |
| #34953 | https://github.com/nodejs/node/pull/34953 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34953#ref-commit-46f94f9 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: make test-tls-reuse-host-from-socket pass without internet | https://github.com/nodejs/node/commit/46f94f9111c17cac360d9bfd377f839febf1018d |
| 46f94f9 | https://github.com/nodejs/node/commit/46f94f9111c17cac360d9bfd377f839febf1018d |
| #34953 | https://github.com/nodejs/node/pull/34953 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34953#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34953 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34953/files/6a625b88cda4ada77a575763ac8c5189d708ef61 |
|
| https://github.com/benjamingr |
|
benjamingr
| https://github.com/benjamingr |
|
| https://github.com/nodejs/node/pull/34953/files/6a625b88cda4ada77a575763ac8c5189d708ef61 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34953/files/6a625b88cda4ada77a575763ac8c5189d708ef61 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34953 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/benjamingr |
|
| https://github.com/lpinca |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |