René's URL Explorer Experiment


Title: module: use isURLInstance instead of instanceof by aduh95 · Pull Request #34951 · nodejs/node · GitHub

Open Graph Title: module: use isURLInstance instead of instanceof by aduh95 · Pull Request #34951 · nodejs/node

X Title: module: use isURLInstance instead of instanceof by aduh95 · Pull Request #34951 · nodejs/node

Description: Related to #34622, in case there are several WHATWG URL implementations available, isURLInstance would work better than instanceof URL. Might also be more efficient, but I haven't run any benchmark...

Open Graph Description: Related to #34622, in case there are several WHATWG URL implementations available, isURLInstance would work better than instanceof URL. Might also be more efficient, but I haven't run any bench...

X Description: Related to #34622, in case there are several WHATWG URL implementations available, isURLInstance would work better than instanceof URL. Might also be more efficient, but I haven't run any b...

Opengraph URL: https://github.com/nodejs/node/pull/34951

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f402127b-18c8-5976-f037-b0df7a565627
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE68C:C8B0C:E692F6:13D3DD3:696A912D
html-safe-noncefd202cf3cbd86dd42180b45fa913312fa222cee06b905e3aea49ebd3f170cedb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjhDOkM4QjBDOkU2OTJGNjoxM0QzREQzOjY5NkE5MTJEIiwidmlzaXRvcl9pZCI6IjcyNTYzNDY4ODMyODgzNzE1MDEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac59e2e45a77c9d7c2947aaf8ac276194529cb4940fe389a907d3b08b5c30c2dd3
hovercard-subject-tagpull_request:474969770
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34951/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d6bbc61a57b115b020df758c423f739eccb61f5fa106e1ae3e9acd6d5c700614/nodejs/node/pull/34951
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d6bbc61a57b115b020df758c423f739eccb61f5fa106e1ae3e9acd6d5c700614/nodejs/node/pull/34951
og:image:altRelated to #34622, in case there are several WHATWG URL implementations available, isURLInstance would work better than instanceof URL. Might also be more efficient, but I haven't run any bench...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaduh95
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34951#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34951
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34951
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34951
Reloadhttps://github.com/nodejs/node/pull/34951
Reloadhttps://github.com/nodejs/node/pull/34951
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34951
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34951
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34951#issue-comment-box
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:use-isurlinstance-createrequirehttps://github.com/aduh95/node/tree/use-isurlinstance-createrequire
module: use isURLInstance instead of instanceof https://github.com/nodejs/node/pull/34951#top
aduh95https://github.com/aduh95
nodejs:masterhttps://github.com/nodejs/node/tree/master
aduh95:use-isurlinstance-createrequirehttps://github.com/aduh95/node/tree/use-isurlinstance-createrequire
Conversation 11 https://github.com/nodejs/node/pull/34951
Commits 1 https://github.com/nodejs/node/pull/34951/commits
Checks 0 https://github.com/nodejs/node/pull/34951/checks
Files changed https://github.com/nodejs/node/pull/34951/files
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 27, 2020https://github.com/nodejs/node/pull/34951#issue-687564956
Please reload this pagehttps://github.com/nodejs/node/pull/34951
#34622https://github.com/nodejs/node/pull/34622
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
module: use isURLInstance instead of instanceofhttps://github.com/nodejs/node/pull/34951/commits/6766b65bedc0295e57327121dec34e36d434e18d
6766b65https://github.com/nodejs/node/pull/34951/commits/6766b65bedc0295e57327121dec34e36d434e18d
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 27, 2020https://github.com/nodejs/node/pull/34951#issuecomment-682208337
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 27, 2020https://github.com/nodejs/node/pull/34951#issuecomment-682210461
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/benjamingr
benjamingrhttps://github.com/benjamingr
Aug 27, 2020 https://github.com/nodejs/node/pull/34951#pullrequestreview-477117826
View reviewed changes https://github.com/nodejs/node/pull/34951/files/6766b65bedc0295e57327121dec34e36d434e18d
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 28, 2020https://github.com/nodejs/node/pull/34951#issuecomment-682433240
@ljharbhttps://github.com/ljharb
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 28, 2020https://github.com/nodejs/node/pull/34951#issuecomment-682854339
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 28, 2020https://github.com/nodejs/node/pull/34951#issuecomment-682996269
#34622https://github.com/nodejs/node/pull/34622
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 28, 2020https://github.com/nodejs/node/pull/34951#issuecomment-683165488
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
aduh95https://github.com/aduh95
Aug 28, 2020https://github.com/nodejs/node/pull/34951#issuecomment-683168632
@ljharbhttps://github.com/ljharb
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 7, 2020https://github.com/nodejs/node/pull/34951#issuecomment-688500342
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/DerekNonGeneric
DerekNonGenerichttps://github.com/DerekNonGeneric
Sep 11, 2020 https://github.com/nodejs/node/pull/34951#pullrequestreview-486426732
View reviewed changes https://github.com/nodejs/node/pull/34951/files/6766b65bedc0295e57327121dec34e36d434e18d
https://github.com/DerekNonGeneric
DerekNonGenerichttps://github.com/DerekNonGeneric
Sep 11, 2020https://github.com/nodejs/node/pull/34951#issuecomment-690833292
node/lib/internal/url.jshttps://github.com/nodejs/node/blob/22c52aac6ace9154e9424c2994289ee4dde12bab/lib/internal/url.js#L1420-L1422
22c52aahttps://github.com/nodejs/node/commit/22c52aac6ace9154e9424c2994289ee4dde12bab
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Sep 11, 2020https://github.com/nodejs/node/pull/34951#event-3753987883
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 11, 2020https://github.com/nodejs/node/pull/34951#issuecomment-690834388
https://ci.nodejs.org/job/node-test-pull-request/33131/https://ci.nodejs.org/job/node-test-pull-request/33131/
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 14, 2020 https://github.com/nodejs/node/pull/34951#ref-issue-678857349
Tracking Issue: commit queue issues and feedback #34770 https://github.com/nodejs/node/issues/34770
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
commit-queue https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue
Sep 15, 2020https://github.com/nodejs/node/pull/34951#event-3770534622
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2020https://github.com/nodejs/node/pull/34951#issuecomment-693009192
d24eecdhttps://github.com/nodejs/node/commit/d24eecd7d73959872058ea5cee5cd83a9825fa13
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 15, 2020https://github.com/nodejs/node/pull/34951#event-3770534983
nodejs-github-bothttps://github.com/nodejs-github-bot
Sep 15, 2020 https://github.com/nodejs/node/pull/34951#ref-commit-d24eecd
https://github.com/aduh95
https://github.com/nodejs-github-bot
module: use isURLInstance instead of instanceofhttps://github.com/nodejs/node/commit/d24eecd7d73959872058ea5cee5cd83a9825fa13
d24eecdhttps://github.com/nodejs/node/commit/d24eecd7d73959872058ea5cee5cd83a9825fa13
#34951https://github.com/nodejs/node/pull/34951
ruyadornohttps://github.com/ruyadorno
Sep 21, 2020 https://github.com/nodejs/node/pull/34951#ref-commit-76e24f9
https://github.com/aduh95
https://github.com/ruyadorno
module: use isURLInstance instead of instanceofhttps://github.com/nodejs/node/commit/76e24f9aa9ba6e95b37b0e339ddf8dba86a2b7b7
76e24f9https://github.com/nodejs/node/commit/76e24f9aa9ba6e95b37b0e339ddf8dba86a2b7b7
#34951https://github.com/nodejs/node/pull/34951
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Sep 21, 2020 https://github.com/nodejs/node/pull/34951#ref-pullrequest-705877178
V14.12.0 proposal #35285 https://github.com/nodejs/node/pull/35285
guybedfordhttps://github.com/guybedford
Sep 28, 2020 https://github.com/nodejs/node/pull/34951#ref-commit-be78b83
https://github.com/aduh95
https://github.com/guybedford
module: use isURLInstance instead of instanceofhttps://github.com/guybedford/node/commit/be78b835f6f5940616a2f3d93a54bc26a83cbbac
be78b83https://github.com/guybedford/node/commit/be78b835f6f5940616a2f3d93a54bc26a83cbbac
nodejs#34951https://github.com/nodejs/node/pull/34951
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-open-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x
Sep 28, 2020https://github.com/nodejs/node/pull/34951#event-3813641582
codebyterehttps://github.com/codebytere
Oct 1, 2020 https://github.com/nodejs/node/pull/34951#ref-commit-89a58f6
https://github.com/aduh95
https://github.com/codebytere
module: use isURLInstance instead of instanceofhttps://github.com/nodejs/node/commit/89a58f61d72eb70e582dc79f838530a60be7b971
89a58f6https://github.com/nodejs/node/commit/89a58f61d72eb70e582dc79f838530a60be7b971
#34951https://github.com/nodejs/node/pull/34951
#35385https://github.com/nodejs/node/pull/35385
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 4, 2020 https://github.com/nodejs/node/pull/34951#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
joesepihttps://github.com/joesepi
Jan 8, 2021 https://github.com/nodejs/node/pull/34951#ref-commit-0f6061a
https://github.com/aduh95
https://github.com/joesepi
module: use isURLInstance instead of instanceofhttps://github.com/joesepi/node/commit/0f6061acfe23f40c3ebd1238af395992d88bb14b
0f6061ahttps://github.com/joesepi/node/commit/0f6061acfe23f40c3ebd1238af395992d88bb14b
nodejs#34951https://github.com/nodejs/node/pull/34951
https://github.com/aduh95
aduh95https://github.com/aduh95
July 16, 2022 16:29https://github.com/nodejs/node/pull/34951#event-7006320168
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34951
https://github.com/benjamingr
benjamingr https://github.com/benjamingr
https://github.com/nodejs/node/pull/34951/files/6766b65bedc0295e57327121dec34e36d434e18d
https://github.com/DerekNonGeneric
DerekNonGeneric https://github.com/DerekNonGeneric
https://github.com/nodejs/node/pull/34951/files/6766b65bedc0295e57327121dec34e36d434e18d
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
module https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Amodule
Please reload this pagehttps://github.com/nodejs/node/pull/34951
https://github.com/aduh95
https://github.com/nodejs-github-bot
https://github.com/ljharb
https://github.com/DerekNonGeneric
https://github.com/benjamingr
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.