| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7aa20732-4a78-edbf-e408-cf7ae0557f4f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C588:312517:6EF869:9AAB0E:696A7242 |
| html-safe-nonce | 86cca5686688fd978d4f53219ffefe36ee4e0cf1f9c11f376cc123b4b204a39f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTg4OjMxMjUxNzo2RUY4Njk6OUFBQjBFOjY5NkE3MjQyIiwidmlzaXRvcl9pZCI6IjQyNTUwNzY4NjAwMzE0MzIzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 964e3863db127c77f0eab22deb7bea90f77d2945f2769fd2eb9e5f3b82a48fc1 |
| hovercard-subject-tag | pull_request:473848316 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34932/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d9d1fa752ecd59a9f9f9179530904e704a15672e33df687256e255ba4eb1a6e4/nodejs/node/pull/34932 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d9d1fa752ecd59a9f9f9179530904e704a15672e33df687256e255ba4eb1a6e4/nodejs/node/pull/34932 |
| og:image:alt | I figured that should explain why the bot didn't tag @nodejs/modules in #34875.
Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?
I'v... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aduh95 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34932#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34932 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34932 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34932 |
| Reload | https://github.com/nodejs/node/pull/34932 |
| Reload | https://github.com/nodejs/node/pull/34932 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34932#issue-comment-box |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:patch-3 | https://github.com/aduh95/node/tree/patch-3 |
|
meta: update module pages in CODEOWNERS
| https://github.com/nodejs/node/pull/34932#top |
| aduh95 | https://github.com/aduh95 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| aduh95:patch-3 | https://github.com/aduh95/node/tree/patch-3 |
|
Conversation
11
| https://github.com/nodejs/node/pull/34932 |
|
Commits
1
| https://github.com/nodejs/node/pull/34932/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34932/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34932/files |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#issue-686250726 |
| #34875 | https://github.com/nodejs/node/pull/34875 |
| #34748 | https://github.com/nodejs/node/pull/34748 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-680827756 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#event-3694387974 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-680830424 |
| #34748 | https://github.com/nodejs/node/pull/34748 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 26, 2020
| https://github.com/nodejs/node/pull/34932#pullrequestreview-475410321 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34932/files |
| .github/CODEOWNERS | https://github.com/nodejs/node/pull/34932/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-681033629 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Aug 26, 2020
| https://github.com/nodejs/node/pull/34932#pullrequestreview-475728499 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34932/files |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34932#event-3695992471 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-683310755 |
| @richardlau | https://github.com/richardlau |
| #34748 | https://github.com/nodejs/node/pull/34748 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
blocked
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ablocked |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34932#event-3706639717 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-683313602 |
| @richardlau | https://github.com/richardlau |
| #34748 | https://github.com/nodejs/node/pull/34748 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
|
| https://github.com/aduh95 |
| meta: update module pages in CODEOWNERS | https://github.com/nodejs/node/pull/34932/commits/cac7dca4084b7c0adec6dd206561e02905559fec |
| cac7dca | https://github.com/nodejs/node/pull/34932/commits/cac7dca4084b7c0adec6dd206561e02905559fec |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| force-pushed | https://github.com/nodejs/node/compare/7dec2d1f801e3248caf044f2a19fad5333ddc3dd..cac7dca4084b7c0adec6dd206561e02905559fec |
| 7dec2d1 | https://github.com/nodejs/node/commit/7dec2d1f801e3248caf044f2a19fad5333ddc3dd |
| cac7dca | https://github.com/nodejs/node/commit/cac7dca4084b7c0adec6dd206561e02905559fec |
|
Compare
| https://github.com/nodejs/node/compare/7dec2d1f801e3248caf044f2a19fad5333ddc3dd..cac7dca4084b7c0adec6dd206561e02905559fec |
| August 29, 2020 16:55 | https://github.com/nodejs/node/pull/34932#event-3706651835 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 29, 2020
| https://github.com/nodejs/node/pull/34932#pullrequestreview-478147486 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
| https://github.com/DerekNonGeneric |
| DerekNonGeneric | https://github.com/DerekNonGeneric |
|
Aug 29, 2020
| https://github.com/nodejs/node/pull/34932#pullrequestreview-478147641 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 31, 2020
| https://github.com/nodejs/node/pull/34932#pullrequestreview-478634753 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
| MylesBorins | https://github.com/MylesBorins |
| https://github.com/nodejs/node/pull/34932#pullrequestreview-478634753 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 31, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-683794207 |
| 622ea75 | https://github.com/nodejs/node/commit/622ea7514e8f80aff7534c44c9a6f2b91feee524 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 31, 2020 | https://github.com/nodejs/node/pull/34932#event-3709993640 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 31, 2020
| https://github.com/nodejs/node/pull/34932#ref-commit-622ea75 |
|
| https://github.com/aduh95 |
|
| https://github.com/MylesBorins |
| meta: update module pages in CODEOWNERS | https://github.com/nodejs/node/commit/622ea7514e8f80aff7534c44c9a6f2b91feee524 |
| 622ea75 | https://github.com/nodejs/node/commit/622ea7514e8f80aff7534c44c9a6f2b91feee524 |
| #34932 | https://github.com/nodejs/node/pull/34932 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| September 1, 2020 10:56 | https://github.com/nodejs/node/pull/34932#event-3714224649 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
| Sep 1, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-684767799 |
| #34875 | https://github.com/nodejs/node/pull/34875 |
| @nodejs-github-bot | https://github.com/nodejs-github-bot |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
backport-blocked-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x |
| Sep 1, 2020 | https://github.com/nodejs/node/pull/34932#event-3716202919 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
| Sep 1, 2020 | https://github.com/nodejs/node/pull/34932#issuecomment-685041360 |
| #34748 | https://github.com/nodejs/node/pull/34748 |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
backport-blocked-v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34932#event-3799568529 |
| addaleax | https://github.com/addaleax |
|
Sep 23, 2020
| https://github.com/nodejs/node/pull/34932#ref-commit-d1be44c |
|
| https://github.com/aduh95 |
|
| https://github.com/addaleax |
| meta: update module pages in CODEOWNERS | https://github.com/nodejs/node/commit/d1be44c705cca4553842650ade673be5837fcd3c |
| d1be44c | https://github.com/nodejs/node/commit/d1be44c705cca4553842650ade673be5837fcd3c |
| #34932 | https://github.com/nodejs/node/pull/34932 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
backport-blocked-v14.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v14.x |
| Sep 24, 2020 | https://github.com/nodejs/node/pull/34932#event-3804621728 |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 24, 2020
| https://github.com/nodejs/node/pull/34932#ref-commit-ab7d0e9 |
|
| https://github.com/aduh95 |
|
| https://github.com/MylesBorins |
| meta: update module pages in CODEOWNERS | https://github.com/nodejs/node/commit/ab7d0e92b1ea2180789d83e31b7ce23edf188af1 |
| ab7d0e9 | https://github.com/nodejs/node/commit/ab7d0e92b1ea2180789d83e31b7ce23edf188af1 |
| #34932 | https://github.com/nodejs/node/pull/34932 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34932#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Sep 29, 2020
| https://github.com/nodejs/node/pull/34932#ref-pullrequest-711269125 |
|
v14.13.0 proposal
#35419
| https://github.com/nodejs/node/pull/35419 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34932 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
|
| https://github.com/MylesBorins |
|
MylesBorins
| https://github.com/MylesBorins |
|
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
|
| https://github.com/mmarchini |
|
mmarchini
| https://github.com/mmarchini |
|
| https://github.com/nodejs/node/pull/34932/files/7dec2d1f801e3248caf044f2a19fad5333ddc3dd |
|
| https://github.com/DerekNonGeneric |
|
DerekNonGeneric
| https://github.com/DerekNonGeneric |
|
| https://github.com/nodejs/node/pull/34932/files/cac7dca4084b7c0adec6dd206561e02905559fec |
|
meta
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ameta |
| Please reload this page | https://github.com/nodejs/node/pull/34932 |
|
| https://github.com/aduh95 |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/richardlau |
|
| https://github.com/mmarchini |
|
| https://github.com/MylesBorins |
|
| https://github.com/DerekNonGeneric |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |