| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:20af91c8-bccc-ce7f-0dae-0e9d7fcd6afe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9A38:392B41:4F5BB5:6D3486:696A766F |
| html-safe-nonce | 1daf4698fd6b8e47d59ae8dedd4a08d289bd2769a2169c9ad742fb6a053f054a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTM4OjM5MkI0MTo0RjVCQjU6NkQzNDg2OjY5NkE3NjZGIiwidmlzaXRvcl9pZCI6IjI4Mjk1MDE3Mjc0MDY0NTQzODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 90c2a03d27c6dc8be60773631c6a8d6f323be9f03b117fd7f51fab4601d8e974 |
| hovercard-subject-tag | pull_request:472731695 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34910/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0f290a4e662e40643ecc9cbf54f59aed7b7bbe03856b5d6fd510a0ad1fbad026/nodejs/node/pull/34910 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0f290a4e662e40643ecc9cbf54f59aed7b7bbe03856b5d6fd510a0ad1fbad026/nodejs/node/pull/34910 |
| og:image:alt | Most of the instances of node-addon-api are surrounded with backticks,
but two aren't. Add backticks for consistency.
Checklist
documentation is changed or added
commit message follows com... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34910#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34910 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34910 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34910 |
| Reload | https://github.com/nodejs/node/pull/34910 |
| Reload | https://github.com/nodejs/node/pull/34910 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34910#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:node-addon-api | https://github.com/Trott/io.js/tree/node-addon-api |
|
doc use consistent typography for node-addon-api
| https://github.com/nodejs/node/pull/34910#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:node-addon-api | https://github.com/Trott/io.js/tree/node-addon-api |
|
Conversation
3
| https://github.com/nodejs/node/pull/34910 |
|
Commits
1
| https://github.com/nodejs/node/pull/34910/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34910/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34910/files |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34910#issue-684924532 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34910#event-3686989528 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34910#issuecomment-679332400 |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 25, 2020
| https://github.com/nodejs/node/pull/34910#pullrequestreview-474185079 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34910/files |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Aug 25, 2020
| https://github.com/nodejs/node/pull/34910#pullrequestreview-474455329 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34910/files |
| NickNaso | https://github.com/NickNaso |
| https://github.com/nodejs/node/pull/34910#pullrequestreview-474455329 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 26, 2020
| https://github.com/nodejs/node/pull/34910#pullrequestreview-475668948 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34910/files |
|
| https://github.com/Trott |
| doc: use consistent typography for node-addon-api | https://github.com/nodejs/node/pull/34910/commits/b01d314167c472237036798783eed7de96cfdfc5 |
| b01d314 | https://github.com/nodejs/node/pull/34910/commits/b01d314167c472237036798783eed7de96cfdfc5 |
| nodejs#34910 | https://github.com/nodejs/node/pull/34910 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/4dd7730c95b8fa414be0b2c3d4204e6fa1223172..b01d314167c472237036798783eed7de96cfdfc5 |
| 4dd7730 | https://github.com/nodejs/node/commit/4dd7730c95b8fa414be0b2c3d4204e6fa1223172 |
| b01d314 | https://github.com/nodejs/node/commit/b01d314167c472237036798783eed7de96cfdfc5 |
|
Compare
| https://github.com/nodejs/node/compare/4dd7730c95b8fa414be0b2c3d4204e6fa1223172..b01d314167c472237036798783eed7de96cfdfc5 |
| August 27, 2020 13:58 | https://github.com/nodejs/node/pull/34910#event-3699777799 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| b01d314 | https://github.com/nodejs/node/commit/b01d314167c472237036798783eed7de96cfdfc5 |
| Aug 27, 2020 | https://github.com/nodejs/node/pull/34910#event-3699779465 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 27, 2020 | https://github.com/nodejs/node/pull/34910#issuecomment-681966355 |
| b01d314 | https://github.com/nodejs/node/commit/b01d314167c472237036798783eed7de96cfdfc5 |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 27, 2020 13:58 | https://github.com/nodejs/node/pull/34910#event-3699779948 |
| richardlau | https://github.com/richardlau |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/34910#ref-commit-4782ec7 |
|
| https://github.com/Trott |
|
| https://github.com/richardlau |
| doc: use consistent typography for node-addon-api | https://github.com/nodejs/node/commit/4782ec7b3b3fe3cf6176e3f5dd2457417c8294f7 |
| 4782ec7 | https://github.com/nodejs/node/commit/4782ec7b3b3fe3cf6176e3f5dd2457417c8294f7 |
| #34910 | https://github.com/nodejs/node/pull/34910 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 2, 2020
| https://github.com/nodejs/node/pull/34910#ref-pullrequest-691140213 |
|
v14.10.0 proposal
#35023
| https://github.com/nodejs/node/pull/35023 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34910#ref-commit-b76affd |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: use consistent typography for node-addon-api | https://github.com/nodejs/node/commit/b76affd4dcc3e3e5035e0a0127448632a4ba1619 |
| b76affd | https://github.com/nodejs/node/commit/b76affd4dcc3e3e5035e0a0127448632a4ba1619 |
| #34910 | https://github.com/nodejs/node/pull/34910 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34910#ref-commit-f50fec6 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: use consistent typography for node-addon-api | https://github.com/nodejs/node/commit/f50fec605db8ce8e5d186b00e88e9238c13724f6 |
| f50fec6 | https://github.com/nodejs/node/commit/f50fec605db8ce8e5d186b00e88e9238c13724f6 |
| #34910 | https://github.com/nodejs/node/pull/34910 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34910#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34910 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34910/files/4dd7730c95b8fa414be0b2c3d4204e6fa1223172 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34910/files/4dd7730c95b8fa414be0b2c3d4204e6fa1223172 |
|
| https://github.com/NickNaso |
|
NickNaso
| https://github.com/NickNaso |
|
| https://github.com/nodejs/node/pull/34910/files/4dd7730c95b8fa414be0b2c3d4204e6fa1223172 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/34910 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/NickNaso |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |