| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:fc17e0aa-9c61-207a-84df-c640b7f0f0fb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E8A2:5105D:72E92A8:A1F1E00:6A50064C |
| html-safe-nonce | f997898a135eef59cf1bd721cc25ec7bd0c7d17c31f15e1e5965a53ca599ba7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEEyOjUxMDVEOjcyRTkyQTg6QTFGMUUwMDo2QTUwMDY0QyIsInZpc2l0b3JfaWQiOiIzNjk2NDkzNTMyNDE4MTQ3OTE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | d77abcd4deade0cce6752191e0f9d4844b83d31b90ca8aa2d0de5328dc0edfae |
| hovercard-subject-tag | pull_request:48487638 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3489/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5a06c90b8cfcc5b8d27c43512f773deb39189a7ac24a69a49647c62f07444ff9/nodejs/node/pull/3489 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5a06c90b8cfcc5b8d27c43512f773deb39189a7ac24a69a49647c62f07444ff9/nodejs/node/pull/3489 |
| og:image:alt | I feel better about doing it this way.
replaces #3308
See: #3308 (comment)
cc @nodejs/build or anyone elase: any sign-off will do. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Fishrock123 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 56eec25a3430492dd6ec2a480eb33256a0da5192d5714b0db4f5ab5f33203d94 |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e155b8a71f9284454f73118dfe5e634e74f7afb3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/3489#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3489 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3489 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/3489 |
| Reload | https://github.com/nodejs/node/pull/3489 |
| Reload | https://github.com/nodejs/node/pull/3489 |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.3k
| https://github.com/nodejs/node/issues |
|
Pull requests
976
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:test-npm-fixes-for-npm3 | https://github.com/Fishrock123/node/tree/test-npm-fixes-for-npm3 |
| Conversation | https://github.com/nodejs/node/pull/3489 |
| Commits0 (0) | https://github.com/nodejs/node/pull/3489/commits |
| Checks | https://github.com/nodejs/node/pull/3489/checks |
| Files changed | https://github.com/nodejs/node/pull/3489/files |
| tools: test-npm fixes for npm3 | https://github.com/nodejs/node/pull/3489#top |
| Fishrock123 | https://github.com/Fishrock123 |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Fishrock123:test-npm-fixes-for-npm3 | https://github.com/Fishrock123/node/tree/test-npm-fixes-for-npm3 |
|
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/3489#issue-112851860 |
| #3308 | https://github.com/nodejs/node/pull/3308 |
| #3308 (comment) | https://github.com/nodejs/node/pull/3308#discussion_r42545229 |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/3489#event-442913281 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/f69b0a0c72119c0c2db8c7ae97a1eb68f6ce7164..6c9938bbfd03d60e7638b0a052f1295d10dbfa06 |
| f69b0a0 | https://github.com/nodejs/node/commit/f69b0a0c72119c0c2db8c7ae97a1eb68f6ce7164 |
| 6c9938b | https://github.com/nodejs/node/commit/6c9938bbfd03d60e7638b0a052f1295d10dbfa06 |
|
Compare
| https://github.com/nodejs/node/compare/f69b0a0c72119c0c2db8c7ae97a1eb68f6ce7164..6c9938bbfd03d60e7638b0a052f1295d10dbfa06 |
| October 22, 2015 17:32 | https://github.com/nodejs/node/pull/3489#event-442915155 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/3489#issuecomment-150303956 |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 22, 2015
| https://github.com/nodejs/node/pull/3489#ref-commit-349fbe9 |
|
| https://github.com/iarna |
|
| https://github.com/Fishrock123 |
| tools: update test-npm to work with npm 3 | https://github.com/nodejs/node/commit/349fbe96aeb7eb3b5100f3d9b559c4b916642287 |
| 349fbe9 | https://github.com/nodejs/node/commit/349fbe96aeb7eb3b5100f3d9b559c4b916642287 |
| #3308 | https://github.com/nodejs/node/pull/3308 |
| #3489 | https://github.com/nodejs/node/pull/3489 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 22, 2015
| https://github.com/nodejs/node/pull/3489#ref-commit-9b88864 |
|
| https://github.com/Fishrock123 |
| tools: ensure npm always uses the local node | https://github.com/nodejs/node/commit/9b8886446dd183cee26adf9c603f8e1cd5da74bd |
| 9b88864 | https://github.com/nodejs/node/commit/9b8886446dd183cee26adf9c603f8e1cd5da74bd |
| #3308 | https://github.com/nodejs/node/pull/3308 |
| #3489 | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 22, 2015 | https://github.com/nodejs/node/pull/3489#event-442935362 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| force-pushed | https://github.com/nodejs/node/compare/6c9938bbfd03d60e7638b0a052f1295d10dbfa06..9b8886446dd183cee26adf9c603f8e1cd5da74bd |
| 6c9938b | https://github.com/nodejs/node/commit/6c9938bbfd03d60e7638b0a052f1295d10dbfa06 |
| 9b88864 | https://github.com/nodejs/node/commit/9b8886446dd183cee26adf9c603f8e1cd5da74bd |
|
Compare
| https://github.com/nodejs/node/compare/6c9938bbfd03d60e7638b0a052f1295d10dbfa06..9b8886446dd183cee26adf9c603f8e1cd5da74bd |
| October 22, 2015 17:51 | https://github.com/nodejs/node/pull/3489#event-442935363 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| October 22, 2015 17:51 | https://github.com/nodejs/node/pull/3489#event-442935460 |
| rvagg | https://github.com/rvagg |
|
Oct 22, 2015
| https://github.com/nodejs/node/pull/3489#ref-commit-3c3435d |
|
| https://github.com/iarna |
|
| https://github.com/rvagg |
| tools: update test-npm to work with npm 3 | https://github.com/nodejs/node/commit/3c3435d017f8b80cb02383c2fc12292ee2b60171 |
| 3c3435d | https://github.com/nodejs/node/commit/3c3435d017f8b80cb02383c2fc12292ee2b60171 |
| #3308 | https://github.com/nodejs/node/pull/3308 |
| #3489 | https://github.com/nodejs/node/pull/3489 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 22, 2015
| https://github.com/nodejs/node/pull/3489#ref-commit-6e78382 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/rvagg |
| tools: ensure npm always uses the local node | https://github.com/nodejs/node/commit/6e78382605239dd0492125acfbdffb3bb38f60e5 |
| 6e78382 | https://github.com/nodejs/node/commit/6e78382605239dd0492125acfbdffb3bb38f60e5 |
| #3308 | https://github.com/nodejs/node/pull/3308 |
| #3489 | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
Oct 22, 2015
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-110757067 |
|
test: update test-npm to work with npm 3
#3308
| https://github.com/nodejs/node/pull/3308 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 23, 2015 | https://github.com/nodejs/node/pull/3489#issuecomment-150663736 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Oct 23, 2015 | https://github.com/nodejs/node/pull/3489#issuecomment-150666399 |
| @thealphanerd | https://github.com/thealphanerd |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
|
Release proposal: v5.0.0
#3466
| https://github.com/nodejs/node/pull/3466 |
|
Preparing v4.2.2 LTS Maintenance
nodejs/Release#50
| https://github.com/nodejs/Release/issues/50 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
Dec 17, 2015
| https://github.com/nodejs/node/pull/3489#ref-issue-122642707 |
|
Release 4.2.4 Planning
#4321
| https://github.com/nodejs/node/issues/4321 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Dec 17, 2015 | https://github.com/nodejs/node/pull/3489#event-495043646 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Dec 29, 2015 | https://github.com/nodejs/node/pull/3489#issuecomment-167883275 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
| Jan 4, 2016 | https://github.com/nodejs/node/pull/3489#issuecomment-168723125 |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
| https://github.com/Fishrock123 |
| Fishrock123 | https://github.com/Fishrock123 |
|
lts-watch-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v4.x |
| Jan 4, 2016 | https://github.com/nodejs/node/pull/3489#event-504929702 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jan 14, 2016
| https://github.com/nodejs/node/pull/3489#ref-issue-126730245 |
|
Audit commits not found on v4.x-staging
#4698
| https://github.com/nodejs/node/issues/4698 |
| https://github.com/rvagg |
| rvagg | https://github.com/rvagg |
|
dont-land-on-v4.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v4.x |
| Jan 15, 2016 | https://github.com/nodejs/node/pull/3489#event-515819200 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#375
| https://github.com/aliscco/alisco-node/pull/375 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#379
| https://github.com/aliscco/alisco-node/pull/379 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#494
| https://github.com/aliscco/alisco-node/pull/494 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#532
| https://github.com/aliscco/alisco-node/pull/532 |
|
[Snyk] Security upgrade karma from 4.4.1 to 5.0.8
aliscco/alisco-node#562
| https://github.com/aliscco/alisco-node/pull/562 |
|
[Snyk] Security upgrade karma from 4.4.1 to 5.0.8
aliscco/alisco-node#595
| https://github.com/aliscco/alisco-node/pull/595 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#614
| https://github.com/aliscco/alisco-node/pull/614 |
| https://github.com/leonardoadame |
| leonardoadame | https://github.com/leonardoadame |
|
Jul 9, 2023
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-1795582213 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
leonardoadame/node#143
| https://github.com/leonardoadame/node/pull/143 |
| https://github.com/aliscco |
| aliscco | https://github.com/aliscco |
|
Oct 27, 2023
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-1964719000 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#646
| https://github.com/aliscco/alisco-node/pull/646 |
| https://github.com/aliscco |
| aliscco | https://github.com/aliscco |
|
Nov 28, 2023
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-2015478170 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#695
| https://github.com/aliscco/alisco-node/pull/695 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
leonardoadame/node#211
| https://github.com/leonardoadame/node/pull/211 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
leonardoadame/node#268
| https://github.com/leonardoadame/node/pull/268 |
| https://github.com/aliscco |
| aliscco | https://github.com/aliscco |
|
Dec 2, 2023
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-2021817777 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
aliscco/alisco-node#1024
| https://github.com/aliscco/alisco-node/pull/1024 |
| https://github.com/leonardoadame |
| leonardoadame | https://github.com/leonardoadame |
|
Dec 3, 2023
| https://github.com/nodejs/node/pull/3489#ref-pullrequest-2022260275 |
|
[Snyk] Security upgrade karma from 3.1.4 to 5.0.8
leonardoadame/node#479
| https://github.com/leonardoadame/node/pull/479 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3489 |
|
npm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anpm |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
tools
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atools |
| Please reload this page | https://github.com/nodejs/node/pull/3489 |
|
| https://github.com/Fishrock123 |
|
| https://github.com/rvagg |
|
| https://github.com/MylesBorins |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |