René's URL Explorer Experiment


Title: http2: fix Http2Response.sendDate by joaolucasl · Pull Request #34850 · nodejs/node · GitHub

Open Graph Title: http2: fix Http2Response.sendDate by joaolucasl · Pull Request #34850 · nodejs/node

X Title: http2: fix Http2Response.sendDate by joaolucasl · Pull Request #34850 · nodejs/node

Description: The sendDate flag was not being respectedby the current implementation and the Date header was being sent regardless of the config. This commit fixes that and adds tests for this case. Fixes: #3484...

Open Graph Description: The sendDate flag was not being respectedby the current implementation and the Date header was being sent regardless of the config. This commit fixes that and adds tests for this case. Fixes: #3484...

X Description: The sendDate flag was not being respectedby the current implementation and the Date header was being sent regardless of the config. This commit fixes that and adds tests for this case. Fixes: #3484...

Opengraph URL: https://github.com/nodejs/node/pull/34850

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1a29fe88-9426-2eff-3b86-eb70bef730e7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE4C:CED76:4FE82D:6F168D:696A7620
html-safe-nonce57ff360b67808a4b37c5b888bf6f41c45cc260ca9e243a54c907b875c49c67f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTRDOkNFRDc2OjRGRTgyRDo2RjE2OEQ6Njk2QTc2MjAiLCJ2aXNpdG9yX2lkIjoiMTA1MjA2MjQzMjg4MTE3ODE0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1efa9193b3f992b60fe8c595701e5709d62f6fe7c2777394d04258500d7ace47
hovercard-subject-tagpull_request:470646578
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34850/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7371e6487988faff8dc6f0be849b7e0313fc508bc6247c06253883c0fefa787e/nodejs/node/pull/34850
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7371e6487988faff8dc6f0be849b7e0313fc508bc6247c06253883c0fefa787e/nodejs/node/pull/34850
og:image:altThe sendDate flag was not being respectedby the current implementation and the Date header was being sent regardless of the config. This commit fixes that and adds tests for this case. Fixes: #3484...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoaolucasl
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34850#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34850
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34850
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34850
Reloadhttps://github.com/nodejs/node/pull/34850
Reloadhttps://github.com/nodejs/node/pull/34850
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34850
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34850
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34850#issue-comment-box
joaolucaslhttps://github.com/joaolucasl
nodejs:masterhttps://github.com/nodejs/node/tree/master
joaolucasl:fix/http2-compat-send-datehttps://github.com/joaolucasl/node/tree/fix/http2-compat-send-date
http2: fix Http2Response.sendDate https://github.com/nodejs/node/pull/34850#top
joaolucaslhttps://github.com/joaolucasl
nodejs:masterhttps://github.com/nodejs/node/tree/master
joaolucasl:fix/http2-compat-send-datehttps://github.com/joaolucasl/node/tree/fix/http2-compat-send-date
Conversation 10 https://github.com/nodejs/node/pull/34850
Commits 2 https://github.com/nodejs/node/pull/34850/commits
Checks 0 https://github.com/nodejs/node/pull/34850/checks
Files changed https://github.com/nodejs/node/pull/34850/files
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/joaolucasl
joaolucaslhttps://github.com/joaolucasl
Aug 20, 2020https://github.com/nodejs/node/pull/34850#issue-682399213
#34841https://github.com/nodejs/node/issues/34841
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/joaolucasl
http2: fix Http2Response.sendDatehttps://github.com/nodejs/node/pull/34850/commits/7d1bfc8f75ba82255b05f7dc584e978702b43e71
7d1bfc8https://github.com/nodejs/node/pull/34850/commits/7d1bfc8f75ba82255b05f7dc584e978702b43e71
nodejs#34841https://github.com/nodejs/node/issues/34841
https://github.com/joaolucasl
joaolucaslhttps://github.com/joaolucasl
code ownershttps://github.com/nodejs/node/blob/03293aa3a1e810c5ae6938cae41bf62ae418bb5f/.github/CODEOWNERS#L72
August 20, 2020 04:20https://github.com/nodejs/node/pull/34850#event-3673445558
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 20, 2020https://github.com/nodejs/node/pull/34850#issuecomment-677016119
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
Aug 20, 2020https://github.com/nodejs/node/pull/34850#event-3673445661
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Aug 20, 2020 https://github.com/nodejs/node/pull/34850#pullrequestreview-471270389
View reviewed changes https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/34850#pullrequestreview-471270389
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Aug 20, 2020 https://github.com/nodejs/node/pull/34850#pullrequestreview-471755256
View reviewed changes https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
https://github.com/rickyes
rickyeshttps://github.com/rickyes
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 20, 2020https://github.com/nodejs/node/pull/34850#event-3675934005
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 20, 2020https://github.com/nodejs/node/pull/34850#event-3675960398
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 22, 2020 https://github.com/nodejs/node/pull/34850#pullrequestreview-472933796
View reviewed changes https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
lib/internal/http2/core.jshttps://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71#diff-ac5af2e03d6e50747ae181d62ebb939ee884b05c70c42aa7297fb7323b3e6639
Please reload this pagehttps://github.com/nodejs/node/pull/34850
test/parallel/test-http2-compat-serverresponse-headers-send-date.jshttps://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71#diff-2824bfe9a15865ef687bab35470b37b8e8c980fc5dfa09ba6b1b6d10dbe216c6
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
Aug 22, 2020https://github.com/nodejs/node/pull/34850#issuecomment-678655071
https://ci.nodejs.org/job/node-test-pull-request/32868/https://ci.nodejs.org/job/node-test-pull-request/32868/
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/joaolucasl
http2: simplify options.sendDate assertion in headershttps://github.com/nodejs/node/pull/34850/commits/3cb8d7221a571a0d43e7f18ebda92422427e73e0
3cb8d72https://github.com/nodejs/node/pull/34850/commits/3cb8d7221a571a0d43e7f18ebda92422427e73e0
https://github.com/lundibundi
lundibundihttps://github.com/lundibundi
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 22, 2020https://github.com/nodejs/node/pull/34850#event-3682185449
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 22, 2020https://github.com/nodejs/node/pull/34850#event-3682187601
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 22, 2020https://github.com/nodejs/node/pull/34850#issuecomment-678669333
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://ci.nodejs.org/job/node-test-pull-request/32890/https://ci.nodejs.org/job/node-test-pull-request/32890/
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34850
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 22, 2020 https://github.com/nodejs/node/pull/34850#pullrequestreview-472947900
View reviewed changes https://github.com/nodejs/node/pull/34850/files/3cb8d7221a571a0d43e7f18ebda92422427e73e0
Trotthttps://github.com/Trott
Aug 22, 2020 https://github.com/nodejs/node/pull/34850#ref-commit-f5102fb
https://github.com/joaolucasl
https://github.com/Trott
http2: fix Http2Response.sendDatehttps://github.com/nodejs/node/commit/f5102fbcf4d959629413e7b8ddb37275286a50d8
f5102fbhttps://github.com/nodejs/node/commit/f5102fbcf4d959629413e7b8ddb37275286a50d8
#34841https://github.com/nodejs/node/issues/34841
#34850https://github.com/nodejs/node/pull/34850
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 22, 2020https://github.com/nodejs/node/pull/34850#issuecomment-678685030
f5102fbhttps://github.com/nodejs/node/commit/f5102fbcf4d959629413e7b8ddb37275286a50d8
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 22, 2020https://github.com/nodejs/node/pull/34850#event-3682273403
https://github.com/joaolucasl
joaolucaslhttps://github.com/joaolucasl
August 22, 2020 22:08https://github.com/nodejs/node/pull/34850#event-3682360548
BethGriggshttps://github.com/BethGriggs
Aug 24, 2020 https://github.com/nodejs/node/pull/34850#ref-commit-cc72584
https://github.com/joaolucasl
https://github.com/BethGriggs
http2: fix Http2Response.sendDatehttps://github.com/nodejs/node/commit/cc7258469c982b40dec562d710ccd785d2b9bef4
cc72584https://github.com/nodejs/node/commit/cc7258469c982b40dec562d710ccd785d2b9bef4
#34841https://github.com/nodejs/node/issues/34841
#34850https://github.com/nodejs/node/pull/34850
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 25, 2020 https://github.com/nodejs/node/pull/34850#ref-pullrequest-682706557
V14.9.0 proposal #34852 https://github.com/nodejs/node/pull/34852
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34850#ref-commit-4079cdd
https://github.com/joaolucasl
https://github.com/addaleax
http2: fix Http2Response.sendDatehttps://github.com/nodejs/node/commit/4079cdd5f2ee098bfc231178f0fab9f9497e1508
4079cddhttps://github.com/nodejs/node/commit/4079cdd5f2ee098bfc231178f0fab9f9497e1508
#34841https://github.com/nodejs/node/issues/34841
#34850https://github.com/nodejs/node/pull/34850
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34850#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34850
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/34850/files/3cb8d7221a571a0d43e7f18ebda92422427e73e0
https://github.com/lundibundi
lundibundi https://github.com/lundibundi
https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/nodejs/node/pull/34850/files/7d1bfc8f75ba82255b05f7dc584e978702b43e71
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
http2 https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp2
HTTP/2 server compatibility API ignores sendDate https://github.com/nodejs/node/issues/34841
Please reload this pagehttps://github.com/nodejs/node/pull/34850
https://github.com/joaolucasl
https://github.com/nodejs-github-bot
https://github.com/lundibundi
https://github.com/Trott
https://github.com/mcollina
https://github.com/rickyes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.