René's URL Explorer Experiment


Title: fs: pass err to callback if buffer is too big by evanlucas · Pull Request #3485 · nodejs/node · GitHub

Open Graph Title: fs: pass err to callback if buffer is too big by evanlucas · Pull Request #3485 · nodejs/node

X Title: fs: pass err to callback if buffer is too big by evanlucas · Pull Request #3485 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: In fs.readFile, if an encoding is specified and toString fails, do not throw an error. Instead, pass the error to the callback. Fixes: #2767

X Description: In fs.readFile, if an encoding is specified and toString fails, do not throw an error. Instead, pass the error to the callback. Fixes: #2767

Opengraph URL: https://github.com/nodejs/node/pull/3485

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:62138382-114b-9134-028e-853901e28216
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB96A:2E1FD9:F8B521:157C71E:6A4DDB3B
html-safe-noncedfc135b51592db160aef1a9432332d5dac151da309d09415f62a141c8b6df486
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTZBOjJFMUZEOTpGOEI1MjE6MTU3QzcxRTo2QTREREIzQiIsInZpc2l0b3JfaWQiOiI3ODkyNzczNzYyODM1MDEyNDExIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac638ce0acd03ea484a94b82b736e0d830d9f07e40fc2ca00fda923a163e73e0fe
hovercard-subject-tagpull_request:48448736
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3485/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88ab283331276dd6586e71a6576c98b55c524428bdd797c38b995fa5b1d812d6/nodejs/node/pull/3485
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88ab283331276dd6586e71a6576c98b55c524428bdd797c38b995fa5b1d812d6/nodejs/node/pull/3485
og:image:altIn fs.readFile, if an encoding is specified and toString fails, do not throw an error. Instead, pass the error to the callback. Fixes: #2767
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameevanlucas
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3485#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3485
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3485
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3485
Reloadhttps://github.com/nodejs/node/pull/3485
Reloadhttps://github.com/nodejs/node/pull/3485
Please reload this pagehttps://github.com/nodejs/node/pull/3485
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3485
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 963 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixreadfileerrhttps://github.com/evanlucas/node/tree/fixreadfileerr
Conversationhttps://github.com/nodejs/node/pull/3485
Commits1 (1)https://github.com/nodejs/node/pull/3485/commits
Checkshttps://github.com/nodejs/node/pull/3485/checks
Files changedhttps://github.com/nodejs/node/pull/3485/files
fs: pass err to callback if buffer is too bighttps://github.com/nodejs/node/pull/3485#top
evanlucashttps://github.com/evanlucas
nodejs:masterhttps://github.com/nodejs/node/tree/master
evanlucas:fixreadfileerrhttps://github.com/evanlucas/node/tree/fixreadfileerr
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#issue-112788742
#2767https://github.com/nodejs/node/issues/2767
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150204104
https://ci.nodejs.org/job/node-test-pull-request/565/https://ci.nodejs.org/job/node-test-pull-request/565/
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/mscdex
mscdexhttps://github.com/mscdex
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
Oct 22, 2015https://github.com/nodejs/node/pull/3485#event-442877252
jasnellhttps://github.com/jasnell
Oct 22, 2015 https://github.com/nodejs/node/pull/3485#discussion-diff-42814784
View reviewed changes https://github.com/nodejs/node/pull/3485/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/fs.jshttps://github.com/nodejs/node/pull/3485/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42814784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42814992
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42815086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42815290
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42815464
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42815511
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42815901
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
force-pushedhttps://github.com/nodejs/node/compare/ad523b551442433da2cb6abf8feacc560668aaf7..3574b974604614a06f610e9264202847fcbfea8d
ad523b5https://github.com/nodejs/node/commit/ad523b551442433da2cb6abf8feacc560668aaf7
3574b97https://github.com/nodejs/node/commit/3574b974604614a06f610e9264202847fcbfea8d
Compare https://github.com/nodejs/node/compare/ad523b551442433da2cb6abf8feacc560668aaf7..3574b974604614a06f610e9264202847fcbfea8d
October 22, 2015 22:43https://github.com/nodejs/node/pull/3485#event-443221640
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150377320
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/jasnell
jasnellhttps://github.com/jasnell
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Oct 22, 2015https://github.com/nodejs/node/pull/3485#event-443227319
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Oct 22, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150378071
Please reload this pagehttps://github.com/nodejs/node/pull/3485
trevnorrishttps://github.com/trevnorris
Oct 22, 2015 https://github.com/nodejs/node/pull/3485#discussion-diff-42816925
View reviewed changes https://github.com/nodejs/node/pull/3485/files#diff-86020844664e7ef569e49601da30e40753e094f20b5a6e5ae91b7a7df88c19b2
test/parallel/test-fs-readfile-tostring-fail.jshttps://github.com/nodejs/node/pull/3485/files#diff-86020844664e7ef569e49601da30e40753e094f20b5a6e5ae91b7a7df88c19b2
trevnorrishttps://github.com/trevnorris
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42816925
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#discussion_r42817301
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
targoshttps://github.com/targos
Oct 23, 2015https://github.com/nodejs/node/pull/3485#discussion_r42843937
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#discussion_r42894623
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 22, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150386539
@trevnorrishttps://github.com/trevnorris
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015 https://github.com/nodejs/node/pull/3485#ref-issue-111805617
v5.0.0 Planning & Checklist #3397 https://github.com/nodejs/node/issues/3397
trevnorrishttps://github.com/trevnorris
Oct 23, 2015 https://github.com/nodejs/node/pull/3485#discussion-diff-42892741
View reviewed changes https://github.com/nodejs/node/pull/3485/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
lib/fs.jshttps://github.com/nodejs/node/pull/3485/files#diff-9b2c5bf36570be7a09ba2597abdf6d9bc2cc1e19866b6674b0cf275c1188dcad
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#discussion_r42892741
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
targoshttps://github.com/targos
Oct 23, 2015https://github.com/nodejs/node/pull/3485#discussion_r42893257
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150649557
@evanlucashttps://github.com/evanlucas
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
force-pushedhttps://github.com/nodejs/node/compare/3574b974604614a06f610e9264202847fcbfea8d..204728295e0252ee7c928618ef20fb6ca4149c8a
3574b97https://github.com/nodejs/node/commit/3574b974604614a06f610e9264202847fcbfea8d
2047282https://github.com/nodejs/node/commit/204728295e0252ee7c928618ef20fb6ca4149c8a
Compare https://github.com/nodejs/node/compare/3574b974604614a06f610e9264202847fcbfea8d..204728295e0252ee7c928618ef20fb6ca4149c8a
October 23, 2015 19:42https://github.com/nodejs/node/pull/3485#event-444182084
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150672595
@trevnorrishttps://github.com/trevnorris
https://ci.nodejs.org/job/node-test-pull-request/585/https://ci.nodejs.org/job/node-test-pull-request/585/
Please reload this pagehttps://github.com/nodejs/node/pull/3485
trevnorrishttps://github.com/trevnorris
Oct 23, 2015 https://github.com/nodejs/node/pull/3485#discussion-diff-42908204
View reviewed changes https://github.com/nodejs/node/pull/3485/files#diff-86020844664e7ef569e49601da30e40753e094f20b5a6e5ae91b7a7df88c19b2
test/parallel/test-fs-readfile-tostring-fail.jshttps://github.com/nodejs/node/pull/3485/files#diff-86020844664e7ef569e49601da30e40753e094f20b5a6e5ae91b7a7df88c19b2
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#discussion_r42908204
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150676136
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
force-pushedhttps://github.com/nodejs/node/compare/204728295e0252ee7c928618ef20fb6ca4149c8a..ac227cb0b82e8a5e33706a04ed3382accc600b91
2047282https://github.com/nodejs/node/commit/204728295e0252ee7c928618ef20fb6ca4149c8a
ac227cbhttps://github.com/nodejs/node/commit/ac227cb0b82e8a5e33706a04ed3382accc600b91
Compare https://github.com/nodejs/node/compare/204728295e0252ee7c928618ef20fb6ca4149c8a..ac227cb0b82e8a5e33706a04ed3382accc600b91
October 23, 2015 20:15https://github.com/nodejs/node/pull/3485#event-444210036
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150679511
https://ci.nodejs.org/job/node-test-pull-request/586/https://ci.nodejs.org/job/node-test-pull-request/586/
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150688155
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150692908
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150693027
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
fs: pass err to callback if buffer is too bighttps://github.com/nodejs/node/pull/3485/commits/b6207906c452be4c5f049a098fc645fdfb897306
b620790https://github.com/nodejs/node/pull/3485/commits/b6207906c452be4c5f049a098fc645fdfb897306
nodejs#2767https://github.com/nodejs/node/issues/2767
nodejs#3485https://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
force-pushedhttps://github.com/nodejs/node/compare/ac227cb0b82e8a5e33706a04ed3382accc600b91..b6207906c452be4c5f049a098fc645fdfb897306
ac227cbhttps://github.com/nodejs/node/commit/ac227cb0b82e8a5e33706a04ed3382accc600b91
b620790https://github.com/nodejs/node/commit/b6207906c452be4c5f049a098fc645fdfb897306
Compare https://github.com/nodejs/node/compare/ac227cb0b82e8a5e33706a04ed3382accc600b91..b6207906c452be4c5f049a098fc645fdfb897306
October 23, 2015 21:11https://github.com/nodejs/node/pull/3485#event-444261042
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#event-444261068
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
October 23, 2015 21:11https://github.com/nodejs/node/pull/3485#event-444261069
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
b620790https://github.com/nodejs/node/commit/b6207906c452be4c5f049a098fc645fdfb897306
Oct 23, 2015https://github.com/nodejs/node/pull/3485#event-444261166
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015https://github.com/nodejs/node/pull/3485#issuecomment-150693734
b620790https://github.com/nodejs/node/commit/b6207906c452be4c5f049a098fc645fdfb897306
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 23, 2015 https://github.com/nodejs/node/pull/3485#ref-pullrequest-113107190
fs: don't throw in read if buffer too big #3503 https://github.com/nodejs/node/pull/3503
evanlucashttps://github.com/evanlucas
Oct 26, 2015 https://github.com/nodejs/node/pull/3485#ref-commit-7added3
https://github.com/evanlucas
https://github.com/rvagg
fs: pass err to callback if buffer is too bighttps://github.com/nodejs/node/commit/7added3b39f13c89aee72491be3d082c2bc56250
7added3https://github.com/nodejs/node/commit/7added3b39f13c89aee72491be3d082c2bc56250
#2767https://github.com/nodejs/node/issues/2767
#3485https://github.com/nodejs/node/pull/3485
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 27, 2015 https://github.com/nodejs/node/pull/3485#ref-pullrequest-112505386
Release proposal: v5.0.0 #3466 https://github.com/nodejs/node/pull/3466
rvagghttps://github.com/rvagg
Oct 29, 2015 https://github.com/nodejs/node/pull/3485#ref-commit-384e6c2
https://github.com/rvagg
2015-10-29, Version 5.0.0 (Stable)https://github.com/rvagg/io.js/commit/384e6c2dfe968002800bc3d3224a57aa19ffdfee
384e6c2https://github.com/rvagg/io.js/commit/384e6c2dfe968002800bc3d3224a57aa19ffdfee
nodejs#2859https://github.com/nodejs/node/pull/2859
nodejs#3166https://github.com/nodejs/node/pull/3166
nodejs#3163https://github.com/nodejs/node/pull/3163
nodejs#3485https://github.com/nodejs/node/pull/3485
nodejs#3503https://github.com/nodejs/node/pull/3503
nodejs#3342https://github.com/nodejs/node/pull/3342
nodejs#3090https://github.com/nodejs/node/pull/3090
nodejs#3090https://github.com/nodejs/node/pull/3090
nodejs#2526https://github.com/nodejs/node/pull/2526
nodejs#3078https://github.com/nodejs/node/pull/3078
nodejs#2922https://github.com/nodejs/node/pull/2922
https://github.com/npm/npm/releases/tag/v3.3.6https://github.com/npm/npm/releases/tag/v3.3.6
nodejs#3310https://github.com/nodejs/node/pull/3310
nodejs#3400https://github.com/nodejs/node/pull/3400
nodejs#3407https://github.com/nodejs/node/pull/3407
nodejs#2564https://github.com/nodejs/node/pull/2564
nodejs#2441https://github.com/nodejs/node/pull/2441
nodejs#1831https://github.com/nodejs/node/pull/1831
nodejs#3432https://github.com/nodejs/node/pull/3432
nodejs#3455https://github.com/nodejs/node/pull/3455
nodejs#3351https://github.com/nodejs/node/pull/3351
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operatorhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.targethttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
nodejs#2595https://github.com/nodejs/node/pull/2595
nodejs#3466https://github.com/nodejs/node/pull/3466
rvagghttps://github.com/rvagg
Oct 29, 2015 https://github.com/nodejs/node/pull/3485#ref-commit-837b174
https://github.com/rvagg
2015-10-29, Version 5.0.0 (Stable)https://github.com/nodejs/node/commit/837b17408acf0f1ddb168fdbc437ce6e8d72165a
837b174https://github.com/nodejs/node/commit/837b17408acf0f1ddb168fdbc437ce6e8d72165a
#2859https://github.com/nodejs/node/pull/2859
#3166https://github.com/nodejs/node/pull/3166
#3163https://github.com/nodejs/node/pull/3163
#3485https://github.com/nodejs/node/pull/3485
#3503https://github.com/nodejs/node/pull/3503
#3342https://github.com/nodejs/node/pull/3342
#3090https://github.com/nodejs/node/pull/3090
#3090https://github.com/nodejs/node/pull/3090
#2526https://github.com/nodejs/node/pull/2526
#3078https://github.com/nodejs/node/pull/3078
#2922https://github.com/nodejs/node/pull/2922
https://github.com/npm/npm/releases/tag/v3.3.6https://github.com/npm/npm/releases/tag/v3.3.6
#3310https://github.com/nodejs/node/pull/3310
#3400https://github.com/nodejs/node/pull/3400
#3407https://github.com/nodejs/node/pull/3407
#2564https://github.com/nodejs/node/pull/2564
#2441https://github.com/nodejs/node/pull/2441
#1831https://github.com/nodejs/node/pull/1831
#3432https://github.com/nodejs/node/pull/3432
#3455https://github.com/nodejs/node/pull/3455
#3351https://github.com/nodejs/node/pull/3351
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operatorhttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_operator
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.targethttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target
#2595https://github.com/nodejs/node/pull/2595
#3466https://github.com/nodejs/node/pull/3466
https://github.com/zbinlin
zbinlinhttps://github.com/zbinlin
Nov 10, 2015 https://github.com/nodejs/node/pull/3485#ref-pullrequest-116152488
fs: fix readFile will pass undefined to callback but not null #3740 https://github.com/nodejs/node/pull/3740
https://github.com/Trott
Trotthttps://github.com/Trott
Mar 4, 2019 https://github.com/nodejs/node/pull/3485#ref-issue-269485789
Investigate flaky test-fs-readfile-tostring-fail #16601 https://github.com/nodejs/node/issues/16601
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3485
fs https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Please reload this pagehttps://github.com/nodejs/node/pull/3485
https://github.com/evanlucas
https://github.com/jasnell
https://github.com/trevnorris
https://github.com/targos
https://github.com/mscdex
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.