| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5bf20739-43ac-cd31-6286-921320961942 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BCF4:247A14:45F5B:61ABD:696A64BE |
| html-safe-nonce | f0097a4793bdf83f09fb5370449d4c71de7cc3f1666f219ddbb4f4a77abfc297 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0Y0OjI0N0ExNDo0NUY1Qjo2MUFCRDo2OTZBNjRCRSIsInZpc2l0b3JfaWQiOiI3NDQ4Mjg4Nzg3MDYzMDA2Mzk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 48f6efe5ff72c75ba921b1971418dfabc7405eb1bb83c0d35ab987da32d8176b |
| hovercard-subject-tag | pull_request:470489451 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34845/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8e132dacd2bb17765395fd5bd361aabe8784600bc1f28e69ce15d297146dae51/nodejs/node/pull/34845 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8e132dacd2bb17765395fd5bd361aabe8784600bc1f28e69ce15d297146dae51/nodejs/node/pull/34845 |
| og:image:alt | Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | clshortfuse |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 87cbd411c2982752221b5751d583a515b23bf5fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34845#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34845 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34845 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34845 |
| Reload | https://github.com/nodejs/node/pull/34845 |
| Reload | https://github.com/nodejs/node/pull/34845 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34845#issue-comment-box |
| clshortfuse | https://github.com/clshortfuse |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| clshortfuse:fixhttp2-v12.x | https://github.com/clshortfuse/node/tree/fixhttp2-v12.x |
|
[v12.x] http2: use and support non-empty DATA frame with END_STREAM flag
| https://github.com/nodejs/node/pull/34845#top |
| clshortfuse | https://github.com/clshortfuse |
| nodejs:v12.x-staging | https://github.com/nodejs/node/tree/v12.x-staging |
| clshortfuse:fixhttp2-v12.x | https://github.com/clshortfuse/node/tree/fixhttp2-v12.x |
|
Conversation
15
| https://github.com/nodejs/node/pull/34845 |
|
Commits
5
| https://github.com/nodejs/node/pull/34845/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34845/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34845/files |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34845#issue-682219049 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-676764310 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
|
v12.x
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Av12.x |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34845#event-3672808670 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Aug 20, 2020 | https://github.com/nodejs/node/pull/34845#event-3677337586 |
| https://github.com/BethGriggs |
| BethGriggs | https://github.com/BethGriggs |
| force-pushed | https://github.com/nodejs/node/compare/729799d81ac239ab08fb537842bdb9af49cd066f..c9bd1a7d8a8063523cbeaf1d5437663ea6b9103a |
| 729799d | https://github.com/nodejs/node/commit/729799d81ac239ab08fb537842bdb9af49cd066f |
| c9bd1a7 | https://github.com/nodejs/node/commit/c9bd1a7d8a8063523cbeaf1d5437663ea6b9103a |
|
Compare
| https://github.com/nodejs/node/compare/729799d81ac239ab08fb537842bdb9af49cd066f..c9bd1a7d8a8063523cbeaf1d5437663ea6b9103a |
| September 15, 2020 21:01 | https://github.com/nodejs/node/pull/34845#event-3770309560 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| September 22, 2020 08:48 | https://github.com/nodejs/node/pull/34845#event-3792131480 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| force-pushed | https://github.com/nodejs/node/compare/55fe022c000fcd87cfd00b7bb76fddb571ae1550..65b7bf40b8076afe43ff46f69919038a943430bd |
| 55fe022 | https://github.com/nodejs/node/commit/55fe022c000fcd87cfd00b7bb76fddb571ae1550 |
| 65b7bf4 | https://github.com/nodejs/node/commit/65b7bf40b8076afe43ff46f69919038a943430bd |
|
Compare
| https://github.com/nodejs/node/compare/55fe022c000fcd87cfd00b7bb76fddb571ae1550..65b7bf40b8076afe43ff46f69919038a943430bd |
| September 22, 2020 17:57 | https://github.com/nodejs/node/pull/34845#event-3794509642 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 22, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-696917015 |
| @clshortfuse | https://github.com/clshortfuse |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| lundibundi | https://github.com/lundibundi |
| September 22, 2020 15:10 | https://github.com/nodejs/node/pull/34845#commits-pushed-4e4592b |
|
| https://github.com/lundibundi |
|
| https://github.com/clshortfuse |
| http2: wait for session to finish writing before destroy | https://github.com/nodejs/node/pull/34845/commits/4e4592bf254d153b9fdf2235f8c6792f44de0e9c |
| 4e4592b | https://github.com/nodejs/node/pull/34845/commits/4e4592bf254d153b9fdf2235f8c6792f44de0e9c |
| nodejs#30854 | https://github.com/nodejs/node/pull/30854 |
|
| https://github.com/lundibundi |
|
| https://github.com/clshortfuse |
| http2: wait for session socket writable end on close/destroy | https://github.com/nodejs/node/pull/34845/commits/0453ece0b997a741750d5d0a21a18ac3778c7c63 |
| 0453ece | https://github.com/nodejs/node/pull/34845/commits/0453ece0b997a741750d5d0a21a18ac3778c7c63 |
| nodejs#30854 | https://github.com/nodejs/node/pull/30854 |
|
| https://github.com/mildsunrise |
|
| https://github.com/clshortfuse |
| http2,doc: minor fixes | https://github.com/nodejs/node/pull/34845/commits/98eea4ff95a9c27202f32912312aafc011793028 |
| 98eea4f | https://github.com/nodejs/node/pull/34845/commits/98eea4ff95a9c27202f32912312aafc011793028 |
| nodejs#28044 | https://github.com/nodejs/node/pull/28044 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| force-pushed | https://github.com/nodejs/node/compare/6d246b422bb86b991dd8c883385cbab3da4a10d1..3513c093dd0f3fe821a956a53d5f7503c585ed08 |
| 6d246b4 | https://github.com/nodejs/node/commit/6d246b422bb86b991dd8c883385cbab3da4a10d1 |
| 3513c09 | https://github.com/nodejs/node/commit/3513c093dd0f3fe821a956a53d5f7503c585ed08 |
|
Compare
| https://github.com/nodejs/node/compare/6d246b422bb86b991dd8c883385cbab3da4a10d1..3513c093dd0f3fe821a956a53d5f7503c585ed08 |
| September 22, 2020 19:12 | https://github.com/nodejs/node/pull/34845#event-3794786775 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-697386332 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#event-3798253034 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#event-3798351482 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-697423076 |
| https://ci.nodejs.org/job/node-test-pull-request/33214/ | https://ci.nodejs.org/job/node-test-pull-request/33214/ |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-697611784 |
| https://ci.nodejs.org/job/node-test-pull-request/33218/ | https://ci.nodejs.org/job/node-test-pull-request/33218/ |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-697611905 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| Sep 23, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-697641568 |
| #31089 | https://github.com/nodejs/node/issues/31089 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/niftylettuce |
| niftylettuce | https://github.com/niftylettuce |
| Sep 29, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-700928406 |
| @clshortfuse | https://github.com/clshortfuse |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-705096979 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| Trott | https://github.com/Trott |
| October 7, 2020 14:18 | https://github.com/nodejs/node/pull/34845#commits-pushed-6802870 |
|
| https://github.com/Trott |
|
| https://github.com/clshortfuse |
| Revert "http2: streamline OnStreamRead streamline memory accounting" | https://github.com/nodejs/node/pull/34845/commits/68028704f493e420fca011301a41d80dfec143e6 |
| 6802870 | https://github.com/nodejs/node/pull/34845/commits/68028704f493e420fca011301a41d80dfec143e6 |
| 51ccf1b | https://github.com/clshortfuse/node/commit/51ccf1b5e90540a11c33866da15d4a7f52d7fddb |
| nodejs#31089 | https://github.com/nodejs/node/issues/31089 |
| nodejs#34315 | https://github.com/nodejs/node/pull/34315 |
|
| https://github.com/clshortfuse |
| http2: use and support non-empty DATA frame with END_STREAM flag | https://github.com/nodejs/node/pull/34845/commits/a9ea96c5eef6e31226285834a1677ef753801017 |
| a9ea96c | https://github.com/nodejs/node/pull/34845/commits/a9ea96c5eef6e31226285834a1677ef753801017 |
| nodejs#31309 | https://github.com/nodejs/node/issues/31309 |
| nodejs#33891 | https://github.com/nodejs/node/issues/33891 |
| https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback | https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback |
| nodejs#33875 | https://github.com/nodejs/node/pull/33875 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| force-pushed | https://github.com/nodejs/node/compare/3513c093dd0f3fe821a956a53d5f7503c585ed08..a9ea96c5eef6e31226285834a1677ef753801017 |
| 3513c09 | https://github.com/nodejs/node/commit/3513c093dd0f3fe821a956a53d5f7503c585ed08 |
| a9ea96c | https://github.com/nodejs/node/commit/a9ea96c5eef6e31226285834a1677ef753801017 |
|
Compare
| https://github.com/nodejs/node/compare/3513c093dd0f3fe821a956a53d5f7503c585ed08..a9ea96c5eef6e31226285834a1677ef753801017 |
| October 7, 2020 18:18 | https://github.com/nodejs/node/pull/34845#event-3851907758 |
| https://github.com/clshortfuse |
| clshortfuse | https://github.com/clshortfuse |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-705136746 |
| @addaleax | https://github.com/addaleax |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/34845#event-3852102206 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/34845#event-3852140301 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 7, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-705143858 |
| https://ci.nodejs.org/job/node-test-pull-request/33463/ | https://ci.nodejs.org/job/node-test-pull-request/33463/ |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nemphys |
| nemphys | https://github.com/nemphys |
| Oct 12, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-707292161 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 12, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-707293145 |
| https://ci.nodejs.org/job/node-test-pull-request/33554/ | https://ci.nodejs.org/job/node-test-pull-request/33554/ |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Oct 12, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-707364365 |
| https://ci.nodejs.org/job/node-test-pull-request/33555/ | https://ci.nodejs.org/job/node-test-pull-request/33555/ |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-1cdf5d8 |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| http2: wait for session to finish writing before destroy | https://github.com/nodejs/node/commit/1cdf5d80d11edef64e626eb3c02c6285858962f8 |
| 1cdf5d8 | https://github.com/nodejs/node/commit/1cdf5d80d11edef64e626eb3c02c6285858962f8 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #30854 | https://github.com/nodejs/node/pull/30854 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-c950e76 |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| http2: wait for session socket writable end on close/destroy | https://github.com/nodejs/node/commit/c950e7676c0ca844efbc179d90cc7349148c17c5 |
| c950e76 | https://github.com/nodejs/node/commit/c950e7676c0ca844efbc179d90cc7349148c17c5 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #30854 | https://github.com/nodejs/node/pull/30854 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-6b5ec36 |
|
| https://github.com/mildsunrise |
|
| https://github.com/MylesBorins |
| http2,doc: minor fixes | https://github.com/nodejs/node/commit/6b5ec365dc9825ec9ea59e1394ea9b8ceb365bd5 |
| 6b5ec36 | https://github.com/nodejs/node/commit/6b5ec365dc9825ec9ea59e1394ea9b8ceb365bd5 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #28044 | https://github.com/nodejs/node/pull/28044 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-b5bc280 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| Revert "http2: streamline OnStreamRead streamline memory accounting" | https://github.com/nodejs/node/commit/b5bc280c226751bd17183cdb6b944a70c4d51672 |
| b5bc280 | https://github.com/nodejs/node/commit/b5bc280c226751bd17183cdb6b944a70c4d51672 |
| 51ccf1b | https://github.com/nodejs/node/commit/51ccf1b5e90540a11c33866da15d4a7f52d7fddb |
| #31089 | https://github.com/nodejs/node/issues/31089 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #34315 | https://github.com/nodejs/node/pull/34315 |
| MylesBorins | https://github.com/MylesBorins |
|
Oct 13, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-4d1df84 |
|
| https://github.com/clshortfuse |
|
| https://github.com/MylesBorins |
| http2: use and support non-empty DATA frame with END_STREAM flag | https://github.com/nodejs/node/commit/4d1df84592a073ffd99b03d7ed5eb598a780ce23 |
| 4d1df84 | https://github.com/nodejs/node/commit/4d1df84592a073ffd99b03d7ed5eb598a780ce23 |
| #31309 | https://github.com/nodejs/node/issues/31309 |
| #33891 | https://github.com/nodejs/node/issues/33891 |
| https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback | https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #33875 | https://github.com/nodejs/node/pull/33875 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 13, 2020 | https://github.com/nodejs/node/pull/34845#issuecomment-707428549 |
| 6a2f050...4d1df84 | https://github.com/nodejs/node/compare/6a2f05012f810ea8a4e776bc861ca914190d906d...4d1df84592a073ffd99b03d7ed5eb598a780ce23 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
| Oct 13, 2020 | https://github.com/nodejs/node/pull/34845#event-3868868257 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-2471197 |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| http2: wait for session to finish writing before destroy | https://github.com/nodejs/node/commit/247119709916970885d0f718feae2a1bcb763e0f |
| 2471197 | https://github.com/nodejs/node/commit/247119709916970885d0f718feae2a1bcb763e0f |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #30854 | https://github.com/nodejs/node/pull/30854 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-e85ca7a |
|
| https://github.com/lundibundi |
|
| https://github.com/MylesBorins |
| http2: wait for session socket writable end on close/destroy | https://github.com/nodejs/node/commit/e85ca7af4322a82b00ad3abb045281a90bed3ff8 |
| e85ca7a | https://github.com/nodejs/node/commit/e85ca7af4322a82b00ad3abb045281a90bed3ff8 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #30854 | https://github.com/nodejs/node/pull/30854 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-82af8ac |
|
| https://github.com/mildsunrise |
|
| https://github.com/MylesBorins |
| http2,doc: minor fixes | https://github.com/nodejs/node/commit/82af8acc8e8b99f8b50401ffe977113fbe033b9e |
| 82af8ac | https://github.com/nodejs/node/commit/82af8acc8e8b99f8b50401ffe977113fbe033b9e |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #28044 | https://github.com/nodejs/node/pull/28044 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-bfce0eb |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| Revert "http2: streamline OnStreamRead streamline memory accounting" | https://github.com/nodejs/node/commit/bfce0eb13aa3a317d471389139d1d806f2418a87 |
| bfce0eb | https://github.com/nodejs/node/commit/bfce0eb13aa3a317d471389139d1d806f2418a87 |
| 51ccf1b | https://github.com/nodejs/node/commit/51ccf1b5e90540a11c33866da15d4a7f52d7fddb |
| #31089 | https://github.com/nodejs/node/issues/31089 |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #34315 | https://github.com/nodejs/node/pull/34315 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34845#ref-commit-b732c92 |
|
| https://github.com/clshortfuse |
|
| https://github.com/MylesBorins |
| http2: use and support non-empty DATA frame with END_STREAM flag | https://github.com/nodejs/node/commit/b732c92e3db554bc954adfb95965e09bb61a4076 |
| b732c92 | https://github.com/nodejs/node/commit/b732c92e3db554bc954adfb95965e09bb61a4076 |
| #31309 | https://github.com/nodejs/node/issues/31309 |
| #33891 | https://github.com/nodejs/node/issues/33891 |
| https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback | https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback |
| #34845 | https://github.com/nodejs/node/pull/34845 |
| #33875 | https://github.com/nodejs/node/pull/33875 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34845 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
lib / src
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22 |
| Please reload this page | https://github.com/nodejs/node/pull/34845 |
|
| https://github.com/clshortfuse |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/addaleax |
|
| https://github.com/niftylettuce |
|
| https://github.com/MylesBorins |
|
| https://github.com/nemphys |
|
| https://github.com/lundibundi |
|
| https://github.com/mildsunrise |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |