| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:36ef124d-12ab-c9cb-13ec-d46a8f733bc3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BB0A:3C7D7F:2687F0:34F2CD:696A7227 |
| html-safe-nonce | b8e019273256af19d1846a0f010d129ccc1df2fd7497a7819afda17bf87562bf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQjBBOjNDN0Q3RjoyNjg3RjA6MzRGMkNEOjY5NkE3MjI3IiwidmlzaXRvcl9pZCI6IjMzMzk5NjY1MDE4NjU4MTI1MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | aa0af0928d48d2de4628d10a0aaa9b486c03aae5d3a5914c91653903123c3b05 |
| hovercard-subject-tag | pull_request:470422384 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34843/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b5f8acb26c57cb1822cfaeffa91226a9b9f18c24a6a4735332c429df3a9ec740/nodejs/node/pull/34843 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b5f8acb26c57cb1822cfaeffa91226a9b9f18c24a6a4735332c429df3a9ec740/nodejs/node/pull/34843 |
| og:image:alt | /cc @Trott
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jasnell |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34843#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34843 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34843 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34843 |
| Reload | https://github.com/nodejs/node/pull/34843 |
| Reload | https://github.com/nodejs/node/pull/34843 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34843#issue-comment-box |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:new-fs-doc-improvements | https://github.com/jasnell/node/tree/new-fs-doc-improvements |
|
doc: improve fs doc intro
| https://github.com/nodejs/node/pull/34843#top |
| jasnell | https://github.com/jasnell |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| jasnell:new-fs-doc-improvements | https://github.com/jasnell/node/tree/new-fs-doc-improvements |
|
Conversation
36
| https://github.com/nodejs/node/pull/34843 |
|
Commits
1
| https://github.com/nodejs/node/pull/34843/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34843/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34843/files |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34843#issue-682140249 |
| @Trott | https://github.com/Trott |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34843#event-3672398847 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 19, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-470845622 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 19, 2020 | https://github.com/nodejs/node/pull/34843#event-3672612308 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-471545184 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-471577695 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
| Aug 20, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-677654956 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/f1c1ac2cd717acacf7e82722e6f212fbaa96c9c5..5e30b3d3a7e0960a55e3dd386085d7988e94377d |
| f1c1ac2 | https://github.com/nodejs/node/commit/f1c1ac2cd717acacf7e82722e6f212fbaa96c9c5 |
| 5e30b3d | https://github.com/nodejs/node/commit/5e30b3d3a7e0960a55e3dd386085d7988e94377d |
|
Compare
| https://github.com/nodejs/node/compare/f1c1ac2cd717acacf7e82722e6f212fbaa96c9c5..5e30b3d3a7e0960a55e3dd386085d7988e94377d |
| August 20, 2020 21:26 | https://github.com/nodejs/node/pull/34843#event-3677175247 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 20, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-677914637 |
| @mscdex | https://github.com/mscdex |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472003055 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472003197 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472003332 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472057857 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/mscdex |
| mscdex | https://github.com/mscdex |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472058101 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472068563 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472068684 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472071340 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472072070 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472073584 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472073645 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472073742 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472073805 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472073904 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472074011 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472074259 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472074332 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 21, 2020 | https://github.com/nodejs/node/pull/34843#event-3677792548 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472625647 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/390246672bf933a4b15c9231ed4f0fbe38a333df..9e1bab0ff9acef0d4ba97fd187040ec2a5b565aa |
| 3902466 | https://github.com/nodejs/node/commit/390246672bf933a4b15c9231ed4f0fbe38a333df |
| 9e1bab0 | https://github.com/nodejs/node/commit/9e1bab0ff9acef0d4ba97fd187040ec2a5b565aa |
|
Compare
| https://github.com/nodejs/node/compare/390246672bf933a4b15c9231ed4f0fbe38a333df..9e1bab0ff9acef0d4ba97fd187040ec2a5b565aa |
| August 21, 2020 16:28 | https://github.com/nodejs/node/pull/34843#event-3680309794 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 21, 2020 | https://github.com/nodejs/node/pull/34843#event-3680311080 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 21, 2020
| https://github.com/nodejs/node/pull/34843#pullrequestreview-472762285 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34843/files |
| doc/api/fs.md | https://github.com/nodejs/node/pull/34843/files#diff-11c13307cb334211e0d11f4e7e43bdc0a34e437779a63a6ff645e62448d973d2 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 21, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-678542629 |
| https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Asynchronous/Promises | https://developer.mozilla.org/en-US/docs/Learn/JavaScript/Asynchronous/Promises |
| Microsoft style guide section on capitalization | https://docs.microsoft.com/en-us/style-guide/capitalization |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 23, 2020 | https://github.com/nodejs/node/pull/34843#event-3682733781 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 23, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-678760910 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/f3cde32038e53e6ceb8c9d74f8e78a77b5d0eb07..fd41a8272bc5cc74e7ba40526589c72414f46b1f |
| f3cde32 | https://github.com/nodejs/node/commit/f3cde32038e53e6ceb8c9d74f8e78a77b5d0eb07 |
| fd41a82 | https://github.com/nodejs/node/commit/fd41a8272bc5cc74e7ba40526589c72414f46b1f |
|
Compare
| https://github.com/nodejs/node/compare/f3cde32038e53e6ceb8c9d74f8e78a77b5d0eb07..fd41a8272bc5cc74e7ba40526589c72414f46b1f |
| August 24, 2020 15:47 | https://github.com/nodejs/node/pull/34843#event-3686084891 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#event-3686085719 |
|
| https://github.com/jasnell |
| doc: improve fs doc intro | https://github.com/nodejs/node/pull/34843/commits/76a83e2e7cd46ecbb0720339c2594724b1b63f4f |
| 76a83e2 | https://github.com/nodejs/node/pull/34843/commits/76a83e2e7cd46ecbb0720339c2594724b1b63f4f |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| force-pushed | https://github.com/nodejs/node/compare/ac4fdffc491d0497add3209a9e616dd6dc243c99..76a83e2e7cd46ecbb0720339c2594724b1b63f4f |
| ac4fdff | https://github.com/nodejs/node/commit/ac4fdffc491d0497add3209a9e616dd6dc243c99 |
| 76a83e2 | https://github.com/nodejs/node/commit/76a83e2e7cd46ecbb0720339c2594724b1b63f4f |
|
Compare
| https://github.com/nodejs/node/compare/ac4fdffc491d0497add3209a9e616dd6dc243c99..76a83e2e7cd46ecbb0720339c2594724b1b63f4f |
| August 24, 2020 15:55 | https://github.com/nodejs/node/pull/34843#event-3686116659 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#event-3686554946 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#event-3686576015 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-679275611 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#event-3686576140 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#issuecomment-679282358 |
| 010383a | https://github.com/nodejs/node/commit/010383a1745a989d27d3462a3beb9fc159000cb4 |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 24, 2020 | https://github.com/nodejs/node/pull/34843#event-3686626747 |
| jasnell | https://github.com/jasnell |
|
Aug 24, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-010383a |
|
| https://github.com/jasnell |
| doc: improve fs doc intro | https://github.com/nodejs/node/commit/010383a1745a989d27d3462a3beb9fc159000cb4 |
| 010383a | https://github.com/nodejs/node/commit/010383a1745a989d27d3462a3beb9fc159000cb4 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| danielleadams | https://github.com/danielleadams |
|
Aug 25, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-ff15c92 |
|
| https://github.com/jasnell |
| doc: improve fs doc intro | https://github.com/nodejs/node/commit/ff15c92a7fa67c6aee79c8a74be85f8a2cd7f6f2 |
| ff15c92 | https://github.com/nodejs/node/commit/ff15c92a7fa67c6aee79c8a74be85f8a2cd7f6f2 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 25, 2020
| https://github.com/nodejs/node/pull/34843#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-5721352 |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| doc: improve fs doc intro | https://github.com/nodejs/node/commit/57213520feb5ba756e8a631315912541484307f3 |
| 5721352 | https://github.com/nodejs/node/commit/57213520feb5ba756e8a631315912541484307f3 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-961844d |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
| doc: improve fs doc intro | https://github.com/nodejs/node/commit/961844d25bda06cd9f42f91243d549265b07e735 |
| 961844d | https://github.com/nodejs/node/commit/961844d25bda06cd9f42f91243d549265b07e735 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34843#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Oct 22, 2020
| https://github.com/nodejs/node/pull/34843#ref-pullrequest-727567927 |
|
[12.x] doc: update fs promise-based examples
#35760
| https://github.com/nodejs/node/pull/35760 |
| richardlau | https://github.com/richardlau |
|
Oct 22, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-10fa5de |
|
| https://github.com/richardlau |
| doc: update fs promise-based examples | https://github.com/richardlau/node-1/commit/10fa5def8bd89e62658358db349234072e1e876a |
| 10fa5de | https://github.com/richardlau/node-1/commit/10fa5def8bd89e62658358db349234072e1e876a |
| nodejs#34843 | https://github.com/nodejs/node/pull/34843 |
| 961844d | https://github.com/richardlau/node-1/commit/961844d25bda06cd9f42f91243d549265b07e735 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 3, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-32d45a3 |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| doc: update fs promise-based examples | https://github.com/nodejs/node/commit/32d45a3ab45f2300bc1e54f17b13289ea29b8d7a |
| 32d45a3 | https://github.com/nodejs/node/commit/32d45a3ab45f2300bc1e54f17b13289ea29b8d7a |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| 961844d | https://github.com/nodejs/node/commit/961844d25bda06cd9f42f91243d549265b07e735 |
| #35760 | https://github.com/nodejs/node/pull/35760 |
| #35740 | https://github.com/nodejs/node/issues/35740 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| MylesBorins | https://github.com/MylesBorins |
|
Nov 16, 2020
| https://github.com/nodejs/node/pull/34843#ref-commit-68c5ee4 |
|
| https://github.com/richardlau |
|
| https://github.com/MylesBorins |
| doc: update fs promise-based examples | https://github.com/nodejs/node/commit/68c5ee45a2e6b35211a166a50eecb54bbd4cb683 |
| 68c5ee4 | https://github.com/nodejs/node/commit/68c5ee45a2e6b35211a166a50eecb54bbd4cb683 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| 961844d | https://github.com/nodejs/node/commit/961844d25bda06cd9f42f91243d549265b07e735 |
| #35760 | https://github.com/nodejs/node/pull/35760 |
| #35740 | https://github.com/nodejs/node/issues/35740 |
| #34843 | https://github.com/nodejs/node/pull/34843 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
commit-queue-failed
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acommit-queue-failed |
| Sep 5, 2021 | https://github.com/nodejs/node/pull/34843#event-5257331650 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34843 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/34843/files/8c307ef5cc4a4599f189f9ca293eae42b9391613 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34843/files/9df351611d19ed04fdee73522c9d45f254b8191b |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34843/files/9e1bab0ff9acef0d4ba97fd187040ec2a5b565aa |
|
| https://github.com/mscdex |
|
mscdex
| https://github.com/mscdex |
|
| https://github.com/nodejs/node/pull/34843/files/8c307ef5cc4a4599f189f9ca293eae42b9391613 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/34843/files/8c307ef5cc4a4599f189f9ca293eae42b9391613 |
|
| https://github.com/rickyes |
|
rickyes
| https://github.com/rickyes |
|
| https://github.com/nodejs/node/pull/34843/files/f1c1ac2cd717acacf7e82722e6f212fbaa96c9c5 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
fs
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afs |
| Please reload this page | https://github.com/nodejs/node/pull/34843 |
|
| https://github.com/jasnell |
|
| https://github.com/mscdex |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/antsmartian |
|
| https://github.com/lpinca |
|
| https://github.com/rickyes |
|
| https://github.com/targos |
|
| https://github.com/trivikr |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |