René's URL Explorer Experiment


Title: n-api: handle weak no-finalizer refs correctly by gabrielschulhof · Pull Request #34839 · nodejs/node · GitHub

Open Graph Title: n-api: handle weak no-finalizer refs correctly by gabrielschulhof · Pull Request #34839 · nodejs/node

X Title: n-api: handle weak no-finalizer refs correctly by gabrielschulhof · Pull Request #34839 · nodejs/node

Description: When deleting a weak reference that has no finalizer we must not defer deletion until the non-existent finalizer gets called. Fixes: #34731 Checklist make -j4 test (UNIX), or vcbuild test (Wind...

Open Graph Description: When deleting a weak reference that has no finalizer we must not defer deletion until the non-existent finalizer gets called. Fixes: #34731 Checklist make -j4 test (UNIX), or vcbuild test (Wind...

X Description: When deleting a weak reference that has no finalizer we must not defer deletion until the non-existent finalizer gets called. Fixes: #34731 Checklist make -j4 test (UNIX), or vcbuild test (Wind...

Opengraph URL: https://github.com/nodejs/node/pull/34839

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9683b93b-1527-a47b-1447-e55559c7641c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8058:6C43E:38DE2E:4EE324:696A71EC
html-safe-nonce03bc590f31147aef15f1a46422346c847135023916e921cd53fbbb957e1de4ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDU4OjZDNDNFOjM4REUyRTo0RUUzMjQ6Njk2QTcxRUMiLCJ2aXNpdG9yX2lkIjoiNzY4Njc4ODc2NzY4NjQ4ODU1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0252465194c0722feaa43ff73be8d13f359af77f923113e9c0bbd7d4cbc9fd5a
hovercard-subject-tagpull_request:469955340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34839/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e7c91669f65b48736e8e97373d89765942b2414ca553ddd22c9a657eb9137463/nodejs/node/pull/34839
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e7c91669f65b48736e8e97373d89765942b2414ca553ddd22c9a657eb9137463/nodejs/node/pull/34839
og:image:altWhen deleting a weak reference that has no finalizer we must not defer deletion until the non-existent finalizer gets called. Fixes: #34731 Checklist make -j4 test (UNIX), or vcbuild test (Wind...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34839#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34839
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34839
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34839
Reloadhttps://github.com/nodejs/node/pull/34839
Reloadhttps://github.com/nodejs/node/pull/34839
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34839
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34839
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34839#issue-comment-box
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:n-api-fix-delete-after-weakenhttps://github.com/gabrielschulhof/node/tree/n-api-fix-delete-after-weaken
n-api: handle weak no-finalizer refs correctly https://github.com/nodejs/node/pull/34839#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:n-api-fix-delete-after-weakenhttps://github.com/gabrielschulhof/node/tree/n-api-fix-delete-after-weaken
Conversation 10 https://github.com/nodejs/node/pull/34839
Commits 1 https://github.com/nodejs/node/pull/34839/commits
Checks 0 https://github.com/nodejs/node/pull/34839/checks
Files changed 2 https://github.com/nodejs/node/pull/34839/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issue-681588244
#34731https://github.com/nodejs/node/issues/34731
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
addaleaxhttps://github.com/addaleax
mhdawsonhttps://github.com/mhdawson
August 19, 2020 06:39https://github.com/nodejs/node/pull/34839#event-3669289211
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issuecomment-675883184
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
Aug 19, 2020https://github.com/nodejs/node/pull/34839#event-3669289416
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Aug 19, 2020https://github.com/nodejs/node/pull/34839#event-3669290078
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 19, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-470496463
View reviewed changes https://github.com/nodejs/node/pull/34839/files
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 19, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-470507186
View reviewed changes https://github.com/nodejs/node/pull/34839/files
src/js_native_api_v8.cchttps://github.com/nodejs/node/pull/34839/files#diff-4b35cbf831be523a4f3e5aac3729c95490ed220892695d0e4245c15c1f63cfc1
addaleaxhttps://github.com/addaleax
Aug 19, 2020https://github.com/nodejs/node/pull/34839#discussion_r473066502
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34839
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#discussion_r473076694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/e9c66de138a301ae5e802d603a10a3b7b1612f4a..7a20fc83516e110059b6b7f027596d812e68a1c0
e9c66dehttps://github.com/nodejs/node/commit/e9c66de138a301ae5e802d603a10a3b7b1612f4a
7a20fc8https://github.com/nodejs/node/commit/7a20fc83516e110059b6b7f027596d812e68a1c0
Compare https://github.com/nodejs/node/compare/e9c66de138a301ae5e802d603a10a3b7b1612f4a..7a20fc83516e110059b6b7f027596d812e68a1c0
August 19, 2020 14:38https://github.com/nodejs/node/pull/34839#event-3671101764
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issuecomment-676466069
Please reload this pagehttps://github.com/nodejs/node/pull/34839
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/devsnek
devsnekhttps://github.com/devsnek
Aug 19, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-470529339
View reviewed changes https://github.com/nodejs/node/pull/34839/files
n-api: handle weak no-finalizer refs correctlyhttps://github.com/nodejs/node/pull/34839/commits/2a25930d629fc8d47909c6628bc172c3916fe99c
2a25930https://github.com/nodejs/node/pull/34839/commits/2a25930d629fc8d47909c6628bc172c3916fe99c
nodejs#34731https://github.com/nodejs/node/issues/34731
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/7a20fc83516e110059b6b7f027596d812e68a1c0..2a25930d629fc8d47909c6628bc172c3916fe99c
7a20fc8https://github.com/nodejs/node/commit/7a20fc83516e110059b6b7f027596d812e68a1c0
2a25930https://github.com/nodejs/node/commit/2a25930d629fc8d47909c6628bc172c3916fe99c
Compare https://github.com/nodejs/node/compare/7a20fc83516e110059b6b7f027596d812e68a1c0..2a25930d629fc8d47909c6628bc172c3916fe99c
August 19, 2020 14:47https://github.com/nodejs/node/pull/34839#event-3671154595
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issuecomment-676472810
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 19, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-470593698
View reviewed changes https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issuecomment-676576652
https://ci.nodejs.org/job/node-test-pull-request/32854/https://ci.nodejs.org/job/node-test-pull-request/32854/
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34839#issuecomment-676589345
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 20, 2020https://github.com/nodejs/node/pull/34839#issuecomment-676820883
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://ci.nodejs.org/job/node-test-pull-request/32860/https://ci.nodejs.org/job/node-test-pull-request/32860/
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 21, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-472477422
View reviewed changes https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
Trotthttps://github.com/Trott
Aug 21, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-acd423b
https://github.com/Trott
n-api: handle weak no-finalizer refs correctlyhttps://github.com/nodejs/node/commit/acd423b45edad27427a6c4faa5bbed624983ae51
acd423bhttps://github.com/nodejs/node/commit/acd423b45edad27427a6c4faa5bbed624983ae51
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 21, 2020https://github.com/nodejs/node/pull/34839#issuecomment-678285400
acd423bhttps://github.com/nodejs/node/commit/acd423b45edad27427a6c4faa5bbed624983ae51
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 21, 2020https://github.com/nodejs/node/pull/34839#event-3679575596
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 21, 2020 https://github.com/nodejs/node/pull/34839#pullrequestreview-472802426
View reviewed changes https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/34839#pullrequestreview-472802426
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34839
CI Reliability 2020-08-22 nodejs/reliability#51 https://github.com/nodejs/reliability/issues/51
CI Reliability 2020-08-23 nodejs/reliability#52 https://github.com/nodejs/reliability/issues/52
CI Reliability 2020-08-24 nodejs/reliability#53 https://github.com/nodejs/reliability/issues/53
BethGriggshttps://github.com/BethGriggs
Aug 24, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-98f7d8e
https://github.com/BethGriggs
n-api: handle weak no-finalizer refs correctlyhttps://github.com/nodejs/node/commit/98f7d8ec81ca867156d04b1a004f465aae56d64c
98f7d8ehttps://github.com/nodejs/node/commit/98f7d8ec81ca867156d04b1a004f465aae56d64c
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 25, 2020 https://github.com/nodejs/node/pull/34839#ref-issue-685071892
CI Reliability 2020-08-25 nodejs/reliability#54 https://github.com/nodejs/reliability/issues/54
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 25, 2020 https://github.com/nodejs/node/pull/34839#ref-pullrequest-682706557
V14.9.0 proposal #34852 https://github.com/nodejs/node/pull/34852
danielleadamshttps://github.com/danielleadams
Aug 25, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-0cb4cbb
2020-08-25, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/0cb4cbbdd8c217d0124ddd75b1efc6d83f4a58f4
0cb4cbbhttps://github.com/nodejs/node/commit/0cb4cbbdd8c217d0124ddd75b1efc6d83f4a58f4
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 26, 2020 https://github.com/nodejs/node/pull/34839#ref-issue-685920403
CI Reliability 2020-08-26 nodejs/reliability#55 https://github.com/nodejs/reliability/issues/55
danielleadamshttps://github.com/danielleadams
Aug 26, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-9f971f1
2020-08-26, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/9f971f1c084f5e154217a6ab7278ec6d05aacf58
9f971f1https://github.com/nodejs/node/commit/9f971f1c084f5e154217a6ab7278ec6d05aacf58
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
danielleadamshttps://github.com/danielleadams
Aug 26, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-cc595f2
2020-08-26, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/cc595f27a82aa2cc4709cf04a25a1561ce631f2b
cc595f2https://github.com/nodejs/node/commit/cc595f27a82aa2cc4709cf04a25a1561ce631f2b
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
danielleadamshttps://github.com/danielleadams
Aug 26, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-7f7d428
2020-08-27, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/7f7d4284f0167b3b63116dd5dc313ad3248b02ab
7f7d428https://github.com/nodejs/node/commit/7f7d4284f0167b3b63116dd5dc313ad3248b02ab
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Aug 27, 2020 https://github.com/nodejs/node/pull/34839#ref-issue-686853144
CI Reliability 2020-08-27 nodejs/reliability#56 https://github.com/nodejs/reliability/issues/56
danielleadamshttps://github.com/danielleadams
Aug 27, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-3153c2d
2020-08-27, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/3153c2d3833a8a46d92fde33d2773e63ef21357b
3153c2dhttps://github.com/nodejs/node/commit/3153c2d3833a8a46d92fde33d2773e63ef21357b
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
BethGriggshttps://github.com/BethGriggs
Aug 27, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-3089f96
https://github.com/BethGriggs
2020-08-27, Version 14.9.0 (Current)https://github.com/nodejs/node/commit/3089f96ed01653aa4d5e4bba5a5db473ffe788a0
3089f96https://github.com/nodejs/node/commit/3089f96ed01653aa4d5e4bba5a5db473ffe788a0
#34705https://github.com/nodejs/node/pull/34705
#34705https://github.com/nodejs/node/pull/34705
#34915https://github.com/nodejs/node/pull/34915
#34915https://github.com/nodejs/node/pull/34915
#34834https://github.com/nodejs/node/pull/34834
#34834https://github.com/nodejs/node/pull/34834
#34673https://github.com/nodejs/node/pull/34673
#34673https://github.com/nodejs/node/pull/34673
#34839https://github.com/nodejs/node/pull/34839
#34839https://github.com/nodejs/node/pull/34839
#34378https://github.com/nodejs/node/pull/34378
#34378https://github.com/nodejs/node/pull/34378
#34852https://github.com/nodejs/node/pull/34852
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-6ccff8e
https://github.com/addaleax
n-api: handle weak no-finalizer refs correctlyhttps://github.com/nodejs/node/commit/6ccff8eb43ff55118632254b3f7930aae9fd0fd7
6ccff8ehttps://github.com/nodejs/node/commit/6ccff8eb43ff55118632254b3f7930aae9fd0fd7
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-a6b6556
https://github.com/addaleax
n-api: handle weak no-finalizer refs correctlyhttps://github.com/nodejs/node/commit/a6b655614f03e073b9c60f3d71ed884c5af32ffc
a6b6556https://github.com/nodejs/node/commit/a6b655614f03e073b9c60f3d71ed884c5af32ffc
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34839#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 2, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-dd7d042
n-api: unlink reference during its destructorhttps://github.com/gabrielschulhof/node/commit/dd7d042c51f8ee363bc81f40446ea790e992a721
dd7d042https://github.com/gabrielschulhof/node/commit/dd7d042c51f8ee363bc81f40446ea790e992a721
nodejs#34731https://github.com/nodejs/node/issues/34731
nodejs#34839https://github.com/nodejs/node/pull/34839
nodejs#35620https://github.com/nodejs/node/issues/35620
nodejs#35777https://github.com/nodejs/node/pull/35777
nodejs#35778https://github.com/nodejs/node/issues/35778
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 2, 2020 https://github.com/nodejs/node/pull/34839#ref-pullrequest-734909438
n-api: unlink reference during its destructor #35933 https://github.com/nodejs/node/pull/35933
gabrielschulhofhttps://github.com/gabrielschulhof
Nov 5, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-c822ba7
n-api: unlink reference during its destructorhttps://github.com/nodejs/node/commit/c822ba7121b073c7a59a7bab05ba46d6a19eb966
c822ba7https://github.com/nodejs/node/commit/c822ba7121b073c7a59a7bab05ba46d6a19eb966
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
#35620https://github.com/nodejs/node/issues/35620
#35777https://github.com/nodejs/node/pull/35777
#35778https://github.com/nodejs/node/issues/35778
#35933https://github.com/nodejs/node/pull/35933
danielleadamshttps://github.com/danielleadams
Nov 9, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-9b6512f
https://github.com/danielleadams
n-api: unlink reference during its destructorhttps://github.com/nodejs/node/commit/9b6512f7ded1729c0770c042dd8816a0e2a1e2ed
9b6512fhttps://github.com/nodejs/node/commit/9b6512f7ded1729c0770c042dd8816a0e2a1e2ed
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
#35620https://github.com/nodejs/node/issues/35620
#35777https://github.com/nodejs/node/pull/35777
#35778https://github.com/nodejs/node/issues/35778
#35933https://github.com/nodejs/node/pull/35933
BethGriggshttps://github.com/BethGriggs
Dec 9, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-c5926f9
https://github.com/BethGriggs
n-api: unlink reference during its destructorhttps://github.com/nodejs/node/commit/c5926f9993c349b678e37d7ea7f56adc87680598
c5926f9https://github.com/nodejs/node/commit/c5926f9993c349b678e37d7ea7f56adc87680598
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
#35620https://github.com/nodejs/node/issues/35620
#35777https://github.com/nodejs/node/pull/35777
#35778https://github.com/nodejs/node/issues/35778
#35933https://github.com/nodejs/node/pull/35933
BethGriggshttps://github.com/BethGriggs
Dec 10, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-512fb7b
https://github.com/BethGriggs
n-api: unlink reference during its destructorhttps://github.com/nodejs/node/commit/512fb7b37402d9c69071fe6bd8f0d456393a83c1
512fb7bhttps://github.com/nodejs/node/commit/512fb7b37402d9c69071fe6bd8f0d456393a83c1
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
#35620https://github.com/nodejs/node/issues/35620
#35777https://github.com/nodejs/node/pull/35777
#35778https://github.com/nodejs/node/issues/35778
#35933https://github.com/nodejs/node/pull/35933
BethGriggshttps://github.com/BethGriggs
Dec 15, 2020 https://github.com/nodejs/node/pull/34839#ref-commit-88aa4e0
https://github.com/BethGriggs
n-api: unlink reference during its destructorhttps://github.com/nodejs/node/commit/88aa4e0d256859cce5b5bbac9af3c03189b18194
88aa4e0https://github.com/nodejs/node/commit/88aa4e0d256859cce5b5bbac9af3c03189b18194
#34731https://github.com/nodejs/node/issues/34731
#34839https://github.com/nodejs/node/pull/34839
#35620https://github.com/nodejs/node/issues/35620
#35777https://github.com/nodejs/node/pull/35777
#35778https://github.com/nodejs/node/issues/35778
#35933https://github.com/nodejs/node/pull/35933
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
January 28, 2021 00:14https://github.com/nodejs/node/pull/34839#event-4258556018
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
January 28, 2021 05:40https://github.com/nodejs/node/pull/34839#event-4259272655
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
February 3, 2021 07:17https://github.com/nodejs/node/pull/34839#event-4283582225
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34839
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34839/files/e9c66de138a301ae5e802d603a10a3b7b1612f4a
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/34839/files/2a25930d629fc8d47909c6628bc172c3916fe99c
https://github.com/devsnek
devsnek https://github.com/devsnek
https://github.com/nodejs/node/pull/34839/files/7a20fc83516e110059b6b7f027596d812e68a1c0
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
N-API reference management leaks memory https://github.com/nodejs/node/issues/34731
Please reload this pagehttps://github.com/nodejs/node/pull/34839
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/Trott
https://github.com/jasnell
https://github.com/addaleax
https://github.com/devsnek
https://github.com/mhdawson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.