René's URL Explorer Experiment


Title: n-api: re-implement async env cleanup hooks by gabrielschulhof · Pull Request #34819 · nodejs/node · GitHub

Open Graph Title: n-api: re-implement async env cleanup hooks by gabrielschulhof · Pull Request #34819 · nodejs/node

X Title: n-api: re-implement async env cleanup hooks by gabrielschulhof · Pull Request #34819 · nodejs/node

Description: Avoid passing core void* and function pointers into add-on. Document napi_async_cleanup_hook_handle type. Render receipt of the handle mandatory. Removal of the handle remains mandatory. Fixes: #3...

Open Graph Description: Avoid passing core void* and function pointers into add-on. Document napi_async_cleanup_hook_handle type. Render receipt of the handle mandatory. Removal of the handle remains mandatory. Fixes: #3...

X Description: Avoid passing core void* and function pointers into add-on. Document napi_async_cleanup_hook_handle type. Render receipt of the handle mandatory. Removal of the handle remains mandatory. Fixes: #3...

Mail addresses
gabriel.schulhof@intel.com

Opengraph URL: https://github.com/nodejs/node/pull/34819

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e013916b-a890-149f-ff9a-8abcdbde9b4a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD652:35B8D6:20A75FF:2CEC8B0:696AB981
html-safe-nonce4309aa6735138e7c4833ea1253cc74b6518d0fd30a517461232da57ac4af64db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjUyOjM1QjhENjoyMEE3NUZGOjJDRUM4QjA6Njk2QUI5ODEiLCJ2aXNpdG9yX2lkIjoiMTUzMjUwMDMwOTI5MDE3MDc1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0416ea3fcb14b8ce6a2e7626c464dbc15d150fb333f8e72b6e77461a49566668
hovercard-subject-tagpull_request:469213050
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34819/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2d8f5cc16e3cbc5c8ddc1458de21faf296a6a441a546fe53abec9bb3c029e4cc/nodejs/node/pull/34819
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2d8f5cc16e3cbc5c8ddc1458de21faf296a6a441a546fe53abec9bb3c029e4cc/nodejs/node/pull/34819
og:image:altAvoid passing core void* and function pointers into add-on. Document napi_async_cleanup_hook_handle type. Render receipt of the handle mandatory. Removal of the handle remains mandatory. Fixes: #3...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegabrielschulhof
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34819#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34819
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34819
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34819
Reloadhttps://github.com/nodejs/node/pull/34819
Reloadhttps://github.com/nodejs/node/pull/34819
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34819
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34819
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34819#issue-comment-box
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:re-implement-async-cleanup-hookshttps://github.com/gabrielschulhof/node/tree/re-implement-async-cleanup-hooks
n-api: re-implement async env cleanup hooks https://github.com/nodejs/node/pull/34819#top
gabrielschulhofhttps://github.com/gabrielschulhof
nodejs:masterhttps://github.com/nodejs/node/tree/master
gabrielschulhof:re-implement-async-cleanup-hookshttps://github.com/gabrielschulhof/node/tree/re-implement-async-cleanup-hooks
Conversation 23 https://github.com/nodejs/node/pull/34819
Commits 6 https://github.com/nodejs/node/pull/34819/commits
Checks 0 https://github.com/nodejs/node/pull/34819/checks
Files changed https://github.com/nodejs/node/pull/34819/files
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 18, 2020https://github.com/nodejs/node/pull/34819#issue-680704446
#34715https://github.com/nodejs/node/issues/34715
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 18, 2020https://github.com/nodejs/node/pull/34819#issuecomment-675259406
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
Aug 18, 2020https://github.com/nodejs/node/pull/34819#event-3664619771
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
addaleaxhttps://github.com/addaleax
himself65https://github.com/himself65
legendecashttps://github.com/legendecas
mhdawsonhttps://github.com/mhdawson
August 18, 2020 05:29https://github.com/nodejs/node/pull/34819#event-3664619917
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 18, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-469002312
View reviewed changes https://github.com/nodejs/node/pull/34819/files
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/34819/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 18, 2020https://github.com/nodejs/node/pull/34819#discussion_r471924372
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
Aug 18, 2020https://github.com/nodejs/node/pull/34819#event-3664802612
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 18, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-469201823
View reviewed changes https://github.com/nodejs/node/pull/34819/files
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/34819#pullrequestreview-469201823
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
src/node_api.cchttps://github.com/nodejs/node/pull/34819/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
Please reload this pagehttps://github.com/nodejs/node/pull/34819
src/node_api.cchttps://github.com/nodejs/node/pull/34819/files#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
Please reload this pagehttps://github.com/nodejs/node/pull/34819
doc/api/n-api.mdhttps://github.com/nodejs/node/pull/34819/files#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d
addaleaxhttps://github.com/addaleax
Aug 18, 2020https://github.com/nodejs/node/pull/34819#discussion_r472086364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34819#discussion_r473235777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
belowhttps://github.com/nodejs/node/pull/34819/files#diff-6782512949f60a32853d80270ceefeb0R5812
Please reload this pagehttps://github.com/nodejs/node/pull/34819
mhdawsonhttps://github.com/mhdawson
Aug 26, 2020https://github.com/nodejs/node/pull/34819#discussion_r477614201
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 18, 2020https://github.com/nodejs/node/pull/34819#issuecomment-675612442
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 18, 2020https://github.com/nodejs/node/pull/34819#issuecomment-675735786
@gabrielschulhofhttps://github.com/gabrielschulhof
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34819#issuecomment-676547155
Please reload this pagehttps://github.com/nodejs/node/pull/34819
August 19, 2020 11:17https://github.com/nodejs/node/pull/34819#commits-pushed-28c8a96
n-api: re-implement async env cleanup hookshttps://github.com/nodejs/node/pull/34819/commits/28c8a962d84b397a36f5fff1cae1624956e83572
28c8a96https://github.com/nodejs/node/pull/34819/commits/28c8a962d84b397a36f5fff1cae1624956e83572
nodejs#34715https://github.com/nodejs/node/issues/34715
move handle differentlyhttps://github.com/nodejs/node/pull/34819/commits/5986bab4e56025035edbb61e370dc37209695b46
5986babhttps://github.com/nodejs/node/pull/34819/commits/5986bab4e56025035edbb61e370dc37209695b46
https://github.com/gabrielschulhof
https://github.com/addaleax
Apply suggestions from code reviewhttps://github.com/nodejs/node/pull/34819/commits/fc6e0b70c0bff283b07037da9776d0af84cdb16d
fc6e0b7https://github.com/nodejs/node/pull/34819/commits/fc6e0b70c0bff283b07037da9776d0af84cdb16d
add link to new callback typehttps://github.com/nodejs/node/pull/34819/commits/2d7c4f21cfabbbc2cf3a9b8837ffe24153c63627
2d7c4f2https://github.com/nodejs/node/pull/34819/commits/2d7c4f21cfabbbc2cf3a9b8837ffe24153c63627
add changes: sectionshttps://github.com/nodejs/node/pull/34819/commits/60377051d9470ae4f8765b74c90af5f85014ad3d
6037705https://github.com/nodejs/node/pull/34819/commits/60377051d9470ae4f8765b74c90af5f85014ad3d
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/5cf1c38166ac7298e40adce3629bd851a2cdadcc..60377051d9470ae4f8765b74c90af5f85014ad3d
5cf1c38https://github.com/nodejs/node/commit/5cf1c38166ac7298e40adce3629bd851a2cdadcc
6037705https://github.com/nodejs/node/commit/60377051d9470ae4f8765b74c90af5f85014ad3d
Compare https://github.com/nodejs/node/compare/5cf1c38166ac7298e40adce3629bd851a2cdadcc..60377051d9470ae4f8765b74c90af5f85014ad3d
August 19, 2020 18:23https://github.com/nodejs/node/pull/34819#event-3672089457
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 19, 2020https://github.com/nodejs/node/pull/34819#issuecomment-676586838
@addaleaxhttps://github.com/addaleax
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/himself65
himself65https://github.com/himself65
Aug 24, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-473850663
View reviewed changes https://github.com/nodejs/node/pull/34819/files/60377051d9470ae4f8765b74c90af5f85014ad3d
himself65https://github.com/himself65
https://github.com/nodejs/node/pull/34819#pullrequestreview-473850663
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 26, 2020 https://github.com/nodejs/node/pull/34819#ref-pullrequest-669299514
n-api,src: provide asynchronous cleanup hooks #34572 https://github.com/nodejs/node/pull/34572
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 26, 2020 https://github.com/nodejs/node/pull/34819#ref-pullrequest-685959717
fix: provide asynchronous cleanup hooks in n-api electron/electron#25135 https://github.com/electron/electron/pull/25135
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 26, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681020286
https://ci.nodejs.org/job/node-test-pull-request/32941/https://ci.nodejs.org/job/node-test-pull-request/32941/
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 26, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-475897684
View reviewed changes https://github.com/nodejs/node/pull/34819/files/60377051d9470ae4f8765b74c90af5f85014ad3d
src/node_api.cchttps://github.com/nodejs/node/pull/34819/files/60377051d9470ae4f8765b74c90af5f85014ad3d#diff-2057dbe503dbb37a65a74cf86e056d50c27ba828070577e0f7f07e734365c9bc
mhdawsonhttps://github.com/mhdawson
Aug 26, 2020https://github.com/nodejs/node/pull/34819#discussion_r477614665
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 26, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-475899325
View reviewed changes https://github.com/nodejs/node/pull/34819/files/60377051d9470ae4f8765b74c90af5f85014ad3d
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/34819#pullrequestreview-475899325
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 26, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681148018
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 26, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681164607
Please reload this pagehttps://github.com/nodejs/node/pull/34819
@mhdawsonhttps://github.com/mhdawson
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 26, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681165250
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 26, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681165495
https://ci.nodejs.org/job/node-test-pull-request/32950/https://ci.nodejs.org/job/node-test-pull-request/32950/
Please reload this pagehttps://github.com/nodejs/node/pull/34819
storing the handle at creation is optional againhttps://github.com/nodejs/node/pull/34819/commits/5b694e443c562a0d4230364302244aba6df3087b
5b694e4https://github.com/nodejs/node/pull/34819/commits/5b694e443c562a0d4230364302244aba6df3087b
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
force-pushedhttps://github.com/nodejs/node/compare/0f4da9b51a2de7796af8c0115a2df65a9c2e052c..5b694e443c562a0d4230364302244aba6df3087b
0f4da9bhttps://github.com/nodejs/node/commit/0f4da9b51a2de7796af8c0115a2df65a9c2e052c
5b694e4https://github.com/nodejs/node/commit/5b694e443c562a0d4230364302244aba6df3087b
Compare https://github.com/nodejs/node/compare/0f4da9b51a2de7796af8c0115a2df65a9c2e052c..5b694e443c562a0d4230364302244aba6df3087b
August 27, 2020 03:51https://github.com/nodejs/node/pull/34819#event-3697527682
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 27, 2020https://github.com/nodejs/node/pull/34819#issuecomment-681345728
https://ci.nodejs.org/job/node-test-pull-request/32951/https://ci.nodejs.org/job/node-test-pull-request/32951/
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Aug 27, 2020 https://github.com/nodejs/node/pull/34819#pullrequestreview-476768967
View reviewed changes https://github.com/nodejs/node/pull/34819/files/5b694e443c562a0d4230364302244aba6df3087b
mhdawsonhttps://github.com/mhdawson
https://github.com/nodejs/node/pull/34819#pullrequestreview-476768967
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 27, 2020https://github.com/nodejs/node/pull/34819#issuecomment-682017004
0848f56https://github.com/nodejs/node/commit/0848f56cb39432090cdb99af9b8541fbc1a2849c
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 27, 2020https://github.com/nodejs/node/pull/34819#event-3700174932
gabrielschulhofhttps://github.com/gabrielschulhof
Aug 27, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-0848f56
https://github.com/addaleax
n-api: re-implement async env cleanup hookshttps://github.com/nodejs/node/commit/0848f56cb39432090cdb99af9b8541fbc1a2849c
0848f56https://github.com/nodejs/node/commit/0848f56cb39432090cdb99af9b8541fbc1a2849c
#34715https://github.com/nodejs/node/issues/34715
#34819https://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
August 27, 2020 15:21https://github.com/nodejs/node/pull/34819#event-3700176666
richardlauhttps://github.com/richardlau
Sep 1, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-3c32fe0
https://github.com/addaleax
https://github.com/richardlau
n-api: re-implement async env cleanup hookshttps://github.com/nodejs/node/commit/3c32fe09e9354479a2527bdd7484d6efab39f864
3c32fe0https://github.com/nodejs/node/commit/3c32fe09e9354479a2527bdd7484d6efab39f864
#34715https://github.com/nodejs/node/issues/34715
#34819https://github.com/nodejs/node/pull/34819
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Sep 2, 2020 https://github.com/nodejs/node/pull/34819#ref-pullrequest-691140213
v14.10.0 proposal #35023 https://github.com/nodejs/node/pull/35023
ianhattendorfhttps://github.com/ianhattendorf
Sep 11, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-9d5a42b
https://github.com/ianhattendorf
Test on node 14 only until backport of required node PRhttps://github.com/ianhattendorf/nodegit/commit/9d5a42bf7daaa83d5badfbf46892eeabc5b8dd24
9d5a42bhttps://github.com/ianhattendorf/nodegit/commit/9d5a42bf7daaa83d5badfbf46892eeabc5b8dd24
nodejs/node#34819https://github.com/nodejs/node/pull/34819
codebyterehttps://github.com/codebytere
Sep 21, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-7a0f220
https://github.com/codebytere
Remove redundant n-api patchhttps://github.com/electron/electron/commit/7a0f22000e4e28bce81656833dede5bfad442abe
7a0f220https://github.com/electron/electron/commit/7a0f22000e4e28bce81656833dede5bfad442abe
nodejs/node#34819https://github.com/nodejs/node/pull/34819
codebyterehttps://github.com/codebytere
Sep 21, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-f397de6
https://github.com/codebytere
Remove redundant n-api patchhttps://github.com/electron/electron/commit/f397de634ae2075a578ced359bfa7a4dfc56361d
f397de6https://github.com/electron/electron/commit/f397de634ae2075a578ced359bfa7a4dfc56361d
nodejs/node#34819https://github.com/nodejs/node/pull/34819
codebyterehttps://github.com/codebytere
Sep 21, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-b75271e
https://github.com/codebytere
Remove redundant n-api patchhttps://github.com/electron/electron/commit/b75271eb7663aad7bf40e4b42a53e646e790123e
b75271ehttps://github.com/electron/electron/commit/b75271eb7663aad7bf40e4b42a53e646e790123e
nodejs/node#34819https://github.com/nodejs/node/pull/34819
codebyterehttps://github.com/codebytere
Sep 21, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-ea664b3
https://github.com/codebytere
Remove redundant n-api patchhttps://github.com/electron/electron/commit/ea664b35f31fe8278fae2d9c487b29d0f8470cbe
ea664b3https://github.com/electron/electron/commit/ea664b35f31fe8278fae2d9c487b29d0f8470cbe
nodejs/node#34819https://github.com/nodejs/node/pull/34819
addaleaxhttps://github.com/addaleax
Sep 26, 2020 https://github.com/nodejs/node/pull/34819#ref-commit-a5aa3dd
https://github.com/addaleax
n-api: re-implement async env cleanup hookshttps://github.com/nodejs/node/commit/a5aa3ddacf7470b10a7be8221d3d52d52d927b99
a5aa3ddhttps://github.com/nodejs/node/commit/a5aa3ddacf7470b10a7be8221d3d52d52d927b99
#34715https://github.com/nodejs/node/issues/34715
#34819https://github.com/nodejs/node/pull/34819
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34819#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/gabrielschulhof
gabrielschulhofhttps://github.com/gabrielschulhof
Oct 7, 2020 https://github.com/nodejs/node/pull/34819#ref-issue-709016754
Tracking for N-API PRs needing backport nodejs/abi-stable-node#406 https://github.com/nodejs/abi-stable-node/issues/406
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34819
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34819/files/1d3eca5b0126917db6263938d3386de95dce8f25
https://github.com/mhdawson
mhdawson https://github.com/mhdawson
https://github.com/nodejs/node/pull/34819/files/5b694e443c562a0d4230364302244aba6df3087b
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/34819/files/60377051d9470ae4f8765b74c90af5f85014ad3d
https://github.com/legendecas
legendecas https://github.com/legendecas
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
node-api https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api
N-API: Some issues with the new async cleanup hooks https://github.com/nodejs/node/issues/34715
Please reload this pagehttps://github.com/nodejs/node/pull/34819
https://github.com/gabrielschulhof
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/mhdawson
https://github.com/himself65
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.