| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:eb20eb21-ef4a-b186-f591-859c4f334e96 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D2CE:9CED1:2388C37:302DA12:696AD329 |
| html-safe-nonce | 55bb25a43f26c86a1f3b9db39073f888a576bbe04f76c17971fbb1c7ef9e9386 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMkNFOjlDRUQxOjIzODhDMzc6MzAyREExMjo2OTZBRDMyOSIsInZpc2l0b3JfaWQiOiI0MzI1OTY1NzEzMTI2MzgwMzI5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6c2e9011be6907ebd77308ab1bf5f42dc4ddf3774cac7e0b71d4f3291f16747a |
| hovercard-subject-tag | pull_request:468380697 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34793/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/79b1eedf09cc018a6b7eafddf61c0a2e0d88ed4a77bc36114b8199a478dadf0b/nodejs/node/pull/34793 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/79b1eedf09cc018a6b7eafddf61c0a2e0d88ed4a77bc36114b8199a478dadf0b/nodejs/node/pull/34793 |
| og:image:alt | In test-http-destroyed-socket-write2, the assert.strictEqual() in the
default case of the switch statement will always fail because it checks
for a value that is already accounted for in one of the... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34793#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34793 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34793 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34793 |
| Reload | https://github.com/nodejs/node/pull/34793 |
| Reload | https://github.com/nodejs/node/pull/34793 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34793#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:assert-fail2 | https://github.com/Trott/io.js/tree/assert-fail2 |
|
test: convert assertion that always fails to assert.fail()
| https://github.com/nodejs/node/pull/34793#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:assert-fail2 | https://github.com/Trott/io.js/tree/assert-fail2 |
|
Conversation
2
| https://github.com/nodejs/node/pull/34793 |
|
Commits
0
| https://github.com/nodejs/node/pull/34793/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34793/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34793/files |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34793#issue-679665422 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34793#event-3658930642 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34793#event-3658930672 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34793#event-3658935752 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34793#issuecomment-674463524 |
| https://ci.nodejs.org/job/node-test-pull-request/32799/ | https://ci.nodejs.org/job/node-test-pull-request/32799/ |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
| https://github.com/cjihrig |
| cjihrig | https://github.com/cjihrig |
|
Aug 16, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468026052 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 16, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468077094 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 16, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468086600 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Aug 16, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468089420 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468745031 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34793#pullrequestreview-468748148 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34793/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/34793#issuecomment-675253229 |
| aa5361c | https://github.com/nodejs/node/commit/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
| Trott | https://github.com/Trott |
|
Aug 18, 2020
| https://github.com/nodejs/node/pull/34793#ref-commit-aa5361c |
|
| https://github.com/Trott |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/commit/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| aa5361c | https://github.com/nodejs/node/commit/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| #34793 | https://github.com/nodejs/node/pull/34793 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/34793#event-3664577313 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/ea86b9fc85590f2fbc7726a016f0499919e62f55..aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| ea86b9f | https://github.com/nodejs/node/commit/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
| aa5361c | https://github.com/nodejs/node/commit/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
|
Compare
| https://github.com/nodejs/node/compare/ea86b9fc85590f2fbc7726a016f0499919e62f55..aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| August 18, 2020 05:10 | https://github.com/nodejs/node/pull/34793#event-3664577316 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 18, 2020 05:10 | https://github.com/nodejs/node/pull/34793#event-3664577446 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34793#ref-commit-7a13e01 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/commit/7a13e0169dceccba1856ed6ce92aaf3466671b7c |
| 7a13e01 | https://github.com/nodejs/node/commit/7a13e0169dceccba1856ed6ce92aaf3466671b7c |
| #34793 | https://github.com/nodejs/node/pull/34793 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34793#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34793#ref-commit-e8eed5c |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/commit/e8eed5c426a73c4529c1040f7db79b387b60a364 |
| e8eed5c | https://github.com/nodejs/node/commit/e8eed5c426a73c4529c1040f7db79b387b60a364 |
| #34793 | https://github.com/nodejs/node/pull/34793 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34793#ref-commit-ef7cec1 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/commit/ef7cec1dcc75e7a4f2330205cf33f662c2de3f5f |
| ef7cec1 | https://github.com/nodejs/node/commit/ef7cec1dcc75e7a4f2330205cf33f662c2de3f5f |
| #34793 | https://github.com/nodejs/node/pull/34793 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34793#ref-commit-ac776f4 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/commit/ac776f43f45df82aa43fe63a52c5bedc88aae235 |
| ac776f4 | https://github.com/nodejs/node/commit/ac776f43f45df82aa43fe63a52c5bedc88aae235 |
| #34793 | https://github.com/nodejs/node/pull/34793 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34793#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34793 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
| https://github.com/cjihrig |
|
cjihrig
| https://github.com/cjihrig |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/34793/files/ea86b9fc85590f2fbc7726a016f0499919e62f55 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34793 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/cjihrig |
|
| https://github.com/tniessen |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |