| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7d78e8ed-4982-f7db-b44d-682e89d97409 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CED8:323DD4:C1DE17:10D1793:696A8BC9 |
| html-safe-nonce | 423e865dd1617d94c9dedf36006392a45d83e18811a7832e8ba644672191417e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQ4OjMyM0RENDpDMURFMTc6MTBEMTc5Mzo2OTZBOEJDOSIsInZpc2l0b3JfaWQiOiI3NjU3MTMyNDIyMjM0NTQxMDAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 72b0baf1b27f16bff3be24be3ab462a5a2b2e0d24cebb0f40f0966ce5bc106ad |
| hovercard-subject-tag | pull_request:467581119 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34764/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a66d0c191d357429c9b611ca86b5e2d058a2bf0be4a9ec2c495a69d924a2f829/nodejs/node/pull/34764 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a66d0c191d357429c9b611ca86b5e2d058a2bf0be4a9ec2c495a69d924a2f829/nodejs/node/pull/34764 |
| og:image:alt | Broken locally for me since f8976a7.
Refs: #34744
@guybedford @jasnell @jkrems Fyi
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | addaleax |
| hostname | github.com |
| expected-hostname | github.com |
| None | d2aa6dedd7d97fa651b17c40401f2605f309df5ca5fb659bf0554cf34f1de825 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c1dbca8981c5e3d6a69bce2f1d289e732b86241d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34764#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34764 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34764 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34764 |
| Reload | https://github.com/nodejs/node/pull/34764 |
| Reload | https://github.com/nodejs/node/pull/34764 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34764#issue-comment-box |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-resolve-test | https://github.com/addaleax/node/tree/fix-resolve-test |
|
test: fix message/esm_loader_not_found_cjs_hint_bare
| https://github.com/nodejs/node/pull/34764#top |
| addaleax | https://github.com/addaleax |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| addaleax:fix-resolve-test | https://github.com/addaleax/node/tree/fix-resolve-test |
|
Conversation
6
| https://github.com/nodejs/node/pull/34764 |
|
Commits
1
| https://github.com/nodejs/node/pull/34764/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34764/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34764/files |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issue-678671959 |
| f8976a7 | https://github.com/nodejs/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2 |
| #34744 | https://github.com/nodejs/node/pull/34744 |
| @guybedford | https://github.com/guybedford |
| @jasnell | https://github.com/jasnell |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
|
| https://github.com/addaleax |
| test: fix message/esm_loader_not_found_cjs_hint_bare | https://github.com/nodejs/node/pull/34764/commits/f53b806d4f8a3d05ed358154226b716adebb774f |
| f53b806 | https://github.com/nodejs/node/pull/34764/commits/f53b806d4f8a3d05ed358154226b716adebb774f |
| f8976a7 | https://github.com/addaleax/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2 |
| nodejs#34744 | https://github.com/nodejs/node/pull/34744 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#event-3653480791 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issuecomment-673658516 |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#event-3653508358 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issuecomment-673662407 |
| https://ci.nodejs.org/job/node-test-pull-request/32761/ | https://ci.nodejs.org/job/node-test-pull-request/32761/ |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issuecomment-673662650 |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/guybedford |
| guybedford | https://github.com/guybedford |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issuecomment-673663737 |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 13, 2020
| https://github.com/nodejs/node/pull/34764#pullrequestreview-467062170 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34764/files/f53b806d4f8a3d05ed358154226b716adebb774f |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Aug 13, 2020
| https://github.com/nodejs/node/pull/34764#pullrequestreview-467064298 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34764/files/f53b806d4f8a3d05ed358154226b716adebb774f |
| richardlau | https://github.com/richardlau |
| https://github.com/nodejs/node/pull/34764#pullrequestreview-467064298 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#issuecomment-673666788 |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 13, 2020 | https://github.com/nodejs/node/pull/34764#event-3653540119 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| August 13, 2020 19:26 | https://github.com/nodejs/node/pull/34764#event-3653540366 |
|
CI Reliability 2020-08-15
nodejs/reliability#44
| https://github.com/nodejs/reliability/issues/44 |
|
CI Reliability 2020-08-16
nodejs/reliability#45
| https://github.com/nodejs/reliability/issues/45 |
|
CI Reliability 2020-08-17
nodejs/reliability#46
| https://github.com/nodejs/reliability/issues/46 |
|
CI Reliability 2020-08-18
nodejs/reliability#47
| https://github.com/nodejs/reliability/issues/47 |
|
CI Reliability 2020-08-19
nodejs/reliability#48
| https://github.com/nodejs/reliability/issues/48 |
|
CI Reliability 2020-08-20
nodejs/reliability#49
| https://github.com/nodejs/reliability/issues/49 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34764 |
|
| https://github.com/richardlau |
|
richardlau
| https://github.com/richardlau |
|
| https://github.com/nodejs/node/pull/34764/files/f53b806d4f8a3d05ed358154226b716adebb774f |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34764/files/f53b806d4f8a3d05ed358154226b716adebb774f |
|
esm
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm |
|
fast-track
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34764 |
|
| https://github.com/addaleax |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/guybedford |
|
| https://github.com/jasnell |
|
| https://github.com/richardlau |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |