| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cfae3bc8-88f8-7c83-0eae-b5a33386fb9f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9EB6:258BE8:9746E8:CC559A:696AB8FE |
| html-safe-nonce | cd50bc455e0d39400c887a15d9b4c063a6026128a102394a8c1f9cd7cbc8d9b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUI2OjI1OEJFODo5NzQ2RTg6Q0M1NTlBOjY5NkFCOEZFIiwidmlzaXRvcl9pZCI6Ijc5NTY5Nzc4ODg4OTgyMzQ2MjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6cf6ff6b42f8b79c39af5f4b9d46daba2a3f91cd7b382b12fa45609747ec443d |
| hovercard-subject-tag | pull_request:466790166 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34749/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/df3683cb64eaaf786bf96784f79ca7dc4ca472d9535c4f2e09af3f8501028803/nodejs/node/pull/34749 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df3683cb64eaaf786bf96784f79ca7dc4ca472d9535c4f2e09af3f8501028803/nodejs/node/pull/34749 |
| og:image:alt | Many style guides (including Microsoft's) suggest avoiding may because
it can be unclear. Using can or might tends to increase clarity.
An example in this change:
They may not change to a Runt... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34749#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34749 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34749 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34749 |
| Reload | https://github.com/nodejs/node/pull/34749 |
| Reload | https://github.com/nodejs/node/pull/34749 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34749#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:cg-may | https://github.com/Trott/io.js/tree/cg-may |
|
doc: avoid _may_ in collaborator guide
| https://github.com/nodejs/node/pull/34749#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:cg-may | https://github.com/Trott/io.js/tree/cg-may |
|
Conversation
4
| https://github.com/nodejs/node/pull/34749 |
|
Commits
0
| https://github.com/nodejs/node/pull/34749/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34749/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34749/files |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 12, 2020 | https://github.com/nodejs/node/pull/34749#issue-677715922 |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Aug 12, 2020 | https://github.com/nodejs/node/pull/34749#event-3647846775 |
| https://github.com/jvmazagao |
| jvmazagao | https://github.com/jvmazagao |
|
Aug 12, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-465991004 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 12, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-466067448 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/34749#pullrequestreview-466067448 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| https://github.com/Leko |
| Leko | https://github.com/Leko |
|
Aug 12, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-466103881 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/6ca8c883f8c494263f026f0cd5ce0eba3c508352..75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
| 6ca8c88 | https://github.com/nodejs/node/commit/6ca8c883f8c494263f026f0cd5ce0eba3c508352 |
| 75801e3 | https://github.com/nodejs/node/commit/75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
|
Compare
| https://github.com/nodejs/node/compare/6ca8c883f8c494263f026f0cd5ce0eba3c508352..75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
| August 12, 2020 17:56 | https://github.com/nodejs/node/pull/34749#event-3648824157 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 12, 2020 | https://github.com/nodejs/node/pull/34749#issuecomment-673022991 |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| https://github.com/trivikr |
| trivikr | https://github.com/trivikr |
|
Aug 13, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-466493788 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Aug 13, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-466696415 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Aug 13, 2020
| https://github.com/nodejs/node/pull/34749#pullrequestreview-467067596 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34749/files |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 14, 2020 | https://github.com/nodejs/node/pull/34749#event-3655433556 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 14, 2020 | https://github.com/nodejs/node/pull/34749#issuecomment-674296349 |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 14, 2020 | https://github.com/nodejs/node/pull/34749#issuecomment-674296635 |
| 8640cd6 | https://github.com/nodejs/node/commit/8640cd6066b858f7499d175b18dfc1947653063f |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
| Trott | https://github.com/Trott |
|
Aug 14, 2020
| https://github.com/nodejs/node/pull/34749#ref-commit-8640cd6 |
|
| https://github.com/Trott |
| doc: avoid _may_ in collaborator guide | https://github.com/nodejs/node/commit/8640cd6066b858f7499d175b18dfc1947653063f |
| 8640cd6 | https://github.com/nodejs/node/commit/8640cd6066b858f7499d175b18dfc1947653063f |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| #34749 | https://github.com/nodejs/node/pull/34749 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 14, 2020 | https://github.com/nodejs/node/pull/34749#event-3657871567 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/75801e34edb2c5432d1d1a90f40b02d78cabeab0..8640cd6066b858f7499d175b18dfc1947653063f |
| 75801e3 | https://github.com/nodejs/node/commit/75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
| 8640cd6 | https://github.com/nodejs/node/commit/8640cd6066b858f7499d175b18dfc1947653063f |
|
Compare
| https://github.com/nodejs/node/compare/75801e34edb2c5432d1d1a90f40b02d78cabeab0..8640cd6066b858f7499d175b18dfc1947653063f |
| August 14, 2020 22:26 | https://github.com/nodejs/node/pull/34749#event-3657871571 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 14, 2020 22:26 | https://github.com/nodejs/node/pull/34749#event-3657871676 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34749#ref-commit-66fcd68 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| doc: avoid _may_ in collaborator guide | https://github.com/nodejs/node/commit/66fcd68076ffdd000380d597a0be3ef6effc3206 |
| 66fcd68 | https://github.com/nodejs/node/commit/66fcd68076ffdd000380d597a0be3ef6effc3206 |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| #34749 | https://github.com/nodejs/node/pull/34749 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34749#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34749#ref-commit-3925fd6 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: avoid _may_ in collaborator guide | https://github.com/nodejs/node/commit/3925fd65504ec0b16a21f9c0149d2ffdd7fd585f |
| 3925fd6 | https://github.com/nodejs/node/commit/3925fd65504ec0b16a21f9c0149d2ffdd7fd585f |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| #34749 | https://github.com/nodejs/node/pull/34749 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34749#ref-commit-6646dec |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: avoid _may_ in collaborator guide | https://github.com/nodejs/node/commit/6646dece0d8004098e1407fb200638c8230ce0ae |
| 6646dec | https://github.com/nodejs/node/commit/6646dece0d8004098e1407fb200638c8230ce0ae |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| #34749 | https://github.com/nodejs/node/pull/34749 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34749#ref-commit-09687b8 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: avoid _may_ in collaborator guide | https://github.com/nodejs/node/commit/09687b85f792facdd6af376a08216b5f05c22524 |
| 09687b8 | https://github.com/nodejs/node/commit/09687b85f792facdd6af376a08216b5f05c22524 |
| https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may | https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may |
| #34749 | https://github.com/nodejs/node/pull/34749 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34749#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34749 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34749/files/6ca8c883f8c494263f026f0cd5ce0eba3c508352 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34749/files/75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
|
| https://github.com/trivikr |
|
trivikr
| https://github.com/trivikr |
|
| https://github.com/nodejs/node/pull/34749/files/75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/34749/files/75801e34edb2c5432d1d1a90f40b02d78cabeab0 |
|
| https://github.com/Leko |
|
Leko
| https://github.com/Leko |
|
| https://github.com/nodejs/node/pull/34749/files/6ca8c883f8c494263f026f0cd5ce0eba3c508352 |
|
| https://github.com/jvmazagao |
|
jvmazagao
| https://github.com/jvmazagao |
|
| https://github.com/nodejs/node/pull/34749/files/6ca8c883f8c494263f026f0cd5ce0eba3c508352 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/34749 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/antsmartian |
|
| https://github.com/Leko |
|
| https://github.com/lpinca |
|
| https://github.com/trivikr |
|
| https://github.com/jvmazagao |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/rickyes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |