René's URL Explorer Experiment


Title: module: CJS / ESM resolver sharing and refactoring by guybedford · Pull Request #34744 · nodejs/node · GitHub

Open Graph Title: module: CJS / ESM resolver sharing and refactoring by guybedford · Pull Request #34744 · nodejs/node

X Title: module: CJS / ESM resolver sharing and refactoring by guybedford · Pull Request #34744 · nodejs/node

Description: This extracts just the resolver refactoring component from #34718. I hope that the negative diff speaks for itself at least! Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...

Open Graph Description: This extracts just the resolver refactoring component from #34718. I hope that the negative diff speaks for itself at least! Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...

X Description: This extracts just the resolver refactoring component from #34718. I hope that the negative diff speaks for itself at least! Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...

Opengraph URL: https://github.com/nodejs/node/pull/34744

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:205a1579-f9bc-d986-4684-bd1c58043547
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD736:1C6213:6866E:90909:696A6527
html-safe-nonceacea49710ab6032248f7b5b8fd26b54290a40a45cb774985100356dfd26bf05f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzM2OjFDNjIxMzo2ODY2RTo5MDkwOTo2OTZBNjUyNyIsInZpc2l0b3JfaWQiOiI1NTQwMjA1NDkwODYwNjE0OTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb60bc638a46d217fb843dceec2d98d3614542fa9f389725bbc07afb37e8aadcd
hovercard-subject-tagpull_request:466452381
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34744/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7c09291e496e7587a043f0ba20be5f2fd30da0b03f97d7b36eca94ba4fe630b5/nodejs/node/pull/34744
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c09291e496e7587a043f0ba20be5f2fd30da0b03f97d7b36eca94ba4fe630b5/nodejs/node/pull/34744
og:image:altThis extracts just the resolver refactoring component from #34718. I hope that the negative diff speaks for itself at least! Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameguybedford
hostnamegithub.com
expected-hostnamegithub.com
None9b7735a184970dd9333b2cbe036c8f3c0a9108c64aaa93827c5a64fc70993392
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release87cbd411c2982752221b5751d583a515b23bf5fa
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34744#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34744
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34744
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34744
Reloadhttps://github.com/nodejs/node/pull/34744
Reloadhttps://github.com/nodejs/node/pull/34744
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34744
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 694 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34744
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34744#issue-comment-box
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:resolve-refactorhttps://github.com/guybedford/node/tree/resolve-refactor
module: CJS / ESM resolver sharing and refactoring https://github.com/nodejs/node/pull/34744#top
guybedfordhttps://github.com/guybedford
nodejs:masterhttps://github.com/nodejs/node/tree/master
guybedford:resolve-refactorhttps://github.com/guybedford/node/tree/resolve-refactor
Conversation 12 https://github.com/nodejs/node/pull/34744
Commits 2 https://github.com/nodejs/node/pull/34744/commits
Checks 0 https://github.com/nodejs/node/pull/34744/checks
Files changed https://github.com/nodejs/node/pull/34744/files
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issue-677315720
Please reload this pagehttps://github.com/nodejs/node/pull/34744
#34718https://github.com/nodejs/node/pull/34718
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Aug 12, 2020https://github.com/nodejs/node/pull/34744#event-3645645999
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-672447847
Please reload this pagehttps://github.com/nodejs/node/pull/34744
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#event-3645650190
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020 https://github.com/nodejs/node/pull/34744#ref-pullrequest-676490701
module: exports patterns #34718 https://github.com/nodejs/node/pull/34718
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-672575906
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-672594627
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-672610873
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/hybrist
hybristhttps://github.com/hybrist
Aug 12, 2020 https://github.com/nodejs/node/pull/34744#pullrequestreview-466102171
View reviewed changes https://github.com/nodejs/node/pull/34744/files
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673038312
@ljharbhttps://github.com/ljharb
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/ljharb
ljharbhttps://github.com/ljharb
Aug 12, 2020 https://github.com/nodejs/node/pull/34744#pullrequestreview-466216661
View reviewed changes https://github.com/nodejs/node/pull/34744/files
lib/internal/modules/cjs/loader.jshttps://github.com/nodejs/node/pull/34744/files#diff-5b5902273122e094ff474fda358605ffa45a4a58b51cd0bf4c1acb93779df142
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
module: CJS/ESM resolver sharing and refactoringhttps://github.com/nodejs/node/pull/34744/commits/fc1f44b20a65e696ff391b15c5973638efe79f33
fc1f44bhttps://github.com/nodejs/node/pull/34744/commits/fc1f44b20a65e696ff391b15c5973638efe79f33
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/734865c3f5d3a135c7938267c88c7de70e0415b6..fc1f44b20a65e696ff391b15c5973638efe79f33
734865chttps://github.com/nodejs/node/commit/734865c3f5d3a135c7938267c88c7de70e0415b6
fc1f44bhttps://github.com/nodejs/node/commit/fc1f44b20a65e696ff391b15c5973638efe79f33
Compare https://github.com/nodejs/node/compare/734865c3f5d3a135c7938267c88c7de70e0415b6..fc1f44b20a65e696ff391b15c5973638efe79f33
August 12, 2020 22:24https://github.com/nodejs/node/pull/34744#event-3649666303
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673140407
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673140518
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673143258
https://ci.nodejs.org/job/node-test-pull-request/32750/https://ci.nodejs.org/job/node-test-pull-request/32750/
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2020 https://github.com/nodejs/node/pull/34744#pullrequestreview-466343139
View reviewed changes https://github.com/nodejs/node/pull/34744/files/fc1f44b20a65e696ff391b15c5973638efe79f33
https://github.com/guybedford
windows fixeshttps://github.com/nodejs/node/pull/34744/commits/b5622f9b162b55bb5411af710b79b6b13d62dd2a
b5622f9https://github.com/nodejs/node/pull/34744/commits/b5622f9b162b55bb5411af710b79b6b13d62dd2a
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673161364
https://ci.nodejs.org/job/node-test-pull-request/32751/https://ci.nodejs.org/job/node-test-pull-request/32751/
Please reload this pagehttps://github.com/nodejs/node/pull/34744
guybedfordhttps://github.com/guybedford
Aug 13, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-f8976a7
https://github.com/guybedford
module: share CJS/ESM resolver fns, refactoringhttps://github.com/nodejs/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2
f8976a7https://github.com/nodejs/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2
#34744https://github.com/nodejs/node/pull/34744
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 13, 2020https://github.com/nodejs/node/pull/34744#issuecomment-673628520
f8976a7https://github.com/nodejs/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 13, 2020https://github.com/nodejs/node/pull/34744#event-3653248431
addaleaxhttps://github.com/addaleax
Aug 13, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-f53b806
https://github.com/addaleax
test: fix message/esm_loader_not_found_cjs_hint_barehttps://github.com/addaleax/node/commit/f53b806d4f8a3d05ed358154226b716adebb774f
f53b806https://github.com/addaleax/node/commit/f53b806d4f8a3d05ed358154226b716adebb774f
f8976a7https://github.com/addaleax/node/commit/f8976a76bbb49d678056d6d2ddd57064cf9e63c2
nodejs#34744https://github.com/nodejs/node/pull/34744
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 13, 2020 https://github.com/nodejs/node/pull/34744#ref-pullrequest-678671959
test: fix message/esm_loader_not_found_cjs_hint_bare #34764 https://github.com/nodejs/node/pull/34764
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 15, 2020 https://github.com/nodejs/node/pull/34744#ref-issue-679207628
module: missing path separator in ERR_PACKAGE_PATH_NOT_EXPORTED message from CJS #34778 https://github.com/nodejs/node/issues/34778
MylesBorinshttps://github.com/MylesBorins
Aug 17, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-2f7cfe5
https://github.com/guybedford
https://github.com/MylesBorins
module: share CJS/ESM resolver fns, refactoringhttps://github.com/nodejs/node/commit/2f7cfe5ce9b3dbec58d4c1e382c465c01dec5852
2f7cfe5https://github.com/nodejs/node/commit/2f7cfe5ce9b3dbec58d4c1e382c465c01dec5852
#34744https://github.com/nodejs/node/pull/34744
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 20, 2020 https://github.com/nodejs/node/pull/34744#ref-pullrequest-682706557
V14.9.0 proposal #34852 https://github.com/nodejs/node/pull/34852
BethGriggshttps://github.com/BethGriggs
Aug 20, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-698cae7
https://github.com/guybedford
https://github.com/BethGriggs
module: share CJS/ESM resolver fns, refactoringhttps://github.com/nodejs/node/commit/698cae76251975984b7a04df2bb6245e73ee0e1c
698cae7https://github.com/nodejs/node/commit/698cae76251975984b7a04df2bb6245e73ee0e1c
#34744https://github.com/nodejs/node/pull/34744
guybedfordhttps://github.com/guybedford
Sep 28, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-7e20df2
https://github.com/guybedford
module: share CJS/ESM resolver fns, refactoringhttps://github.com/guybedford/node/commit/7e20df26113b01421fac564ceb554613af85eb87
7e20df2https://github.com/guybedford/node/commit/7e20df26113b01421fac564ceb554613af85eb87
nodejs#34744https://github.com/nodejs/node/pull/34744
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
backport-open-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-open-v12.x
Sep 28, 2020https://github.com/nodejs/node/pull/34744#event-3813643583
codebyterehttps://github.com/codebytere
Oct 1, 2020 https://github.com/nodejs/node/pull/34744#ref-commit-cecc193
https://github.com/guybedford
https://github.com/codebytere
module: share CJS/ESM resolver fns, refactoringhttps://github.com/nodejs/node/commit/cecc193abcf64d7d7b1b2bb5bacf036982e59ac7
cecc193https://github.com/nodejs/node/commit/cecc193abcf64d7d7b1b2bb5bacf036982e59ac7
#34744https://github.com/nodejs/node/pull/34744
#35385https://github.com/nodejs/node/pull/35385
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Oct 4, 2020 https://github.com/nodejs/node/pull/34744#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/cyyynthia
cyyynthiahttps://github.com/cyyynthia
Apr 7, 2025 https://github.com/nodejs/node/pull/34744#ref-pullrequest-2974902414
esm: remove check for trailing slash during resolve #57773 https://github.com/nodejs/node/pull/57773
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34744
https://github.com/ljharb
ljharb https://github.com/ljharb
https://github.com/nodejs/node/pull/34744/files/734865c3f5d3a135c7938267c88c7de70e0415b6
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34744/files/fc1f44b20a65e696ff391b15c5973638efe79f33
https://github.com/hybrist
hybrist https://github.com/hybrist
https://github.com/nodejs/node/pull/34744/files/1fa11101e3deb66a0dda54e7ceb5c4a620e01a99
errors https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aerrors
esm https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aesm
Please reload this pagehttps://github.com/nodejs/node/pull/34744
https://github.com/guybedford
https://github.com/nodejs-github-bot
https://github.com/ljharb
https://github.com/jasnell
https://github.com/hybrist
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.