René's URL Explorer Experiment


Title: lib: add UNC support to url.pathToFileURL() by mceachen · Pull Request #34743 · nodejs/node · GitHub

Open Graph Title: lib: add UNC support to url.pathToFileURL() by mceachen · Pull Request #34743 · nodejs/node

X Title: lib: add UNC support to url.pathToFileURL() by mceachen · Pull Request #34743 · nodejs/node

Description: Fixes: #34736 Checklist make -j4 test (UNIX) passes vcbuild test (Windows) passes tests are included commit message follows commit guidelines certified Developer's Certificate of Origin 1.1

Open Graph Description: Fixes: #34736 Checklist make -j4 test (UNIX) passes vcbuild test (Windows) passes tests are included commit message follows commit guidelines certified Developer's Certificate of Origin 1.1

X Description: Fixes: #34736 Checklist make -j4 test (UNIX) passes vcbuild test (Windows) passes tests are included commit message follows commit guidelines certified Developer's Certificate of Origin 1.1

Opengraph URL: https://github.com/nodejs/node/pull/34743

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:be7c47a3-5e7b-6d6a-caab-d267c2ed047e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA1F4:2BBD61:A43DC6:DF4DC2:696ABA36
html-safe-noncee692a37d4476bd67f4ce907886d75a5450765395c74781b71a8ad054edc267ce
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMUY0OjJCQkQ2MTpBNDNEQzY6REY0REMyOjY5NkFCQTM2IiwidmlzaXRvcl9pZCI6IjI3Mzc3ODI2MDYzMTExMTEyMjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca120ff3a930f5de3d1ad6c26c1b83f8b30bcf10180842bdd2507cd94d1d59d77
hovercard-subject-tagpull_request:466444517
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34743/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/caf429cf4770b967e5e38be0aa30ab2139eeb7d6e52a9e534ea987aed766200b/nodejs/node/pull/34743
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/caf429cf4770b967e5e38be0aa30ab2139eeb7d6e52a9e534ea987aed766200b/nodejs/node/pull/34743
og:image:altFixes: #34736 Checklist make -j4 test (UNIX) passes vcbuild test (Windows) passes tests are included commit message follows commit guidelines certified Developer's Certificate of Origin 1.1
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemceachen
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34743#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34743
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34743
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34743
Reloadhttps://github.com/nodejs/node/pull/34743
Reloadhttps://github.com/nodejs/node/pull/34743
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34743
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34743
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34743#issue-comment-box
mceachenhttps://github.com/mceachen
nodejs:masterhttps://github.com/nodejs/node/tree/master
lib: add UNC support to url.pathToFileURL() https://github.com/nodejs/node/pull/34743#top
mceachenhttps://github.com/mceachen
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversation 12 https://github.com/nodejs/node/pull/34743
Commits 2 https://github.com/nodejs/node/pull/34743/commits
Checks 0 https://github.com/nodejs/node/pull/34743/checks
Files changed https://github.com/nodejs/node/pull/34743/files
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/mceachen
mceachenhttps://github.com/mceachen
Aug 12, 2020https://github.com/nodejs/node/pull/34743#issue-677306181
#34736https://github.com/nodejs/node/issues/34736
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/mceachen
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/pull/34743/commits/80d42fc36361bd89b7a15216a011743be547a427
80d42fchttps://github.com/nodejs/node/pull/34743/commits/80d42fc36361bd89b7a15216a011743be547a427
#34736https://github.com/nodejs/node/issues/34736
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Aug 12, 2020 https://github.com/nodejs/node/pull/34743#pullrequestreview-465541931
View reviewed changes https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
guybedfordhttps://github.com/guybedford
https://github.com/nodejs/node/pull/34743#pullrequestreview-465541931
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mceachenhttps://github.com/mceachen
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
jasnellhttps://github.com/jasnell
August 12, 2020 02:02https://github.com/nodejs/node/pull/34743#event-3645666336
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2020 https://github.com/nodejs/node/pull/34743#pullrequestreview-465543655
View reviewed changes https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
https://github.com/mceachen
mceachenhttps://github.com/mceachen
Aug 12, 2020https://github.com/nodejs/node/pull/34743#issuecomment-672545620
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/rickyes
rickyeshttps://github.com/rickyes
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 12, 2020https://github.com/nodejs/node/pull/34743#event-3645913841
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 12, 2020https://github.com/nodejs/node/pull/34743#event-3645921395
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 12, 2020https://github.com/nodejs/node/pull/34743#issuecomment-672565655
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://ci.nodejs.org/job/node-test-pull-request/32742/https://ci.nodejs.org/job/node-test-pull-request/32742/
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 12, 2020https://github.com/nodejs/node/pull/34743#issuecomment-672965374
@mceachenhttps://github.com/mceachen
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 12, 2020 https://github.com/nodejs/node/pull/34743#pullrequestreview-466179213
View reviewed changes https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
lib/internal/url.jshttps://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
lpincahttps://github.com/lpinca
Aug 12, 2020https://github.com/nodejs/node/pull/34743#discussion_r469466050
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34743
mceachenhttps://github.com/mceachen
Aug 12, 2020https://github.com/nodejs/node/pull/34743#discussion_r469477309
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34743
lib/internal/url.jshttps://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427#diff-26e6b1e2a90040b1ce20e7f305b2ff3140b483f863ee2573b4c6af9b696ad31e
Please reload this pagehttps://github.com/nodejs/node/pull/34743
test/parallel/test-url-pathtofileurl.jshttps://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427#diff-0256bd60e832dcc4e3ac76d4d39723581fce24d3d416ec8780f889d456a57c5f
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/lpinca
lpincahttps://github.com/lpinca
Aug 12, 2020 https://github.com/nodejs/node/pull/34743#pullrequestreview-466194383
View reviewed changes https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
https://github.com/mceachen
Update url.jshttps://github.com/nodejs/node/pull/34743/commits/94a21261927d871acc954eaedab4d95063389882
94a2126https://github.com/nodejs/node/pull/34743/commits/94a21261927d871acc954eaedab4d95063389882
https://github.com/mceachen
mceachenhttps://github.com/mceachen
Aug 13, 2020https://github.com/nodejs/node/pull/34743#issuecomment-673179981
Please reload this pagehttps://github.com/nodejs/node/pull/34743
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/lpinca
lpincahttps://github.com/lpinca
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 13, 2020https://github.com/nodejs/node/pull/34743#event-3650465406
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
request-ci https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci
Aug 13, 2020https://github.com/nodejs/node/pull/34743#event-3650478700
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 14, 2020https://github.com/nodejs/node/pull/34743#issuecomment-673840304
https://ci.nodejs.org/job/node-test-pull-request/32772/https://ci.nodejs.org/job/node-test-pull-request/32772/
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 14, 2020 https://github.com/nodejs/node/pull/34743#pullrequestreview-467271673
View reviewed changes https://github.com/nodejs/node/pull/34743/files/94a21261927d871acc954eaedab4d95063389882
Trotthttps://github.com/Trott
Aug 14, 2020 https://github.com/nodejs/node/pull/34743#ref-commit-7b8c6b0
https://github.com/mceachen
https://github.com/Trott
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/commit/7b8c6b0c00f5e321e431047794fde8b84d0c4c3f
7b8c6b0https://github.com/nodejs/node/commit/7b8c6b0c00f5e321e431047794fde8b84d0c4c3f
#34736https://github.com/nodejs/node/issues/34736
#34743https://github.com/nodejs/node/pull/34743
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 14, 2020https://github.com/nodejs/node/pull/34743#issuecomment-673852432
7b8c6b0https://github.com/nodejs/node/commit/7b8c6b0c00f5e321e431047794fde8b84d0c4c3f
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 14, 2020https://github.com/nodejs/node/pull/34743#event-3654541386
MylesBorinshttps://github.com/MylesBorins
Aug 17, 2020 https://github.com/nodejs/node/pull/34743#ref-commit-72e7380
https://github.com/mceachen
https://github.com/MylesBorins
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/commit/72e7380c1300dde92ba95145e9421a1dfbcb6488
72e7380https://github.com/nodejs/node/commit/72e7380c1300dde92ba95145e9421a1dfbcb6488
#34736https://github.com/nodejs/node/issues/34736
#34743https://github.com/nodejs/node/pull/34743
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
Aug 20, 2020 https://github.com/nodejs/node/pull/34743#ref-pullrequest-682706557
V14.9.0 proposal #34852 https://github.com/nodejs/node/pull/34852
BethGriggshttps://github.com/BethGriggs
Aug 20, 2020 https://github.com/nodejs/node/pull/34743#ref-commit-1a9496a
https://github.com/mceachen
https://github.com/BethGriggs
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/commit/1a9496a79dd54566461c10650a8d6662264cb1be
1a9496ahttps://github.com/nodejs/node/commit/1a9496a79dd54566461c10650a8d6662264cb1be
#34736https://github.com/nodejs/node/issues/34736
#34743https://github.com/nodejs/node/pull/34743
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34743#ref-commit-418ff2d
https://github.com/mceachen
https://github.com/addaleax
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/commit/418ff2d208bdd50a28a2ac8a10a6bec035908c0c
418ff2dhttps://github.com/nodejs/node/commit/418ff2d208bdd50a28a2ac8a10a6bec035908c0c
#34736https://github.com/nodejs/node/issues/34736
#34743https://github.com/nodejs/node/pull/34743
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34743#ref-commit-f29ab40
https://github.com/mceachen
https://github.com/addaleax
lib: add UNC support to url.pathToFileURL()https://github.com/nodejs/node/commit/f29ab4092f8387293ff9c46e0653891a15f6af8f
f29ab40https://github.com/nodejs/node/commit/f29ab4092f8387293ff9c46e0653891a15f6af8f
#34736https://github.com/nodejs/node/issues/34736
#34743https://github.com/nodejs/node/pull/34743
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34743#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34743
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
https://github.com/Trott
Trott https://github.com/Trott
https://github.com/nodejs/node/pull/34743/files/94a21261927d871acc954eaedab4d95063389882
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/34743/files/80d42fc36361bd89b7a15216a011743be547a427
lib / src https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22lib%20%2F%20src%22
url.pathToFileURL doesn't generate valid URLs for UNC paths https://github.com/nodejs/node/issues/34736
Please reload this pagehttps://github.com/nodejs/node/pull/34743
https://github.com/mceachen
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/Trott
https://github.com/guybedford
https://github.com/lpinca
https://github.com/rickyes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.