| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a6d41744-a49a-1117-b329-b02128ba3767 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DFC0:29957D:23EB515:30F1A2E:696AD424 |
| html-safe-nonce | 5db24fb6ada58d814ac63d7b4225f06ee261d73f9c3cd7507793d80cbcbebf68 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERkMwOjI5OTU3RDoyM0VCNTE1OjMwRjFBMkU6Njk2QUQ0MjQiLCJ2aXNpdG9yX2lkIjoiMTAzNzIxNDQxNzQwNjMxNzYwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | adb0a1cfe83c95093bca2da23709fc493ec5b4e9f0f3b542b6cb3b973bc5e746 |
| hovercard-subject-tag | pull_request:465205996 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34697/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c061d8abffb7ab6f1b56c2f077d2ade5d3dc0544159ef71dbab46ecb02d11f6/nodejs/node/pull/34697 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c061d8abffb7ab6f1b56c2f077d2ade5d3dc0544159ef71dbab46ecb02d11f6/nodejs/node/pull/34697 |
| og:image:alt | The text for the legacy API sends mixed signals. It's legacy, but still
supported, so not deprecated, but not recommended. Let's begin to
clarify this by removing "not recommended"... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | c785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c718a376fcf780eb22089171adb84a543f660bf7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34697#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34697 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34697 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34697 |
| Reload | https://github.com/nodejs/node/pull/34697 |
| Reload | https://github.com/nodejs/node/pull/34697 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34697#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:crypto-recommended-1 | https://github.com/Trott/io.js/tree/crypto-recommended-1 |
|
doc: remove "is recommended" from crypto legacy API text
| https://github.com/nodejs/node/pull/34697#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:crypto-recommended-1 | https://github.com/Trott/io.js/tree/crypto-recommended-1 |
|
Conversation
5
| https://github.com/nodejs/node/pull/34697 |
|
Commits
25
| https://github.com/nodejs/node/pull/34697/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34697/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34697/files |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34697#issue-675776564 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34697#event-3636797632 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34697#event-3636797866 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34697#pullrequestreview-464291887 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34697/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/34697#pullrequestreview-464291887 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/b264d46940691237d0d9ea241414b10f049e82d5..9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
| b264d46 | https://github.com/nodejs/node/commit/b264d46940691237d0d9ea241414b10f049e82d5 |
| 9a6ed8c | https://github.com/nodejs/node/commit/9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
|
Compare
| https://github.com/nodejs/node/compare/b264d46940691237d0d9ea241414b10f049e82d5..9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
| August 16, 2020 16:57 | https://github.com/nodejs/node/pull/34697#event-3659460271 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 16, 2020 | https://github.com/nodejs/node/pull/34697#issuecomment-674550756 |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.com/ryzokuken |
| ryzokuken | https://github.com/ryzokuken |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34697#pullrequestreview-468183412 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34697/files |
| ryzokuken | https://github.com/ryzokuken |
| https://github.com/nodejs/node/pull/34697#pullrequestreview-468183412 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| mildsunrise | https://github.com/mildsunrise |
| August 17, 2020 13:49 | https://github.com/nodejs/node/pull/34697#commits-pushed-f5c0e28 |
|
| https://github.com/mildsunrise |
| http2: allow Host in HTTP/2 requests | https://github.com/nodejs/node/pull/34697/commits/f5c0e282ccf98e17f295c11850649ad19a6fff51 |
| f5c0e28 | https://github.com/nodejs/node/pull/34697/commits/f5c0e282ccf98e17f295c11850649ad19a6fff51 |
| nodejs#29858 | https://github.com/nodejs/node/issues/29858 |
| nodejs#34664 | https://github.com/nodejs/node/pull/34664 |
|
| https://github.com/clshortfuse |
|
| https://github.com/addaleax |
| http2: use and support non-empty DATA frame with END_STREAM flag | https://github.com/nodejs/node/pull/34697/commits/0e30c5bc261756dffaa874e4a9ef9858f16ba1d9 |
| 0e30c5b | https://github.com/nodejs/node/pull/34697/commits/0e30c5bc261756dffaa874e4a9ef9858f16ba1d9 |
| nodejs#31309 | https://github.com/nodejs/node/issues/31309 |
| nodejs#33891 | https://github.com/nodejs/node/issues/33891 |
| https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback | https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback |
| nodejs#33875 | https://github.com/nodejs/node/pull/33875 |
|
| https://github.com/lpinca |
|
| https://github.com/mmarchini |
| doc: fix broken links in commit-queue.md | https://github.com/nodejs/node/pull/34697/commits/92167e272be9dff7441f061ef8eac00bafa667e5 |
| 92167e2 | https://github.com/nodejs/node/pull/34697/commits/92167e272be9dff7441f061ef8eac00bafa667e5 |
| nodejs#34787 | https://github.com/nodejs/node/issues/34787 |
| nodejs#34789 | https://github.com/nodejs/node/pull/34789 |
|
| https://github.com/mmarchini |
| build: add CODEOWNERS linter action | https://github.com/nodejs/node/pull/34697/commits/8b818cf92515e77138e14dd2819856c3414c132e |
| 8b818cf | https://github.com/nodejs/node/pull/34697/commits/8b818cf92515e77138e14dd2819856c3414c132e |
| nodejs#34739 | https://github.com/nodejs/node/pull/34739 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34697#pullrequestreview-468729298 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34697/files |
| jasnell | https://github.com/jasnell |
| August 17, 2020 11:23 | https://github.com/nodejs/node/pull/34697#commits-pushed-1e6e5c3 |
|
| https://github.com/jasnell |
| quic: resolve minor TODO in QuicSocket | https://github.com/nodejs/node/pull/34697/commits/1e6e5c3ef33112f8cec97ab700411b93adf26baf |
| 1e6e5c3 | https://github.com/nodejs/node/pull/34697/commits/1e6e5c3ef33112f8cec97ab700411b93adf26baf |
| nodejs#34655 | https://github.com/nodejs/node/pull/34655 |
|
| https://github.com/jasnell |
| quic: resolve some minor TODOs | https://github.com/nodejs/node/pull/34697/commits/34165f03aa33d58c1a4fbbad0b2c3306a97b0657 |
| 34165f0 | https://github.com/nodejs/node/pull/34697/commits/34165f03aa33d58c1a4fbbad0b2c3306a97b0657 |
| nodejs#34655 | https://github.com/nodejs/node/pull/34655 |
|
| https://github.com/jasnell |
| quic: limit push check to http/3 | https://github.com/nodejs/node/pull/34697/commits/344c5e4e508ee6c7fad98bb5a34daa98ff43df68 |
| 344c5e4 | https://github.com/nodejs/node/pull/34697/commits/344c5e4e508ee6c7fad98bb5a34daa98ff43df68 |
| nodejs#34655 | https://github.com/nodejs/node/pull/34655 |
|
| https://github.com/jasnell |
| quic: fixup set_socket, fix skipped test | https://github.com/nodejs/node/pull/34697/commits/10d5047a4fbe2cbae4c0895dee4509341e8e77a0 |
| 10d5047 | https://github.com/nodejs/node/pull/34697/commits/10d5047a4fbe2cbae4c0895dee4509341e8e77a0 |
| nodejs#34669 | https://github.com/nodejs/node/pull/34669 |
|
| https://github.com/jasnell |
| quic: check setSocket natRebinding argument, extend test | https://github.com/nodejs/node/pull/34697/commits/442968c92a0f131c153dba40e607e081811e5eb3 |
| 442968c | https://github.com/nodejs/node/pull/34697/commits/442968c92a0f131c153dba40e607e081811e5eb3 |
| nodejs#34669 | https://github.com/nodejs/node/pull/34669 |
|
| https://github.com/jasnell |
| quic: add natRebinding argument to docs | https://github.com/nodejs/node/pull/34697/commits/c17eaa3f3fe1ed18aef661540b07e80404172431 |
| c17eaa3 | https://github.com/nodejs/node/pull/34697/commits/c17eaa3f3fe1ed18aef661540b07e80404172431 |
| nodejs#34669 | https://github.com/nodejs/node/pull/34669 |
|
| https://github.com/jasnell |
| quic: fixup session ticket app data todo comments | https://github.com/nodejs/node/pull/34697/commits/240592228bc794918443d46a8fcee85fe25a80d7 |
| 2405922 | https://github.com/nodejs/node/pull/34697/commits/240592228bc794918443d46a8fcee85fe25a80d7 |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/jasnell |
| quic: resolve InitializeSecureContext TODO comment | https://github.com/nodejs/node/pull/34697/commits/19e712b9b2982404bbb4b8e1f9e1700ee8048d6f |
| 19e712b | https://github.com/nodejs/node/pull/34697/commits/19e712b9b2982404bbb4b8e1f9e1700ee8048d6f |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/jasnell |
| quic: clarify TODO statements | https://github.com/nodejs/node/pull/34697/commits/94aa29134830b7ff1f99211ecd3ef0d12b32a793 |
| 94aa291 | https://github.com/nodejs/node/pull/34697/commits/94aa29134830b7ff1f99211ecd3ef0d12b32a793 |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/jasnell |
| quic: consolidate stats collecting in QuicSession | https://github.com/nodejs/node/pull/34697/commits/bfc35354c1290d7c1061c35fbd507aa129acc9d2 |
| bfc3535 | https://github.com/nodejs/node/pull/34697/commits/bfc35354c1290d7c1061c35fbd507aa129acc9d2 |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/jasnell |
| src: allow instances of net.BlockList to be created internally | https://github.com/nodejs/node/pull/34697/commits/1c14810edc68cc460d32da80fc52284c079d20ff |
| 1c14810 | https://github.com/nodejs/node/pull/34697/commits/1c14810edc68cc460d32da80fc52284c079d20ff |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/jasnell |
| quic: use net.BlockList for limiting access to a QuicSocket | https://github.com/nodejs/node/pull/34697/commits/c855c3e8ca5142e7b7f4a4e6adbf43e0ab18439b |
| c855c3e | https://github.com/nodejs/node/pull/34697/commits/c855c3e8ca5142e7b7f4a4e6adbf43e0ab18439b |
| nodejs#34741 | https://github.com/nodejs/node/pull/34741 |
|
| https://github.com/mmarchini |
| meta: fix codeowners docs path | https://github.com/nodejs/node/pull/34697/commits/5835367df4961bb2d71b0700b430b11f9ad32022 |
| 5835367 | https://github.com/nodejs/node/pull/34697/commits/5835367df4961bb2d71b0700b430b11f9ad32022 |
| nodejs#34811 | https://github.com/nodejs/node/pull/34811 |
|
| https://github.com/addaleax |
|
| https://github.com/jasnell |
| worker: do not crash when JSTransferable lists untransferable value | https://github.com/nodejs/node/pull/34697/commits/81df6684807072824ac51b4d14548bbf357c24b8 |
| 81df668 | https://github.com/nodejs/node/pull/34697/commits/81df6684807072824ac51b4d14548bbf357c24b8 |
| nodejs#34746 (comment) | https://github.com/nodejs/node/pull/34746#issuecomment-673675333 |
| nodejs#34766 | https://github.com/nodejs/node/pull/34766 |
|
| https://github.com/cjihrig |
|
| https://github.com/jasnell |
| tools: update ESLint to 7.7.0 | https://github.com/nodejs/node/pull/34697/commits/0eca660948d545d5cf83e95b1089f23dbc17a62d |
| 0eca660 | https://github.com/nodejs/node/pull/34697/commits/0eca660948d545d5cf83e95b1089f23dbc17a62d |
| nodejs#34783 | https://github.com/nodejs/node/pull/34783 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
| doc: edit filehandle.close() entry in fs.md | https://github.com/nodejs/node/pull/34697/commits/c62cf1d9c50aa4d152f28f61df86a6faafa45093 |
| c62cf1d | https://github.com/nodejs/node/pull/34697/commits/c62cf1d9c50aa4d152f28f61df86a6faafa45093 |
| nodejs#34782 | https://github.com/nodejs/node/pull/34782 |
|
| https://github.com/lundibundi |
|
| https://github.com/jasnell |
| lib: allow to validate enums with validateOneOf | https://github.com/nodejs/node/pull/34697/commits/6726246dbb83e3251f080fc4729154d492f7e340 |
| 6726246 | https://github.com/nodejs/node/pull/34697/commits/6726246dbb83e3251f080fc4729154d492f7e340 |
| nodejs#34070 | https://github.com/nodejs/node/pull/34070 |
|
| https://github.com/Trott |
| doc,lib: remove unused error code | https://github.com/nodejs/node/pull/34697/commits/15fdd9861bead2facc413f86b347a224c494fb47 |
| 15fdd98 | https://github.com/nodejs/node/pull/34697/commits/15fdd9861bead2facc413f86b347a224c494fb47 |
| nodejs#34792 | https://github.com/nodejs/node/pull/34792 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/34697#issuecomment-675252440 |
| @jasnell | https://github.com/jasnell |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 18, 2020
| https://github.com/nodejs/node/pull/34697#pullrequestreview-468994024 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34697/files |
| Trott | https://github.com/Trott |
| August 17, 2020 22:09 | https://github.com/nodejs/node/pull/34697#commits-pushed-aa5361c |
|
| https://github.com/Trott |
| test: convert assertion that always fails to assert.fail() | https://github.com/nodejs/node/pull/34697/commits/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| aa5361c | https://github.com/nodejs/node/pull/34697/commits/aa5361cfa90c42c29f832fd029d75af0a69c4180 |
| nodejs#34793 | https://github.com/nodejs/node/pull/34793 |
|
| https://github.com/Trott |
| doc: remove "is recommended from crypto legacy API text | https://github.com/nodejs/node/pull/34697/commits/60d572cf76eee29b7e766f57af1f3f6fb59843a0 |
| 60d572c | https://github.com/nodejs/node/pull/34697/commits/60d572cf76eee29b7e766f57af1f3f6fb59843a0 |
| nodejs#34697 | https://github.com/nodejs/node/pull/34697 |
|
| https://github.com/Trott |
| doc: deprecate (doc-only) crypto.Certificate() | https://github.com/nodejs/node/pull/34697/commits/ca5ff723d1390ae1e1434969e8c47a23ae151a21 |
| ca5ff72 | https://github.com/nodejs/node/pull/34697/commits/ca5ff723d1390ae1e1434969e8c47a23ae151a21 |
| nodejs#34697 | https://github.com/nodejs/node/pull/34697 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/34697#issuecomment-675254068 |
| aa5361c...ca5ff72 | https://github.com/nodejs/node/compare/aa5361cfa90c42c29f832fd029d75af0a69c4180...ca5ff723d1390ae1e1434969e8c47a23ae151a21 |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| ca5ff72 | https://github.com/nodejs/node/commit/ca5ff723d1390ae1e1434969e8c47a23ae151a21 |
| Aug 18, 2020 | https://github.com/nodejs/node/pull/34697#event-3664582922 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 18, 2020 05:12 | https://github.com/nodejs/node/pull/34697#event-3664583103 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-a01011b |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: remove "is recommended from crypto legacy API text | https://github.com/nodejs/node/commit/a01011bd6e5113e63eb975757751df3bbf715720 |
| a01011b | https://github.com/nodejs/node/commit/a01011bd6e5113e63eb975757751df3bbf715720 |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-3b48d7a |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: deprecate (doc-only) crypto.Certificate() | https://github.com/nodejs/node/commit/3b48d7acd5044d6f3ceda9844a662df5e6347a93 |
| 3b48d7a | https://github.com/nodejs/node/commit/3b48d7acd5044d6f3ceda9844a662df5e6347a93 |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34697#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-3bfe199 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: remove "is recommended from crypto legacy API text | https://github.com/nodejs/node/commit/3bfe199c28c7d12762d4c09b4a32cc0b0f8fe098 |
| 3bfe199 | https://github.com/nodejs/node/commit/3bfe199c28c7d12762d4c09b4a32cc0b0f8fe098 |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-47f2f45 |
|
| https://github.com/Trott |
|
| https://github.com/BethGriggs |
| doc: deprecate (doc-only) crypto.Certificate() | https://github.com/nodejs/node/commit/47f2f45dd84e8dfa60131b331ec8fefbaec629f4 |
| 47f2f45 | https://github.com/nodejs/node/commit/47f2f45dd84e8dfa60131b331ec8fefbaec629f4 |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-d0e7bf1 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: remove "is recommended from crypto legacy API text | https://github.com/nodejs/node/commit/d0e7bf11857404c297d1c16d7fff0918bd035b5f |
| d0e7bf1 | https://github.com/nodejs/node/commit/d0e7bf11857404c297d1c16d7fff0918bd035b5f |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34697#ref-commit-7a983f5 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: remove "is recommended from crypto legacy API text | https://github.com/nodejs/node/commit/7a983f5f1dff5d2104cfe8c4ef9d3aa7aba714b0 |
| 7a983f5 | https://github.com/nodejs/node/commit/7a983f5f1dff5d2104cfe8c4ef9d3aa7aba714b0 |
| #34697 | https://github.com/nodejs/node/pull/34697 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34697#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34697 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34697/files/9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
|
| https://github.com/tniessen |
|
tniessen
| https://github.com/tniessen |
|
| https://github.com/nodejs/node/pull/34697/files/9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
|
| https://github.com/ryzokuken |
|
ryzokuken
| https://github.com/ryzokuken |
|
| https://github.com/nodejs/node/pull/34697/files/9a6ed8cd1c61cf54d6fb5e11e91cd12b78a9f481 |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/34697 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/tniessen |
|
| https://github.com/ryzokuken |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/mildsunrise |
|
| https://github.com/clshortfuse |
|
| https://github.com/lpinca |
|
| https://github.com/mmarchini |
|
| https://github.com/addaleax |
|
| https://github.com/cjihrig |
|
| https://github.com/lundibundi |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |