| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cfedf769-9acd-5b9a-4880-83968322cdab |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 874A:9E28B:949A60:C77670:6A4D7017 |
| html-safe-nonce | ae874c75135d878552cef612cd88f7fc09effd1469b7f2406c8e4dda3671447b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzRBOjlFMjhCOjk0OUE2MDpDNzc2NzA6NkE0RDcwMTciLCJ2aXNpdG9yX2lkIjoiNDk1OTIzOTM0MzY0ODM3MDcxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 963e55478fea658951033a03a967cee483a42c5c2e03da2b5beb969ff5f219c9 |
| hovercard-subject-tag | pull_request:464998052 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34675/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/86e75fe1f53a4d26ba0c5bff34606cbd099ec7bce04e44b6015d46ff23a7910f/nodejs/node/pull/34675 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/86e75fe1f53a4d26ba0c5bff34606cbd099ec7bce04e44b6015d46ff23a7910f/nodejs/node/pull/34675 |
| og:image:alt | Fixes: #33463
Adds a note to the documentation of the readline module that you may miss lines if you have async operations between interface creation and async iteration (since readline is not a st... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mikhalev-im |
| hostname | github.com |
| expected-hostname | github.com |
| None | c78260c7b3f4ac4b0356c8208537f05406a3a2d46a9ec3f735b372dcc519c39e |
| turbo-cache-control | no-cache |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 399fff412f48461d435721c009efc17ea44be72f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34675#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34675 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34675 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34675 |
| Reload | https://github.com/nodejs/node/pull/34675 |
| Reload | https://github.com/nodejs/node/pull/34675 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
36k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
118k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.4k
| https://github.com/nodejs/node/issues |
|
Pull requests
962
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
0
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security and quality
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| mikhalev-im | https://github.com/mikhalev-im |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mikhalev-im:docs-readline-async-iterator-missing-lines | https://github.com/mikhalev-im/node/tree/docs-readline-async-iterator-missing-lines |
| Conversation | https://github.com/nodejs/node/pull/34675 |
| Commits1 (1) | https://github.com/nodejs/node/pull/34675/commits |
| Checks | https://github.com/nodejs/node/pull/34675/checks |
| Files changed | https://github.com/nodejs/node/pull/34675/files |
| doc: add a note about possible missing lines to readline.asyncIterator | https://github.com/nodejs/node/pull/34675#top |
| mikhalev-im | https://github.com/mikhalev-im |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mikhalev-im:docs-readline-async-iterator-missing-lines | https://github.com/mikhalev-im/node/tree/docs-readline-async-iterator-missing-lines |
|
| https://github.com/mikhalev-im |
| mikhalev-im | https://github.com/mikhalev-im |
| Aug 8, 2020 | https://github.com/nodejs/node/pull/34675#issue-675478307 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| #33463 | https://github.com/nodejs/node/issues/33463 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
|
| https://github.com/mikhalev-im |
| doc: add a note about possible missing lines to readline.asyncIterator | https://github.com/nodejs/node/pull/34675/commits/490ceae8860208ef218c78d002e03e34c98af3bb |
| 490ceae | https://github.com/nodejs/node/pull/34675/commits/490ceae8860208ef218c78d002e03e34c98af3bb |
| nodejs#33463 | https://github.com/nodejs/node/issues/33463 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
| Aug 8, 2020 | https://github.com/nodejs/node/pull/34675#event-3635438324 |
| https://github.com/mikhalev-im |
| mikhalev-im | https://github.com/mikhalev-im |
| Aug 8, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-670850660 |
| #28565 | https://github.com/nodejs/node/issues/28565 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 10, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-671644997 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| BridgeAR | https://github.com/BridgeAR |
| devsnek | https://github.com/devsnek |
| August 23, 2020 11:53 | https://github.com/nodejs/node/pull/34675#event-3682761442 |
| https://github.com/BridgeAR |
| BridgeAR | https://github.com/BridgeAR |
|
Aug 23, 2020
| https://github.com/nodejs/node/pull/34675#pullrequestreview-473012098 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Aug 24, 2020
| https://github.com/nodejs/node/pull/34675#pullrequestreview-473060098 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 24, 2020
| https://github.com/nodejs/node/pull/34675#pullrequestreview-473597514 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Aug 24, 2020
| https://github.com/nodejs/node/pull/34675#pullrequestreview-473669325 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34675#event-3695142211 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
request-ci
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arequest-ci |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34675#event-3695155053 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 26, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-680922461 |
| https://ci.nodejs.org/job/node-test-pull-request/32936/ | https://ci.nodejs.org/job/node-test-pull-request/32936/ |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Aug 27, 2020
| https://github.com/nodejs/node/pull/34675#ref-issue-686853144 |
|
CI Reliability 2020-08-27
nodejs/reliability#56
| https://github.com/nodejs/reliability/issues/56 |
| https://github.com/mikhalev-im |
| mikhalev-im | https://github.com/mikhalev-im |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-683245440 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-683351607 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 29, 2020
| https://github.com/nodejs/node/pull/34675#pullrequestreview-478159971 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
| Trott | https://github.com/Trott |
|
Aug 29, 2020
| https://github.com/nodejs/node/pull/34675#ref-commit-33eda80 |
|
| https://github.com/mikhalev-im |
|
| https://github.com/Trott |
| doc: add a note about possible missing lines to readline.asyncIterator | https://github.com/nodejs/node/commit/33eda8046e59b672dbdc57183446bfa922f96ce5 |
|
| https://github.com/nodejs/node/commit/33eda8046e59b672dbdc57183446bfa922f96ce5#comments |
| 33eda80 | https://github.com/nodejs/node/commit/33eda8046e59b672dbdc57183446bfa922f96ce5 |
| #33463 | https://github.com/nodejs/node/issues/33463 |
| #34675 | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34675#issuecomment-683351802 |
| 33eda80 | https://github.com/nodejs/node/commit/33eda8046e59b672dbdc57183446bfa922f96ce5 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 29, 2020 | https://github.com/nodejs/node/pull/34675#event-3706877922 |
| richardlau | https://github.com/richardlau |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/34675#ref-commit-2407a7a |
|
| https://github.com/mikhalev-im |
|
| https://github.com/richardlau |
| doc: add a note about possible missing lines to readline.asyncIterator | https://github.com/nodejs/node/commit/2407a7a6714cf157c9d3d3588c445863d5f89bb6 |
| 2407a7a | https://github.com/nodejs/node/commit/2407a7a6714cf157c9d3d3588c445863d5f89bb6 |
| #33463 | https://github.com/nodejs/node/issues/33463 |
| #34675 | https://github.com/nodejs/node/pull/34675 |
| https://github.com/richardlau |
| richardlau | https://github.com/richardlau |
|
Sep 2, 2020
| https://github.com/nodejs/node/pull/34675#ref-pullrequest-691140213 |
|
v14.10.0 proposal
#35023
| https://github.com/nodejs/node/pull/35023 |
| richardlau | https://github.com/richardlau |
|
Apr 3, 2022
| https://github.com/nodejs/node/pull/34675#ref-commit-333eda8 |
|
| https://github.com/mikhalev-im |
|
| https://github.com/richardlau |
| doc: add a note about possible missing lines to readline.asyncIterator | https://github.com/nodejs/node/commit/333eda8d03bef36cf951bf54b33c7bbf2c0ef75c |
| 333eda8 | https://github.com/nodejs/node/commit/333eda8d03bef36cf951bf54b33c7bbf2c0ef75c |
| #33463 | https://github.com/nodejs/node/issues/33463 |
| #34675 | https://github.com/nodejs/node/pull/34675 |
|
v12.22.12 proposal
#42531
| https://github.com/nodejs/node/pull/42531 |
|
[v12.x] doc: ported missing readline statement from v16.x
#42592
| https://github.com/nodejs/node/pull/42592 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34675 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
|
| https://github.com/BridgeAR |
|
BridgeAR
| https://github.com/BridgeAR |
|
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/34675/files/490ceae8860208ef218c78d002e03e34c98af3bb |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
readline
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Areadline |
|
awaiting between creating a readline interface, and using async iterator will cause iterator to sometimes skip.
| https://github.com/nodejs/node/issues/33463 |
| Please reload this page | https://github.com/nodejs/node/pull/34675 |
|
| https://github.com/mikhalev-im |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/antsmartian |
|
| https://github.com/devsnek |
|
| https://github.com/BridgeAR |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |