René's URL Explorer Experiment


Title: tls: use the most recently added matching SecureContext in default SNICallback. by mkrawczuk · Pull Request #34638 · nodejs/node · GitHub

Open Graph Title: tls: use the most recently added matching SecureContext in default SNICallback. by mkrawczuk · Pull Request #34638 · nodejs/node

X Title: tls: use the most recently added matching SecureContext in default SNICallback. by mkrawczuk · Pull Request #34638 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #34110 make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

X Description: Fixes: #34110 make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34638

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:68dcba34-4c78-51f7-1216-3eaaaf54ec64
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA56A:1B72D2:53C9E:72551:6A525FA0
html-safe-noncea4ed4fb856189dffa93dfb5e85a05edfed0001b9ed200a166b8582261bfe8ba6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTZBOjFCNzJEMjo1M0M5RTo3MjU1MTo2QTUyNUZBMCIsInZpc2l0b3JfaWQiOiI2NzM1Mzg3NzQ1OTcyNjMyNjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac94f440722b86ba0aaeec7f6e9e892067dce1b809cb4b68013431c4a6e1958f12
hovercard-subject-tagpull_request:463680266
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34638/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/dee7972b0bd8e48002ec48a9b216bc5ae3921f2c92afb9baaeb7a79ce2cd9167/nodejs/node/pull/34638
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/dee7972b0bd8e48002ec48a9b216bc5ae3921f2c92afb9baaeb7a79ce2cd9167/nodejs/node/pull/34638
og:image:altFixes: #34110 make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included documentation is changed or added commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemkrawczuk
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34638#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34638
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34638
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34638
Reloadhttps://github.com/nodejs/node/pull/34638
Reloadhttps://github.com/nodejs/node/pull/34638
Please reload this pagehttps://github.com/nodejs/node/pull/34638
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34638
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 984 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
mkrawczukhttps://github.com/mkrawczuk
nodejs:masterhttps://github.com/nodejs/node/tree/master
mkrawczuk:34110https://github.com/mkrawczuk/node/tree/34110
Conversationhttps://github.com/nodejs/node/pull/34638
Commits365 (365)https://github.com/nodejs/node/pull/34638/commits
Checkshttps://github.com/nodejs/node/pull/34638/checks
Files changedhttps://github.com/nodejs/node/pull/34638/files
tls: use the most recently added matching SecureContext in default SNICallback.https://github.com/nodejs/node/pull/34638#top
mkrawczukhttps://github.com/mkrawczuk
nodejs:masterhttps://github.com/nodejs/node/tree/master
mkrawczuk:34110https://github.com/mkrawczuk/node/tree/34110
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Aug 5, 2020https://github.com/nodejs/node/pull/34638#issue-673892091
Please reload this pagehttps://github.com/nodejs/node/pull/34638
#34110https://github.com/nodejs/node/issues/34110
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Aug 5, 2020https://github.com/nodejs/node/pull/34638#event-3626680519
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Aug 5, 2020 https://github.com/nodejs/node/pull/34638#ref-pullrequest-662059299
tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order #34444 https://github.com/nodejs/node/pull/34444
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 5, 2020 https://github.com/nodejs/node/pull/34638#pullrequestreview-462083668
View reviewed changes https://github.com/nodejs/node/pull/34638/files/36fb6f154792c279fd5b1083d7bc19fca2f38dba
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 5, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669591418
https://ci.nodejs.org/job/node-test-pull-request/32637/https://ci.nodejs.org/job/node-test-pull-request/32637/
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669593564
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reversehttps://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reverse
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669597483
Please reload this pagehttps://github.com/nodejs/node/pull/34638
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669599757
Please reload this pagehttps://github.com/nodejs/node/pull/34638
#34444https://github.com/nodejs/node/pull/34444
https://github.com/masx200/node/tree/patch-2https://github.com/masx200/node/tree/patch-2
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/masx200
masx200https://github.com/masx200
Aug 6, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669643129
#34110https://github.com/nodejs/node/issues/34110
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Aug 6, 2020https://github.com/nodejs/node/pull/34638#issuecomment-669737386
@masx200https://github.com/masx200
https://github.com/nodejs/node/blob/master/CONTRIBUTING.mdhttps://github.com/nodejs/node/blob/master/CONTRIBUTING.md
https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.mdhttps://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020 https://github.com/nodejs/node/pull/34638#pullrequestreview-462317140
View reviewed changes https://github.com/nodejs/node/pull/34638/files/47eecd27cc7f612700d7f1a623fbf426d702187d
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 10, 2020https://github.com/nodejs/node/pull/34638#issuecomment-671421765
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Aug 10, 2020https://github.com/nodejs/node/pull/34638#issuecomment-671574462
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Sep 20, 2020https://github.com/nodejs/node/pull/34638#issuecomment-695761668
@Trotthttps://github.com/Trott
@addaleaxhttps://github.com/addaleax
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/Trott
Trotthttps://github.com/Trott
Sep 22, 2020https://github.com/nodejs/node/pull/34638#issuecomment-696505798
Please reload this pagehttps://github.com/nodejs/node/pull/34638
watildehttps://github.com/watilde
October 16, 2020 11:43https://github.com/nodejs/node/pull/34638#commits-pushed-c143266
https://github.com/watilde
test: add a few uncovered url tests from wpthttps://github.com/nodejs/node/pull/34638/commits/c143266b551b73867ed9d509a6c4944d0c389676
c143266https://github.com/nodejs/node/pull/34638/commits/c143266b551b73867ed9d509a6c4944d0c389676
web-platform-tests/wpt#25987https://github.com/web-platform-tests/wpt/pull/25987
nodejs#35636https://github.com/nodejs/node/pull/35636
https://github.com/targos
build: do not install jq in workflowshttps://github.com/nodejs/node/pull/34638/commits/8a93b371a324ddda435589297578209938e255ee
8a93b37https://github.com/nodejs/node/pull/34638/commits/8a93b371a324ddda435589297578209938e255ee
nodejs#35638https://github.com/nodejs/node/pull/35638
https://github.com/targos
build: use GITHUB_ENV file to set env variableshttps://github.com/nodejs/node/pull/34638/commits/cfbbeea4a1de41f026b6459d7a680a367addbbb0
cfbbeeahttps://github.com/nodejs/node/pull/34638/commits/cfbbeea4a1de41f026b6459d7a680a367addbbb0
nodejs#35638https://github.com/nodejs/node/pull/35638
https://github.com/lxdicted
https://github.com/aduh95
net: add support for resolving DNS CAA recordshttps://github.com/nodejs/node/pull/34638/commits/6f34498148612e8aa3537a9c865d2940cb9e8c7a
6f34498https://github.com/nodejs/node/pull/34638/commits/6f34498148612e8aa3537a9c865d2940cb9e8c7a
nodejs#35466https://github.com/nodejs/node/pull/35466
nodejs#19239https://github.com/nodejs/node/issues/19239
nodejs#14713https://github.com/nodejs/node/issues/14713
https://github.com/Trott
doc: fix stability indicator in webcrypto dochttps://github.com/nodejs/node/pull/34638/commits/2c2c87e291d36df4c8c3357cc6b896a711c219ef
https://github.com/nodejs/node/commit/2c2c87e291d36df4c8c3357cc6b896a711c219ef#comments
2c2c87ehttps://github.com/nodejs/node/pull/34638/commits/2c2c87e291d36df4c8c3357cc6b896a711c219ef
nodejs#35672https://github.com/nodejs/node/pull/35672
https://github.com/Trott
fs: remove unused assignmenthttps://github.com/nodejs/node/pull/34638/commits/7f25fe8b67eeb05a44b107378a2f3e59e4d8f2f9
7f25fe8https://github.com/nodejs/node/pull/34638/commits/7f25fe8b67eeb05a44b107378a2f3e59e4d8f2f9
nodejs#35642https://github.com/nodejs/node/pull/35642
https://github.com/shaw91
https://github.com/aduh95
doc: fix EventEmitter exampleshttps://github.com/nodejs/node/pull/34638/commits/9e5a27a9d310ba64289a326777d9a86e4b9a3928
9e5a27ahttps://github.com/nodejs/node/pull/34638/commits/9e5a27a9d310ba64289a326777d9a86e4b9a3928
nodejs#33513https://github.com/nodejs/node/pull/33513
https://github.com/yashLadha
https://github.com/aduh95
src: error reporting on CPUUsagehttps://github.com/nodejs/node/pull/34638/commits/eeb6b473fd9f8399583fafe1807781dd1e760c5e
eeb6b47https://github.com/nodejs/node/pull/34638/commits/eeb6b473fd9f8399583fafe1807781dd1e760c5e
nodejs#34762https://github.com/nodejs/node/pull/34762
https://github.com/tniessen
https://github.com/aduh95
test: add common.mustSucceedhttps://github.com/nodejs/node/pull/34638/commits/30fb4a015db2226aabaed457ec8930c9f9b8fd78
30fb4a0https://github.com/nodejs/node/pull/34638/commits/30fb4a015db2226aabaed457ec8930c9f9b8fd78
nodejs#35086https://github.com/nodejs/node/pull/35086
https://github.com/aduh95
module: add setter for module.parenthttps://github.com/nodejs/node/pull/34638/commits/aaf225a2a0175178f3b55add5f20f16bdb8ef01c
aaf225ahttps://github.com/nodejs/node/pull/34638/commits/aaf225a2a0175178f3b55add5f20f16bdb8ef01c
nodejs#35522https://github.com/nodejs/node/pull/35522
https://github.com/himself65
https://github.com/nodejs-github-bot
test: refactor test-https-host-headershttps://github.com/nodejs/node/pull/34638/commits/a3731309ccd0db7051803c4bb0639019cf867559
a373130https://github.com/nodejs/node/pull/34638/commits/a3731309ccd0db7051803c4bb0639019cf867559
nodejs#32805https://github.com/nodejs/node/pull/32805
https://github.com/targos
https://github.com/Trott
tools: update gyp-next to v0.6.2https://github.com/nodejs/node/pull/34638/commits/35a69461937880ab8bdd38532a6460b7dce6da19
35a6946https://github.com/nodejs/node/pull/34638/commits/35a69461937880ab8bdd38532a6460b7dce6da19
nodejs#35690https://github.com/nodejs/node/pull/35690
https://github.com/Trott
build: add GitHub Action for code coveragehttps://github.com/nodejs/node/pull/34638/commits/bb2945ed6b8e7cc94d485de6cb8377885ee352c4
bb2945ehttps://github.com/nodejs/node/pull/34638/commits/bb2945ed6b8e7cc94d485de6cb8377885ee352c4
nodejs#35653https://github.com/nodejs/node/pull/35653
https://github.com/adinhtdsibm
https://github.com/gireeshpunathil
test: add test for listen callback runtime bindinghttps://github.com/nodejs/node/pull/34638/commits/9ce5a031480a51abdb3d65fe67fba52df6a3851a
9ce5a03https://github.com/nodejs/node/pull/34638/commits/9ce5a031480a51abdb3d65fe67fba52df6a3851a
nodejs#35657https://github.com/nodejs/node/pull/35657
https://github.com/SimenB
https://github.com/Trott
doc: importModuleDynamically gets Script, not Modulehttps://github.com/nodejs/node/pull/34638/commits/ee85eb9f8a311e955116ecfd9c6c336351336116
ee85eb9https://github.com/nodejs/node/pull/34638/commits/ee85eb9f8a311e955116ecfd9c6c336351336116
nodejs#35593https://github.com/nodejs/node/pull/35593
https://github.com/Trott
doc: correct order of metadata for deprecationhttps://github.com/nodejs/node/pull/34638/commits/89defff3b9e29de4dfab055ca216b2d12aeedde3
89defffhttps://github.com/nodejs/node/pull/34638/commits/89defff3b9e29de4dfab055ca216b2d12aeedde3
nodejs#35668https://github.com/nodejs/node/pull/35668
danbevhttps://github.com/danbev
November 9, 2020 11:02https://github.com/nodejs/node/pull/34638#commits-pushed-1bba8c8
https://github.com/danbev
deps: cherry-pickhttps://github.com/nodejs/node/pull/34638/commits/1bba8c81118425e2bc5457e408f398870255d26a
9a49b22https://github.com/mkrawczuk/node/commit/9a49b227cf178a48be548ef11d08d9c05768c565
from V8 upstreamhttps://github.com/nodejs/node/pull/34638/commits/1bba8c81118425e2bc5457e408f398870255d26a
1bba8c8https://github.com/nodejs/node/pull/34638/commits/1bba8c81118425e2bc5457e408f398870255d26a
https://chromium-review.googlesource.com/c/v8/v8/+/2506712https://chromium-review.googlesource.com/c/v8/v8/+/2506712
nodejs#35939https://github.com/nodejs/node/pull/35939
nodejs#35669https://github.com/nodejs/node/issues/35669
v8/v8@9a49b22https://github.com/v8/v8/commit/9a49b2298f65f6b18c5245f3681aca04e5fe4e46
https://github.com/Trott
dns: fix trace_events name for resolveCaa()https://github.com/nodejs/node/pull/34638/commits/642174a31f7c2d3a8352002095d35a2b34c1126c
642174ahttps://github.com/nodejs/node/pull/34638/commits/642174a31f7c2d3a8352002095d35a2b34c1126c
6f34498https://github.com/mkrawczuk/node/commit/6f34498148612e8aa3537a9c865d2940cb9e8c7a
nodejs#35979https://github.com/nodejs/node/pull/35979
https://github.com/aduh95
https://github.com/Trott
tools,lib: tighten prefer-primordials rules for Error staticshttps://github.com/nodejs/node/pull/34638/commits/8f954388ed80fd25fc74e0e10bc02e1691801a86
8f95438https://github.com/nodejs/node/pull/34638/commits/8f954388ed80fd25fc74e0e10bc02e1691801a86
nodejs#36017https://github.com/nodejs/node/pull/36017
https://github.com/coderaiser
https://github.com/aduh95
doc,fs: document value of stats.isDirectory on symbolic linkshttps://github.com/nodejs/node/pull/34638/commits/6c3326c42d3fef6b7f3141c0b5844fa437a2ed86
6c3326chttps://github.com/nodejs/node/pull/34638/commits/6c3326c42d3fef6b7f3141c0b5844fa437a2ed86
nodejs#27413https://github.com/nodejs/node/pull/27413
https://github.com/haqer1
https://github.com/aduh95
doc: advise users to import the full set of trusted release keyshttps://github.com/nodejs/node/pull/34638/commits/888900b01623997c5ac2d5f3e8fb3eef5baed16a
888900bhttps://github.com/nodejs/node/pull/34638/commits/888900b01623997c5ac2d5f3e8fb3eef5baed16a
nodejs#32655https://github.com/nodejs/node/pull/32655
nodejs#32559https://github.com/nodejs/node/issues/32559
https://github.com/kobelb
https://github.com/aduh95
doc,net: document socket.timeouthttps://github.com/nodejs/node/pull/34638/commits/5bbc4f48927e5b02c90a41a4e79a28522422cea8
5bbc4f4https://github.com/nodejs/node/pull/34638/commits/5bbc4f48927e5b02c90a41a4e79a28522422cea8
nodejs#34543https://github.com/nodejs/node/pull/34543
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 9, 2020https://github.com/nodejs/node/pull/34638#issuecomment-724171093
@mkrawczukhttps://github.com/mkrawczuk
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/aduh95
aduh95https://github.com/aduh95
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Nov 9, 2020https://github.com/nodejs/node/pull/34638#event-3975036012
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 9, 2020https://github.com/nodejs/node/pull/34638#issuecomment-724171351
Please reload this pagehttps://github.com/nodejs/node/pull/34638
lundibundihttps://github.com/lundibundi
November 9, 2020 19:00https://github.com/nodejs/node/pull/34638#commits-pushed-da3626a
https://github.com/lundibundi
https://github.com/aduh95
doc: add note regarding file structure in src/README.mdhttps://github.com/nodejs/node/pull/34638/commits/da3626adccdbe1ff8d7abf496e2906a91e308de4
da3626ahttps://github.com/nodejs/node/pull/34638/commits/da3626adccdbe1ff8d7abf496e2906a91e308de4
nodejs#34944 (comment)https://github.com/nodejs/node/pull/34944#discussion_r480321239
nodejs#35000https://github.com/nodejs/node/pull/35000
https://github.com/masx200
https://github.com/aduh95
http2: add has method to proxySocketHandlerhttps://github.com/nodejs/node/pull/34638/commits/0d2e198914bf9a5fc666a2f60a71b222cfb15273
0d2e198https://github.com/nodejs/node/pull/34638/commits/0d2e198914bf9a5fc666a2f60a71b222cfb15273
nodejs#35197https://github.com/nodejs/node/pull/35197
https://github.com/dev-script
https://github.com/aduh95
doc,stream: write(chunk, encoding, cb) encoding can be nullhttps://github.com/nodejs/node/pull/34638/commits/caa5a0516eada089e7df3e00960b4043b98c1ab4
caa5a05https://github.com/nodejs/node/pull/34638/commits/caa5a0516eada089e7df3e00960b4043b98c1ab4
nodejs#33715https://github.com/nodejs/node/issues/33715
nodejs#35372https://github.com/nodejs/node/pull/35372
https://github.com/bmeck
https://github.com/aduh95
test: improve error message for policy failureshttps://github.com/nodejs/node/pull/34638/commits/5b95f0128467d096e6e7ac9948939ae3f061604d
5b95f01https://github.com/nodejs/node/pull/34638/commits/5b95f0128467d096e6e7ac9948939ae3f061604d
nodejs#35633https://github.com/nodejs/node/pull/35633
nodejs#35600https://github.com/nodejs/node/issues/35600
https://github.com/aduh95
bootstrap: refactor to use more primordialshttps://github.com/nodejs/node/pull/34638/commits/b589128f6f4c3c6f636bfb0146957847ef0a8d53
b589128https://github.com/nodejs/node/pull/34638/commits/b589128f6f4c3c6f636bfb0146957847ef0a8d53
nodejs#35999https://github.com/nodejs/node/pull/35999
https://github.com/aduh95
test: use global.EventTarget instead of internalshttps://github.com/nodejs/node/pull/34638/commits/36fbbe0b86131fa2dcca558872b02335586e0089
36fbbe0https://github.com/nodejs/node/pull/34638/commits/36fbbe0b86131fa2dcca558872b02335586e0089
nodejs#35496https://github.com/nodejs/node/pull/35496
nodejs#36002https://github.com/nodejs/node/pull/36002
https://github.com/baruchiro
https://github.com/nodejs-github-bot
fs: replace finally with PromisePrototypeFinallyhttps://github.com/nodejs/node/pull/34638/commits/a8b9ede3c10eadb775c5e0f5eab7c31cea7e8b53
a8b9edehttps://github.com/nodejs/node/pull/34638/commits/a8b9ede3c10eadb775c5e0f5eab7c31cea7e8b53
nodejs#35993 (comment)https://github.com/nodejs/node/pull/35993#discussion_r518703665
nodejs#35995https://github.com/nodejs/node/pull/35995
https://github.com/aduh95
https://github.com/nodejs-github-bot
module: refactor to use more primordialshttps://github.com/nodejs/node/pull/34638/commits/2c77fe192e0f07b8ac8aed448c70a7767714614a
2c77fe1https://github.com/nodejs/node/pull/34638/commits/2c77fe192e0f07b8ac8aed448c70a7767714614a
nodejs#36024https://github.com/nodejs/node/pull/36024
https://github.com/aduh95
https://github.com/nodejs-github-bot
tools,lib: recommend using safe primordialshttps://github.com/nodejs/node/pull/34638/commits/831f4c755d2270e7b44c075176ab4a05698d21d9
831f4c7https://github.com/nodejs/node/pull/34638/commits/831f4c755d2270e7b44c075176ab4a05698d21d9
nodejs#36026https://github.com/nodejs/node/pull/36026
https://github.com/RaisinTen
https://github.com/Trott
build: fix zlib inlining for IA-32https://github.com/nodejs/node/pull/34638/commits/ab587ca46b49190564a4d808115af3a9b5ba71b6
ab587cahttps://github.com/nodejs/node/pull/34638/commits/ab587ca46b49190564a4d808115af3a9b5ba71b6
nodejs#35679https://github.com/nodejs/node/pull/35679
nodejs#35629https://github.com/nodejs/node/issues/35629
https://github.com/aduh95
https://github.com/Trott
crypto: refactor to use more primordialshttps://github.com/nodejs/node/pull/34638/commits/da53a3caa306dfd31dc26fc837739571052e5c20
da53a3chttps://github.com/nodejs/node/pull/34638/commits/da53a3caa306dfd31dc26fc837739571052e5c20
nodejs#36012https://github.com/nodejs/node/pull/36012
https://github.com/ronag
https://github.com/aduh95
stream: writableNeedDrainhttps://github.com/nodejs/node/pull/34638/commits/dd0f8f18c253e4cbd4f8e0121dd68b033168524e
dd0f8f1https://github.com/nodejs/node/pull/34638/commits/dd0f8f18c253e4cbd4f8e0121dd68b033168524e
nodejs#35341https://github.com/nodejs/node/issues/35341
nodejs#35348https://github.com/nodejs/node/pull/35348
https://github.com/richardlau
https://github.com/nodejs-github-bot
build, tools: look for local installation of NASMhttps://github.com/nodejs/node/pull/34638/commits/322abb4e051f71448ecc52e7351e84022a58aab7
322abb4https://github.com/nodejs/node/pull/34638/commits/322abb4e051f71448ecc52e7351e84022a58aab7
nodejs#36014https://github.com/nodejs/node/pull/36014
https://github.com/mkrawczuk
tls: use the most recently added matching SecureContext in default SN…https://github.com/nodejs/node/pull/34638/commits/6ce5bd8dca194d23b3a3827b0cfb18582c7fd48e
6ce5bd8https://github.com/nodejs/node/pull/34638/commits/6ce5bd8dca194d23b3a3827b0cfb18582c7fd48e
https://github.com//issues/34110https://github.com//issues/34110
https://github.com/mkrawczuk
fixup! do not reverse in place, add a test for it.https://github.com/nodejs/node/pull/34638/commits/ec8d2bd132febf25ed4658e999fc29f5a1ae57b4
ec8d2bdhttps://github.com/nodejs/node/pull/34638/commits/ec8d2bd132febf25ed4658e999fc29f5a1ae57b4
https://github.com/mkrawczuk
Merge branch '34110' of github.com:mkrawczuk/node into 34110https://github.com/nodejs/node/pull/34638/commits/60ab351a502760ea109b00ce7028dbd56afbb287
60ab351https://github.com/nodejs/node/pull/34638/commits/60ab351a502760ea109b00ce7028dbd56afbb287
https://github.com/mkrawczuk
Revert "Merge branch '34110' of github.com:mkrawczuk/node into 34110"https://github.com/nodejs/node/pull/34638/commits/acccc68220fdeb9d58802513bdb7d283ac3e3dcd
acccc68https://github.com/nodejs/node/pull/34638/commits/acccc68220fdeb9d58802513bdb7d283ac3e3dcd
60ab351https://github.com/mkrawczuk/node/commit/60ab351a502760ea109b00ce7028dbd56afbb287
47eecd2https://github.com/mkrawczuk/node/commit/47eecd27cc7f612700d7f1a623fbf426d702187d
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Nov 10, 2020 https://github.com/nodejs/node/pull/34638#ref-pullrequest-740139373
tls: use the most recently added matching SecureContext in default SN… #36072 https://github.com/nodejs/node/pull/36072
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Nov 10, 2020https://github.com/nodejs/node/pull/34638#issuecomment-724881528
@aduh95https://github.com/aduh95
#36072https://github.com/nodejs/node/pull/36072
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Nov 10, 2020https://github.com/nodejs/node/pull/34638#event-3980338053
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34638
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/34638/files/47eecd27cc7f612700d7f1a623fbf426d702187d
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34638/files/36fb6f154792c279fd5b1083d7bc19fca2f38dba
review wanted https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22review%20wanted%22
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
tls: server.addContext does not update the context if there was one registered for a given servername wildcard. https://github.com/nodejs/node/issues/34110
Please reload this pagehttps://github.com/nodejs/node/pull/34638
https://github.com/mkrawczuk
https://github.com/nodejs-github-bot
https://github.com/masx200
https://github.com/Trott
https://github.com/aduh95
https://github.com/boorad
https://github.com/panva
https://github.com/bnoordhuis
https://github.com/amark
https://github.com/addaleax
https://github.com/watilde
https://github.com/targos
https://github.com/lxdicted
https://github.com/shaw91
https://github.com/yashLadha
https://github.com/tniessen
https://github.com/himself65
https://github.com/adinhtdsibm
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.