| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:5ed81953-31ff-7e41-bb9a-adb5f13cc533 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A37A:6C43E:4F7953:6DE6E9:696A756D |
| html-safe-nonce | c8c60b5c9f4999946616687e673c4b0bdd6df377bd8b7a616ca641e122086e06 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzdBOjZDNDNFOjRGNzk1Mzo2REU2RTk6Njk2QTc1NkQiLCJ2aXNpdG9yX2lkIjoiNjA3ODQzNjg2ODExMTM2NTQ4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5127cd93dbd4bc9bd0c6fe56e1c016b42251d9217adc25035147a39d7ee402e9 |
| hovercard-subject-tag | pull_request:463060281 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34626/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9c42a726ac2ee484eeea78551793d4b10f97bb34440c521037faab98a6eae342/nodejs/node/pull/34626 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9c42a726ac2ee484eeea78551793d4b10f97bb34440c521037faab98a6eae342/nodejs/node/pull/34626 |
| og:image:alt | We use Class Method rather than static in documentation headers in
buffer.md and crypto.md. We use static in one place in
async_hooks.md. Change to Class Method for consistency.
Checklist
docu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34626#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34626 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34626 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34626 |
| Reload | https://github.com/nodejs/node/pull/34626 |
| Reload | https://github.com/nodejs/node/pull/34626 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34626#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:class-method | https://github.com/Trott/io.js/tree/class-method |
|
doc: use _Class Method_ in async_hooks.md
| https://github.com/nodejs/node/pull/34626#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:class-method | https://github.com/Trott/io.js/tree/class-method |
|
Conversation
2
| https://github.com/nodejs/node/pull/34626 |
|
Commits
0
| https://github.com/nodejs/node/pull/34626/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34626/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34626/files |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34626#issue-673144686 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34626#issuecomment-668876733 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4206 | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4206 |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34626#event-3622377260 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34626#pullrequestreview-461731358 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34626/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34626#pullrequestreview-461768635 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34626/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 5, 2020 | https://github.com/nodejs/node/pull/34626#event-3625343728 |
| https://github.com/Flarna |
| Flarna | https://github.com/Flarna |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34626#pullrequestreview-461946367 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34626/files |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34626#pullrequestreview-461946935 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34626/files |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34626#event-3631374732 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a..e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa |
| 671ab7c | https://github.com/nodejs/node/commit/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a |
| e692adf | https://github.com/nodejs/node/commit/e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa |
|
Compare
| https://github.com/nodejs/node/compare/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a..e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa |
| August 7, 2020 01:16 | https://github.com/nodejs/node/pull/34626#event-3631374734 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| e692adf | https://github.com/nodejs/node/commit/e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34626#event-3631374878 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34626#issuecomment-670268382 |
| e692adf | https://github.com/nodejs/node/commit/e692adf3cf29eb33fafa8be0e1bfa1b8aee404fa |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| August 7, 2020 01:17 | https://github.com/nodejs/node/pull/34626#event-3631375983 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2020
| https://github.com/nodejs/node/pull/34626#ref-commit-b78278b |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: use _Class Method_ in async_hooks.md | https://github.com/nodejs/node/commit/b78278b92229fa697a444d27adf3dc01a457080c |
| b78278b | https://github.com/nodejs/node/commit/b78278b92229fa697a444d27adf3dc01a457080c |
| #34626 | https://github.com/nodejs/node/pull/34626 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34626#ref-pullrequest-675867215 |
|
v14.8.0 proposal
#34704
| https://github.com/nodejs/node/pull/34704 |
| codebytere | https://github.com/codebytere |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/34626#ref-commit-a944dab |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| doc: use _Class Method_ in async_hooks.md | https://github.com/nodejs/node/commit/a944dab7076331944aeefd2802ec252811e9a702 |
| a944dab | https://github.com/nodejs/node/commit/a944dab7076331944aeefd2802ec252811e9a702 |
| #34626 | https://github.com/nodejs/node/pull/34626 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34626#ref-commit-5846bef |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| doc: use _Class Method_ in async_hooks.md | https://github.com/nodejs/node/commit/5846befacbd56bd81c22d159424f5062c8ec2f09 |
| 5846bef | https://github.com/nodejs/node/commit/5846befacbd56bd81c22d159424f5062c8ec2f09 |
| #34626 | https://github.com/nodejs/node/pull/34626 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34626#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34626 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34626/files/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34626/files/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/34626/files/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a |
|
| https://github.com/Flarna |
|
Flarna
| https://github.com/Flarna |
|
| https://github.com/nodejs/node/pull/34626/files/671ab7cf2b2de1c183f54968dd19cf3e03e1eb9a |
|
async_hooks
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
| Please reload this page | https://github.com/nodejs/node/pull/34626 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/joyeecheung |
|
| https://github.com/Flarna |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |