| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:bc87c117-f286-a973-3862-ddb4f72a5600 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8E4C:275F42:30440E:4360E4:696A72AE |
| html-safe-nonce | 7abfa90419417092535dad4b273f3e41b099fdecb3170431bf5aaa7d39ef1209 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RTRDOjI3NUY0MjozMDQ0MEU6NDM2MEU0OjY5NkE3MkFFIiwidmlzaXRvcl9pZCI6IjIyNTYxMjk3NDM3ODM2MjEyOTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f6132e697c3c5bf2cae3717841e67b8b3dd6dde9b65ae09960df6d7b6136ccd7 |
| hovercard-subject-tag | pull_request:462868134 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34622/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d72b895a21c46f23450fc49b8fcd69df54042d02fe1a5125f97daf4ebfef6033/nodejs/node/pull/34622 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d72b895a21c46f23450fc49b8fcd69df54042d02fe1a5125f97daf4ebfef6033/nodejs/node/pull/34622 |
| og:image:alt | This slightly changes the conditional used to determine whether or not something is a URL instance. Since Node.js adds symbols to the URL not specified by the WHATWG, those symbols are not present ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | codebytere |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34622#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34622 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34622 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34622 |
| Reload | https://github.com/nodejs/node/pull/34622 |
| Reload | https://github.com/nodejs/node/pull/34622 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34622#issue-comment-box |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:better-url-instance-check | https://github.com/codebytere/node/tree/better-url-instance-check |
|
lib: use non-symbols in isURLInstance check
| https://github.com/nodejs/node/pull/34622#top |
| codebytere | https://github.com/codebytere |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| codebytere:better-url-instance-check | https://github.com/codebytere/node/tree/better-url-instance-check |
|
Conversation
8
| https://github.com/nodejs/node/pull/34622 |
|
Commits
1
| https://github.com/nodejs/node/pull/34622/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34622/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34622/files |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34622#issue-672914328 |
| @jasnell | https://github.com/jasnell |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-668690722 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4203 | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4203 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 4, 2020
| https://github.com/nodejs/node/pull/34622#pullrequestreview-460972531 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34622/files |
| jasnell | https://github.com/jasnell |
| https://github.com/nodejs/node/pull/34622#pullrequestreview-460972531 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-668701765 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-668719720 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-668724839 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| @devsnek | https://github.com/devsnek |
| https://user-images.githubusercontent.com/2036040/89324761-a605c800-d63c-11ea-9396-8c3ce598e4f4.png |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
|
| https://github.com/codebytere |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/pull/34622/commits/ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| ab961ef | https://github.com/nodejs/node/pull/34622/commits/ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| force-pushed | https://github.com/nodejs/node/compare/604cdfdafbcdb10c572db509835b76dba93aee37..ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| 604cdfd | https://github.com/nodejs/node/commit/604cdfdafbcdb10c572db509835b76dba93aee37 |
| ab961ef | https://github.com/nodejs/node/commit/ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
|
Compare
| https://github.com/nodejs/node/compare/604cdfdafbcdb10c572db509835b76dba93aee37..ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| August 4, 2020 17:30 | https://github.com/nodejs/node/pull/34622#event-3621276961 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34622#ref-pullrequest-672924875 |
|
fix: use non-symbols in isURLInstance check
electron/electron#24831
| https://github.com/electron/electron/pull/24831 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 5, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-668998899 |
| https://ci.nodejs.org/job/node-test-pull-request/32632/ | https://ci.nodejs.org/job/node-test-pull-request/32632/ |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 5, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-669477306 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://ci.nodejs.org/job/node-test-pull-request/32636/ | https://ci.nodejs.org/job/node-test-pull-request/32636/ |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
|
CI Relability 2020-08-06
JaneaSystems/nodejs-reliability#60
| https://github.com/JaneaSystems/nodejs-reliability/issues/60 |
|
CI Reliability 2020-08-06
nodejs/reliability#35
| https://github.com/nodejs/reliability/issues/35 |
|
CI Relability 2020-08-07
JaneaSystems/nodejs-reliability#61
| https://github.com/JaneaSystems/nodejs-reliability/issues/61 |
|
CI Reliability 2020-08-07
nodejs/reliability#36
| https://github.com/nodejs/reliability/issues/36 |
|
CI Relability 2020-08-08
JaneaSystems/nodejs-reliability#62
| https://github.com/JaneaSystems/nodejs-reliability/issues/62 |
|
CI Reliability 2020-08-08
nodejs/reliability#37
| https://github.com/nodejs/reliability/issues/37 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Aug 9, 2020
| https://github.com/nodejs/node/pull/34622#pullrequestreview-463833960 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34622/files/ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| Trott | https://github.com/Trott |
|
Aug 9, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-8825eb4 |
|
| https://github.com/codebytere |
|
| https://github.com/Trott |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/commit/8825eb4d734c78ccdaa06811a5b033e59f7fa978 |
| 8825eb4 | https://github.com/nodejs/node/commit/8825eb4d734c78ccdaa06811a5b033e59f7fa978 |
| #34622 | https://github.com/nodejs/node/pull/34622 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34622#issuecomment-670988009 |
| 8825eb4 | https://github.com/nodejs/node/commit/8825eb4d734c78ccdaa06811a5b033e59f7fa978 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34622#event-3636069061 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
| August 9, 2020 00:20 | https://github.com/nodejs/node/pull/34622#event-3636069194 |
|
CI Relability 2020-08-09
JaneaSystems/nodejs-reliability#63
| https://github.com/JaneaSystems/nodejs-reliability/issues/63 |
|
CI Reliability 2020-08-09
nodejs/reliability#38
| https://github.com/nodejs/reliability/issues/38 |
|
CI Relability 2020-08-10
JaneaSystems/nodejs-reliability#64
| https://github.com/JaneaSystems/nodejs-reliability/issues/64 |
|
CI Reliability 2020-08-10
nodejs/reliability#39
| https://github.com/nodejs/reliability/issues/39 |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-d0efaf2 |
|
| https://github.com/codebytere |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/commit/d0efaf2fe337035f56652e0168a5d397e266d3af |
| d0efaf2 | https://github.com/nodejs/node/commit/d0efaf2fe337035f56652e0168a5d397e266d3af |
| #34622 | https://github.com/nodejs/node/pull/34622 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34622#ref-pullrequest-675867215 |
|
v14.8.0 proposal
#34704
| https://github.com/nodejs/node/pull/34704 |
|
CI Relability 2020-08-11
JaneaSystems/nodejs-reliability#65
| https://github.com/JaneaSystems/nodejs-reliability/issues/65 |
|
CI Reliability 2020-08-11
nodejs/reliability#40
| https://github.com/nodejs/reliability/issues/40 |
| codebytere | https://github.com/codebytere |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-4efc5f6 |
|
| https://github.com/codebytere |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/commit/4efc5f66faaa7f61b046b5614441bd6124c9fc86 |
| 4efc5f6 | https://github.com/nodejs/node/commit/4efc5f66faaa7f61b046b5614441bd6124c9fc86 |
| #34622 | https://github.com/nodejs/node/pull/34622 |
| https://github.com/aduh95 |
| aduh95 | https://github.com/aduh95 |
|
Aug 27, 2020
| https://github.com/nodejs/node/pull/34622#ref-pullrequest-687564956 |
|
module: use isURLInstance instead of instanceof
#34951
| https://github.com/nodejs/node/pull/34951 |
| codebytere | https://github.com/codebytere |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-a0d9aac |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/a0d9aac8f19f9b84c1cd106c106bf07f5defc7b6 |
| a0d9aac | https://github.com/electron/electron/commit/a0d9aac8f19f9b84c1cd106c106bf07f5defc7b6 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 1, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-c8c89cd |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/c8c89cda996d9c1c4e3bdd2dc6946283d2517ed1 |
| c8c89cd | https://github.com/electron/electron/commit/c8c89cda996d9c1c4e3bdd2dc6946283d2517ed1 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 2, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-4e8cd7c |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/4e8cd7c6076bd5b9b4a2273d584dbee70de0d0ee |
| 4e8cd7c | https://github.com/electron/electron/commit/4e8cd7c6076bd5b9b4a2273d584dbee70de0d0ee |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 4, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-f9c7804 |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/f9c7804a298c7d7fd4de3ce22dd516ffbe58f1e5 |
| f9c7804 | https://github.com/electron/electron/commit/f9c7804a298c7d7fd4de3ce22dd516ffbe58f1e5 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 14, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-0b42e44 |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/0b42e44665df13f3c5852b088b6cc41b24c1768d |
| 0b42e44 | https://github.com/electron/electron/commit/0b42e44665df13f3c5852b088b6cc41b24c1768d |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 14, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-d3f4e35 |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/d3f4e35056fe4fbe52f5abcb3cb0cf80f4362a86 |
| d3f4e35 | https://github.com/electron/electron/commit/d3f4e35056fe4fbe52f5abcb3cb0cf80f4362a86 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 14, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-35605ab |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/35605ab9ecd73ca9ef0b0ed91fcea99b63c04cd9 |
| 35605ab | https://github.com/electron/electron/commit/35605ab9ecd73ca9ef0b0ed91fcea99b63c04cd9 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| codebytere | https://github.com/codebytere |
|
Sep 16, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-e67c007 |
|
| https://github.com/codebytere |
| Remove symbol instance check | https://github.com/electron/electron/commit/e67c007ba23eab1bc62e15d50dce9301756205f7 |
| e67c007 | https://github.com/electron/electron/commit/e67c007ba23eab1bc62e15d50dce9301756205f7 |
| nodejs/node#34622 | https://github.com/nodejs/node/pull/34622 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-698457e |
|
| https://github.com/codebytere |
|
| https://github.com/addaleax |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/commit/698457e706be0255d356e53b6a95434446f2e766 |
| 698457e | https://github.com/nodejs/node/commit/698457e706be0255d356e53b6a95434446f2e766 |
| #34622 | https://github.com/nodejs/node/pull/34622 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34622#ref-commit-176f8c3 |
|
| https://github.com/codebytere |
|
| https://github.com/addaleax |
| lib: use non-symbols in isURLInstance check | https://github.com/nodejs/node/commit/176f8c35c57ff94d75bf006c0d893e6a668c9665 |
| 176f8c3 | https://github.com/nodejs/node/commit/176f8c35c57ff94d75bf006c0d893e6a668c9665 |
| #34622 | https://github.com/nodejs/node/pull/34622 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34622#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34622 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34622/files/604cdfdafbcdb10c572db509835b76dba93aee37 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/34622/files/ab961ef50c5ee7177d846f28cd13adcf0d831ad7 |
| Please reload this page | https://github.com/nodejs/node/pull/34622 |
|
| https://github.com/codebytere |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/devsnek |
|
| https://github.com/jasnell |
|
| https://github.com/Trott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |