René's URL Explorer Experiment


Title: async_hooks: improve property descriptors in als.bind by Flarna · Pull Request #34620 · nodejs/node · GitHub

Open Graph Title: async_hooks: improve property descriptors in als.bind by Flarna · Pull Request #34620 · nodejs/node

X Title: async_hooks: improve property descriptors in als.bind by Flarna · Pull Request #34620 · nodejs/node

Description: The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30...

Open Graph Description: The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30...

X Description: The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30...

Opengraph URL: https://github.com/nodejs/node/pull/34620

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5dc01958-4f1a-ef70-68df-1e0a8115415b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE2E:C2480:71047D:9E0613:696A729C
html-safe-nonce1e0de76385320e523e5208a00b51c5e4fd46611fc83ef940b75b8a95fd2388ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTJFOkMyNDgwOjcxMDQ3RDo5RTA2MTM6Njk2QTcyOUMiLCJ2aXNpdG9yX2lkIjoiNzY4Mzg4MTM1Mzk5OTk3MDk3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac68a77ab5e5a88fd2fe8c0e1076ae594b2d27c889512d6ba5a4dbcc58401a5e99
hovercard-subject-tagpull_request:462612534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34620/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5357030522e07a912476c50d494547cd874da6f24708ea8dd41d003d4ed95af7/nodejs/node/pull/34620
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5357030522e07a912476c50d494547cd874da6f24708ea8dd41d003d4ed95af7/nodejs/node/pull/34620
og:image:altThe length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: #30...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFlarna
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34620#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34620
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34620
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34620
Reloadhttps://github.com/nodejs/node/pull/34620
Reloadhttps://github.com/nodejs/node/pull/34620
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34620
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34620
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34620#issue-comment-box
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
dynatrace-oss-contrib:als-bind-propshttps://github.com/dynatrace-oss-contrib/node/tree/als-bind-props
async_hooks: improve property descriptors in als.bind https://github.com/nodejs/node/pull/34620#top
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
dynatrace-oss-contrib:als-bind-propshttps://github.com/dynatrace-oss-contrib/node/tree/als-bind-props
Conversation 4 https://github.com/nodejs/node/pull/34620
Commits 1 https://github.com/nodejs/node/pull/34620/commits
Checks 0 https://github.com/nodejs/node/pull/34620/checks
Files changed https://github.com/nodejs/node/pull/34620/files
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020https://github.com/nodejs/node/pull/34620#issue-672607448
#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
#34574https://github.com/nodejs/node/pull/34574
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.com/Flarna
[async_hooks] improve property descriptors in als.bindhttps://github.com/nodejs/node/pull/34620/commits/ccc046718732cadd57eefb14d5eec8895f59bbb6
ccc0467https://github.com/nodejs/node/pull/34620/commits/ccc046718732cadd57eefb14d5eec8895f59bbb6
nodejs#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
nodejs#34574https://github.com/nodejs/node/pull/34574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2020https://github.com/nodejs/node/pull/34620#issuecomment-668459062
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4202https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4202
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Aug 4, 2020https://github.com/nodejs/node/pull/34620#event-3619138432
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020 https://github.com/nodejs/node/pull/34620#ref-pullrequest-669360222
async_hooks: add AsyncResource.bind utility #34574 https://github.com/nodejs/node/pull/34574
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2020https://github.com/nodejs/node/pull/34620#issuecomment-668465474
https://ci.nodejs.org/job/node-test-pull-request/32622/https://ci.nodejs.org/job/node-test-pull-request/32622/
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Aug 4, 2020 https://github.com/nodejs/node/pull/34620#pullrequestreview-460619204
View reviewed changes https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
https://github.com/Flarna
Flarnahttps://github.com/Flarna
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 4, 2020https://github.com/nodejs/node/pull/34620#event-3619329018
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 4, 2020 https://github.com/nodejs/node/pull/34620#pullrequestreview-460725144
View reviewed changes https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 4, 2020 https://github.com/nodejs/node/pull/34620#pullrequestreview-460751132
View reviewed changes https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
https://github.com/jasnell
jasnellhttps://github.com/jasnell
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Aug 4, 2020https://github.com/nodejs/node/pull/34620#event-3620747230
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Aug 4, 2020https://github.com/nodejs/node/pull/34620#issuecomment-668658804
Please reload this pagehttps://github.com/nodejs/node/pull/34620
Flarnahttps://github.com/Flarna
Aug 4, 2020 https://github.com/nodejs/node/pull/34620#ref-commit-3ea94ec
https://github.com/Flarna
async_hooks: improve property descriptors in als.bindhttps://github.com/nodejs/node/commit/3ea94ec84510f5ecd08b75e6e10ef7c5f5df4fe8
3ea94echttps://github.com/nodejs/node/commit/3ea94ec84510f5ecd08b75e6e10ef7c5f5df4fe8
#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
#34574https://github.com/nodejs/node/pull/34574
#34620https://github.com/nodejs/node/pull/34620
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020https://github.com/nodejs/node/pull/34620#issuecomment-668685440
3ea94echttps://github.com/nodejs/node/commit/3ea94ec84510f5ecd08b75e6e10ef7c5f5df4fe8
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020https://github.com/nodejs/node/pull/34620#event-3620963077
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020https://github.com/nodejs/node/pull/34620#event-3620963831
https://github.com/Flarna
Flarnahttps://github.com/Flarna
August 4, 2020 16:06https://github.com/nodejs/node/pull/34620#event-3620964974
addaleaxhttps://github.com/addaleax
Aug 8, 2020 https://github.com/nodejs/node/pull/34620#ref-commit-0af9bee
https://github.com/Flarna
https://github.com/addaleax
async_hooks: improve property descriptors in als.bindhttps://github.com/nodejs/node/commit/0af9bee4c3c4b53f2cdb398bbf764baaaea7759b
0af9beehttps://github.com/nodejs/node/commit/0af9bee4c3c4b53f2cdb398bbf764baaaea7759b
#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
#34574https://github.com/nodejs/node/pull/34574
#34620https://github.com/nodejs/node/pull/34620
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 10, 2020 https://github.com/nodejs/node/pull/34620#ref-pullrequest-675867215
v14.8.0 proposal #34704 https://github.com/nodejs/node/pull/34704
codebyterehttps://github.com/codebytere
Aug 11, 2020 https://github.com/nodejs/node/pull/34620#ref-commit-0730c76
https://github.com/Flarna
https://github.com/codebytere
async_hooks: improve property descriptors in als.bindhttps://github.com/nodejs/node/commit/0730c76023d99b8a7bb540617b0e2d13210f74d3
0730c76https://github.com/nodejs/node/commit/0730c76023d99b8a7bb540617b0e2d13210f74d3
#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
#34574https://github.com/nodejs/node/pull/34574
#34620https://github.com/nodejs/node/pull/34620
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34620#ref-commit-07968ac
https://github.com/Flarna
https://github.com/addaleax
async_hooks: improve property descriptors in als.bindhttps://github.com/nodejs/node/commit/07968ac456c7b95a38ae1ede91c211bfc6eaab47
07968achttps://github.com/nodejs/node/commit/07968ac456c7b95a38ae1ede91c211bfc6eaab47
#30932 (comment)https://github.com/nodejs/node/pull/30932#discussion_r379679982
#34574https://github.com/nodejs/node/pull/34574
#34620https://github.com/nodejs/node/pull/34620
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34620#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34620
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
https://github.com/puzpuzpuz
puzpuzpuz https://github.com/puzpuzpuz
https://github.com/nodejs/node/pull/34620/files/ccc046718732cadd57eefb14d5eec8895f59bbb6
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Please reload this pagehttps://github.com/nodejs/node/pull/34620
https://github.com/Flarna
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/addaleax
https://github.com/puzpuzpuz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.