René's URL Explorer Experiment


Title: async_hooks: avoid unneeded AsyncResource creation by Flarna · Pull Request #34616 · nodejs/node · GitHub

Open Graph Title: async_hooks: avoid unneeded AsyncResource creation by Flarna · Pull Request #34616 · nodejs/node

X Title: async_hooks: avoid unneeded AsyncResource creation by Flarna · Pull Request #34616 · nodejs/node

Description: Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) fyi @vdeturckheim @puzpuzpuz @Qard

Open Graph Description: Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) fyi @vdeturckheim @puzpuzpuz @Qard

X Description: Inspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) fyi @vdeturckheim @puzpuzpuz @Qard

Opengraph URL: https://github.com/nodejs/node/pull/34616

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c6a6499-63fb-fd69-737b-10aa596aafbc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2AE:36585F:34BD17:49B124:696A7169
html-safe-nonceb81fad7a86ad073f64808785183498f900c38398bf20c5f7ac5bce78c1cf3531
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkFFOjM2NTg1RjozNEJEMTc6NDlCMTI0OjY5NkE3MTY5IiwidmlzaXRvcl9pZCI6Ijg3Mzk5Nzk5ODA2Mjg5ODAwNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7b23c0c340d6674712756505c7c2dc329e9b41c90d92aecd3d64035d2764204f
hovercard-subject-tagpull_request:462406515
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34616/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2462ad49d779882fdbcdc054ea153ad5d1b60e6c197675b0ff57e0bfba2739be/nodejs/node/pull/34616
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2462ad49d779882fdbcdc054ea153ad5d1b60e6c197675b0ff57e0bfba2739be/nodejs/node/pull/34616
og:image:altInspired by the callstack at #34556 (comment) If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: #34556 (comment) fyi @vdeturckheim @puzpuzpuz @Qard
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFlarna
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34616#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34616
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34616
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34616
Reloadhttps://github.com/nodejs/node/pull/34616
Reloadhttps://github.com/nodejs/node/pull/34616
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34616
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34616
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34616#issue-comment-box
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
dynatrace-oss-contrib:async-local-no-unneeded-resourcehttps://github.com/dynatrace-oss-contrib/node/tree/async-local-no-unneeded-resource
async_hooks: avoid unneeded AsyncResource creation https://github.com/nodejs/node/pull/34616#top
Flarnahttps://github.com/Flarna
nodejs:masterhttps://github.com/nodejs/node/tree/master
dynatrace-oss-contrib:async-local-no-unneeded-resourcehttps://github.com/dynatrace-oss-contrib/node/tree/async-local-no-unneeded-resource
Conversation 5 https://github.com/nodejs/node/pull/34616
Commits 1 https://github.com/nodejs/node/pull/34616/commits
Checks 0 https://github.com/nodejs/node/pull/34616/checks
Files changed 2 https://github.com/nodejs/node/pull/34616/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 3, 2020https://github.com/nodejs/node/pull/34616#issue-672354282
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
@vdeturckheimhttps://github.com/vdeturckheim
@puzpuzpuzhttps://github.com/puzpuzpuz
@Qardhttps://github.com/Qard
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 3, 2020https://github.com/nodejs/node/pull/34616#issuecomment-668251151
https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4199https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4199
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
Aug 3, 2020https://github.com/nodejs/node/pull/34616#event-3617659257
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Aug 3, 2020 https://github.com/nodejs/node/pull/34616#pullrequestreview-460366800
View reviewed changes https://github.com/nodejs/node/pull/34616/files
https://github.com/Qard
Qardhttps://github.com/Qard
Aug 3, 2020 https://github.com/nodejs/node/pull/34616#pullrequestreview-460406283
View reviewed changes https://github.com/nodejs/node/pull/34616/files
https://github.com/vdeturckheim
vdeturckheimhttps://github.com/vdeturckheim
Aug 4, 2020 https://github.com/nodejs/node/pull/34616#pullrequestreview-460522782
View reviewed changes https://github.com/nodejs/node/pull/34616/files
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Aug 4, 2020https://github.com/nodejs/node/pull/34616#issuecomment-668423116
@Flarnahttps://github.com/Flarna
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Aug 4, 2020 https://github.com/nodejs/node/pull/34616#pullrequestreview-460554167
View reviewed changes https://github.com/nodejs/node/pull/34616/files
https://github.com/Flarna
[async_hooks] avoid unneeded AsyncResource creationhttps://github.com/nodejs/node/pull/34616/commits/5eb30aa205b445e99117a8d7f652cee2015c5053
5eb30aahttps://github.com/nodejs/node/pull/34616/commits/5eb30aa205b445e99117a8d7f652cee2015c5053
nodejs#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
nodejs#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
https://github.com/Flarna
Flarnahttps://github.com/Flarna
force-pushedhttps://github.com/nodejs/node/compare/048632c983fd767295162bdbf644dcbaef28ca48..5eb30aa205b445e99117a8d7f652cee2015c5053
048632chttps://github.com/nodejs/node/commit/048632c983fd767295162bdbf644dcbaef28ca48
5eb30aahttps://github.com/nodejs/node/commit/5eb30aa205b445e99117a8d7f652cee2015c5053
Compare https://github.com/nodejs/node/compare/048632c983fd767295162bdbf644dcbaef28ca48..5eb30aa205b445e99117a8d7f652cee2015c5053
August 4, 2020 08:08https://github.com/nodejs/node/pull/34616#event-3619065921
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34616
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 4, 2020https://github.com/nodejs/node/pull/34616#issuecomment-668474773
https://ci.nodejs.org/job/node-test-pull-request/32623/https://ci.nodejs.org/job/node-test-pull-request/32623/
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/Flarna
Flarnahttps://github.com/Flarna
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Aug 4, 2020https://github.com/nodejs/node/pull/34616#event-3619330131
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 4, 2020https://github.com/nodejs/node/pull/34616#event-3620967400
https://github.com/Qard
Qardhttps://github.com/Qard
Aug 4, 2020 https://github.com/nodejs/node/pull/34616#pullrequestreview-461242398
View reviewed changes https://github.com/nodejs/node/pull/34616/files/5eb30aa205b445e99117a8d7f652cee2015c5053
CI Relability 2020-08-05 JaneaSystems/nodejs-reliability#59 https://github.com/JaneaSystems/nodejs-reliability/issues/59
CI Reliability 2020-08-05 nodejs/reliability#34 https://github.com/nodejs/reliability/issues/34
CI Relability 2020-08-06 JaneaSystems/nodejs-reliability#60 https://github.com/JaneaSystems/nodejs-reliability/issues/60
CI Reliability 2020-08-06 nodejs/reliability#35 https://github.com/nodejs/reliability/issues/35
Flarnahttps://github.com/Flarna
Aug 6, 2020 https://github.com/nodejs/node/pull/34616#ref-commit-4824988
https://github.com/Flarna
async_hooks: avoid unneeded AsyncResource creationhttps://github.com/nodejs/node/commit/48249889b6b1af69d3c2b6fb9e59fea08d2bd023
4824988https://github.com/nodejs/node/commit/48249889b6b1af69d3c2b6fb9e59fea08d2bd023
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34616https://github.com/nodejs/node/pull/34616
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 6, 2020https://github.com/nodejs/node/pull/34616#issuecomment-670201125
4824988https://github.com/nodejs/node/commit/48249889b6b1af69d3c2b6fb9e59fea08d2bd023
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Aug 6, 2020https://github.com/nodejs/node/pull/34616#event-3630903171
https://github.com/Flarna
Flarnahttps://github.com/Flarna
August 6, 2020 21:28https://github.com/nodejs/node/pull/34616#event-3630903958
CI Relability 2020-08-07 JaneaSystems/nodejs-reliability#61 https://github.com/JaneaSystems/nodejs-reliability/issues/61
CI Reliability 2020-08-07 nodejs/reliability#36 https://github.com/nodejs/reliability/issues/36
addaleaxhttps://github.com/addaleax
Aug 8, 2020 https://github.com/nodejs/node/pull/34616#ref-commit-0a51aa8
https://github.com/Flarna
https://github.com/addaleax
async_hooks: avoid unneeded AsyncResource creationhttps://github.com/nodejs/node/commit/0a51aa8fdb37771c5f5ee88e5b082ae3c1603d56
0a51aa8https://github.com/nodejs/node/commit/0a51aa8fdb37771c5f5ee88e5b082ae3c1603d56
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34616https://github.com/nodejs/node/pull/34616
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 10, 2020 https://github.com/nodejs/node/pull/34616#ref-pullrequest-675867215
v14.8.0 proposal #34704 https://github.com/nodejs/node/pull/34704
codebyterehttps://github.com/codebytere
Aug 11, 2020 https://github.com/nodejs/node/pull/34616#ref-commit-641a5fb
https://github.com/Flarna
https://github.com/codebytere
async_hooks: avoid unneeded AsyncResource creationhttps://github.com/nodejs/node/commit/641a5fb0aac763fd7871df0fc185ab95c25b091a
641a5fbhttps://github.com/nodejs/node/commit/641a5fb0aac763fd7871df0fc185ab95c25b091a
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34616https://github.com/nodejs/node/pull/34616
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34616#ref-commit-0a44017
https://github.com/Flarna
https://github.com/addaleax
async_hooks: avoid unneeded AsyncResource creationhttps://github.com/nodejs/node/commit/0a4401713ad5ebf1a70b77c99ef8bf3257ad84b4
0a44017https://github.com/nodejs/node/commit/0a4401713ad5ebf1a70b77c99ef8bf3257ad84b4
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34556 (comment)https://github.com/nodejs/node/issues/34556#issuecomment-666743528
#34616https://github.com/nodejs/node/pull/34616
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34616#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34616
https://github.com/Qard
Qard https://github.com/Qard
https://github.com/nodejs/node/pull/34616/files/5eb30aa205b445e99117a8d7f652cee2015c5053
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34616/files/048632c983fd767295162bdbf644dcbaef28ca48
https://github.com/vdeturckheim
vdeturckheim https://github.com/vdeturckheim
https://github.com/nodejs/node/pull/34616/files/048632c983fd767295162bdbf644dcbaef28ca48
https://github.com/puzpuzpuz
puzpuzpuz https://github.com/puzpuzpuz
https://github.com/nodejs/node/pull/34616/files/048632c983fd767295162bdbf644dcbaef28ca48
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Please reload this pagehttps://github.com/nodejs/node/pull/34616
https://github.com/Flarna
https://github.com/nodejs-github-bot
https://github.com/puzpuzpuz
https://github.com/Qard
https://github.com/addaleax
https://github.com/vdeturckheim
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.