| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:1d8fbb31-341b-aafd-160f-6dc2d7f42dbf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8728:1272F1:19C8472:23BD30E:696AA6C7 |
| html-safe-nonce | 225f0f02b4ed6ccbb5ed0a53202eb5cc9d145fe5d01ebe7279939e2631c06ba4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzI4OjEyNzJGMToxOUM4NDcyOjIzQkQzMEU6Njk2QUE2QzciLCJ2aXNpdG9yX2lkIjoiNDU4MzQ3MjMzNzA3ODg4ODEzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 3de0a199f71cf2765a15b278980816617d500f50a8e87ee3972abb3d9e984cbf |
| hovercard-subject-tag | pull_request:461840873 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34603/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3636573afead9aa05295b583de20d3c1b2e57d6660ca904df93f1d8458b2acab/nodejs/node/pull/34603 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3636573afead9aa05295b583de20d3c1b2e57d6660ca904df93f1d8458b2acab/nodejs/node/pull/34603 |
| og:image:alt | The test is timing out once in a very long while on Windows CI. It is
unclear where the test gets stuck, so add more debugging statements to
try to locate it.
Refs: #24397
Checklist
make -j4 te... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34603#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34603 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34603 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34603 |
| Reload | https://github.com/nodejs/node/pull/34603 |
| Reload | https://github.com/nodejs/node/pull/34603 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
694
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34603#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:foaf | https://github.com/Trott/io.js/tree/foaf |
|
test: add debugging for test-https-foafssl.js
| https://github.com/nodejs/node/pull/34603#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:foaf | https://github.com/Trott/io.js/tree/foaf |
|
Conversation
5
| https://github.com/nodejs/node/pull/34603 |
|
Commits
2
| https://github.com/nodejs/node/pull/34603/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34603/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34603/files |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 2, 2020 | https://github.com/nodejs/node/pull/34603#issue-671663505 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
|
| https://github.com/Trott |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/pull/34603/commits/1a28fbe00dc4e1bf6a7b9422e43b62f0fcf7bdd8 |
| 1a28fbe | https://github.com/nodejs/node/pull/34603/commits/1a28fbe00dc4e1bf6a7b9422e43b62f0fcf7bdd8 |
| nodejs#24397 | https://github.com/nodejs/node/issues/24397 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 2, 2020 | https://github.com/nodejs/node/pull/34603#issuecomment-667706913 |
| https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4192 | https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4192 |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Aug 2, 2020 | https://github.com/nodejs/node/pull/34603#event-3613553578 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 2, 2020 | https://github.com/nodejs/node/pull/34603#issuecomment-667728513 |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
|
| https://github.com/Trott |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/pull/34603/commits/01407340d39e088b96eff3565467c8cf79da2357 |
| 0140734 | https://github.com/nodejs/node/pull/34603/commits/01407340d39e088b96eff3565467c8cf79da2357 |
| nodejs#24397 | https://github.com/nodejs/node/issues/24397 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 2, 2020 | https://github.com/nodejs/node/pull/34603#issuecomment-667731441 |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
| https://github.com/joyeecheung |
| joyeecheung | https://github.com/joyeecheung |
|
Aug 4, 2020
| https://github.com/nodejs/node/pull/34603#pullrequestreview-460836252 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
Aug 4, 2020
| https://github.com/nodejs/node/pull/34603#pullrequestreview-460948304 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34603#event-3621806652 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Aug 4, 2020 | https://github.com/nodejs/node/pull/34603#issuecomment-668873307 |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Aug 7, 2020
| https://github.com/nodejs/node/pull/34603#pullrequestreview-463412492 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
| jasnell | https://github.com/jasnell |
|
Aug 7, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-57c8549 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/commit/57c8549c561c9892c0c1efb948728b92ddb78516 |
| 57c8549 | https://github.com/nodejs/node/commit/57c8549c561c9892c0c1efb948728b92ddb78516 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| jasnell | https://github.com/jasnell |
|
Aug 7, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-93959b2 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/commit/93959b22b197e2e9fdb4a21e65e567729d76338d |
| 93959b2 | https://github.com/nodejs/node/commit/93959b22b197e2e9fdb4a21e65e567729d76338d |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34603#issuecomment-670579779 |
| 0dff5bc...93959b2 | https://github.com/nodejs/node/compare/0dff5bc2d8d03733093848d6691a347755f914cc...93959b22b197e2e9fdb4a21e65e567729d76338d |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34603#event-3633755172 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-2133b18 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/commit/2133b18beebcd093e075bb65b93b39b3e8158430 |
| 2133b18 | https://github.com/nodejs/node/commit/2133b18beebcd093e075bb65b93b39b3e8158430 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-ca89c37 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/commit/ca89c375f7b9066138a81c73dd98d43b12d073ce |
| ca89c37 | https://github.com/nodejs/node/commit/ca89c375f7b9066138a81c73dd98d43b12d073ce |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34603#ref-pullrequest-675867215 |
|
v14.8.0 proposal
#34704
| https://github.com/nodejs/node/pull/34704 |
| codebytere | https://github.com/codebytere |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-4cd9c4f |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/commit/4cd9c4f94d69bd9bfd7ad898823d42930526c40e |
| 4cd9c4f | https://github.com/nodejs/node/commit/4cd9c4f94d69bd9bfd7ad898823d42930526c40e |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| codebytere | https://github.com/codebytere |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-27333b1 |
|
| https://github.com/Trott |
|
| https://github.com/codebytere |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/commit/27333b1b732c6cc93e2b178f1d61b0a6e0b1c0b5 |
| 27333b1 | https://github.com/nodejs/node/commit/27333b1b732c6cc93e2b178f1d61b0a6e0b1c0b5 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-e05f80b |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/commit/e05f80b36cece5441a1e63997a789a2f95ef935d |
| e05f80b | https://github.com/nodejs/node/commit/e05f80b36cece5441a1e63997a789a2f95ef935d |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-0e823e3 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/commit/0e823e3d9c8f8413ea8ef7edd690ed48dd125a15 |
| 0e823e3 | https://github.com/nodejs/node/commit/0e823e3d9c8f8413ea8ef7edd690ed48dd125a15 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-4dbc787 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for test-https-foafssl.js | https://github.com/nodejs/node/commit/4dbc787a2f0918a4c045ff8620af453e8af5c89b |
| 4dbc787 | https://github.com/nodejs/node/commit/4dbc787a2f0918a4c045ff8620af453e8af5c89b |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34603#ref-commit-7eb8040 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: add debugging for callbacks in test-https-foafssl.js | https://github.com/nodejs/node/commit/7eb80403b5201cdaf75d2dbea96fdf3de4ff4b72 |
| 7eb8040 | https://github.com/nodejs/node/commit/7eb80403b5201cdaf75d2dbea96fdf3de4ff4b72 |
| #24397 | https://github.com/nodejs/node/issues/24397 |
| #34603 | https://github.com/nodejs/node/pull/34603 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34603#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| April 14, 2022 11:29 | https://github.com/nodejs/node/pull/34603#event-6433877197 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34603 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
|
| https://github.com/joyeecheung |
|
joyeecheung
| https://github.com/joyeecheung |
|
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
|
| https://github.com/rickyes |
|
rickyes
| https://github.com/rickyes |
|
| https://github.com/nodejs/node/pull/34603/files/01407340d39e088b96eff3565467c8cf79da2357 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34603 |
|
| https://github.com/Trott |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/joyeecheung |
|
| https://github.com/rickyes |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |