René's URL Explorer Experiment


Title: test: change Fixes: to Refs: by Trott · Pull Request #34568 · nodejs/node · GitHub

Open Graph Title: test: change Fixes: to Refs: by Trott · Pull Request #34568 · nodejs/node

X Title: test: change Fixes: to Refs: by Trott · Pull Request #34568 · nodejs/node

Description: Tests don't fix things generally, so use "Refs:" to refer people to GitHub issues. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit...

Open Graph Description: Tests don't fix things generally, so use "Refs:" to refer people to GitHub issues. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are in...

X Description: Tests don't fix things generally, so use "Refs:" to refer people to GitHub issues. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or bench...

Opengraph URL: https://github.com/nodejs/node/pull/34568

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6e7ae48d-13ae-45cb-944f-a527b5e718b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB77C:1D81B0:2D0B48:3DC613:696A72A1
html-safe-nonce491dd1389c09557542dc7f3d7d065b86ac25e65d34957aeb4ba10a67d364cdc3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzdDOjFEODFCMDoyRDBCNDg6M0RDNjEzOjY5NkE3MkExIiwidmlzaXRvcl9pZCI6Ijg4OTY3MTA2MTcyMjk1ODcxMDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8c68d725bbb99b83bf67c6f501be43fca1a5ce02ae7fdccd34c88d05459494ca
hovercard-subject-tagpull_request:459494499
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34568/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/58edc42d834421cea8310c7e8539ea493428abf839d3e2d25508c20017beef9d/nodejs/node/pull/34568
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58edc42d834421cea8310c7e8539ea493428abf839d3e2d25508c20017beef9d/nodejs/node/pull/34568
og:image:altTests don't fix things generally, so use "Refs:" to refer people to GitHub issues. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are in...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34568#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34568
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34568
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34568
Reloadhttps://github.com/nodejs/node/pull/34568
Reloadhttps://github.com/nodejs/node/pull/34568
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34568
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34568
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34568#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:refshttps://github.com/Trott/io.js/tree/refs
test: change Fixes: to Refs: https://github.com/nodejs/node/pull/34568#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:refshttps://github.com/Trott/io.js/tree/refs
Conversation 3 https://github.com/nodejs/node/pull/34568
Commits 19 https://github.com/nodejs/node/pull/34568/commits
Checks 0 https://github.com/nodejs/node/pull/34568/checks
Files changed https://github.com/nodejs/node/pull/34568/files
Please reload this pagehttps://github.com/nodejs/node/pull/34568
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 30, 2020https://github.com/nodejs/node/pull/34568#issue-669077508
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34568
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jul 30, 2020https://github.com/nodejs/node/pull/34568#event-3605289170
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 30, 2020 https://github.com/nodejs/node/pull/34568#pullrequestreview-458673775
View reviewed changes https://github.com/nodejs/node/pull/34568/files
Trotthttps://github.com/Trott
July 30, 2020 12:54https://github.com/nodejs/node/pull/34568#commits-pushed-2d2a812
https://github.com/Trott
test: remove unneeded flag check in test-vm-memleakhttps://github.com/nodejs/node/pull/34568/commits/2d2a812645db794698abec602a10366e41305b98
2d2a812https://github.com/nodejs/node/pull/34568/commits/2d2a812645db794698abec602a10366e41305b98
nodejs#34528https://github.com/nodejs/node/pull/34528
https://github.com/devsnek
Revert "module: disable cjs snapshotting into esm loader"https://github.com/nodejs/node/pull/34568/commits/dc00a07426f0b2dee9bfe39c766a703eb9b5b880
dc00a07https://github.com/nodejs/node/pull/34568/commits/dc00a07426f0b2dee9bfe39c766a703eb9b5b880
1fe39f0https://github.com/Trott/io.js/commit/1fe39f0b4bad8da38e5f02542c176d5999ad3ecb
nodejs#34562https://github.com/nodejs/node/pull/34562
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34568
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 30, 2020 https://github.com/nodejs/node/pull/34568#pullrequestreview-458829495
View reviewed changes https://github.com/nodejs/node/pull/34568/files
CI Relability 2020-07-31 JaneaSystems/nodejs-reliability#54 https://github.com/JaneaSystems/nodejs-reliability/issues/54
CI Reliability 2020-07-31 nodejs/reliability#29 https://github.com/nodejs/reliability/issues/29
puzpuzpuzhttps://github.com/puzpuzpuz
July 31, 2020 14:35https://github.com/nodejs/node/pull/34568#commits-pushed-1e47051
https://github.com/puzpuzpuz
https://github.com/addaleax
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/pull/34568/commits/1e470510ff74391d7d4ec382909ea8960d2d2fbc
1e47051https://github.com/nodejs/node/pull/34568/commits/1e470510ff74391d7d4ec382909ea8960d2d2fbc
nodejs#34565https://github.com/nodejs/node/pull/34565
https://github.com/jasnell
quic: use OpenSSL built-in cert and hostname validationhttps://github.com/nodejs/node/pull/34568/commits/a97b5f9c6acd101ec20d9278a840b2cb6ef94ac9
a97b5f9https://github.com/nodejs/node/pull/34568/commits/a97b5f9c6acd101ec20d9278a840b2cb6ef94ac9
nodejs#34533https://github.com/nodejs/node/pull/34533
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 31, 2020 https://github.com/nodejs/node/pull/34568#pullrequestreview-459367880
View reviewed changes https://github.com/nodejs/node/pull/34568/files
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 31, 2020https://github.com/nodejs/node/pull/34568#event-3610150053
July 31, 2020 13:45https://github.com/nodejs/node/pull/34568#commits-pushed-0cc2a54
n-api: simplify bigint-from-word creationhttps://github.com/nodejs/node/pull/34568/commits/0cc2a54a53831968d5c955cb6cc09a2c46bd75ea
0cc2a54https://github.com/nodejs/node/pull/34568/commits/0cc2a54a53831968d5c955cb6cc09a2c46bd75ea
nodejs#34554https://github.com/nodejs/node/pull/34554
https://github.com/mmarchini
build: auto start Jenkins CI via PR labelshttps://github.com/nodejs/node/pull/34568/commits/6cab3b0e261dfaedd42ca46ee04957d4ec6d1be0
6cab3b0https://github.com/nodejs/node/pull/34568/commits/6cab3b0e261dfaedd42ca46ee04957d4ec6d1be0
nodejs/github-bot#234https://github.com/nodejs/github-bot/issues/234
nodejs#34089https://github.com/nodejs/node/pull/34089
https://github.com/mmarchini
doc: update .mailmap for mmarchinihttps://github.com/nodejs/node/pull/34568/commits/c8c2f4d0ae6162ab29ab7eabe87a409c7f836a66
c8c2f4dhttps://github.com/nodejs/node/pull/34568/commits/c8c2f4d0ae6162ab29ab7eabe87a409c7f836a66
nodejs#34586https://github.com/nodejs/node/pull/34586
https://github.com/mmarchini
doc: update mmarchini contact infohttps://github.com/nodejs/node/pull/34568/commits/f5df3c25826ad8b9d9e18b3ef449f8d40593a418
f5df3c2https://github.com/nodejs/node/pull/34568/commits/f5df3c25826ad8b9d9e18b3ef449f8d40593a418
nodejs#34586https://github.com/nodejs/node/pull/34586
https://github.com/mmarchini
doc: add mmarchini pronounshttps://github.com/nodejs/node/pull/34568/commits/8b3ad75b03ee49688ac0e9e4aa2481231fd4ff96
8b3ad75https://github.com/nodejs/node/pull/34568/commits/8b3ad75b03ee49688ac0e9e4aa2481231fd4ff96
nodejs#34586https://github.com/nodejs/node/pull/34586
CI Relability 2020-08-01 JaneaSystems/nodejs-reliability#55 https://github.com/JaneaSystems/nodejs-reliability/issues/55
CI Reliability 2020-08-01 nodejs/reliability#30 https://github.com/nodejs/reliability/issues/30
July 31, 2020 18:30https://github.com/nodejs/node/pull/34568#commits-pushed-cc7ec88
https://github.com/addaleax
n-api: support type-tagging objectshttps://github.com/nodejs/node/pull/34568/commits/cc7ec889e863433c248bc4b5c8e33f61ccc40f29
cc7ec88https://github.com/nodejs/node/pull/34568/commits/cc7ec889e863433c248bc4b5c8e33f61ccc40f29
nodejs#28164https://github.com/nodejs/node/issues/28164
nodejs#28237https://github.com/nodejs/node/pull/28237
https://github.com/Trott
doc: use consistent capitalization for addonshttps://github.com/nodejs/node/pull/34568/commits/3e9caaf5051961f640664a138297de11bb5c5c26
3e9caafhttps://github.com/nodejs/node/pull/34568/commits/3e9caaf5051961f640664a138297de11bb5c5c26
nodejs#34536https://github.com/nodejs/node/pull/34536
https://github.com/Trott
doc: simplify and clarify console.assert() documentationhttps://github.com/nodejs/node/pull/34568/commits/3b9a252dccb0ca296f18379ae8a5716d892a2cca
3b9a252https://github.com/nodejs/node/pull/34568/commits/3b9a252dccb0ca296f18379ae8a5716d892a2cca
nodejs#34544https://github.com/nodejs/node/pull/34544
https://github.com/Trott
doc: use consistent spelling for "falsy"https://github.com/nodejs/node/pull/34568/commits/770a02d3c826e81d52b10af9a7143ad33fe31487
770a02dhttps://github.com/nodejs/node/pull/34568/commits/770a02d3c826e81d52b10af9a7143ad33fe31487
nodejs#34545https://github.com/nodejs/node/pull/34545
https://github.com/ronag
http: provide keep-alive timeout response headerhttps://github.com/nodejs/node/pull/34568/commits/849d9e7b90ebaae930a28a7994b3a56ec4f280c6
849d9e7https://github.com/nodejs/node/pull/34568/commits/849d9e7b90ebaae930a28a7994b3a56ec4f280c6
nodejs#34560https://github.com/nodejs/node/issues/34560
nodejs#34561https://github.com/nodejs/node/pull/34561
https://github.com/mmarchini
build: fix auto-start-ci script pathhttps://github.com/nodejs/node/pull/34568/commits/4268c6112feaf82d7ca171c381b269ebfcf403f7
4268c61https://github.com/nodejs/node/pull/34568/commits/4268c6112feaf82d7ca171c381b269ebfcf403f7
nodejs#34588https://github.com/nodejs/node/pull/34588
https://github.com/mmarchini
build: don't run auto-start-ci on pushhttps://github.com/nodejs/node/pull/34568/commits/9b6c16c5acb4e47794fec4f2c7aa4d79fecda46d
9b6c16chttps://github.com/nodejs/node/pull/34568/commits/9b6c16c5acb4e47794fec4f2c7aa4d79fecda46d
nodejs#34588https://github.com/nodejs/node/pull/34588
https://github.com/DerekNonGeneric
https://github.com/Trott
esm: fix hook mistypes and links to typeshttps://github.com/nodejs/node/pull/34568/commits/45fa216ee533abc189d4b9bf0fc8f40430af7ef4
45fa216https://github.com/nodejs/node/pull/34568/commits/45fa216ee533abc189d4b9bf0fc8f40430af7ef4
https://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIAhttps://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIA
https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257Dhttps://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D
nodejs#34240https://github.com/nodejs/node/pull/34240
https://github.com/Trott
doc: revise N-API versions matrix texthttps://github.com/nodejs/node/pull/34568/commits/aeaf16194bac6510a48019b4b55481006f11f714
aeaf161https://github.com/nodejs/node/pull/34568/commits/aeaf16194bac6510a48019b4b55481006f11f714
nodejs#34566https://github.com/nodejs/node/pull/34566
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Aug 2, 2020https://github.com/nodejs/node/pull/34568#issuecomment-667602997
https://ci.nodejs.org/job/node-test-pull-request/32598/https://ci.nodejs.org/job/node-test-pull-request/32598/
Please reload this pagehttps://github.com/nodejs/node/pull/34568
https://github.com/Trott
test: change Fixes: to Refs:https://github.com/nodejs/node/pull/34568/commits/73d713b16e764a2b52028803e14ce4ed8343a0a5
73d713bhttps://github.com/nodejs/node/pull/34568/commits/73d713b16e764a2b52028803e14ce4ed8343a0a5
nodejs#34568https://github.com/nodejs/node/pull/34568
CI Relability 2020-08-02 JaneaSystems/nodejs-reliability#56 https://github.com/JaneaSystems/nodejs-reliability/issues/56
CI Reliability 2020-08-02 nodejs/reliability#31 https://github.com/nodejs/reliability/issues/31
https://github.com/Trott
Trotthttps://github.com/Trott
Aug 2, 2020https://github.com/nodejs/node/pull/34568#issuecomment-667606231
73d713bhttps://github.com/nodejs/node/commit/73d713b16e764a2b52028803e14ce4ed8343a0a5
Please reload this pagehttps://github.com/nodejs/node/pull/34568
https://github.com/Trott
Trotthttps://github.com/Trott
73d713bhttps://github.com/nodejs/node/commit/73d713b16e764a2b52028803e14ce4ed8343a0a5
Aug 2, 2020https://github.com/nodejs/node/pull/34568#event-3612727987
https://github.com/Trott
Trotthttps://github.com/Trott
August 2, 2020 00:43https://github.com/nodejs/node/pull/34568#event-3612728107
CI Relability 2020-08-03 JaneaSystems/nodejs-reliability#57 https://github.com/JaneaSystems/nodejs-reliability/issues/57
CI Reliability 2020-08-03 nodejs/reliability#32 https://github.com/nodejs/reliability/issues/32
CI Relability 2020-08-04 JaneaSystems/nodejs-reliability#58 https://github.com/JaneaSystems/nodejs-reliability/issues/58
CI Reliability 2020-08-04 nodejs/reliability#33 https://github.com/nodejs/reliability/issues/33
CI Relability 2020-08-05 JaneaSystems/nodejs-reliability#59 https://github.com/JaneaSystems/nodejs-reliability/issues/59
CI Reliability 2020-08-05 nodejs/reliability#34 https://github.com/nodejs/reliability/issues/34
CI Relability 2020-08-06 JaneaSystems/nodejs-reliability#60 https://github.com/JaneaSystems/nodejs-reliability/issues/60
CI Reliability 2020-08-06 nodejs/reliability#35 https://github.com/nodejs/reliability/issues/35
codebyterehttps://github.com/codebytere
Aug 6, 2020 https://github.com/nodejs/node/pull/34568#ref-commit-bd55236
https://github.com/Trott
https://github.com/codebytere
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/bd552367883136c77914e9d2a163fee75d00d102
bd55236https://github.com/nodejs/node/commit/bd552367883136c77914e9d2a163fee75d00d102
#34568https://github.com/nodejs/node/pull/34568
CI Relability 2020-08-07 JaneaSystems/nodejs-reliability#61 https://github.com/JaneaSystems/nodejs-reliability/issues/61
CI Reliability 2020-08-07 nodejs/reliability#36 https://github.com/nodejs/reliability/issues/36
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 10, 2020 https://github.com/nodejs/node/pull/34568#ref-pullrequest-675867215
v14.8.0 proposal #34704 https://github.com/nodejs/node/pull/34704
codebyterehttps://github.com/codebytere
Aug 11, 2020 https://github.com/nodejs/node/pull/34568#ref-commit-dba869e
https://github.com/Trott
https://github.com/codebytere
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/dba869ecee23e56fff8dfac69c8d9d5a47bdec18
dba869ehttps://github.com/nodejs/node/commit/dba869ecee23e56fff8dfac69c8d9d5a47bdec18
#34568https://github.com/nodejs/node/pull/34568
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34568#ref-commit-c13357d
https://github.com/Trott
https://github.com/addaleax
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/c13357d50a17274ba7cdb6f07b1117defc1569d4
c13357dhttps://github.com/nodejs/node/commit/c13357d50a17274ba7cdb6f07b1117defc1569d4
#34568https://github.com/nodejs/node/pull/34568
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34568#ref-commit-71ee488
https://github.com/Trott
https://github.com/addaleax
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/71ee48863adebc37c8733c2b32911fb47d706be6
71ee488https://github.com/nodejs/node/commit/71ee48863adebc37c8733c2b32911fb47d706be6
#34568https://github.com/nodejs/node/pull/34568
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34568#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
targoshttps://github.com/targos
May 1, 2021 https://github.com/nodejs/node/pull/34568#ref-commit-cd95bf3
https://github.com/Trott
https://github.com/targos
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/cd95bf3dd78f0aaf02c0d5dbe278ec77c245ca3f
cd95bf3https://github.com/nodejs/node/commit/cd95bf3dd78f0aaf02c0d5dbe278ec77c245ca3f
#34568https://github.com/nodejs/node/pull/34568
https://github.com/danielleadams
danielleadamshttps://github.com/danielleadams
May 3, 2021 https://github.com/nodejs/node/pull/34568#ref-pullrequest-874193529
v14.17.0 proposal #38507 https://github.com/nodejs/node/pull/38507
danielleadamshttps://github.com/danielleadams
May 8, 2021 https://github.com/nodejs/node/pull/34568#ref-commit-a67e689
https://github.com/Trott
https://github.com/danielleadams
test: change Fixes: to Refs:https://github.com/nodejs/node/commit/a67e689b1d68eabcd0045bc12cae51ac5998496e
a67e689https://github.com/nodejs/node/commit/a67e689b1d68eabcd0045bc12cae51ac5998496e
#34568https://github.com/nodejs/node/pull/34568
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34568
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34568/files/c5766da7d8ba3710279580dc27353642ab97af97
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/34568/files/c5766da7d8ba3710279580dc27353642ab97af97
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/34568/files/c5766da7d8ba3710279580dc27353642ab97af97
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Please reload this pagehttps://github.com/nodejs/node/pull/34568
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com/richardlau
https://github.com/devsnek
https://github.com/puzpuzpuz
https://github.com/mmarchini
https://github.com/ronag
https://github.com/DerekNonGeneric
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.