René's URL Explorer Experiment


Title: src: fix unused namespace member in node_util by puzpuzpuz · Pull Request #34565 · nodejs/node · GitHub

Open Graph Title: src: fix unused namespace member in node_util by puzpuzpuz · Pull Request #34565 · nodejs/node

X Title: src: fix unused namespace member in node_util by puzpuzpuz · Pull Request #34565 · nodejs/node

Description: make -j4 test currently fails with the following message: Running C++ linter... File "src/node_util.cc" does not use "MaybeLocal" Makefile:1337: recipe for target 'tools/.cpplintstamp' failed make[...

Open Graph Description: make -j4 test currently fails with the following message: Running C++ linter... File "src/node_util.cc" does not use "MaybeLocal" Makefile:1337: recipe for target 'tools/.cp...

X Description: make -j4 test currently fails with the following message: Running C++ linter... File "src/node_util.cc" does not use "MaybeLocal" Makefile:1337: recipe for targe...

Opengraph URL: https://github.com/nodejs/node/pull/34565

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c0caa2c3-4d08-1fa3-29de-3050d549cf97
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC178:2C2C4D:EF249E:14AD8E2:696A912A
html-safe-nonce930054a43405ffbe22685909b8a308774b98b3e98580b37a204a9f4a00a1db07
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTc4OjJDMkM0RDpFRjI0OUU6MTRBRDhFMjo2OTZBOTEyQSIsInZpc2l0b3JfaWQiOiI1MTYxMzYzMzA0OTAxOTM5NDk4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac70284fe09b8fac65a462eccb1a95cf48ba8ee6ec2671ca155a542459ed02a024
hovercard-subject-tagpull_request:459432315
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34565/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/97faa0cc5789b6e8476298d47ed4f3508452add8cae7410f745848bfbe49f278/nodejs/node/pull/34565
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/97faa0cc5789b6e8476298d47ed4f3508452add8cae7410f745848bfbe49f278/nodejs/node/pull/34565
og:image:altmake -j4 test currently fails with the following message: Running C++ linter... File "src/node_util.cc" does not use "MaybeLocal" Makefile:1337: recipe for target 'tools/.cp...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepuzpuzpuz
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34565#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34565
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34565
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34565
Reloadhttps://github.com/nodejs/node/pull/34565
Reloadhttps://github.com/nodejs/node/pull/34565
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34565
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34565
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34565#issue-comment-box
puzpuzpuzhttps://github.com/puzpuzpuz
nodejs:masterhttps://github.com/nodejs/node/tree/master
puzpuzpuz:cleanup/remove-unused-import-from-node-utilhttps://github.com/puzpuzpuz/node/tree/cleanup/remove-unused-import-from-node-util
src: fix unused namespace member in node_util https://github.com/nodejs/node/pull/34565#top
puzpuzpuzhttps://github.com/puzpuzpuz
nodejs:masterhttps://github.com/nodejs/node/tree/master
puzpuzpuz:cleanup/remove-unused-import-from-node-utilhttps://github.com/puzpuzpuz/node/tree/cleanup/remove-unused-import-from-node-util
Conversation 6 https://github.com/nodejs/node/pull/34565
Commits 1 https://github.com/nodejs/node/pull/34565/commits
Checks 0 https://github.com/nodejs/node/pull/34565/checks
Files changed https://github.com/nodejs/node/pull/34565/files
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issue-669008446
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/puzpuzpuz
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/pull/34565/commits/1591ad48cd49c9a06657a20560129c837f63beee
1591ad4https://github.com/nodejs/node/pull/34565/commits/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Jul 30, 2020https://github.com/nodejs/node/pull/34565#event-3605007427
https://github.com/himself65
himself65https://github.com/himself65
Jul 30, 2020 https://github.com/nodejs/node/pull/34565#pullrequestreview-458615300
View reviewed changes https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 30, 2020 https://github.com/nodejs/node/pull/34565#pullrequestreview-458646053
View reviewed changes https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issuecomment-666577644
Please reload this pagehttps://github.com/nodejs/node/pull/34565
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issuecomment-666636301
@richardlauhttps://github.com/richardlau
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issuecomment-666716472
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 30, 2020 https://github.com/nodejs/node/pull/34565#pullrequestreview-458830485
View reviewed changes https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
Jul 30, 2020https://github.com/nodejs/node/pull/34565#event-3606235738
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issuecomment-666775639
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 30, 2020https://github.com/nodejs/node/pull/34565#issuecomment-666776072
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2020https://github.com/nodejs/node/pull/34565#issuecomment-667098093
1e47051https://github.com/nodejs/node/commit/1e470510ff74391d7d4ec382909ea8960d2d2fbc
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2020https://github.com/nodejs/node/pull/34565#event-3608320466
addaleaxhttps://github.com/addaleax
Jul 31, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-1e47051
https://github.com/puzpuzpuz
https://github.com/addaleax
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/commit/1e470510ff74391d7d4ec382909ea8960d2d2fbc
1e47051https://github.com/nodejs/node/commit/1e470510ff74391d7d4ec382909ea8960d2d2fbc
#34565https://github.com/nodejs/node/pull/34565
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
July 31, 2020 12:38https://github.com/nodejs/node/pull/34565#event-3608326811
addaleaxhttps://github.com/addaleax
Jul 31, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-22c467d
https://github.com/addaleax
tools: fix C++ import checker argument expansionhttps://github.com/addaleax/node/commit/22c467d5ae4c505a2e61b6bcba644a72a8513ecc
22c467dhttps://github.com/addaleax/node/commit/22c467d5ae4c505a2e61b6bcba644a72a8513ecc
nodejs#34565https://github.com/nodejs/node/pull/34565
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 31, 2020 https://github.com/nodejs/node/pull/34565#ref-pullrequest-669967823
tools: fix C++ import checker argument expansion #34582 https://github.com/nodejs/node/pull/34582
codebyterehttps://github.com/codebytere
Aug 5, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-c1abc8d
https://github.com/puzpuzpuz
https://github.com/codebytere
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/commit/c1abc8d3e5ff8385d2a7e42a812ed2b22f4966e7
c1abc8dhttps://github.com/nodejs/node/commit/c1abc8d3e5ff8385d2a7e42a812ed2b22f4966e7
#34565https://github.com/nodejs/node/pull/34565
jasnellhttps://github.com/jasnell
Aug 7, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-bfebfdb
https://github.com/addaleax
https://github.com/jasnell
src: fix linter failureshttps://github.com/nodejs/node/commit/bfebfdb149cf2d68ceee19f207ba65e0d8357a7f
bfebfdbhttps://github.com/nodejs/node/commit/bfebfdb149cf2d68ceee19f207ba65e0d8357a7f
#34582https://github.com/nodejs/node/pull/34582
#34565https://github.com/nodejs/node/pull/34565
jasnellhttps://github.com/jasnell
Aug 7, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-318c982
https://github.com/addaleax
https://github.com/jasnell
tools: fix C++ import checker argument expansionhttps://github.com/nodejs/node/commit/318c982f3b1cd2d836de0e03ca9c9ecb634b546c
318c982https://github.com/nodejs/node/commit/318c982f3b1cd2d836de0e03ca9c9ecb634b546c
#34565https://github.com/nodejs/node/pull/34565
#34582https://github.com/nodejs/node/pull/34582
addaleaxhttps://github.com/addaleax
Aug 8, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-2dbd15a
https://github.com/addaleax
src: fix linter failureshttps://github.com/nodejs/node/commit/2dbd15a075cd4635b79aae98f8ebac5360a236de
2dbd15ahttps://github.com/nodejs/node/commit/2dbd15a075cd4635b79aae98f8ebac5360a236de
#34582https://github.com/nodejs/node/pull/34582
#34565https://github.com/nodejs/node/pull/34565
addaleaxhttps://github.com/addaleax
Aug 8, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-05100e1
https://github.com/addaleax
tools: fix C++ import checker argument expansionhttps://github.com/nodejs/node/commit/05100e1eec748e5b65463dfd003aa6e93f567408
05100e1https://github.com/nodejs/node/commit/05100e1eec748e5b65463dfd003aa6e93f567408
#34565https://github.com/nodejs/node/pull/34565
#34582https://github.com/nodejs/node/pull/34582
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 10, 2020 https://github.com/nodejs/node/pull/34565#ref-pullrequest-675867215
v14.8.0 proposal #34704 https://github.com/nodejs/node/pull/34704
codebyterehttps://github.com/codebytere
Aug 11, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-e97fe4b
https://github.com/addaleax
https://github.com/codebytere
src: fix linter failureshttps://github.com/nodejs/node/commit/e97fe4b6307023f42c0e8617718693e991e4670a
e97fe4bhttps://github.com/nodejs/node/commit/e97fe4b6307023f42c0e8617718693e991e4670a
#34582https://github.com/nodejs/node/pull/34582
#34565https://github.com/nodejs/node/pull/34565
codebyterehttps://github.com/codebytere
Aug 11, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-af0cfeb
https://github.com/addaleax
https://github.com/codebytere
tools: fix C++ import checker argument expansionhttps://github.com/nodejs/node/commit/af0cfeb1bbbe77a19ef91c3ed467f377392e9d26
af0cfebhttps://github.com/nodejs/node/commit/af0cfeb1bbbe77a19ef91c3ed467f377392e9d26
#34565https://github.com/nodejs/node/pull/34565
#34582https://github.com/nodejs/node/pull/34582
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-761c6f4
https://github.com/puzpuzpuz
https://github.com/addaleax
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/commit/761c6f4d490116c9a6c50ebe1a96e5a4d1431b50
761c6f4https://github.com/nodejs/node/commit/761c6f4d490116c9a6c50ebe1a96e5a4d1431b50
#34565https://github.com/nodejs/node/pull/34565
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34565#ref-commit-c0a961e
https://github.com/puzpuzpuz
https://github.com/addaleax
src: fix unused namespace member in node_utilhttps://github.com/nodejs/node/commit/c0a961efc72092805d0d1c396a37f47be37dfc82
c0a961ehttps://github.com/nodejs/node/commit/c0a961efc72092805d0d1c396a37f47be37dfc82
#34565https://github.com/nodejs/node/pull/34565
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34565#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34565
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
https://github.com/himself65
himself65 https://github.com/himself65
https://github.com/nodejs/node/pull/34565/files/1591ad48cd49c9a06657a20560129c837f63beee
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
fast-track https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Afast-track
util https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Autil
Please reload this pagehttps://github.com/nodejs/node/pull/34565
https://github.com/puzpuzpuz
https://github.com/richardlau
https://github.com/addaleax
https://github.com/jasnell
https://github.com/himself65
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.