René's URL Explorer Experiment


Title: benchmark: always throw the same Error instance by addaleax · Pull Request #34523 · nodejs/node · GitHub

Open Graph Title: benchmark: always throw the same Error instance by addaleax · Pull Request #34523 · nodejs/node

X Title: benchmark: always throw the same Error instance by addaleax · Pull Request #34523 · nodejs/node

Description: Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is...

Open Graph Description: Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is...

X Description: Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is...

Opengraph URL: https://github.com/nodejs/node/pull/34523

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:638c0077-71ee-3c1b-a37b-c18dc421bc8a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8F8:236F3C:3CED3E:540A65:696A7560
html-safe-nonce4b0f8c4d9040317a3f7927ea91efa66f5f4de551c3679cbc76be396f783f2f69
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEY4OjIzNkYzQzozQ0VEM0U6NTQwQTY1OjY5NkE3NTYwIiwidmlzaXRvcl9pZCI6IjcyNDI0MzAxMTU1MDc1MDAzODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfeedfde52f56098bdb7842bbf5ca1296670cf7dc98a3b15627e09988dc6df171
hovercard-subject-tagpull_request:456819342
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34523/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f394038ecd747379f7bd712508d2febe5c268281ac9dab3d35636c876b58d75b/nodejs/node/pull/34523
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f394038ecd747379f7bd712508d2febe5c268281ac9dab3d35636c876b58d75b/nodejs/node/pull/34523
og:image:altStack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34523#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34523
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34523
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34523
Reloadhttps://github.com/nodejs/node/pull/34523
Reloadhttps://github.com/nodejs/node/pull/34523
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34523
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34523
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34523#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:benchmark-async-hooks-promiseshttps://github.com/addaleax/node/tree/benchmark-async-hooks-promises
benchmark: always throw the same Error instance https://github.com/nodejs/node/pull/34523#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:benchmark-async-hooks-promiseshttps://github.com/addaleax/node/tree/benchmark-async-hooks-promises
Conversation 5 https://github.com/nodejs/node/pull/34523
Commits 1 https://github.com/nodejs/node/pull/34523/commits
Checks 0 https://github.com/nodejs/node/pull/34523/checks
Files changed 1 https://github.com/nodejs/node/pull/34523/files
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 26, 2020https://github.com/nodejs/node/pull/34523#issue-665878721
#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/addaleax
benchmark: always throw the same Error instancehttps://github.com/nodejs/node/pull/34523/commits/583f390dad4fbda24ade1beb77dfab67fef7d80f
583f390https://github.com/nodejs/node/pull/34523/commits/583f390dad4fbda24ade1beb77dfab67fef7d80f
nodejs#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Jul 26, 2020https://github.com/nodejs/node/pull/34523#event-3587494427
https://github.com/targos
targoshttps://github.com/targos
Jul 27, 2020 https://github.com/nodejs/node/pull/34523#pullrequestreview-455472929
View reviewed changes https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 27, 2020 https://github.com/nodejs/node/pull/34523#pullrequestreview-455531645
View reviewed changes https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/BridgeAR
BridgeARhttps://github.com/BridgeAR
Jul 27, 2020 https://github.com/nodejs/node/pull/34523#pullrequestreview-455664121
View reviewed changes https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 27, 2020 https://github.com/nodejs/node/pull/34523#pullrequestreview-455838025
View reviewed changes https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 27, 2020https://github.com/nodejs/node/pull/34523#issuecomment-664518762
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 27, 2020https://github.com/nodejs/node/pull/34523#issuecomment-664520733
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 27, 2020https://github.com/nodejs/node/pull/34523#issuecomment-664523649
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/Flarna
Flarnahttps://github.com/Flarna
Jul 27, 2020 https://github.com/nodejs/node/pull/34523#pullrequestreview-456114883
View reviewed changes https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 27, 2020https://github.com/nodejs/node/pull/34523#event-3591587853
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 27, 2020https://github.com/nodejs/node/pull/34523#issuecomment-664630200
https://ci.nodejs.org/job/node-test-pull-request/32518/https://ci.nodejs.org/job/node-test-pull-request/32518/
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 28, 2020 https://github.com/nodejs/node/pull/34523#ref-issue-664421942
AsyncLocalStorage kills 97% of performance in an async environment #34493 https://github.com/nodejs/node/issues/34493
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 29, 2020 https://github.com/nodejs/node/pull/34523#ref-commit-b14ce72
https://github.com/addaleax
https://github.com/puzpuzpuz
benchmark: always throw the same Error instancehttps://github.com/nodejs/node/commit/b14ce72353517d51e64e12fc3fdd5153c6951302
b14ce72https://github.com/nodejs/node/commit/b14ce72353517d51e64e12fc3fdd5153c6951302
#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
#34523https://github.com/nodejs/node/pull/34523
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 29, 2020https://github.com/nodejs/node/pull/34523#issuecomment-665502694
b14ce72https://github.com/nodejs/node/commit/b14ce72353517d51e64e12fc3fdd5153c6951302
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/puzpuzpuz
puzpuzpuzhttps://github.com/puzpuzpuz
Jul 29, 2020https://github.com/nodejs/node/pull/34523#event-3597781560
codebyterehttps://github.com/codebytere
Aug 5, 2020 https://github.com/nodejs/node/pull/34523#ref-commit-c4457d8
https://github.com/addaleax
https://github.com/codebytere
benchmark: always throw the same Error instancehttps://github.com/nodejs/node/commit/c4457d873ffa6b04c51a7e6d3cac500045ea30b3
c4457d8https://github.com/nodejs/node/commit/c4457d873ffa6b04c51a7e6d3cac500045ea30b3
#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
#34523https://github.com/nodejs/node/pull/34523
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Aug 10, 2020 https://github.com/nodejs/node/pull/34523#ref-pullrequest-675867215
v14.8.0 proposal #34704 https://github.com/nodejs/node/pull/34704
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34523#ref-commit-3e6fce4
https://github.com/addaleax
benchmark: always throw the same Error instancehttps://github.com/nodejs/node/commit/3e6fce4f330d3759d39d160c89eaf574311a3969
3e6fce4https://github.com/nodejs/node/commit/3e6fce4f330d3759d39d160c89eaf574311a3969
#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
#34523https://github.com/nodejs/node/pull/34523
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34523#ref-commit-145691b
https://github.com/addaleax
benchmark: always throw the same Error instancehttps://github.com/nodejs/node/commit/145691b83ec507564c2379fb75e962eb062b97c1
145691bhttps://github.com/nodejs/node/commit/145691b83ec507564c2379fb75e962eb062b97c1
#34512 (comment)https://github.com/nodejs/node/pull/34512#issuecomment-663977271
#34523https://github.com/nodejs/node/pull/34523
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34523#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34523
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/BridgeAR
BridgeAR https://github.com/BridgeAR
https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/Flarna
Flarna https://github.com/Flarna
https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
https://github.com/puzpuzpuz
puzpuzpuz https://github.com/puzpuzpuz
https://github.com/nodejs/node/pull/34523/files/583f390dad4fbda24ade1beb77dfab67fef7d80f
async_hooks https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aasync_hooks
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
benchmark https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abenchmark
Please reload this pagehttps://github.com/nodejs/node/pull/34523
https://github.com/addaleax
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com/puzpuzpuz
https://github.com/lpinca
https://github.com/targos
https://github.com/BridgeAR
https://github.com/Flarna
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.