René's URL Explorer Experiment


Title: src: skip weak references for memory tracking by addaleax · Pull Request #34469 · nodejs/node · GitHub

Open Graph Title: src: skip weak references for memory tracking by addaleax · Pull Request #34469 · nodejs/node

X Title: src: skip weak references for memory tracking by addaleax · Pull Request #34469 · nodejs/node

Description: The memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the heap. Weak references do not participate in that relation. Therefore, we should not be tracking them. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: The memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the h...

X Description: The memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the h...

Opengraph URL: https://github.com/nodejs/node/pull/34469

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:532db02e-7850-7ebf-c032-f0a1dfb5c21d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC28E:2E9046:1420259:1BD7606:69976E31
html-safe-nonce627bcc30ced9f5adadcb808e92c97548fc20072bea3cb81a431206e0f68441cb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMjhFOjJFOTA0NjoxNDIwMjU5OjFCRDc2MDY6Njk5NzZFMzEiLCJ2aXNpdG9yX2lkIjoiNDMxNDQ3ODUxODE1MzQ3MzU4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac31126d77bb7e3bd47105714bf3af5d7467db50b23229f1d821b2ae5cae9a155d
hovercard-subject-tagpull_request:454757000
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
twitter:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
og:image:altThe memory tracking is supposed to represent the “keeps-alive” relations between objects for a heap dump, in order to enable developers to figure out which objects keep which other objects on the h...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f6df5422af98e8455c055522f48ada1a19fab299cf47471bdd590f8b7291770
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecefaebe5dce897ac919acd478e66f59c8855d342
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34469%2Fcommits%2F9908765a30c9d93184237aa5497207700e854538
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34469%2Fcommits%2F9908765a30c9d93184237aa5497207700e854538
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Reloadhttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Reloadhttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:memory-tracker-weakhttps://github.com/addaleax/node/tree/memory-tracker-weak
Conversation 3 https://github.com/nodejs/node/pull/34469
Commits 1 https://github.com/nodejs/node/pull/34469/commits
Checks 0 https://github.com/nodejs/node/pull/34469/checks
Files changed https://github.com/nodejs/node/pull/34469/files
Please reload this pagehttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
src: skip weak references for memory tracking https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#top
Show all changes 1 commit https://github.com/nodejs/node/pull/34469/files
9908765 src: skip weak references for memory tracking addaleax Jul 21, 2020 https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Clear filters https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Please reload this pagehttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Please reload this pagehttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
Please reload this pagehttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538
https://github.com/addaleax
addaleaxhttps://github.com/nodejs/node/commits?author=addaleax
src/memory_tracker-inl.hhttps://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1
View file https://github.com/addaleax/node/blob/9908765a30c9d93184237aa5497207700e854538/src/memory_tracker-inl.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34469/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1
https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1
https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1
https://github.com/nodejs/node/pull/34469/commits/9908765a30c9d93184237aa5497207700e854538#diff-9f5555d14e8d9383061594a64b5251a87704f148821df39698f7a77075c252d1
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.