René's URL Explorer Experiment


Title: tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order by masx200 · Pull Request #34444 · nodejs/node · GitHub

Open Graph Title: tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order by masx200 · Pull Request #34444 · nodejs/node

X Title: tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order by masx200 · Pull Request #34444 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Checklist [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ x] tests and/or benchmarks are included [ x] documentation is changed or added [ x] commit message follows commit guideline...

X Description: Checklist [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ x] tests and/or benchmarks are included [ x] documentation is changed or added [ x] commit message follows commit guideline...

Opengraph URL: https://github.com/nodejs/node/pull/34444

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:40c40d57-db49-f48d-6a7c-0be49641b6f0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AB8:1B53EB:1E2A4A:28E42E:6A5271DC
html-safe-noncef15d9bc532394da146336fe525bba6a56578d54789e6deb2f201c813fceac9ae
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUI4OjFCNTNFQjoxRTJBNEE6MjhFNDJFOjZBNTI3MURDIiwidmlzaXRvcl9pZCI6IjY4NzU3MDg3ODY4MzQ4Mjk3ODkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc0fb1197cf9aeed6b5826b43dd7ce4f9601006ee965beed6a077a98cebc7792e
hovercard-subject-tagpull_request:453656136
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34444/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e9f86def7bb1aa00b4e51f2628b96a6a6d8219b56de8d95751ecb77dfc1279cd/nodejs/node/pull/34444
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e9f86def7bb1aa00b4e51f2628b96a6a6d8219b56de8d95751ecb77dfc1279cd/nodejs/node/pull/34444
og:image:altChecklist [x ] make -j4 test (UNIX), or vcbuild test (Windows) passes [ x] tests and/or benchmarks are included [ x] documentation is changed or added [ x] commit message follows commit guideline...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemasx200
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34444#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34444
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34444
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34444
Reloadhttps://github.com/nodejs/node/pull/34444
Reloadhttps://github.com/nodejs/node/pull/34444
Please reload this pagehttps://github.com/nodejs/node/pull/34444
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34444
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.2k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 986 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
masx200https://github.com/masx200
nodejs:masterhttps://github.com/nodejs/node/tree/master
Conversationhttps://github.com/nodejs/node/pull/34444
Commits7 (7)https://github.com/nodejs/node/pull/34444/commits
Checkshttps://github.com/nodejs/node/pull/34444/checks
Files changedhttps://github.com/nodejs/node/pull/34444/files
tls default SNICallback should Check the servername and select the appropriate secure context in Reverse order https://github.com/nodejs/node/pull/34444#top
masx200https://github.com/masx200
nodejs:masterhttps://github.com/nodejs/node/tree/master
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issue-662059299
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
Update _tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/9a9e2e5a7a7eb29514575b192951d3c20e92c529
9a9e2e5https://github.com/nodejs/node/pull/34444/commits/9a9e2e5a7a7eb29514575b192951d3c20e92c529
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Jul 20, 2020https://github.com/nodejs/node/pull/34444#event-3566939101
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#pullrequestreview-451810503
View reviewed changes https://github.com/nodejs/node/pull/34444/files/9a9e2e5a7a7eb29514575b192951d3c20e92c529
addaleaxhttps://github.com/addaleax
https://github.com/nodejs/node/pull/34444#pullrequestreview-451810503
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#34110https://github.com/nodejs/node/issues/34110
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661216319
@mkrawczukhttps://github.com/mkrawczuk
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
Update _tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/16e252053d83ae5dfdd141dfde48840eb1e6c8c7
16e2520https://github.com/nodejs/node/pull/34444/commits/16e252053d83ae5dfdd141dfde48840eb1e6c8c7
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661227547
Please reload this pagehttps://github.com/nodejs/node/pull/34444
#34110https://github.com/nodejs/node/issues/34110
Please reload this pagehttps://github.com/nodejs/node/pull/34444
masx200https://github.com/masx200
July 21, 2020 01:37https://github.com/nodejs/node/pull/34444#commits-pushed-206a724
https://github.com/masx200
https://github.com/nodejs/node/issues/34110https://github.com/nodejs/node/pull/34444/commits/206a72466c5a6326311acc390374e58eda964ab6
206a724https://github.com/nodejs/node/pull/34444/commits/206a72466c5a6326311acc390374e58eda964ab6
https://github.com/masx200
Update _tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/b75bdd33ece3583c3f7900da1e2c8d5248f191f1
b75bdd3https://github.com/nodejs/node/pull/34444/commits/b75bdd33ece3583c3f7900da1e2c8d5248f191f1
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661238009
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#ref-issue-659980322
How to hot update the certificate and private key of the HTTPS server without restarting the server?The old ssl/tls certificate should be deleted. nodejs/help#2859 https://github.com/nodejs/help/issues/2859
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#pullrequestreview-451828758
View reviewed changes https://github.com/nodejs/node/pull/34444/files/b75bdd33ece3583c3f7900da1e2c8d5248f191f1
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/files/b75bdd33ece3583c3f7900da1e2c8d5248f191f1#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
https://github.com/jasnell
Update lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/dfd9a31336d71e2de0845da337aa9fd2a43aa584
dfd9a31https://github.com/nodejs/node/pull/34444/commits/dfd9a31336d71e2de0845da337aa9fd2a43aa584
Reload certificate files of https.createServer() without restarting node server #15115 https://github.com/nodejs/node/issues/15115
https server should allow changing credentials dynamically #4464 https://github.com/nodejs/node/issues/4464
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#pullrequestreview-451830387
View reviewed changes https://github.com/nodejs/node/pull/34444/files/dfd9a31336d71e2de0845da337aa9fd2a43aa584
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/files/dfd9a31336d71e2de0845da337aa9fd2a43aa584#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
https://github.com/jasnell
Update lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/5549fd26ef7de87d29581a93861b07de2f89f50c
5549fd2https://github.com/nodejs/node/pull/34444/commits/5549fd26ef7de87d29581a93861b07de2f89f50c
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#pullrequestreview-451830886
View reviewed changes https://github.com/nodejs/node/pull/34444/files/dfd9a31336d71e2de0845da337aa9fd2a43aa584
lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/files/dfd9a31336d71e2de0845da337aa9fd2a43aa584#diff-358dfba23e2d09322e1b8cd21536846965c9a2bdbe6b0cbc021c0d3ceb548da8
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
https://github.com/jasnell
Update lib/_tls_wrap.jshttps://github.com/nodejs/node/pull/34444/commits/9d17cb9fcd919a9db40b63b9a6523bee33056ec9
9d17cb9https://github.com/nodejs/node/pull/34444/commits/9d17cb9fcd919a9db40b63b9a6523bee33056ec9
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661286373
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661405908
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Jul 20, 2020 https://github.com/nodejs/node/pull/34444#ref-issue-662359555
Should we add a new api, "tls.Server.prototype.removeContexts(servername)" and "tls.Server.prototype.replaceContext(servername,context)" ? #34451 https://github.com/nodejs/node/issues/34451
https://github.com/masx200
masx200https://github.com/masx200
Jul 21, 2020https://github.com/nodejs/node/pull/34444#issuecomment-661594862
#34451https://github.com/nodejs/node/issues/34451
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 22, 2020https://github.com/nodejs/node/pull/34444#issuecomment-662166056
Please reload this pagehttps://github.com/nodejs/node/pull/34444
@masx200https://github.com/masx200
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/mkrawczuk
mkrawczukhttps://github.com/mkrawczuk
Aug 5, 2020https://github.com/nodejs/node/pull/34444#issuecomment-669563234
#34110https://github.com/nodejs/node/issues/34110
#34638https://github.com/nodejs/node/pull/34638
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020https://github.com/nodejs/node/pull/34444#issuecomment-669594514
@mkrawczukhttps://github.com/mkrawczuk
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020 https://github.com/nodejs/node/pull/34444#ref-pullrequest-673892091
tls: use the most recently added matching SecureContext in default SNICallback. #34638 https://github.com/nodejs/node/pull/34638
https://github.com/masx200
masx200https://github.com/masx200
Aug 5, 2020https://github.com/nodejs/node/pull/34444#issuecomment-669601464
@mkrawczukhttps://github.com/mkrawczuk
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/aduh95
aduh95https://github.com/aduh95
Nov 8, 2020https://github.com/nodejs/node/pull/34444#issuecomment-723567142
@masx200https://github.com/masx200
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/aduh95
aduh95https://github.com/aduh95
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Nov 8, 2020https://github.com/nodejs/node/pull/34444#event-3970680128
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 8, 2020https://github.com/nodejs/node/pull/34444#issuecomment-723567183
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Nov 8, 2020https://github.com/nodejs/node/pull/34444#issuecomment-723570991
#34638https://github.com/nodejs/node/pull/34638
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
masx200https://github.com/masx200
Nov 8, 2020https://github.com/nodejs/node/pull/34444#event-3970706257
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34444
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34444/files/dfd9a31336d71e2de0845da337aa9fd2a43aa584
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34444/files/9a9e2e5a7a7eb29514575b192951d3c20e92c529
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
tls https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atls
Please reload this pagehttps://github.com/nodejs/node/pull/34444
https://github.com/masx200
https://github.com/addaleax
https://github.com/lpinca
https://github.com/rickyes
https://github.com/mkrawczuk
https://github.com/aduh95
https://github.com/jasnell
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.