René's URL Explorer Experiment


Title: build: fix test-ci-js task in Makefile by Trott · Pull Request #34433 · nodejs/node · GitHub

Open Graph Title: build: fix test-ci-js task in Makefile by Trott · Pull Request #34433 · nodejs/node

X Title: build: fix test-ci-js task in Makefile by Trott · Pull Request #34433 · nodejs/node

Description: Move benchmark CI to native suite since it requires building an addon. Refs: #34427 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gui...

Open Graph Description: Move benchmark CI to native suite since it requires building an addon. Refs: #34427 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gui...

X Description: Move benchmark CI to native suite since it requires building an addon. Refs: #34427 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gui...

Opengraph URL: https://github.com/nodejs/node/pull/34433

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5729c2bc-f7e2-d561-d0ea-191ce83c63fc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7EA:9CC2A:73CF70:A26F84:696A7229
html-safe-nonce563fb92fe209a61cd7549755444cd4dedcc5954e5cd48d49ee210b866aeade60
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0VBOjlDQzJBOjczQ0Y3MDpBMjZGODQ6Njk2QTcyMjkiLCJ2aXNpdG9yX2lkIjoiMTg1OTAwNDg0NDExODUzNjc0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1940b7ef60329a4ac3fc880883b1a1105dea5fc86d1e27c79fc7fee098f0d769
hovercard-subject-tagpull_request:452963215
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34433/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7d1eef0491d63f7a3ce39f29309e284489509e17d429706525a3bf7b1b123f62/nodejs/node/pull/34433
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d1eef0491d63f7a3ce39f29309e284489509e17d429706525a3bf7b1b123f62/nodejs/node/pull/34433
og:image:altMove benchmark CI to native suite since it requires building an addon. Refs: #34427 (comment) Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit gui...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34433#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34433
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34433
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34433
Reloadhttps://github.com/nodejs/node/pull/34433
Reloadhttps://github.com/nodejs/node/pull/34433
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34433
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34433
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34433#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-makehttps://github.com/Trott/io.js/tree/fix-make
build: fix test-ci-js task in Makefile https://github.com/nodejs/node/pull/34433#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-makehttps://github.com/Trott/io.js/tree/fix-make
Conversation 12 https://github.com/nodejs/node/pull/34433
Commits 0 https://github.com/nodejs/node/pull/34433/commits
Checks 0 https://github.com/nodejs/node/pull/34433/checks
Files changed https://github.com/nodejs/node/pull/34433/files
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 20, 2020https://github.com/nodejs/node/pull/34433#issue-661272999
Please reload this pagehttps://github.com/nodejs/node/pull/34433
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Jul 20, 2020https://github.com/nodejs/node/pull/34433#event-3563570477
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 20, 2020https://github.com/nodejs/node/pull/34433#issuecomment-660766795
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 20, 2020 https://github.com/nodejs/node/pull/34433#pullrequestreview-451276770
View reviewed changes https://github.com/nodejs/node/pull/34433/files
Makefilehttps://github.com/nodejs/node/pull/34433/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/bzoz
bzozhttps://github.com/bzoz
Jul 20, 2020https://github.com/nodejs/node/pull/34433#issuecomment-660932243
Please reload this pagehttps://github.com/nodejs/node/pull/34433
log herehttps://gist.github.com/bzoz/cedf13218bb0652e7f37bd58eae15452
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/038c641eee00101d815a3bacb069c97671dad9ae..debfdf1a6d3b5240a31e679bb8a34ded73fc9489
038c641https://github.com/nodejs/node/commit/038c641eee00101d815a3bacb069c97671dad9ae
debfdf1https://github.com/nodejs/node/commit/debfdf1a6d3b5240a31e679bb8a34ded73fc9489
Compare https://github.com/nodejs/node/compare/038c641eee00101d815a3bacb069c97671dad9ae..debfdf1a6d3b5240a31e679bb8a34ded73fc9489
July 22, 2020 01:35https://github.com/nodejs/node/pull/34433#event-3573722113
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34433
https://github.com/nodejs-github-bot
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34433
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 22, 2020 https://github.com/nodejs/node/pull/34433#pullrequestreview-453137278
View reviewed changes https://github.com/nodejs/node/pull/34433/files
Makefilehttps://github.com/nodejs/node/pull/34433/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 22, 2020https://github.com/nodejs/node/pull/34433#issuecomment-662430483
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://ci.nodejs.org/job/node-test-pull-request/32472/https://ci.nodejs.org/job/node-test-pull-request/32472/
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 22, 2020 https://github.com/nodejs/node/pull/34433#pullrequestreview-453304749
View reviewed changes https://github.com/nodejs/node/pull/34433/files
https://github.com/richardlau
richardlauhttps://github.com/richardlau
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 22, 2020https://github.com/nodejs/node/pull/34433#event-3575723911
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 22, 2020 https://github.com/nodejs/node/pull/34433#pullrequestreview-453702927
View reviewed changes https://github.com/nodejs/node/pull/34433/files
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/19a1f6158a41295f4d63674825ebcf9de99add5c..fdc4d0adafbdf5079fc5718d1057169be99f9124
19a1f61https://github.com/nodejs/node/commit/19a1f6158a41295f4d63674825ebcf9de99add5c
fdc4d0ahttps://github.com/nodejs/node/commit/fdc4d0adafbdf5079fc5718d1057169be99f9124
Compare https://github.com/nodejs/node/compare/19a1f6158a41295f4d63674825ebcf9de99add5c..fdc4d0adafbdf5079fc5718d1057169be99f9124
July 23, 2020 00:46https://github.com/nodejs/node/pull/34433#event-3578046329
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 23, 2020https://github.com/nodejs/node/pull/34433#issuecomment-662767754
https://ci.nodejs.org/job/node-test-pull-request/32481/https://ci.nodejs.org/job/node-test-pull-request/32481/
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2020https://github.com/nodejs/node/pull/34433#issuecomment-662810381
41c1e72https://github.com/nodejs/node/commit/41c1e72b761ea70b0b4b8407702d831586cba321
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 23, 2020https://github.com/nodejs/node/pull/34433#event-3578369631
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/fdc4d0adafbdf5079fc5718d1057169be99f9124..41c1e72b761ea70b0b4b8407702d831586cba321
fdc4d0ahttps://github.com/nodejs/node/commit/fdc4d0adafbdf5079fc5718d1057169be99f9124
41c1e72https://github.com/nodejs/node/commit/41c1e72b761ea70b0b4b8407702d831586cba321
Compare https://github.com/nodejs/node/compare/fdc4d0adafbdf5079fc5718d1057169be99f9124..41c1e72b761ea70b0b4b8407702d831586cba321
July 23, 2020 04:16https://github.com/nodejs/node/pull/34433#event-3578369632
https://github.com/Trott
Trotthttps://github.com/Trott
41c1e72https://github.com/nodejs/node/commit/41c1e72b761ea70b0b4b8407702d831586cba321
Jul 23, 2020https://github.com/nodejs/node/pull/34433#event-3578369763
https://github.com/Trott
Trotthttps://github.com/Trott
July 23, 2020 04:16https://github.com/nodejs/node/pull/34433#event-3578369973
ruyadornohttps://github.com/ruyadorno
Jul 28, 2020 https://github.com/nodejs/node/pull/34433#ref-commit-f91f4f6
https://github.com/Trott
https://github.com/ruyadorno
build: fix test-ci-js task in Makefilehttps://github.com/nodejs/node/commit/f91f4f6efdfede36b3da80bec8930a68738c923b
f91f4f6https://github.com/nodejs/node/commit/f91f4f6efdfede36b3da80bec8930a68738c923b
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
#34433https://github.com/nodejs/node/pull/34433
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jul 28, 2020 https://github.com/nodejs/node/pull/34433#ref-pullrequest-667312866
v14.7.0 proposal #34542 https://github.com/nodejs/node/pull/34542
ruyadornohttps://github.com/ruyadorno
Jul 28, 2020 https://github.com/nodejs/node/pull/34433#ref-commit-9814a2d
https://github.com/Trott
https://github.com/ruyadorno
build: fix test-ci-js task in Makefilehttps://github.com/nodejs/node/commit/9814a2db5c97818604d7a51928badf9a95c63395
9814a2dhttps://github.com/nodejs/node/commit/9814a2db5c97818604d7a51928badf9a95c63395
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
#34433https://github.com/nodejs/node/pull/34433
ruyadornohttps://github.com/ruyadorno
Jul 29, 2020 https://github.com/nodejs/node/pull/34433#ref-commit-358b934
https://github.com/Trott
https://github.com/ruyadorno
build: fix test-ci-js task in Makefilehttps://github.com/nodejs/node/commit/358b934284c8a8b135626cf9f44ccb0eb593541d
358b934https://github.com/nodejs/node/commit/358b934284c8a8b135626cf9f44ccb0eb593541d
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
#34433https://github.com/nodejs/node/pull/34433
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34433#ref-commit-52f790f
https://github.com/Trott
https://github.com/addaleax
build: fix test-ci-js task in Makefilehttps://github.com/nodejs/node/commit/52f790f5c8f059f1e2682e8e064e6b4b8a48b5d7
52f790fhttps://github.com/nodejs/node/commit/52f790f5c8f059f1e2682e8e064e6b4b8a48b5d7
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
#34433https://github.com/nodejs/node/pull/34433
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34433#ref-commit-e7252df
https://github.com/Trott
https://github.com/addaleax
build: fix test-ci-js task in Makefilehttps://github.com/nodejs/node/commit/e7252df0b9e163cdc437c10b103f5050c1ceaba6
e7252dfhttps://github.com/nodejs/node/commit/e7252df0b9e163cdc437c10b103f5050c1ceaba6
#34427 (comment)https://github.com/nodejs/node/issues/34427#issuecomment-660760789
#34433https://github.com/nodejs/node/pull/34433
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34433#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2022 https://github.com/nodejs/node/pull/34433#ref-issue-1082574196
pummel/test-worker-take-heapsnapshot - crash in debug mode on arm #41204 https://github.com/nodejs/node/issues/41204
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34433
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34433/files/19a1f6158a41295f4d63674825ebcf9de99add5c
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/34433/files/19a1f6158a41295f4d63674825ebcf9de99add5c
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
build https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abuild
Please reload this pagehttps://github.com/nodejs/node/pull/34433
https://github.com/Trott
https://github.com/bzoz
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/richardlau
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.