René's URL Explorer Experiment


Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node · GitHub

Open Graph Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

X Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Open Graph Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34412

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c6a48bc8-47bd-db1d-143f-b481b7b758a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95AE:E530F:20347B:2B1841:6AED0AE4
html-safe-nonce09f69e00f7d1ee2d512d678d700fd801264ff073f4a42182292c757834caaa15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUFFOkU1MzBGOjIwMzQ3QjoyQjE4NDE6NkFFRDBBRTQiLCJ2aXNpdG9yX2lkIjoiMTQzNTUwMTkzNDY3ODk2OTA2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca0c3bbf60ae79f2b663033c2d49f0d230a7c7fca260813b8d5f781311dcc23cd
hovercard-subject-tagpull_request:451217508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/34412/files
twitter:imagehttps://avatars.githubusercontent.com/u/12710227?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/12710227?s=400&v=4
og:image:altFixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonefe1176aafc8029267cb0358377ab58ce39547be3f743f36e1b549da3e6483a68
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release106bd81506ed8ed05cbd358a6a7d969bc8215167
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34412/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34412/files
Reloadhttps://github.com/nodejs/node/pull/34412/files
Reloadhttps://github.com/nodejs/node/pull/34412/files
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
preyunkhttps://github.com/preyunk
nodejs:mainhttps://github.com/nodejs/node/tree/main
preyunk:connect-pathnamehttps://github.com/preyunk/node/tree/connect-pathname
Conversation 34 https://github.com/nodejs/node/pull/34412
Commits 9 https://github.com/nodejs/node/pull/34412/commits
Checks 0 https://github.com/nodejs/node/pull/34412/checks
Files changed https://github.com/nodejs/node/pull/34412/files
Please reload this pagehttps://github.com/nodejs/node/pull/34412/files
Fixed invalid path in CONNECT method requests. https://github.com/nodejs/node/pull/34412/files#top
Show all changes 9 commits https://github.com/nodejs/node/pull/34412/files
edd8f6e http: fixed invalid path with connect method preyunk Jul 17, 2020 https://github.com/nodejs/node/pull/34412/commits/edd8f6e9989ab05d819f664a1130e51bd4970385
0825564 http: fixed invalid path with connect method preyunk Jul 17, 2020 https://github.com/nodejs/node/pull/34412/commits/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
247401a Fixed linting preyunk Jul 17, 2020 https://github.com/nodejs/node/pull/34412/commits/247401a98db089aba9521f76dfc1b7081b12bdf5
989cecd checked for undefined options.path preyunk Jul 17, 2020 https://github.com/nodejs/node/pull/34412/commits/989cecd1b3ebf0270bd8b73002b9edc315f74997
e1283be Added check for valid host:port path preyunk Jul 21, 2020 https://github.com/nodejs/node/pull/34412/commits/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
669ee65 Fixes preyunk Jul 22, 2020 https://github.com/nodejs/node/pull/34412/commits/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
c9f1597 fixes preyunk Aug 5, 2020 https://github.com/nodejs/node/pull/34412/commits/c9f15978da4dbb406be72c8379a4c76626f149a0
d8039e3 minor fixes preyunk Aug 6, 2020 https://github.com/nodejs/node/pull/34412/commits/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
9426cbb removed regex preyunk Sep 6, 2020 https://github.com/nodejs/node/pull/34412/commits/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
Clear filters https://github.com/nodejs/node/pull/34412/files
Please reload this pagehttps://github.com/nodejs/node/pull/34412/files
Please reload this pagehttps://github.com/nodejs/node/pull/34412/files
_http_client.js https://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
http.js https://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
test-http-request-connect-method.js https://github.com/nodejs/node/pull/34412/files#diff-5b1dcddba6fd1915ff6ab3051c9181aff6698407d1c45a8caf5b33c30c3ad5bb
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
View file https://github.com/preyunk/node/blob/9426cbb95d5f17b08cde5bff8cc11dc6898816f4/lib/_http_client.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34412/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
https://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
szmarczakhttps://github.com/szmarczak
Aug 6, 2020https://github.com/nodejs/node/pull/34412/files#r466336985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412/files
https://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
View file https://github.com/preyunk/node/blob/9426cbb95d5f17b08cde5bff8cc11dc6898816f4/lib/internal/http.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34412/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
https://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
https://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
test/parallel/test-http-request-connect-method.jshttps://github.com/nodejs/node/pull/34412/files#diff-5b1dcddba6fd1915ff6ab3051c9181aff6698407d1c45a8caf5b33c30c3ad5bb
View file https://github.com/preyunk/node/blob/9426cbb95d5f17b08cde5bff8cc11dc6898816f4/test/parallel/test-http-request-connect-method.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34412/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.