René's URL Explorer Experiment


Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node · GitHub

Open Graph Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

X Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34412

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:30bdbfd4-fd85-bfc8-a9ee-75e8dc99ca2f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEEC:2F339D:21ACD:2DA13:6AED02DD
html-safe-noncebf0c20b27ef53fc5a3523e2799dce0a0de44a631a7aaeaf8cae406e502c78ea0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUVDOjJGMzM5RDoyMUFDRDoyREExMzo2QUVEMDJERCIsInZpc2l0b3JfaWQiOiIxNjg0NDU3NTY2NTA3OTU5MDA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca8a72e97b2eca92f12414e46dbff04926a15c8e0553d5def92a8ee78d4e63889
hovercard-subject-tagpull_request:451217508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/34412/commits
twitter:imagehttps://opengraph.githubassets.com/f0d10f293aa47c34ca6466adcc74fa85cf6ab99a45ab9f3948c33daf7f65ac7e/nodejs/node/pull/34412
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f0d10f293aa47c34ca6466adcc74fa85cf6ab99a45ab9f3948c33daf7f65ac7e/nodejs/node/pull/34412
og:image:altFixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepreyunk
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34412/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34412/commits
Reloadhttps://github.com/nodejs/node/pull/34412/commits
Reloadhttps://github.com/nodejs/node/pull/34412/commits
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests666 (666)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
preyunkhttps://github.com/preyunk
nodejs:mainhttps://github.com/nodejs/node/tree/main
preyunk:connect-pathnamehttps://github.com/preyunk/node/tree/connect-pathname
Conversationhttps://github.com/nodejs/node/pull/34412
Commits9 (9)https://github.com/nodejs/node/pull/34412/commits
Checkshttps://github.com/nodejs/node/pull/34412/checks
Files changedhttps://github.com/nodejs/node/pull/34412/files
Fixed invalid path in CONNECT method requests.https://github.com/nodejs/node/pull/34412/commits#top
preyunkhttps://github.com/preyunk
nodejs:mainhttps://github.com/nodejs/node/tree/main
preyunk:connect-pathnamehttps://github.com/preyunk/node/tree/connect-pathname
http: fixed invalid path with connect methodhttps://github.com/nodejs/node/pull/34412/commits/edd8f6e9989ab05d819f664a1130e51bd4970385
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
edd8f6ehttps://github.com/nodejs/node/pull/34412/commits/edd8f6e9989ab05d819f664a1130e51bd4970385
https://github.com/nodejs/node/tree/edd8f6e9989ab05d819f664a1130e51bd4970385
http: fixed invalid path with connect methodhttps://github.com/nodejs/node/pull/34412/commits/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
0825564https://github.com/nodejs/node/pull/34412/commits/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
https://github.com/nodejs/node/tree/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
Fixed lintinghttps://github.com/nodejs/node/pull/34412/commits/247401a98db089aba9521f76dfc1b7081b12bdf5
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
247401ahttps://github.com/nodejs/node/pull/34412/commits/247401a98db089aba9521f76dfc1b7081b12bdf5
https://github.com/nodejs/node/tree/247401a98db089aba9521f76dfc1b7081b12bdf5
checked for undefined options.pathhttps://github.com/nodejs/node/pull/34412/commits/989cecd1b3ebf0270bd8b73002b9edc315f74997
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
989cecdhttps://github.com/nodejs/node/pull/34412/commits/989cecd1b3ebf0270bd8b73002b9edc315f74997
https://github.com/nodejs/node/tree/989cecd1b3ebf0270bd8b73002b9edc315f74997
Added check for valid host:port pathhttps://github.com/nodejs/node/pull/34412/commits/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
e1283behttps://github.com/nodejs/node/pull/34412/commits/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
https://github.com/nodejs/node/tree/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
Fixeshttps://github.com/nodejs/node/pull/34412/commits/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
669ee65https://github.com/nodejs/node/pull/34412/commits/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
https://github.com/nodejs/node/tree/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
fixeshttps://github.com/nodejs/node/pull/34412/commits/c9f15978da4dbb406be72c8379a4c76626f149a0
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
c9f1597https://github.com/nodejs/node/pull/34412/commits/c9f15978da4dbb406be72c8379a4c76626f149a0
https://github.com/nodejs/node/tree/c9f15978da4dbb406be72c8379a4c76626f149a0
minor fixeshttps://github.com/nodejs/node/pull/34412/commits/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
d8039e3https://github.com/nodejs/node/pull/34412/commits/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
https://github.com/nodejs/node/tree/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
removed regexhttps://github.com/nodejs/node/pull/34412/commits/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
https://github.com/preyunk
preyunkhttps://github.com/nodejs/node/commits?author=preyunk
9426cbbhttps://github.com/nodejs/node/pull/34412/commits/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
https://github.com/nodejs/node/tree/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.