René's URL Explorer Experiment


Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node · GitHub

Open Graph Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

X Title: Fixed invalid path in CONNECT method requests. by preyunk · Pull Request #34412 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

X Description: Fixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34412

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ab1e57ec-b2fd-4519-89ec-080d0fcd9b3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBCCE:30BEC6:42E377:5DAD29:6AED00D1
html-safe-nonceb12adb6483f3b82b53bb1919942b8b1998e51a10579f8ecd6f2013cda0bdc50e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0NFOjMwQkVDNjo0MkUzNzc6NURBRDI5OjZBRUQwMEQxIiwidmlzaXRvcl9pZCI6IjgxNTIxMjQ4MTc1NTM1NTU2NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfffad1fb76262b37ac4c71f867067b62bc2251c7f0d071b737babee0e584eb5c
hovercard-subject-tagpull_request:451217508
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34412/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f0d10f293aa47c34ca6466adcc74fa85cf6ab99a45ab9f3948c33daf7f65ac7e/nodejs/node/pull/34412
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f0d10f293aa47c34ca6466adcc74fa85cf6ab99a45ab9f3948c33daf7f65ac7e/nodejs/node/pull/34412
og:image:altFixes: #34347 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepreyunk
hostnamegithub.com
expected-hostnamegithub.com
None21e10c535436b2122cfb44c76dfb4af296e371850fb60de16776f8a64e5c3ed8
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release302a6d707c3288a5f951258a2fa3e926b8c8f8cf
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34412#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34412
Reloadhttps://github.com/nodejs/node/pull/34412
Reloadhttps://github.com/nodejs/node/pull/34412
nodejshttps://github.com/nodejs
nodehttps://github.com/nodejs/node
Codehttps://github.com/nodejs/node
Issues654 (654)https://github.com/nodejs/node/issues
Pull requests668 (668)https://github.com/nodejs/node/pulls
Actionshttps://github.com/nodejs/node/actions
Projectshttps://github.com/nodejs/node/projects
Security and qualityhttps://github.com/nodejs/node/security
Insightshttps://github.com/nodejs/node/pulse
https://github.com/nodejs/node
preyunkhttps://github.com/preyunk
nodejs:mainhttps://github.com/nodejs/node/tree/main
preyunk:connect-pathnamehttps://github.com/preyunk/node/tree/connect-pathname
Conversationhttps://github.com/nodejs/node/pull/34412
Commits9 (9)https://github.com/nodejs/node/pull/34412/commits
Checkshttps://github.com/nodejs/node/pull/34412/checks
Files changedhttps://github.com/nodejs/node/pull/34412/files
Fixed invalid path in CONNECT method requests.https://github.com/nodejs/node/pull/34412#top
preyunkhttps://github.com/preyunk
nodejs:mainhttps://github.com/nodejs/node/tree/main
preyunk:connect-pathnamehttps://github.com/preyunk/node/tree/connect-pathname
https://github.com/preyunk
preyunkhttps://github.com/preyunk
Jul 17, 2020https://github.com/nodejs/node/pull/34412#issue-659365324
Please reload this pagehttps://github.com/nodejs/node/pull/34412
#34347https://github.com/nodejs/node/issues/34347
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
Jul 17, 2020https://github.com/nodejs/node/pull/34412#event-3558723577
https://github.com/preyunk
preyunkhttps://github.com/preyunk
Jul 17, 2020https://github.com/nodejs/node/pull/34412#issuecomment-660232157
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 17, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-450998803
View reviewed changes https://github.com/nodejs/node/pull/34412/files
test/parallel/test-http-request-connect-method.jshttps://github.com/nodejs/node/pull/34412/files#diff-5b1dcddba6fd1915ff6ab3051c9181aff6698407d1c45a8caf5b33c30c3ad5bb
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Jul 18, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-451022232
View reviewed changes https://github.com/nodejs/node/pull/34412/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
szmarczakhttps://github.com/szmarczak
Jul 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r456735236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
bnoordhuishttps://github.com/bnoordhuis
Jul 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r456761605
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
preyunkhttps://github.com/preyunk
Jul 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r456831833
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@szmarczakhttps://github.com/szmarczak
Please reload this pagehttps://github.com/nodejs/node/pull/34412
preyunkhttps://github.com/preyunk
Jul 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r456832061
Please reload this pagehttps://github.com/nodejs/node/pull/34412
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/34412
bnoordhuishttps://github.com/bnoordhuis
Jul 19, 2020https://github.com/nodejs/node/pull/34412#discussion_r456845903
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/preyunk
preyunkhttps://github.com/preyunk
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
July 21, 2020 20:59https://github.com/nodejs/node/pull/34412#event-3573112276
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 21, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-452887180
View reviewed changes https://github.com/nodejs/node/pull/34412/files
doc/api/errors.mdhttps://github.com/nodejs/node/pull/34412/files#diff-25028e2a7d2f7b55d8325ef4098b431b59a49ae129b66c33a0108549a37ff0b8
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 21, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-452888510
View reviewed changes https://github.com/nodejs/node/pull/34412/files
test/parallel/test-http-request-connect-method.jshttps://github.com/nodejs/node/pull/34412/files#diff-5b1dcddba6fd1915ff6ab3051c9181aff6698407d1c45a8caf5b33c30c3ad5bb
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/preyunk
preyunkhttps://github.com/preyunk
jasnellhttps://github.com/jasnell
July 22, 2020 14:52https://github.com/nodejs/node/pull/34412#event-3576170734
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 22, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-453518872
View reviewed changes https://github.com/nodejs/node/pull/34412/files
https://github.com/preyunk
preyunkhttps://github.com/preyunk
Jul 25, 2020https://github.com/nodejs/node/pull/34412#issuecomment-663910625
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Jul 26, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-455341873
View reviewed changes https://github.com/nodejs/node/pull/34412/files
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
szmarczakhttps://github.com/szmarczak
Jul 26, 2020https://github.com/nodejs/node/pull/34412#discussion_r460494809
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
szmarczakhttps://github.com/szmarczak
Jul 26, 2020https://github.com/nodejs/node/pull/34412#discussion_r460494932
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
szmarczakhttps://github.com/szmarczak
Jul 26, 2020https://github.com/nodejs/node/pull/34412#discussion_r460495513
Please reload this pagehttps://github.com/nodejs/node/pull/34412
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
bnoordhuishttps://github.com/bnoordhuis
Jul 27, 2020https://github.com/nodejs/node/pull/34412#discussion_r460745344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
szmarczakhttps://github.com/szmarczak
Jul 28, 2020https://github.com/nodejs/node/pull/34412#discussion_r461346526
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/34412
preyunkhttps://github.com/preyunk
Jul 28, 2020https://github.com/nodejs/node/pull/34412#discussion_r461465638
Please reload this pagehttps://github.com/nodejs/node/pull/34412
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 27, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-455597989
View reviewed changes https://github.com/nodejs/node/pull/34412/files
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
bnoordhuishttps://github.com/bnoordhuis
Jul 27, 2020https://github.com/nodejs/node/pull/34412#discussion_r460745344
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
bnoordhuishttps://github.com/bnoordhuis
Jul 27, 2020https://github.com/nodejs/node/pull/34412#discussion_r460746473
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
bnoordhuishttps://github.com/bnoordhuis
Jul 27, 2020https://github.com/nodejs/node/pull/34412#discussion_r460749723
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
preyunkhttps://github.com/preyunk
August 5, 2020 20:34https://github.com/nodejs/node/pull/34412#commits-pushed-edd8f6e
https://github.com/preyunk
http: fixed invalid path with connect methodhttps://github.com/nodejs/node/pull/34412/commits/edd8f6e9989ab05d819f664a1130e51bd4970385
edd8f6ehttps://github.com/nodejs/node/pull/34412/commits/edd8f6e9989ab05d819f664a1130e51bd4970385
nodejs#34347https://github.com/nodejs/node/issues/34347
https://github.com/preyunk
http: fixed invalid path with connect methodhttps://github.com/nodejs/node/pull/34412/commits/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
0825564https://github.com/nodejs/node/pull/34412/commits/0825564bfad6669682d45bf0dc7f1d3ac2254e1f
nodejs#34347https://github.com/nodejs/node/issues/34347
https://github.com/preyunk
Fixed lintinghttps://github.com/nodejs/node/pull/34412/commits/247401a98db089aba9521f76dfc1b7081b12bdf5
247401ahttps://github.com/nodejs/node/pull/34412/commits/247401a98db089aba9521f76dfc1b7081b12bdf5
https://github.com/preyunk
checked for undefined options.pathhttps://github.com/nodejs/node/pull/34412/commits/989cecd1b3ebf0270bd8b73002b9edc315f74997
989cecdhttps://github.com/nodejs/node/pull/34412/commits/989cecd1b3ebf0270bd8b73002b9edc315f74997
https://github.com/preyunk
Added check for valid host:port pathhttps://github.com/nodejs/node/pull/34412/commits/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
e1283behttps://github.com/nodejs/node/pull/34412/commits/e1283be09dfa1064c3ccfc4dd82591c6de2bf5ba
https://github.com/preyunk
Fixeshttps://github.com/nodejs/node/pull/34412/commits/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
669ee65https://github.com/nodejs/node/pull/34412/commits/669ee6507a732b948b0e1a332c5083d5bc8fa8bb
https://github.com/preyunk
fixeshttps://github.com/nodejs/node/pull/34412/commits/c9f15978da4dbb406be72c8379a4c76626f149a0
c9f1597https://github.com/nodejs/node/pull/34412/commits/c9f15978da4dbb406be72c8379a4c76626f149a0
https://github.com/preyunk
preyunkhttps://github.com/preyunk
force-pushedhttps://github.com/nodejs/node/compare/e7d3f83ded293f74ffb7395463091f06802a56c2..c9f15978da4dbb406be72c8379a4c76626f149a0
e7d3f83https://github.com/nodejs/node/commit/e7d3f83ded293f74ffb7395463091f06802a56c2
c9f1597https://github.com/nodejs/node/commit/c9f15978da4dbb406be72c8379a4c76626f149a0
Compare https://github.com/nodejs/node/compare/e7d3f83ded293f74ffb7395463091f06802a56c2..c9f15978da4dbb406be72c8379a4c76626f149a0
August 5, 2020 15:10https://github.com/nodejs/node/pull/34412#event-3625145986
https://github.com/preyunk
preyunkhttps://github.com/preyunk
bnoordhuishttps://github.com/bnoordhuis
August 5, 2020 15:11https://github.com/nodejs/node/pull/34412#event-3625149594
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-462294079
View reviewed changes https://github.com/nodejs/node/pull/34412/files/c9f15978da4dbb406be72c8379a4c76626f149a0
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/34412#pullrequestreview-462294079
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jasnellhttps://github.com/jasnell
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files/c9f15978da4dbb406be72c8379a4c76626f149a0#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020https://github.com/nodejs/node/pull/34412#discussion_r466233274
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files/c9f15978da4dbb406be72c8379a4c76626f149a0#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020https://github.com/nodejs/node/pull/34412#discussion_r466235297
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files/c9f15978da4dbb406be72c8379a4c76626f149a0#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020https://github.com/nodejs/node/pull/34412#discussion_r466236599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files/c9f15978da4dbb406be72c8379a4c76626f149a0#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
bnoordhuishttps://github.com/bnoordhuis
Aug 6, 2020https://github.com/nodejs/node/pull/34412#discussion_r466237026
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
stale reviewhttps://github.com/nodejs/node/pull/34412#pullrequestreview-453518872
August 6, 2020 08:34https://github.com/nodejs/node/pull/34412#event-3628003236
https://github.com/preyunk
minor fixeshttps://github.com/nodejs/node/pull/34412/commits/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
d8039e3https://github.com/nodejs/node/pull/34412/commits/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
https://github.com/preyunk
preyunkhttps://github.com/preyunk
bnoordhuishttps://github.com/bnoordhuis
jasnellhttps://github.com/jasnell
August 6, 2020 10:33https://github.com/nodejs/node/pull/34412#event-3628435754
https://github.com/szmarczak
szmarczakhttps://github.com/szmarczak
Aug 6, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-462420588
View reviewed changes https://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
lib/_http_client.jshttps://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d#diff-cf533721360d04a028e31659e9b6cde7e4bd871200d13ce37d4a358be65bfd43
szmarczakhttps://github.com/szmarczak
Aug 6, 2020https://github.com/nodejs/node/pull/34412#discussion_r466336985
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/preyunk
preyunkhttps://github.com/preyunk
code ownerhttps://github.com/nodejs/node/blob/64acae2e0681ba02f99c0f2d3ee9c2058c0f7e46/.github/CODEOWNERS#L45
August 10, 2020 16:06https://github.com/nodejs/node/pull/34412#event-3639463867
https://github.com/preyunk
preyunkhttps://github.com/preyunk
Aug 16, 2020https://github.com/nodejs/node/pull/34412#issuecomment-674507605
@bnoordhuishttps://github.com/bnoordhuis
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Aug 18, 2020 https://github.com/nodejs/node/pull/34412#pullrequestreview-469574644
View reviewed changes https://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
rickyeshttps://github.com/rickyes
Aug 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r472292836
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
lib/internal/http.jshttps://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d#diff-4cac473cd84f89f39f5dc2e74299ec3bd6e55d7b4842520143cdee1f62500c8f
rickyeshttps://github.com/rickyes
Aug 18, 2020https://github.com/nodejs/node/pull/34412#discussion_r472296515
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
preyunkhttps://github.com/preyunk
Aug 19, 2020https://github.com/nodejs/node/pull/34412#discussion_r472968205
Please reload this pagehttps://github.com/nodejs/node/pull/34412
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@rickyeshttps://github.com/rickyes
Please reload this pagehttps://github.com/nodejs/node/pull/34412
rickyeshttps://github.com/rickyes
Aug 19, 2020https://github.com/nodejs/node/pull/34412#discussion_r472985643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@preyunkhttps://github.com/preyunk
https://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.mdhttps://github.com/nodejs/node/blob/master/doc/guides/writing-and-running-benchmarks.md
Please reload this pagehttps://github.com/nodejs/node/pull/34412
jasnellhttps://github.com/jasnell
Aug 19, 2020https://github.com/nodejs/node/pull/34412#discussion_r473227810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
szmarczakhttps://github.com/szmarczak
Aug 19, 2020https://github.com/nodejs/node/pull/34412#discussion_r473258943
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/preyunk
removed regexhttps://github.com/nodejs/node/pull/34412/commits/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
9426cbbhttps://github.com/nodejs/node/pull/34412/commits/9426cbb95d5f17b08cde5bff8cc11dc6898816f4
https://github.com/preyunk
preyunkhttps://github.com/preyunk
rickyeshttps://github.com/rickyes
September 6, 2020 17:38https://github.com/nodejs/node/pull/34412#event-3734278252
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
force-pushedhttps://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
dc5a5dahttps://github.com/nodejs/node/commit/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04
8e46568https://github.com/nodejs/node/commit/8e46568b1e12fe00581b1292bd6c2b01373f17bd
Compare https://github.com/nodejs/node/compare/dc5a5da4f82eba4b2e5e09a1ac827e75eddc6b04..8e46568b1e12fe00581b1292bd6c2b01373f17bd
March 29, 2021 21:33https://github.com/nodejs/node/pull/34412#event-4523995814
https://github.com/Trott
Trotthttps://github.com/Trott
force-pushedhttps://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
2d76238https://github.com/nodejs/node/commit/2d76238f9184c9009bfa395848a120ac3e5b98e5
ca3ed36https://github.com/nodejs/node/commit/ca3ed363ffefa4819c1414aff7ffca34b53a7b95
Compare https://github.com/nodejs/node/compare/2d76238f9184c9009bfa395848a120ac3e5b98e5..ca3ed363ffefa4819c1414aff7ffca34b53a7b95
November 12, 2022 01:49https://github.com/nodejs/node/pull/34412#event-7795751662
https://github.com/aduh95
aduh95https://github.com/aduh95
Sep 19, 2023https://github.com/nodejs/node/pull/34412#issuecomment-1725791758
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/aduh95
aduh95https://github.com/aduh95
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Sep 19, 2023https://github.com/nodejs/node/pull/34412#event-10411713890
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Sep 19, 2023https://github.com/nodejs/node/pull/34412#issuecomment-1725792382
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 13, 2023https://github.com/nodejs/node/pull/34412#issuecomment-1807289526
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Nov 13, 2023https://github.com/nodejs/node/pull/34412#event-10935695504
https://github.com/efekrskl
efekrsklhttps://github.com/efekrskl
Jul 31, 2026 https://github.com/nodejs/node/pull/34412#ref-pullrequest-5031548797
http: normalize CONNECT request paths #64876 https://github.com/nodejs/node/pull/64876
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34412
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/rickyes
rickyes https://github.com/rickyes
https://github.com/szmarczak
szmarczak https://github.com/szmarczak
https://github.com/nodejs/node/pull/34412/files/d8039e3036033ca77c5c07e162d8dc9fe1e6c36d
Please reload this pagehttps://github.com/nodejs/node/pull/34412
http https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ahttp
stalled https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astalled
Passing a URL instance with a CONNECT method results in an invalid path https://github.com/nodejs/node/issues/34347
Please reload this pagehttps://github.com/nodejs/node/pull/34412
https://github.com/preyunk
https://github.com/aduh95
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com/rickyes
https://github.com/szmarczak
https://github.com/nodejs-github-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.