René's URL Explorer Experiment


Title: Revert "module: fix check for package.json at volume root" by MylesBorins · Pull Request #34403 · nodejs/node · GitHub

Open Graph Title: Revert "module: fix check for package.json at volume root" by MylesBorins · Pull Request #34403 · nodejs/node

X Title: Revert "module: fix check for package.json at volume root" by MylesBorins · Pull Request #34403 · nodejs/node

Description: This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: coffeescript JSONStream gulp an...

Open Graph Description: This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: coffeescript JSONStream gulp an...

X Description: This reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: coffeescript JSONStream gulp an...

Opengraph URL: https://github.com/nodejs/node/pull/34403

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e66631ed-fb20-3a61-e737-a3c88dce8616
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8550:10252F:E41B6B:137E3C7:696A908D
html-safe-nonce5a4d253eaec61442be3cf2d371219fe4140a1fd20b9fc4361551564286aa7ba8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTUwOjEwMjUyRjpFNDFCNkI6MTM3RTNDNzo2OTZBOTA4RCIsInZpc2l0b3JfaWQiOiI0NTc0MjU2MTI3NTM1NjQ4OTA5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd323fd33ac21e8cc352acd881b35049980af67844027e223f20983413f8a4f93
hovercard-subject-tagpull_request:450533140
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34403/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c0d50752f28df0b687f9eae045ccae30f1f57224c47540ff6355472ba0cafd6/nodejs/node/pull/34403
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c0d50752f28df0b687f9eae045ccae30f1f57224c47540ff6355472ba0cafd6/nodejs/node/pull/34403
og:image:altThis reverts commit 51af89f. This has needed to be backed out of both the 14.5.0 and 14.6.0 releases due to creating regressions across multiple projects including: coffeescript JSONStream gulp an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMylesBorins
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34403#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34403
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34403
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34403
Reloadhttps://github.com/nodejs/node/pull/34403
Reloadhttps://github.com/nodejs/node/pull/34403
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34403
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34403
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34403#issue-comment-box
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:revert-33476https://github.com/MylesBorins/node/tree/revert-33476
Revert "module: fix check for package.json at volume root" https://github.com/nodejs/node/pull/34403#top
MylesBorinshttps://github.com/MylesBorins
nodejs:masterhttps://github.com/nodejs/node/tree/master
MylesBorins:revert-33476https://github.com/MylesBorins/node/tree/revert-33476
Conversation 7 https://github.com/nodejs/node/pull/34403
Commits 1 https://github.com/nodejs/node/pull/34403/commits
Checks 0 https://github.com/nodejs/node/pull/34403/checks
Files changed https://github.com/nodejs/node/pull/34403/files
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 16, 2020https://github.com/nodejs/node/pull/34403#issue-658589048
Please reload this pagehttps://github.com/nodejs/node/pull/34403
51af89fhttps://github.com/nodejs/node/commit/51af89fe453738262e2c10c831705a385ec78530
#33476https://github.com/nodejs/node/pull/33476
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/MylesBorins
Revert "module: fix check for package.json at volume root"https://github.com/nodejs/node/pull/34403/commits/50e7859b4512b3894978a742d110cdb9c4f12dbb
50e7859https://github.com/nodejs/node/pull/34403/commits/50e7859b4512b3894978a742d110cdb9c4f12dbb
51af89fhttps://github.com/MylesBorins/node/commit/51af89fe453738262e2c10c831705a385ec78530
nodejs#33476https://github.com/nodejs/node/pull/33476
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
GeoffreyBoothhttps://github.com/GeoffreyBooth
July 16, 2020 21:32https://github.com/nodejs/node/pull/34403#event-3555252813
https://github.com/richardlau
richardlauhttps://github.com/richardlau
Jul 16, 2020 https://github.com/nodejs/node/pull/34403#pullrequestreview-450251188
View reviewed changes https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/guybedford
guybedfordhttps://github.com/guybedford
Jul 17, 2020 https://github.com/nodejs/node/pull/34403#pullrequestreview-450612611
View reviewed changes https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 18, 2020 https://github.com/nodejs/node/pull/34403#pullrequestreview-451085340
View reviewed changes https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 18, 2020https://github.com/nodejs/node/pull/34403#issuecomment-660551353
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/DerekNonGeneric
DerekNonGenerichttps://github.com/DerekNonGeneric
Jul 18, 2020https://github.com/nodejs/node/pull/34403#issuecomment-660555596
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/GeoffreyBooth
GeoffreyBoothhttps://github.com/GeoffreyBooth
Jul 20, 2020https://github.com/nodejs/node/pull/34403#issuecomment-660733464
#34093 (comment)https://github.com/nodejs/node/pull/34093#issuecomment-651887986
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/trivikr
trivikrhttps://github.com/trivikr
Jul 20, 2020 https://github.com/nodejs/node/pull/34403#pullrequestreview-451274262
View reviewed changes https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/DerekNonGeneric
DerekNonGenerichttps://github.com/DerekNonGeneric
Jul 20, 2020https://github.com/nodejs/node/pull/34403#issuecomment-660798896
Please reload this pagehttps://github.com/nodejs/node/pull/34403
@GeoffreyBoothhttps://github.com/GeoffreyBooth
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2020https://github.com/nodejs/node/pull/34403#issuecomment-661061959
https://ci.nodejs.org/job/node-test-pull-request/32411/https://ci.nodejs.org/job/node-test-pull-request/32411/
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 20, 2020https://github.com/nodejs/node/pull/34403#issuecomment-661117579
https://ci.nodejs.org/job/node-test-pull-request/32414/https://ci.nodejs.org/job/node-test-pull-request/32414/
Please reload this pagehttps://github.com/nodejs/node/pull/34403
MylesBorinshttps://github.com/MylesBorins
Jul 20, 2020 https://github.com/nodejs/node/pull/34403#ref-commit-da95dd7
https://github.com/MylesBorins
Revert "module: fix check for package.json at volume root"https://github.com/nodejs/node/commit/da95dd773216a7fe7bf985014f3920893cbdf23d
da95dd7https://github.com/nodejs/node/commit/da95dd773216a7fe7bf985014f3920893cbdf23d
51af89fhttps://github.com/nodejs/node/commit/51af89fe453738262e2c10c831705a385ec78530
#33476https://github.com/nodejs/node/pull/33476
#34403https://github.com/nodejs/node/pull/34403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 20, 2020https://github.com/nodejs/node/pull/34403#issuecomment-661137071
da95dd7https://github.com/nodejs/node/commit/da95dd773216a7fe7bf985014f3920893cbdf23d
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 20, 2020https://github.com/nodejs/node/pull/34403#event-3566648103
https://github.com/targos
targoshttps://github.com/targos
dont-land-on-v10.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adont-land-on-v10.x
Jul 20, 2020https://github.com/nodejs/node/pull/34403#event-3566750412
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jul 21, 2020 https://github.com/nodejs/node/pull/34403#ref-issue-662409556
CI Relability 2020-07-21 JaneaSystems/nodejs-reliability#44 https://github.com/JaneaSystems/nodejs-reliability/issues/44
cjihrighttps://github.com/cjihrig
Jul 23, 2020 https://github.com/nodejs/node/pull/34403#ref-commit-247ce2e
https://github.com/MylesBorins
https://github.com/cjihrig
Revert "module: fix check for package.json at volume root"https://github.com/nodejs/node/commit/247ce2e996d3107ae8d35a38f141af667b7fa153
247ce2ehttps://github.com/nodejs/node/commit/247ce2e996d3107ae8d35a38f141af667b7fa153
51af89fhttps://github.com/nodejs/node/commit/51af89fe453738262e2c10c831705a385ec78530
#33476https://github.com/nodejs/node/pull/33476
#34403https://github.com/nodejs/node/pull/34403
CI Relability 2020-07-24 JaneaSystems/nodejs-reliability#47 https://github.com/JaneaSystems/nodejs-reliability/issues/47
CI Relability 2020-07-25 JaneaSystems/nodejs-reliability#48 https://github.com/JaneaSystems/nodejs-reliability/issues/48
CI Relability 2020-07-26 JaneaSystems/nodejs-reliability#49 https://github.com/JaneaSystems/nodejs-reliability/issues/49
CI Relability 2020-07-27 JaneaSystems/nodejs-reliability#50 https://github.com/JaneaSystems/nodejs-reliability/issues/50
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34403
https://github.com/GeoffreyBooth
GeoffreyBooth https://github.com/GeoffreyBooth
https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/guybedford
guybedford https://github.com/guybedford
https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/richardlau
richardlau https://github.com/richardlau
https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
https://github.com/trivikr
trivikr https://github.com/trivikr
https://github.com/nodejs/node/pull/34403/files/50e7859b4512b3894978a742d110cdb9c4f12dbb
Please reload this pagehttps://github.com/nodejs/node/pull/34403
https://github.com/MylesBorins
https://github.com/trivikr
https://github.com/DerekNonGeneric
https://github.com/GeoffreyBooth
https://github.com/nodejs-github-bot
https://github.com/guybedford
https://github.com/richardlau
https://github.com/targos
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.