| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f89507be-ef4c-be3c-e565-87a3e2e0c11e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 976C:2AB87B:525C3A:73119E:696A7629 |
| html-safe-nonce | 8bab1f46392fc5b5284a5932b6a0307366dd43c60143bcb39587d73b64c557be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NzZDOjJBQjg3Qjo1MjVDM0E6NzMxMTlFOjY5NkE3NjI5IiwidmlzaXRvcl9pZCI6Ijg1Mjc5OTQyODA1Mjc2ODkyNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 037df875d20fdd8353bab0285e9d963e3545eff33743b228e79a4f7a5d4bd357 |
| hovercard-subject-tag | pull_request:449580213 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34383/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a2787bd8ead17b0316f8799ade4ffb7a2d974c9f9de485426bb4240f77fc2520/nodejs/node/pull/34383 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a2787bd8ead17b0316f8799ade4ffb7a2d974c9f9de485426bb4240f77fc2520/nodejs/node/pull/34383 |
| og:image:alt | Fixes: #34382
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | preyunk |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34383#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34383 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34383 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34383 |
| Reload | https://github.com/nodejs/node/pull/34383 |
| Reload | https://github.com/nodejs/node/pull/34383 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34383#issue-comment-box |
| preyunk | https://github.com/preyunk |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| preyunk:add-doc-duplex | https://github.com/preyunk/node/tree/add-doc-duplex |
|
doc: add writable and readable options to Duplex docs
| https://github.com/nodejs/node/pull/34383#top |
| preyunk | https://github.com/preyunk |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| preyunk:add-doc-duplex | https://github.com/preyunk/node/tree/add-doc-duplex |
|
Conversation
5
| https://github.com/nodejs/node/pull/34383 |
|
Commits
1
| https://github.com/nodejs/node/pull/34383/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34383/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34383/files |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34383#issue-657469766 |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
|
| https://github.com/preyunk |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/pull/34383/commits/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| d2e695d | https://github.com/nodejs/node/pull/34383/commits/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| nodejs#34382 | https://github.com/nodejs/node/issues/34382 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34383#event-3549188982 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34383#issuecomment-658854091 |
| @ronag | https://github.com/ronag |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449108088 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449108735 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| ronag | https://github.com/ronag |
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449108735 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449446885 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/willin |
| willin | https://github.com/willin |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449482798 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-449521048 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/juanarbol |
| juanarbol | https://github.com/juanarbol |
|
Jul 17, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-450407234 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/antsmartian |
| antsmartian | https://github.com/antsmartian |
|
Jul 18, 2020
| https://github.com/nodejs/node/pull/34383#pullrequestreview-451027598 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34383#issuecomment-671033639 |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://ci.nodejs.org/job/node-test-pull-request/32693/ | https://ci.nodejs.org/job/node-test-pull-request/32693/ |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 9, 2020 | https://github.com/nodejs/node/pull/34383#event-3636364265 |
| rickyes | https://github.com/rickyes |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34383#ref-commit-3ddf2c9 |
|
| https://github.com/preyunk |
|
| https://github.com/rickyes |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/commit/3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a |
| 3ddf2c9 | https://github.com/nodejs/node/commit/3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| #34383 | https://github.com/nodejs/node/pull/34383 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
| Aug 10, 2020 | https://github.com/nodejs/node/pull/34383#issuecomment-671155444 |
| 3ddf2c9 | https://github.com/nodejs/node/commit/3ddf2c9c996dea6bbf0d24c632ccc85e720a9b1a |
| @preyunk | https://github.com/preyunk |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| https://github.com/rickyes |
| rickyes | https://github.com/rickyes |
| Aug 10, 2020 | https://github.com/nodejs/node/pull/34383#event-3637163080 |
| https://github.com/preyunk |
| preyunk | https://github.com/preyunk |
| Aug 10, 2020 | https://github.com/nodejs/node/pull/34383#issuecomment-671164948 |
| @rickyes | https://github.com/rickyes |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
| MylesBorins | https://github.com/MylesBorins |
|
Aug 17, 2020
| https://github.com/nodejs/node/pull/34383#ref-commit-4377690 |
|
| https://github.com/preyunk |
|
| https://github.com/MylesBorins |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/commit/437769009e840bd34b6add2540bce706505c787f |
| 4377690 | https://github.com/nodejs/node/commit/437769009e840bd34b6add2540bce706505c787f |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| #34383 | https://github.com/nodejs/node/pull/34383 |
| https://github.com/danielleadams |
| danielleadams | https://github.com/danielleadams |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34383#ref-pullrequest-682706557 |
|
V14.9.0 proposal
#34852
| https://github.com/nodejs/node/pull/34852 |
| BethGriggs | https://github.com/BethGriggs |
|
Aug 20, 2020
| https://github.com/nodejs/node/pull/34383#ref-commit-b93ba07 |
|
| https://github.com/preyunk |
|
| https://github.com/BethGriggs |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/commit/b93ba07fa5f8de228cc9775e3c068adf7f627e7e |
| b93ba07 | https://github.com/nodejs/node/commit/b93ba07fa5f8de228cc9775e3c068adf7f627e7e |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| #34383 | https://github.com/nodejs/node/pull/34383 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34383#ref-commit-2260037 |
|
| https://github.com/preyunk |
|
| https://github.com/addaleax |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/commit/2260037a4ae0bf4ab3d8f8b5b57c97d03f4f6a2a |
| 2260037 | https://github.com/nodejs/node/commit/2260037a4ae0bf4ab3d8f8b5b57c97d03f4f6a2a |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| #34383 | https://github.com/nodejs/node/pull/34383 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34383#ref-commit-0ba9052 |
|
| https://github.com/preyunk |
|
| https://github.com/addaleax |
| doc: add writable and readable options to Duplex docs | https://github.com/nodejs/node/commit/0ba9052b574494ee0ffe5527997ba0ef1d907ffc |
| 0ba9052 | https://github.com/nodejs/node/commit/0ba9052b574494ee0ffe5527997ba0ef1d907ffc |
| #34382 | https://github.com/nodejs/node/issues/34382 |
| #34383 | https://github.com/nodejs/node/pull/34383 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34383#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34383 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/juanarbol |
|
juanarbol
| https://github.com/juanarbol |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/antsmartian |
|
antsmartian
| https://github.com/antsmartian |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/willin |
|
willin
| https://github.com/willin |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
| https://github.com/rickyes |
|
rickyes
| https://github.com/rickyes |
|
| https://github.com/nodejs/node/pull/34383/files/d2e695dba389f5c5a8db9940d8bda94c305c93c2 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
add 'writable' and 'readable' to 'new stream.Duplex(options)' docs.
| https://github.com/nodejs/node/issues/34382 |
| Please reload this page | https://github.com/nodejs/node/pull/34383 |
|
| https://github.com/preyunk |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/rickyes |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/antsmartian |
|
| https://github.com/willin |
|
| https://github.com/ronag |
|
| https://github.com/juanarbol |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |