| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d1cef6d5-307f-9dba-569d-1127efb8e3ed |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E9B8:166D49:13061F0:1A3F5E3:696A9116 |
| html-safe-nonce | 8df36f11329e73728cfdeb467b0cb66b2ba7b476a96dec83ee1ac89b218675cb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUI4OjE2NkQ0OToxMzA2MUYwOjFBM0Y1RTM6Njk2QTkxMTYiLCJ2aXNpdG9yX2lkIjoiNTI2OTUwNzQzMzIwNDE5MTUxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fa794f6ce4b250fc19ef9ee6820651a49d86f3e9f366294b30c72b6c4a866a14 |
| hovercard-subject-tag | pull_request:449227511 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34375/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/48ad6fb5c2e75d5b2deefd4a8b5008e8bb1f2fea5303b72c41bc3a04d72c0d99/nodejs/node/pull/34375 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/48ad6fb5c2e75d5b2deefd4a8b5008e8bb1f2fea5303b72c41bc3a04d72c0d99/nodejs/node/pull/34375 |
| og:image:alt | CallJSOnreadMethod expects the return value to be undefined or
a new buffer, so make sure to return nothing, even when an error
causes us to destroy the stream.
Fixes: #34346
Checklist
make -j4 t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | robey |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 31496a13b80a2f6ad77d6c617ee2255a3545b539 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34375#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34375 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34375 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34375 |
| Reload | https://github.com/nodejs/node/pull/34375 |
| Reload | https://github.com/nodejs/node/pull/34375 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34375#issue-comment-box |
| robey | https://github.com/robey |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
net/streams: don't return the stream object from onStreamRead
| https://github.com/nodejs/node/pull/34375#top |
| robey | https://github.com/robey |
| nodejs:master | https://github.com/nodejs/node/tree/master |
|
Conversation
37
| https://github.com/nodejs/node/pull/34375 |
|
Commits
10
| https://github.com/nodejs/node/pull/34375/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34375/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34375/files |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34375#issue-657040078 |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-658680580 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-658863874 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-449153777 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-658892042 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-449267004 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| ronag | https://github.com/ronag |
| https://github.com/nodejs/node/pull/34375#pullrequestreview-449267004 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/nodejs/node/pull/34375/files#diff-704db381d3305bdcd2c6b8b3468acfb7R230 | https://github.com/nodejs/node/pull/34375/files#diff-704db381d3305bdcd2c6b8b3468acfb7R230 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| July 18, 2020 00:22 | https://github.com/nodejs/node/pull/34375#event-3560286046 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 18, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660391128 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 18, 2020 | https://github.com/nodejs/node/pull/34375#event-3560287903 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 18, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660439723 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 18, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660520959 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
| Jul 18, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660541544 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 18, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451081972 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| lib/internal/stream_base_commons.js | https://github.com/nodejs/node/pull/34375/files#diff-55e49d067e487da5dffc29a2cd42b82572c563784f91ae8af4fe04d0d442b227 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| lib/internal/stream_base_commons.js | https://github.com/nodejs/node/pull/34375/files#diff-55e49d067e487da5dffc29a2cd42b82572c563784f91ae8af4fe04d0d442b227 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 18, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451087670 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451087670 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 19, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660565535 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 19, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-660568793 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/mcollina |
| mcollina | https://github.com/mcollina |
|
Jul 19, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451108440 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| mcollina | https://github.com/mcollina |
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451108440 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/robey |
| robey | https://github.com/robey |
| ronag | https://github.com/ronag |
| July 20, 2020 18:21 | https://github.com/nodejs/node/pull/34375#event-3567210680 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 20, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451853538 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 20, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451854605 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| addaleax | https://github.com/addaleax |
| https://github.com/nodejs/node/pull/34375#pullrequestreview-451854605 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 20, 2020 | https://github.com/nodejs/node/pull/34375#event-3567233430 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 20, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-661258388 |
| https://ci.nodejs.org/job/node-test-pull-request/32426/ | https://ci.nodejs.org/job/node-test-pull-request/32426/ |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 21, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-662056694 |
| https://ci.nodejs.org/job/node-test-pull-request/32451/ | https://ci.nodejs.org/job/node-test-pull-request/32451/ |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
| Jul 23, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-663042003 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 23, 2020 | https://github.com/nodejs/node/pull/34375#event-3580278396 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Jul 23, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-663157266 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Jul 23, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-663174990 |
| @robey | https://github.com/robey |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/ronag |
| ronag | https://github.com/ronag |
|
Jul 23, 2020
| https://github.com/nodejs/node/pull/34375#pullrequestreview-454410738 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34375/files |
| src/stream_base.cc | https://github.com/nodejs/node/pull/34375/files#diff-8aa3ffa0df16e1ec3bcedb6c8af59c612201517302d738cd2f40263f1eb39a19 |
| ronag | https://github.com/ronag |
| Jul 23, 2020 | https://github.com/nodejs/node/pull/34375#discussion_r459661167 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| robey | https://github.com/robey |
| Jul 24, 2020 | https://github.com/nodejs/node/pull/34375#discussion_r459878011 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
|
| https://github.com/robey |
| streams: don't return the stream object from onStreamRead | https://github.com/nodejs/node/pull/34375/commits/0865a22cf01d7d8ced3f13bbcd3ee2e97e400935 |
| 0865a22 | https://github.com/nodejs/node/pull/34375/commits/0865a22cf01d7d8ced3f13bbcd3ee2e97e400935 |
| #34346 | https://github.com/nodejs/node/issues/34346 |
|
CI Relability 2020-08-01
JaneaSystems/nodejs-reliability#55
| https://github.com/JaneaSystems/nodejs-reliability/issues/55 |
|
CI Reliability 2020-08-01
nodejs/reliability#30
| https://github.com/nodejs/reliability/issues/30 |
|
CI Relability 2020-08-02
JaneaSystems/nodejs-reliability#56
| https://github.com/JaneaSystems/nodejs-reliability/issues/56 |
|
CI Reliability 2020-08-02
nodejs/reliability#31
| https://github.com/nodejs/reliability/issues/31 |
|
CI Relability 2020-08-03
JaneaSystems/nodejs-reliability#57
| https://github.com/JaneaSystems/nodejs-reliability/issues/57 |
|
CI Reliability 2020-08-03
nodejs/reliability#32
| https://github.com/nodejs/reliability/issues/32 |
|
CI Relability 2020-08-04
JaneaSystems/nodejs-reliability#58
| https://github.com/JaneaSystems/nodejs-reliability/issues/58 |
|
CI Reliability 2020-08-04
nodejs/reliability#33
| https://github.com/nodejs/reliability/issues/33 |
|
CI Relability 2020-08-05
JaneaSystems/nodejs-reliability#59
| https://github.com/JaneaSystems/nodejs-reliability/issues/59 |
|
CI Reliability 2020-08-05
nodejs/reliability#34
| https://github.com/nodejs/reliability/issues/34 |
|
CI Relability 2020-08-06
JaneaSystems/nodejs-reliability#60
| https://github.com/JaneaSystems/nodejs-reliability/issues/60 |
|
CI Reliability 2020-08-06
nodejs/reliability#35
| https://github.com/nodejs/reliability/issues/35 |
|
CI Relability 2020-08-07
JaneaSystems/nodejs-reliability#61
| https://github.com/JaneaSystems/nodejs-reliability/issues/61 |
|
CI Reliability 2020-08-07
nodejs/reliability#36
| https://github.com/nodejs/reliability/issues/36 |
| https://github.com/robey |
| robey | https://github.com/robey |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-670670101 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-670672478 |
| https://ci.nodejs.org/job/node-test-pull-request/32675/ | https://ci.nodejs.org/job/node-test-pull-request/32675/ |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-670686895 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Aug 7, 2020 | https://github.com/nodejs/node/pull/34375#event-3634572992 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 8, 2020 | https://github.com/nodejs/node/pull/34375#issuecomment-670968458 |
| c0be31f | https://github.com/nodejs/node/commit/c0be31f0efd162f0edd416ed23f5aac082edd2aa |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
| Aug 8, 2020 | https://github.com/nodejs/node/pull/34375#event-3635947868 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2020
| https://github.com/nodejs/node/pull/34375#ref-commit-c0be31f |
|
| https://github.com/robey |
|
| https://github.com/addaleax |
| net: don't return the stream object from onStreamRead | https://github.com/nodejs/node/commit/c0be31f0efd162f0edd416ed23f5aac082edd2aa |
| c0be31f | https://github.com/nodejs/node/commit/c0be31f0efd162f0edd416ed23f5aac082edd2aa |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| #34375 | https://github.com/nodejs/node/pull/34375 |
| addaleax | https://github.com/addaleax |
|
Aug 8, 2020
| https://github.com/nodejs/node/pull/34375#ref-commit-b1890e0 |
|
| https://github.com/robey |
|
| https://github.com/addaleax |
| net: don't return the stream object from onStreamRead | https://github.com/nodejs/node/commit/b1890e0866ce20ebd0c07d74d1379b1dad61438f |
| b1890e0 | https://github.com/nodejs/node/commit/b1890e0866ce20ebd0c07d74d1379b1dad61438f |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| #34375 | https://github.com/nodejs/node/pull/34375 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34375#ref-pullrequest-675867215 |
|
v14.8.0 proposal
#34704
| https://github.com/nodejs/node/pull/34704 |
| codebytere | https://github.com/codebytere |
|
Aug 11, 2020
| https://github.com/nodejs/node/pull/34375#ref-commit-7887ce2 |
|
| https://github.com/robey |
|
| https://github.com/codebytere |
| net: don't return the stream object from onStreamRead | https://github.com/nodejs/node/commit/7887ce2a7891f27dbcbbdc0538890771a2546cf3 |
| 7887ce2 | https://github.com/nodejs/node/commit/7887ce2a7891f27dbcbbdc0538890771a2546cf3 |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| #34375 | https://github.com/nodejs/node/pull/34375 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34375#ref-commit-4bafe69 |
|
| https://github.com/robey |
|
| https://github.com/addaleax |
| net: don't return the stream object from onStreamRead | https://github.com/nodejs/node/commit/4bafe69bdd4eeb7a7783323bc5109d7f0cad0cb3 |
| 4bafe69 | https://github.com/nodejs/node/commit/4bafe69bdd4eeb7a7783323bc5109d7f0cad0cb3 |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| #34375 | https://github.com/nodejs/node/pull/34375 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34375#ref-commit-09056fd |
|
| https://github.com/robey |
|
| https://github.com/addaleax |
| net: don't return the stream object from onStreamRead | https://github.com/nodejs/node/commit/09056fdf3826e4fbfc237b31936b29fb89641ae5 |
| 09056fd | https://github.com/nodejs/node/commit/09056fdf3826e4fbfc237b31936b29fb89641ae5 |
| #34346 | https://github.com/nodejs/node/issues/34346 |
| #34375 | https://github.com/nodejs/node/pull/34375 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34375#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| https://github.com/apps/github-actions |
| github-actions | https://github.com/apps/github-actions |
|
Apr 24, 2024
| https://github.com/nodejs/node/pull/34375#ref-pullrequest-2262279643 |
|
Adding VersionStream for nodejs-22
wolfi-dev/os#17646
| https://github.com/wolfi-dev/os/pull/17646 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34375 |
|
| https://github.com/ronag |
|
ronag
| https://github.com/ronag |
|
| https://github.com/nodejs/node/pull/34375/files/c0a41cfdfd108dd1f8b4c38e73b7af3ccc1fc883 |
|
| https://github.com/mcollina |
|
mcollina
| https://github.com/mcollina |
|
| https://github.com/nodejs/node/pull/34375/files/c0a41cfdfd108dd1f8b4c38e73b7af3ccc1fc883 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34375/files/c0a41cfdfd108dd1f8b4c38e73b7af3ccc1fc883 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34375/files/8b6ec77ff2ada7ddbf2f43f2776bcc79a9aa6242 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
net
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anet |
|
stream
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream |
|
crash in node_buffer.cc on ECONNRESET when using net.Socket onread
| https://github.com/nodejs/node/issues/34346 |
| Please reload this page | https://github.com/nodejs/node/pull/34375 |
|
| https://github.com/robey |
|
| https://github.com/lpinca |
|
| https://github.com/mcollina |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/jasnell |
|
| https://github.com/ronag |
|
| https://github.com/addaleax |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |