René's URL Explorer Experiment


Title: repl: event ordering: delay 'close' until 'flushHistory' by Fishrock123 · Pull Request #3435 · nodejs/node · GitHub

Open Graph Title: repl: event ordering: delay 'close' until 'flushHistory' by Fishrock123 · Pull Request #3435 · nodejs/node

X Title: repl: event ordering: delay 'close' until 'flushHistory' by Fishrock123 · Pull Request #3435 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: Emitting close before the history has flushed is somewhat incorrect and rather confusing. Fixes an issue related to #2356 Separate PR since I'm going to try to make #2356 work without it, but w...

X Description: Emitting close before the history has flushed is somewhat incorrect and rather confusing. Fixes an issue related to #2356 Separate PR since I'm going to try to make #2356 work without it, b...

Opengraph URL: https://github.com/nodejs/node/pull/3435

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1eeb7f59-5efc-90cb-cbf0-4e409d093b87
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9BBC:6435C:2D8E87F:3E6F5FE:6A4F0C98
html-safe-nonce8540a927948421cf80047fb3eff37c0cadac96d1e30faddf981eaa2562a3de85
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkJDOjY0MzVDOjJEOEU4N0Y6M0U2RjVGRTo2QTRGMEM5OCIsInZpc2l0b3JfaWQiOiIyNzExMjg1Nzg0ODQ1OTQ2MDA4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca81583f195bb6b573633b19fd7aeb3abf7bede0363d3dc92fc9aec76b899bb8f
hovercard-subject-tagpull_request:48084317
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/3435/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/860be69fbf8639859581b7a5873d3337ec47fed2497d522b406ca3ffa265dc0d/nodejs/node/pull/3435
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/860be69fbf8639859581b7a5873d3337ec47fed2497d522b406ca3ffa265dc0d/nodejs/node/pull/3435
og:image:altEmitting close before the history has flushed is somewhat incorrect and rather confusing. Fixes an issue related to #2356 Separate PR since I'm going to try to make #2356 work without it, but w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFishrock123
hostnamegithub.com
expected-hostnamegithub.com
Noneb92d11c0aa4a77d54ef4af1078b6a15fb5a70a215b30c4ecf28889d5a8e656d9
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b8f23afb982271f1b22258a94aede67a6b77760
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/3435#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3435
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3435
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/3435
Reloadhttps://github.com/nodejs/node/pull/3435
Reloadhttps://github.com/nodejs/node/pull/3435
Please reload this pagehttps://github.com/nodejs/node/pull/3435
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/3435
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.3k https://github.com/nodejs/node/issues
Pull requests 966 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:repl-close-after-flushhttps://github.com/Fishrock123/node/tree/repl-close-after-flush
Conversationhttps://github.com/nodejs/node/pull/3435
Commits1 (1)https://github.com/nodejs/node/pull/3435/commits
Checkshttps://github.com/nodejs/node/pull/3435/checks
Files changedhttps://github.com/nodejs/node/pull/3435/files
repl: event ordering: delay 'close' until 'flushHistory'https://github.com/nodejs/node/pull/3435#top
Fishrock123https://github.com/Fishrock123
nodejs:masterhttps://github.com/nodejs/node/tree/master
Fishrock123:repl-close-after-flushhttps://github.com/Fishrock123/node/tree/repl-close-after-flush
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 19, 2015https://github.com/nodejs/node/pull/3435#issue-112165306
#2356https://github.com/nodejs/node/pull/2356
#2356https://github.com/nodejs/node/pull/2356
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
Oct 19, 2015https://github.com/nodejs/node/pull/3435#event-439242685
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
5.0.0https://github.com/nodejs/node/milestone/12
Oct 19, 2015https://github.com/nodejs/node/pull/3435#event-439242691
Fishrock123https://github.com/Fishrock123
Oct 19, 2015 https://github.com/nodejs/node/pull/3435#discussion-diff-42389631
View reviewed changes https://github.com/nodejs/node/pull/3435/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
lib/repl.jshttps://github.com/nodejs/node/pull/3435/files#diff-392b628f0a5eb047b1117351e6eedcefb8ec70a48933479e0e9bdc711a04f047
Fishrock123https://github.com/Fishrock123
Oct 19, 2015https://github.com/nodejs/node/pull/3435#discussion_r42389631
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3435
evanlucashttps://github.com/evanlucas
Oct 19, 2015https://github.com/nodejs/node/pull/3435#discussion_r42398988
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 19, 2015https://github.com/nodejs/node/pull/3435#issuecomment-149296016
https://ci.nodejs.org/job/node-test-commit/878/https://ci.nodejs.org/job/node-test-commit/878/
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 19, 2015https://github.com/nodejs/node/pull/3435#issuecomment-149299716
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 21, 2015 https://github.com/nodejs/node/pull/3435#ref-issue-111805617
v5.0.0 Planning & Checklist #3397 https://github.com/nodejs/node/issues/3397
https://github.com/evanlucas
evanlucashttps://github.com/evanlucas
Oct 21, 2015https://github.com/nodejs/node/pull/3435#issuecomment-149861995
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
Oct 21, 2015https://github.com/nodejs/node/pull/3435#issuecomment-149896048
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/trevnorris
trevnorrishttps://github.com/trevnorris
Oct 21, 2015https://github.com/nodejs/node/pull/3435#issuecomment-150042163
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/1f69c51144a6c03f6fb159940a2dbf0c34557a17..5539b5e81cf80b71f1ccda201dc877f68b96a413
1f69c51https://github.com/nodejs/node/commit/1f69c51144a6c03f6fb159940a2dbf0c34557a17
5539b5ehttps://github.com/nodejs/node/commit/5539b5e81cf80b71f1ccda201dc877f68b96a413
Compare https://github.com/nodejs/node/compare/1f69c51144a6c03f6fb159940a2dbf0c34557a17..5539b5e81cf80b71f1ccda201dc877f68b96a413
October 22, 2015 17:37https://github.com/nodejs/node/pull/3435#event-442920623
https://github.com/Fishrock123
repl: event ordering: delay 'close' until 'flushHistory'https://github.com/nodejs/node/pull/3435/commits/ecab7a6bee6857a07855bcbf749c75c68502ab49
ecab7a6https://github.com/nodejs/node/pull/3435/commits/ecab7a6bee6857a07855bcbf749c75c68502ab49
nodejs#2356https://github.com/nodejs/node/pull/2356
nodejs#3435https://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
force-pushedhttps://github.com/nodejs/node/compare/5539b5e81cf80b71f1ccda201dc877f68b96a413..ecab7a6bee6857a07855bcbf749c75c68502ab49
5539b5ehttps://github.com/nodejs/node/commit/5539b5e81cf80b71f1ccda201dc877f68b96a413
ecab7a6https://github.com/nodejs/node/commit/ecab7a6bee6857a07855bcbf749c75c68502ab49
Compare https://github.com/nodejs/node/compare/5539b5e81cf80b71f1ccda201dc877f68b96a413..ecab7a6bee6857a07855bcbf749c75c68502ab49
October 22, 2015 17:39https://github.com/nodejs/node/pull/3435#event-442922255
https://github.com/Fishrock123
Fishrock123https://github.com/Fishrock123
ecab7a6https://github.com/nodejs/node/commit/ecab7a6bee6857a07855bcbf749c75c68502ab49
Oct 22, 2015https://github.com/nodejs/node/pull/3435#event-442923076
Fishrock123https://github.com/Fishrock123
Oct 22, 2015 https://github.com/nodejs/node/pull/3435#ref-commit-ce391ed
https://github.com/Fishrock123
https://github.com/rvagg
repl: event ordering: delay 'close' until 'flushHistory'https://github.com/nodejs/node/commit/ce391ed849514692cfd3e15a07b5876f3275dd70
ce391edhttps://github.com/nodejs/node/commit/ce391ed849514692cfd3e15a07b5876f3275dd70
#2356https://github.com/nodejs/node/pull/2356
#3435https://github.com/nodejs/node/pull/3435
https://github.com/rvagg
rvagghttps://github.com/rvagg
Oct 27, 2015 https://github.com/nodejs/node/pull/3435#ref-pullrequest-112505386
Release proposal: v5.0.0 #3466 https://github.com/nodejs/node/pull/3466
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Nov 28, 2023 https://github.com/nodejs/node/pull/3435#ref-pullrequest-2015152314
[Snyk] Fix for 6 vulnerabilities leonardoadame/node#185 https://github.com/leonardoadame/node/pull/185
https://github.com/aliscco
alisccohttps://github.com/aliscco
Nov 28, 2023 https://github.com/nodejs/node/pull/3435#ref-pullrequest-2015478073
[Snyk] Fix for 5 vulnerabilities aliscco/alisco-node#694 https://github.com/aliscco/alisco-node/pull/694
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Nov 29, 2023 https://github.com/nodejs/node/pull/3435#ref-pullrequest-2015561950
[Snyk] Fix for 6 vulnerabilities leonardoadame/node#210 https://github.com/leonardoadame/node/pull/210
[Snyk] Fix for 4 vulnerabilities aliscco/alisco-node#714 https://github.com/aliscco/alisco-node/pull/714
[Snyk] Fix for 5 vulnerabilities aliscco/alisco-node#732 https://github.com/aliscco/alisco-node/pull/732
https://github.com/leonardoadame
leonardoadamehttps://github.com/leonardoadame
Nov 29, 2023 https://github.com/nodejs/node/pull/3435#ref-pullrequest-2017572614
[Snyk] Fix for 5 vulnerabilities leonardoadame/node#263 https://github.com/leonardoadame/node/pull/263
[Snyk] Fix for 14 vulnerabilities aliscco/alisco-node#776 https://github.com/aliscco/alisco-node/pull/776
[Snyk] Fix for 6 vulnerabilities aliscco/alisco-node#1023 https://github.com/aliscco/alisco-node/pull/1023
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F3435
repl https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Arepl
semver-major https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Asemver-major
5.0.0 https://github.com/nodejs/node/milestone/12
Please reload this pagehttps://github.com/nodejs/node/pull/3435
https://github.com/Fishrock123
https://github.com/evanlucas
https://github.com/trevnorris
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.