| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:40aa65c4-6db4-c8b9-a5ba-6393731f9c1e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D76E:297F82:1C064A2:267FB80:696ABA24 |
| html-safe-nonce | 02570abe57ad15e675ebbe6c5d14cf28af9b2d11a957e44169789e37319876f1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzZFOjI5N0Y4MjoxQzA2NEEyOjI2N0ZCODA6Njk2QUJBMjQiLCJ2aXNpdG9yX2lkIjoiODk3MzkyODYzNTk0ODUxMzgyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 41cd1847a76eae2963eb3a1779b3e7b988727ca68d61036cd42c886d81cf3c48 |
| hovercard-subject-tag | pull_request:448481508 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34344/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9b37e99ecc5e39cfb6a08ab1e96febb458d31ea0177252848ebe3df5e2b70e4b/nodejs/node/pull/34344 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b37e99ecc5e39cfb6a08ab1e96febb458d31ea0177252848ebe3df5e2b70e4b/nodejs/node/pull/34344 |
| og:image:alt | Refs: nodejs/node-addon-api#760
Clarify which version of 8.x in which N-API version 1
matches the shape in later versions like 10.x
Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com
Checklis... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhdawson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 30300f30bb3949de255e84a146706a3bdb5c19c9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34344#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34344 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34344 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34344 |
| Reload | https://github.com/nodejs/node/pull/34344 |
| Reload | https://github.com/nodejs/node/pull/34344 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
693
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34344#issue-comment-box |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:napi-version1 | https://github.com/mhdawson/io.js/tree/napi-version1 |
|
doc: clarify N-API version 1
| https://github.com/nodejs/node/pull/34344#top |
| mhdawson | https://github.com/mhdawson |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| mhdawson:napi-version1 | https://github.com/mhdawson/io.js/tree/napi-version1 |
|
Conversation
24
| https://github.com/nodejs/node/pull/34344 |
|
Commits
9
| https://github.com/nodejs/node/pull/34344/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34344/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34344/files |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 13, 2020 | https://github.com/nodejs/node/pull/34344#issue-656128852 |
| nodejs/node-addon-api#760 | https://github.com/nodejs/node-addon-api/issues/760 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
| doc: clarify N-API version 1 | https://github.com/nodejs/node/pull/34344/commits/71c7a512efc37f807230ed64993cc39dd65ee1d7 |
| 71c7a51 | https://github.com/nodejs/node/pull/34344/commits/71c7a512efc37f807230ed64993cc39dd65ee1d7 |
| nodejs/node-addon-api#760 | https://github.com/nodejs/node-addon-api/issues/760 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Jul 13, 2020 | https://github.com/nodejs/node/pull/34344#event-3541243428 |
|
| https://github.com/mhdawson |
| squash: fixup formatting of note | https://github.com/nodejs/node/pull/34344/commits/6904325d7d59041128087813466f75b0ee5915c5 |
| 6904325 | https://github.com/nodejs/node/pull/34344/commits/6904325d7d59041128087813466f75b0ee5915c5 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-447615088 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.com/devsnek |
| devsnek | https://github.com/devsnek |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-447619927 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-448400364 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
|
| https://github.com/addaleax |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/9455cdc3bd3d57e020428b388012a9aa7da27d9f |
| 9455cdc | https://github.com/nodejs/node/pull/34344/commits/9455cdc3bd3d57e020428b388012a9aa7da27d9f |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-450265024 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/9455cdc3bd3d57e020428b388012a9aa7da27d9f |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/9455cdc3bd3d57e020428b388012a9aa7da27d9f#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/4bc4c139ffeb9c47072f4cc200db6377ea0a9c39 |
| 4bc4c13 | https://github.com/nodejs/node/pull/34344/commits/4bc4c139ffeb9c47072f4cc200db6377ea0a9c39 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-450268326 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/4bc4c139ffeb9c47072f4cc200db6377ea0a9c39 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/4bc4c139ffeb9c47072f4cc200db6377ea0a9c39#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/6713a61f5bf7d2ac556a120dde1bd119fa54c8a9 |
| 6713a61 | https://github.com/nodejs/node/pull/34344/commits/6713a61f5bf7d2ac556a120dde1bd119fa54c8a9 |
| https://github.com/nodejs |
| nodejs | https://github.com/nodejs |
| Trott | https://github.com/Trott |
| Jul 20, 2020 | https://github.com/nodejs/node/pull/34344#event-3567920049 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 20, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-451972335 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/6713a61f5bf7d2ac556a120dde1bd119fa54c8a9 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/6713a61f5bf7d2ac556a120dde1bd119fa54c8a9#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/7d81104651037e5db8a5a0e03dfbb7c3a602c17f |
| 7d81104 | https://github.com/nodejs/node/pull/34344/commits/7d81104651037e5db8a5a0e03dfbb7c3a602c17f |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 20, 2020 | https://github.com/nodejs/node/pull/34344#issuecomment-661343704 |
| @Trott | https://github.com/Trott |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 21, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-452620880 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/7d81104651037e5db8a5a0e03dfbb7c3a602c17f |
| gabrielschulhof | https://github.com/gabrielschulhof |
| https://github.com/nodejs/node/pull/34344#pullrequestreview-452620880 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/7d81104651037e5db8a5a0e03dfbb7c3a602c17f#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/7d81104651037e5db8a5a0e03dfbb7c3a602c17f#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| gabrielschulhof | https://github.com/gabrielschulhof |
| Jul 21, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r458228463 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 21, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r458357483 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 21, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r458359241 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @gabrielschulhof | https://github.com/gabrielschulhof |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| devsnek | https://github.com/devsnek |
| Jul 21, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r458379329 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459010666 |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459015672 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459016307 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459018336 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| devsnek | https://github.com/devsnek |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459018793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#discussion_r459019243 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
|
| https://github.com/gabrielschulhof |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/c9ad6f169e19e60b4bd5bea4935039674800a5ec |
| c9ad6f1 | https://github.com/nodejs/node/pull/34344/commits/c9ad6f169e19e60b4bd5bea4935039674800a5ec |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jul 22, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-453603857 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/c9ad6f169e19e60b4bd5bea4935039674800a5ec |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/c9ad6f169e19e60b4bd5bea4935039674800a5ec#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/127f15335696578d31677fcc45998f4c599c0c4b |
| 127f153 | https://github.com/nodejs/node/pull/34344/commits/127f15335696578d31677fcc45998f4c599c0c4b |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 22, 2020 | https://github.com/nodejs/node/pull/34344#issuecomment-662632546 |
| @gabrielf | https://github.com/gabrielf |
| @devsnek | https://github.com/devsnek |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Jul 28, 2020
| https://github.com/nodejs/node/pull/34344#pullrequestreview-456215712 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34344/files/127f15335696578d31677fcc45998f4c599c0c4b |
| doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/files/127f15335696578d31677fcc45998f4c599c0c4b#diff-26709ee1f9f0cb60d2d67f45106b31de8ed5eb28ad66c91903fd935a6d607d4d |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.com/mmarchini |
| mmarchini | https://github.com/mmarchini |
|
Jul 28, 2020
| https://github.com/nodejs/node/pull/34344#ref-pullrequest-644656585 |
|
meta: add N-API to codeowners coverage
#34039
| https://github.com/nodejs/node/pull/34039 |
| https://github.com/NickNaso |
| NickNaso | https://github.com/NickNaso |
|
Jul 28, 2020
| https://github.com/nodejs/node/pull/34344#ref-issue-666635819 |
|
napi_throw_error function syntax in Node v8.2.1 and below is different from N-API V1 docs
nodejs/node-addon-api#778
| https://github.com/nodejs/node-addon-api/issues/778 |
|
| https://github.com/mhdawson |
|
| https://github.com/gabrielschulhof |
| Update doc/api/n-api.md | https://github.com/nodejs/node/pull/34344/commits/2ece38b05f2f440c93ca39d3bf663708eec557e3 |
| 2ece38b | https://github.com/nodejs/node/pull/34344/commits/2ece38b05f2f440c93ca39d3bf663708eec557e3 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 29, 2020 | https://github.com/nodejs/node/pull/34344#event-3601100804 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 29, 2020 | https://github.com/nodejs/node/pull/34344#issuecomment-665959382 |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| mhdawson | https://github.com/mhdawson |
|
Jul 29, 2020
| https://github.com/nodejs/node/pull/34344#ref-commit-15333ad |
|
| https://github.com/mhdawson |
| doc: clarify N-API version 1 | https://github.com/nodejs/node/commit/15333ad552b3e81cc325f31c9920ea7bbb07be0c |
| 15333ad | https://github.com/nodejs/node/commit/15333ad552b3e81cc325f31c9920ea7bbb07be0c |
| nodejs/node-addon-api#760 | https://github.com/nodejs/node-addon-api/issues/760 |
| #34344 | https://github.com/nodejs/node/pull/34344 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 29, 2020 | https://github.com/nodejs/node/pull/34344#issuecomment-665962842 |
| 15333ad | https://github.com/nodejs/node/commit/15333ad552b3e81cc325f31c9920ea7bbb07be0c |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
| Jul 29, 2020 | https://github.com/nodejs/node/pull/34344#event-3601131868 |
| https://github.com/gabrielschulhof |
| gabrielschulhof | https://github.com/gabrielschulhof |
|
Aug 3, 2020
| https://github.com/nodejs/node/pull/34344#ref-issue-651703336 |
|
errors from node-addon-api on node 8.0.0
nodejs/node-addon-api#760
| https://github.com/nodejs/node-addon-api/issues/760 |
| codebytere | https://github.com/codebytere |
|
Aug 5, 2020
| https://github.com/nodejs/node/pull/34344#ref-commit-e2bea73 |
|
| https://github.com/mhdawson |
|
| https://github.com/codebytere |
| doc: clarify N-API version 1 | https://github.com/nodejs/node/commit/e2bea73b0362a95fcf1679eb6e2dfe605bf328ef |
| e2bea73 | https://github.com/nodejs/node/commit/e2bea73b0362a95fcf1679eb6e2dfe605bf328ef |
| nodejs/node-addon-api#760 | https://github.com/nodejs/node-addon-api/issues/760 |
| #34344 | https://github.com/nodejs/node/pull/34344 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Aug 10, 2020
| https://github.com/nodejs/node/pull/34344#ref-pullrequest-675867215 |
|
v14.8.0 proposal
#34704
| https://github.com/nodejs/node/pull/34704 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34344 |
|
| https://github.com/Trott |
|
Trott
| https://github.com/Trott |
|
| https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34344/files/6904325d7d59041128087813466f75b0ee5915c5 |
|
| https://github.com/gabrielschulhof |
|
gabrielschulhof
| https://github.com/gabrielschulhof |
|
| https://github.com/nodejs/node/pull/34344/files/127f15335696578d31677fcc45998f4c599c0c4b |
|
| https://github.com/devsnek |
|
devsnek
| https://github.com/devsnek |
|
| https://github.com/nodejs/node/pull/34344/files/c9ad6f169e19e60b4bd5bea4935039674800a5ec |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
doc
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Adoc |
|
node-api
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Anode-api |
| Please reload this page | https://github.com/nodejs/node/pull/34344 |
|
| https://github.com/mhdawson |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
|
| https://github.com/gabrielschulhof |
|
| https://github.com/devsnek |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |