René's URL Explorer Experiment


Title: stream: Rename opts to options by rickyes · Pull Request #34339 · nodejs/node · GitHub

Open Graph Title: stream: Rename opts to options by rickyes · Pull Request #34339 · nodejs/node

X Title: stream: Rename opts to options by rickyes · Pull Request #34339 · nodejs/node

Description: Node.js JavaScript runtime ✨🐢🚀✨. Contribute to nodejs/node development by creating an account on GitHub.

Open Graph Description: As described in the documentation , the signature should be options. Refs: https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback Checklist make...

X Description: As described in the documentation , the signature should be options. Refs: https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback Checklist make...

Opengraph URL: https://github.com/nodejs/node/pull/34339

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:399a567e-459b-4d58-8cab-4bd3f3c0034c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC140:93CC4:2727E6A:37C774F:6A51050F
html-safe-nonce76b61f6643a6b1c2eb13b7f78c2be95eb92cfe5eb19a6382ceefce9726fb504d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTQwOjkzQ0M0OjI3MjdFNkE6MzdDNzc0Rjo2QTUxMDUwRiIsInZpc2l0b3JfaWQiOiI4MDMwMTEwOTY4NTMxOTc3NDg3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac50d5c4a36a9b3d5f0711722acbf2b49b95b488471e2d3fea815ba549f4d78098
hovercard-subject-tagpull_request:448344562
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34339/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bbd8982d7055a370a80a4ff18aaa5823409f83a7d60679fab5da296da91f77c3/nodejs/node/pull/34339
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bbd8982d7055a370a80a4ff18aaa5823409f83a7d60679fab5da296da91f77c3/nodejs/node/pull/34339
og:image:altAs described in the documentation , the signature should be options. Refs: https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback Checklist make...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerickyes
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-cache
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34339#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34339
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34339
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34339
Reloadhttps://github.com/nodejs/node/pull/34339
Reloadhttps://github.com/nodejs/node/pull/34339
Please reload this pagehttps://github.com/nodejs/node/pull/34339
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34339
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 36.1k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 118k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.4k https://github.com/nodejs/node/issues
Pull requests 980 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security and quality https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
rickyeshttps://github.com/rickyes
nodejs:masterhttps://github.com/nodejs/node/tree/master
rickyes:rename-stream-finished-signaturehttps://github.com/rickyes/node/tree/rename-stream-finished-signature
Conversationhttps://github.com/nodejs/node/pull/34339
Commits1 (1)https://github.com/nodejs/node/pull/34339/commits
Checkshttps://github.com/nodejs/node/pull/34339/checks
Files changedhttps://github.com/nodejs/node/pull/34339/files
stream: Rename opts to optionshttps://github.com/nodejs/node/pull/34339#top
rickyeshttps://github.com/rickyes
nodejs:masterhttps://github.com/nodejs/node/tree/master
rickyes:rename-stream-finished-signaturehttps://github.com/rickyes/node/tree/rename-stream-finished-signature
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 13, 2020https://github.com/nodejs/node/pull/34339#issue-655960801
https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callbackhttps://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/rickyes
stream: Rename opts to optionshttps://github.com/nodejs/node/pull/34339/commits/151db8b82e4299c3f1bc86f4509eeb04dd39e609
151db8bhttps://github.com/nodejs/node/pull/34339/commits/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/sxa
sxahttps://github.com/sxa
force-pushedhttps://github.com/nodejs/node/compare/74bc061bbc1380388935e9d380c8b29252dfc4b2..63a856fba9aa931a59c8e6fb6487ac9741e258db
74bc061https://github.com/nodejs/node/commit/74bc061bbc1380388935e9d380c8b29252dfc4b2
63a856fhttps://github.com/nodejs/node/commit/63a856fba9aa931a59c8e6fb6487ac9741e258db
Compare https://github.com/nodejs/node/compare/74bc061bbc1380388935e9d380c8b29252dfc4b2..63a856fba9aa931a59c8e6fb6487ac9741e258db
July 13, 2020 15:56https://github.com/nodejs/node/pull/34339#event-3540206080
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 13, 2020https://github.com/nodejs/node/pull/34339#issuecomment-657647037
@ronaghttps://github.com/ronag
@mcollinahttps://github.com/mcollina
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 13, 2020 https://github.com/nodejs/node/pull/34339#pullrequestreview-447420797
View reviewed changes https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 14, 2020https://github.com/nodejs/node/pull/34339#issuecomment-657986072
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/mcollina
mcollinahttps://github.com/mcollina
Jul 14, 2020 https://github.com/nodejs/node/pull/34339#pullrequestreview-447814880
View reviewed changes https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
mcollinahttps://github.com/mcollina
https://github.com/nodejs/node/pull/34339#pullrequestreview-447814880
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/targos
targoshttps://github.com/targos
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Jul 14, 2020https://github.com/nodejs/node/pull/34339#event-3542629080
https://github.com/targos
targoshttps://github.com/targos
Jul 14, 2020 https://github.com/nodejs/node/pull/34339#pullrequestreview-447815449
View reviewed changes https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/rickyes
rickyeshttps://github.com/rickyes
Jul 14, 2020https://github.com/nodejs/node/pull/34339#issuecomment-658126971
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/ronag
ronaghttps://github.com/ronag
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 14, 2020https://github.com/nodejs/node/pull/34339#event-3543749458
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 14, 2020https://github.com/nodejs/node/pull/34339#issuecomment-658128830
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://ci.nodejs.org/job/node-test-pull-request/32329/https://ci.nodejs.org/job/node-test-pull-request/32329/
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 14, 2020 https://github.com/nodejs/node/pull/34339#pullrequestreview-448167090
View reviewed changes https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
addaleaxhttps://github.com/addaleax
Jul 15, 2020 https://github.com/nodejs/node/pull/34339#ref-commit-48404a1
https://github.com/rickyes
https://github.com/addaleax
stream: rename opts to optionshttps://github.com/nodejs/node/commit/48404a179fa91adb14c13af38dfd4b28852db208
48404a1https://github.com/nodejs/node/commit/48404a179fa91adb14c13af38dfd4b28852db208
#34339https://github.com/nodejs/node/pull/34339
https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callbackhttps://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 15, 2020https://github.com/nodejs/node/pull/34339#issuecomment-659047296
48404a1https://github.com/nodejs/node/commit/48404a179fa91adb14c13af38dfd4b28852db208
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 15, 2020https://github.com/nodejs/node/pull/34339#event-3550601690
https://github.com/rickyes
rickyeshttps://github.com/rickyes
July 16, 2020 01:50https://github.com/nodejs/node/pull/34339#event-3551004683
cjihrighttps://github.com/cjihrig
Jul 23, 2020 https://github.com/nodejs/node/pull/34339#ref-commit-e7b56f3
https://github.com/rickyes
https://github.com/cjihrig
stream: rename opts to optionshttps://github.com/nodejs/node/commit/e7b56f387dec8485dd2b51f49eca20a1f1802bd0
e7b56f3https://github.com/nodejs/node/commit/e7b56f387dec8485dd2b51f49eca20a1f1802bd0
#34339https://github.com/nodejs/node/pull/34339
https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callbackhttps://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback
MylesBorinshttps://github.com/MylesBorins
Jul 27, 2020 https://github.com/nodejs/node/pull/34339#ref-commit-3d4f608
https://github.com/rickyes
https://github.com/MylesBorins
stream: rename opts to optionshttps://github.com/nodejs/node/commit/3d4f608e42788ddb73eb861f255575b6801c01d8
3d4f608https://github.com/nodejs/node/commit/3d4f608e42788ddb73eb861f255575b6801c01d8
#34339https://github.com/nodejs/node/pull/34339
https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callbackhttps://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jul 28, 2020 https://github.com/nodejs/node/pull/34339#ref-pullrequest-667312866
v14.7.0 proposal #34542 https://github.com/nodejs/node/pull/34542
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Nov 2, 2020https://github.com/nodejs/node/pull/34339#issuecomment-720790784
Please reload this pagehttps://github.com/nodejs/node/pull/34339
#31527https://github.com/nodejs/node/pull/31527
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/codebytere
codebyterehttps://github.com/codebytere
backport-blocked-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Abackport-blocked-v12.x
Nov 2, 2020https://github.com/nodejs/node/pull/34339#event-3950551584
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2022 https://github.com/nodejs/node/pull/34339#ref-issue-1082574196
pummel/test-worker-take-heapsnapshot - crash in debug mode on arm #41204 https://github.com/nodejs/node/issues/41204
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34339
https://github.com/mcollina
mcollina https://github.com/mcollina
https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/34339/files/151db8b82e4299c3f1bc86f4509eeb04dd39e609
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
stream https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Astream
Please reload this pagehttps://github.com/nodejs/node/pull/34339
https://github.com/rickyes
https://github.com/nodejs-github-bot
https://github.com/addaleax
https://github.com/codebytere
https://github.com/mcollina
https://github.com/jasnell
https://github.com/targos
https://github.com/ronag
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.