René's URL Explorer Experiment


Title: src: avoid strcmp in SecureContext::Init by tniessen · Pull Request #34329 · nodejs/node · GitHub

Open Graph Title: src: avoid strcmp in SecureContext::Init by tniessen · Pull Request #34329 · nodejs/node

X Title: src: avoid strcmp in SecureContext::Init by tniessen · Pull Request #34329 · nodejs/node

Description: This change uses std::string::operator== instead of strcmp, and de-duplicates some code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: This change uses std::string::operator== instead of strcmp, and de-duplicates some code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: This change uses std::string::operator== instead of strcmp, and de-duplicates some code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34329

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d662b8b2-e3ad-52e6-b405-db6d7de5c7cd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DAA:338071:705A49:9D2D6E:696A725B
html-safe-noncefba7e2f5ec70848d1300430253859550455a3d5a64b9bdedf89104493b03f67b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4REFBOjMzODA3MTo3MDVBNDk6OUQyRDZFOjY5NkE3MjVCIiwidmlzaXRvcl9pZCI6IjM2MDc0ODQ0MzI1OTIzMDI2ODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca414bf21c3f068f8bb9bc6bc25ffd8c318193e504927da24913f152b3ac8b744
hovercard-subject-tagpull_request:447973051
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34329/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7a7408d867f1b5547bcadfabaa3acfeb3baebd9a4c5915528eefe683f5e4ffbb/nodejs/node/pull/34329
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a7408d867f1b5547bcadfabaa3acfeb3baebd9a4c5915528eefe683f5e4ffbb/nodejs/node/pull/34329
og:image:altThis change uses std::string::operator== instead of strcmp, and de-duplicates some code. Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametniessen
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34329#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34329
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34329
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34329
Reloadhttps://github.com/nodejs/node/pull/34329
Reloadhttps://github.com/nodejs/node/pull/34329
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34329
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34329
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34329#issue-comment-box
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:src-avoid-strcmp-in-securecontext-inithttps://github.com/tniessen/node/tree/src-avoid-strcmp-in-securecontext-init
src: avoid strcmp in SecureContext::Init https://github.com/nodejs/node/pull/34329#top
tniessenhttps://github.com/tniessen
nodejs:masterhttps://github.com/nodejs/node/tree/master
tniessen:src-avoid-strcmp-in-securecontext-inithttps://github.com/tniessen/node/tree/src-avoid-strcmp-in-securecontext-init
Conversation 9 https://github.com/nodejs/node/pull/34329
Commits 3 https://github.com/nodejs/node/pull/34329/commits
Checks 0 https://github.com/nodejs/node/pull/34329/checks
Files changed https://github.com/nodejs/node/pull/34329/files
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 12, 2020https://github.com/nodejs/node/pull/34329#issue-655502092
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/pull/34329/commits/9c5d55fbadefe9290f715e121bb2b35a92c19731
9c5d55fhttps://github.com/nodejs/node/pull/34329/commits/9c5d55fbadefe9290f715e121bb2b35a92c19731
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Jul 12, 2020https://github.com/nodejs/node/pull/34329#event-3537549981
https://github.com/yashLadha
yashLadhahttps://github.com/yashLadha
Jul 13, 2020https://github.com/nodejs/node/pull/34329#issuecomment-657365077
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/yashLadha
yashLadhahttps://github.com/yashLadha
Jul 13, 2020 https://github.com/nodejs/node/pull/34329#pullrequestreview-446988049
View reviewed changes https://github.com/nodejs/node/pull/34329/files/9c5d55fbadefe9290f715e121bb2b35a92c19731
src/node_crypto.cchttps://github.com/nodejs/node/pull/34329/files/9c5d55fbadefe9290f715e121bb2b35a92c19731#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
yashLadhahttps://github.com/yashLadha
Jul 13, 2020https://github.com/nodejs/node/pull/34329#discussion_r453440888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 13, 2020https://github.com/nodejs/node/pull/34329#issuecomment-657492538
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 13, 2020 https://github.com/nodejs/node/pull/34329#pullrequestreview-447179746
View reviewed changes https://github.com/nodejs/node/pull/34329/files/9c5d55fbadefe9290f715e121bb2b35a92c19731
src/node_crypto.cchttps://github.com/nodejs/node/pull/34329/files/9c5d55fbadefe9290f715e121bb2b35a92c19731#diff-fbb424b0c726f25a6ab1100125b7e97a96142f900c0c328805905f39004e0e8e
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
fixup! src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/pull/34329/commits/24487c90cac5fdcb4336be02e0d70442b2ca0db2
24487c9https://github.com/nodejs/node/pull/34329/commits/24487c90cac5fdcb4336be02e0d70442b2ca0db2
https://github.com/bnoordhuis
bnoordhuishttps://github.com/bnoordhuis
Jul 14, 2020 https://github.com/nodejs/node/pull/34329#pullrequestreview-447867400
View reviewed changes https://github.com/nodejs/node/pull/34329/files/24487c90cac5fdcb4336be02e0d70442b2ca0db2
bnoordhuishttps://github.com/bnoordhuis
https://github.com/nodejs/node/pull/34329#pullrequestreview-447867400
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 14, 2020 https://github.com/nodejs/node/pull/34329#pullrequestreview-448152281
View reviewed changes https://github.com/nodejs/node/pull/34329/files/24487c90cac5fdcb4336be02e0d70442b2ca0db2
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2020https://github.com/nodejs/node/pull/34329#issuecomment-660304181
https://ci.nodejs.org/job/node-test-pull-request/32394/https://ci.nodejs.org/job/node-test-pull-request/32394/
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 17, 2020https://github.com/nodejs/node/pull/34329#event-3559629254
https://github.com/tniessen
fixup! src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/pull/34329/commits/c6cf437d03dd7d6a2c1a05cc3a6b6d9d0ba4c464
c6cf437https://github.com/nodejs/node/pull/34329/commits/c6cf437d03dd7d6a2c1a05cc3a6b6d9d0ba4c464
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 17, 2020https://github.com/nodejs/node/pull/34329#issuecomment-660323368
https://ci.nodejs.org/job/node-test-pull-request/32396/https://ci.nodejs.org/job/node-test-pull-request/32396/
Please reload this pagehttps://github.com/nodejs/node/pull/34329
tniessenhttps://github.com/tniessen
Jul 19, 2020 https://github.com/nodejs/node/pull/34329#ref-commit-efd1667
https://github.com/tniessen
src: avoid strcmp in SecureContext::Inithttps://github.com/tniessen/node/commit/efd16672185e85611d995eec36474eaf1fed39cc
efd1667https://github.com/tniessen/node/commit/efd16672185e85611d995eec36474eaf1fed39cc
nodejs#34329https://github.com/nodejs/node/pull/34329
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 19, 2020https://github.com/nodejs/node/pull/34329#issuecomment-660623473
efd1667https://github.com/nodejs/node/commit/efd16672185e85611d995eec36474eaf1fed39cc
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
tniessenhttps://github.com/tniessen
Jul 19, 2020https://github.com/nodejs/node/pull/34329#event-3562392274
https://github.com/tniessen
tniessenhttps://github.com/tniessen
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 19, 2020https://github.com/nodejs/node/pull/34329#event-3562394343
cjihrighttps://github.com/cjihrig
Jul 23, 2020 https://github.com/nodejs/node/pull/34329#ref-commit-5d5036d
https://github.com/tniessen
https://github.com/cjihrig
src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/commit/5d5036d0584c755663d91fa0474d9d9d529f5ac0
5d5036dhttps://github.com/nodejs/node/commit/5d5036d0584c755663d91fa0474d9d9d529f5ac0
#34329https://github.com/nodejs/node/pull/34329
MylesBorinshttps://github.com/MylesBorins
Jul 27, 2020 https://github.com/nodejs/node/pull/34329#ref-commit-9d40af5
https://github.com/tniessen
https://github.com/MylesBorins
src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/commit/9d40af54a6e6ff5228a18d8601cb5ad4f3dd7899
9d40af5https://github.com/nodejs/node/commit/9d40af54a6e6ff5228a18d8601cb5ad4f3dd7899
#34329https://github.com/nodejs/node/pull/34329
https://github.com/ruyadorno
ruyadornohttps://github.com/ruyadorno
Jul 28, 2020 https://github.com/nodejs/node/pull/34329#ref-pullrequest-667312866
v14.7.0 proposal #34542 https://github.com/nodejs/node/pull/34542
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34329#ref-commit-c5b6c69
https://github.com/tniessen
https://github.com/addaleax
src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/commit/c5b6c69374673e0aae6ce521e39339ae71156d54
c5b6c69https://github.com/nodejs/node/commit/c5b6c69374673e0aae6ce521e39339ae71156d54
#34329https://github.com/nodejs/node/pull/34329
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34329#ref-commit-5a16a67
https://github.com/tniessen
https://github.com/addaleax
src: avoid strcmp in SecureContext::Inithttps://github.com/nodejs/node/commit/5a16a671eff6c85d6da542abd7b708a74f8db030
5a16a67https://github.com/nodejs/node/commit/5a16a671eff6c85d6da542abd7b708a74f8db030
#34329https://github.com/nodejs/node/pull/34329
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34329#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/mhdawson
mhdawsonhttps://github.com/mhdawson
Jan 18, 2022 https://github.com/nodejs/node/pull/34329#ref-issue-1082574196
pummel/test-worker-take-heapsnapshot - crash in debug mode on arm #41204 https://github.com/nodejs/node/issues/41204
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34329
https://github.com/bnoordhuis
bnoordhuis https://github.com/bnoordhuis
https://github.com/nodejs/node/pull/34329/files/24487c90cac5fdcb4336be02e0d70442b2ca0db2
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34329/files/24487c90cac5fdcb4336be02e0d70442b2ca0db2
https://github.com/yashLadha
yashLadha https://github.com/yashLadha
https://github.com/nodejs/node/pull/34329/files/9c5d55fbadefe9290f715e121bb2b35a92c19731
c++ https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B
crypto https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto
Please reload this pagehttps://github.com/nodejs/node/pull/34329
https://github.com/tniessen
https://github.com/yashLadha
https://github.com/nodejs-github-bot
https://github.com/bnoordhuis
https://github.com/jasnell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.