| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca61d5f4-d1b1-e41a-02a3-348476217ea1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9AB0:15DFF5:45088E:6092D0:696A7637 |
| html-safe-nonce | 783ae216e4b898a8ab7a9bf8d85cb2af81bf3f7f360efb95e93d4b640f626353 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUIwOjE1REZGNTo0NTA4OEU6NjA5MkQwOjY5NkE3NjM3IiwidmlzaXRvcl9pZCI6IjgxNTk1MDgwNDY2OTg2NzM3MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | a255d53695f91530b100b36cbedf7fde0bd9ac0960655205138b9845273b6ebb |
| hovercard-subject-tag | pull_request:447964074 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34327/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/bc72f59f86b5c8fb93d32a67ad7efc54d69187f748565654a8f3194725934ee3/nodejs/node/pull/34327 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bc72f59f86b5c8fb93d32a67ad7efc54d69187f748565654a8f3194725934ee3/nodejs/node/pull/34327 |
| og:image:alt | Replace 'exit' check with common.mustCall().
Checklist
make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Trott |
| hostname | github.com |
| expected-hostname | github.com |
| None | cfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a0b6893c221f98f607598e939299fdf5763435d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34327#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34327 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34327 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34327 |
| Reload | https://github.com/nodejs/node/pull/34327 |
| Reload | https://github.com/nodejs/node/pull/34327 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34327#issue-comment-box |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:mustcall-pummel | https://github.com/Trott/io.js/tree/mustcall-pummel |
|
test: use mustCall() in pummel test
| https://github.com/nodejs/node/pull/34327#top |
| Trott | https://github.com/Trott |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| Trott:mustcall-pummel | https://github.com/Trott/io.js/tree/mustcall-pummel |
|
Conversation
3
| https://github.com/nodejs/node/pull/34327 |
|
Commits
0
| https://github.com/nodejs/node/pull/34327/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34327/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34327/files |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 12, 2020 | https://github.com/nodejs/node/pull/34327#issue-655489834 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Jul 12, 2020 | https://github.com/nodejs/node/pull/34327#event-3537491894 |
| https://github.com/addaleax |
| addaleax | https://github.com/addaleax |
|
Jul 12, 2020
| https://github.com/nodejs/node/pull/34327#pullrequestreview-446916359 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34327/files |
| https://github.com/Trott |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34327 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 13, 2020 | https://github.com/nodejs/node/pull/34327#event-3537911829 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 13, 2020 | https://github.com/nodejs/node/pull/34327#issuecomment-657351855 |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
| https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15351/ | https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15351/ |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
| https://github.com/targos |
| targos | https://github.com/targos |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/34327#pullrequestreview-447153027 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34327/files |
| https://github.com/lpinca |
| lpinca | https://github.com/lpinca |
|
Jul 13, 2020
| https://github.com/nodejs/node/pull/34327#pullrequestreview-447479782 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34327/files |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34327#pullrequestreview-448147250 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34327/files |
| Trott | https://github.com/Trott |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-3b13032 |
|
| https://github.com/Trott |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/3b130327fa96cda42fed581df7c763acbf706a13 |
| 3b13032 | https://github.com/nodejs/node/commit/3b130327fa96cda42fed581df7c763acbf706a13 |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34327#issuecomment-658508684 |
| 3b13032 | https://github.com/nodejs/node/commit/3b130327fa96cda42fed581df7c763acbf706a13 |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| Jul 15, 2020 | https://github.com/nodejs/node/pull/34327#event-3546604023 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| force-pushed | https://github.com/nodejs/node/compare/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722..3b130327fa96cda42fed581df7c763acbf706a13 |
| d4f780c | https://github.com/nodejs/node/commit/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722 |
| 3b13032 | https://github.com/nodejs/node/commit/3b130327fa96cda42fed581df7c763acbf706a13 |
|
Compare
| https://github.com/nodejs/node/compare/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722..3b130327fa96cda42fed581df7c763acbf706a13 |
| July 15, 2020 02:29 | https://github.com/nodejs/node/pull/34327#event-3546604024 |
| https://github.com/Trott |
| Trott | https://github.com/Trott |
| July 15, 2020 02:29 | https://github.com/nodejs/node/pull/34327#event-3546604181 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-04a65d4 |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/04a65d4c0525b0f57da3c462fad9215d0eb76c13 |
| 04a65d4 | https://github.com/nodejs/node/commit/04a65d4c0525b0f57da3c462fad9215d0eb76c13 |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| https://github.com/MylesBorins |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 15, 2020
| https://github.com/nodejs/node/pull/34327#ref-pullrequest-656877627 |
|
v14.6.0 proposal
#34371
| https://github.com/nodejs/node/pull/34371 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 16, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-58dfeac |
|
| https://github.com/Trott |
|
| https://github.com/MylesBorins |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/58dfeac1338308b47d53b185fd311a364fca557a |
| 58dfeac | https://github.com/nodejs/node/commit/58dfeac1338308b47d53b185fd311a364fca557a |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| cjihrig | https://github.com/cjihrig |
|
Jul 23, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-c306b8d |
|
| https://github.com/Trott |
|
| https://github.com/cjihrig |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/c306b8d849c00bfd3fa63024f2db29f48de1c420 |
| c306b8d | https://github.com/nodejs/node/commit/c306b8d849c00bfd3fa63024f2db29f48de1c420 |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-a1ab020 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/a1ab02030a5660b41dc3e27fc5aa421b34b11acf |
| a1ab020 | https://github.com/nodejs/node/commit/a1ab02030a5660b41dc3e27fc5aa421b34b11acf |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34327#ref-commit-bd3cef7 |
|
| https://github.com/Trott |
|
| https://github.com/addaleax |
| test: use mustCall() in pummel test | https://github.com/nodejs/node/commit/bd3cef7e0fb0f72638a04e18c7cf9ae7e74f6c5b |
| bd3cef7 | https://github.com/nodejs/node/commit/bd3cef7e0fb0f72638a04e18c7cf9ae7e74f6c5b |
| #34327 | https://github.com/nodejs/node/pull/34327 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34327#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34327 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34327/files/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722 |
|
| https://github.com/addaleax |
|
addaleax
| https://github.com/addaleax |
|
| https://github.com/nodejs/node/pull/34327/files/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722 |
|
| https://github.com/lpinca |
|
lpinca
| https://github.com/lpinca |
|
| https://github.com/nodejs/node/pull/34327/files/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722 |
|
| https://github.com/targos |
|
targos
| https://github.com/targos |
|
| https://github.com/nodejs/node/pull/34327/files/d4f780c9c2451ee2ebe1ca1c3910ce209bef2722 |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
|
test
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest |
| Please reload this page | https://github.com/nodejs/node/pull/34327 |
|
| https://github.com/Trott |
|
| https://github.com/jasnell |
|
| https://github.com/addaleax |
|
| https://github.com/lpinca |
|
| https://github.com/targos |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |