| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6f57d261-ac4a-1d3f-dd49-7cbc09eb538b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EBF8:1EFC6:44EA35:60408C:696A7625 |
| html-safe-nonce | 0e3c3f05570331c9a7323445b1fa3f81a1e74d8c7abdbb061f71fe5a416ae1cf |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkY4OjFFRkM2OjQ0RUEzNTo2MDQwOEM6Njk2QTc2MjUiLCJ2aXNpdG9yX2lkIjoiNTQ1NTc2NzMyMjg3OTQ4OTU3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ba2cdbd8fe0570e61d2f10c4bc384ab60df9e6814c5cba2db6b4adf30dc69cbb |
| hovercard-subject-tag | pull_request:447909658 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34325/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/43bc2bbf2e13ced2d652caba40bfd35c1a4c4ea3d2386461ee0547eb25036936/nodejs/node/pull/34325 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43bc2bbf2e13ced2d652caba40bfd35c1a4c4ea3d2386461ee0547eb25036936/nodejs/node/pull/34325 |
| og:image:alt | Based on my understanding of FunctionTemplate::HasInstance, cons->HasInstance(ctx) should return false if ctx is not an object, and this should be functionally equivalent to the previous code.
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tniessen |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5b774e44f85c14a75886edd04ddda4e5a25ddebbb241bcbb590b08a3048730e8 |
| turbo-cache-control | no-preview |
| go-import | github.com/nodejs/node git https://github.com/nodejs/node.git |
| octolytics-dimension-user_id | 9950313 |
| octolytics-dimension-user_login | nodejs |
| octolytics-dimension-repository_id | 27193779 |
| octolytics-dimension-repository_nwo | nodejs/node |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 27193779 |
| octolytics-dimension-repository_network_root_nwo | nodejs/node |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cc5f4eee261b3601c1e98e217ceaf28508b9567e |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/nodejs/node/pull/34325#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34325 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34325 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode |
| Reload | https://github.com/nodejs/node/pull/34325 |
| Reload | https://github.com/nodejs/node/pull/34325 |
| Reload | https://github.com/nodejs/node/pull/34325 |
|
nodejs
| https://github.com/nodejs |
| node | https://github.com/nodejs/node |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
|
Notifications
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Fork
34.4k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Star
115k
| https://github.com/login?return_to=%2Fnodejs%2Fnode |
|
Code
| https://github.com/nodejs/node |
|
Issues
1.7k
| https://github.com/nodejs/node/issues |
|
Pull requests
695
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
3
| https://github.com/nodejs/node/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/nodejs/node/security |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
|
Insights
| https://github.com/nodejs/node/pulse |
|
Code
| https://github.com/nodejs/node |
|
Issues
| https://github.com/nodejs/node/issues |
|
Pull requests
| https://github.com/nodejs/node/pulls |
|
Actions
| https://github.com/nodejs/node/actions |
|
Projects
| https://github.com/nodejs/node/projects |
|
Security
| https://github.com/nodejs/node/security |
|
Insights
| https://github.com/nodejs/node/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/nodejs/node/pull/34325#issue-comment-box |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:src-refactor-certcbdone-to-avoid-goto | https://github.com/tniessen/node/tree/src-refactor-certcbdone-to-avoid-goto |
|
src: refactor CertCbDone to avoid goto statement
| https://github.com/nodejs/node/pull/34325#top |
| tniessen | https://github.com/tniessen |
| nodejs:master | https://github.com/nodejs/node/tree/master |
| tniessen:src-refactor-certcbdone-to-avoid-goto | https://github.com/tniessen/node/tree/src-refactor-certcbdone-to-avoid-goto |
|
Conversation
3
| https://github.com/nodejs/node/pull/34325 |
|
Commits
1
| https://github.com/nodejs/node/pull/34325/commits |
|
Checks
0
| https://github.com/nodejs/node/pull/34325/checks |
|
Files changed
| https://github.com/nodejs/node/pull/34325/files |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
| https://github.co/hiddenchars |
| https://github.com/nodejs/node/pull/{{ revealButtonHref }} |
|
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jul 12, 2020 | https://github.com/nodejs/node/pull/34325#issue-655413668 |
| commit guidelines | https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
|
| https://github.com/tniessen |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/pull/34325/commits/b4b208bb64326f989ee132504fabc5e4881e7001 |
| b4b208b | https://github.com/nodejs/node/pull/34325/commits/b4b208bb64326f989ee132504fabc5e4881e7001 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
| Jul 12, 2020 | https://github.com/nodejs/node/pull/34325#event-3537165015 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Jul 12, 2020 | https://github.com/nodejs/node/pull/34325#event-3537165071 |
| https://github.com/jasnell |
| jasnell | https://github.com/jasnell |
|
Jul 12, 2020
| https://github.com/nodejs/node/pull/34325#pullrequestreview-446905712 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34325/files/b4b208bb64326f989ee132504fabc5e4881e7001 |
| https://github.com/bnoordhuis |
| bnoordhuis | https://github.com/bnoordhuis |
|
Jul 14, 2020
| https://github.com/nodejs/node/pull/34325#pullrequestreview-447880056 |
|
View reviewed changes
| https://github.com/nodejs/node/pull/34325/files/b4b208bb64326f989ee132504fabc5e4881e7001 |
| bnoordhuis | https://github.com/bnoordhuis |
| https://github.com/nodejs/node/pull/34325#pullrequestreview-447880056 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
| https://github.com/nodejs-github-bot |
| nodejs-github-bot | https://github.com/nodejs-github-bot |
| Jul 17, 2020 | https://github.com/nodejs/node/pull/34325#issuecomment-660304018 |
| https://ci.nodejs.org/job/node-test-pull-request/32393/ | https://ci.nodejs.org/job/node-test-pull-request/32393/ |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 17, 2020 | https://github.com/nodejs/node/pull/34325#event-3559630282 |
| tniessen | https://github.com/tniessen |
|
Jul 19, 2020
| https://github.com/nodejs/node/pull/34325#ref-commit-a6ba8de |
|
| https://github.com/tniessen |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/commit/a6ba8deecf660e024b90123147019c2fd5728627 |
| a6ba8de | https://github.com/nodejs/node/commit/a6ba8deecf660e024b90123147019c2fd5728627 |
| #34325 | https://github.com/nodejs/node/pull/34325 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jul 19, 2020 | https://github.com/nodejs/node/pull/34325#issuecomment-660622701 |
| a6ba8de | https://github.com/nodejs/node/commit/a6ba8deecf660e024b90123147019c2fd5728627 |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
| Jul 19, 2020 | https://github.com/nodejs/node/pull/34325#event-3562384990 |
| https://github.com/tniessen |
| tniessen | https://github.com/tniessen |
|
author ready
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22 |
| Jul 19, 2020 | https://github.com/nodejs/node/pull/34325#event-3562385074 |
| cjihrig | https://github.com/cjihrig |
|
Jul 23, 2020
| https://github.com/nodejs/node/pull/34325#ref-commit-ed01db6 |
|
| https://github.com/tniessen |
|
| https://github.com/cjihrig |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/commit/ed01db6390bd7fd5490bc1b374a6111febec916b |
| ed01db6 | https://github.com/nodejs/node/commit/ed01db6390bd7fd5490bc1b374a6111febec916b |
| #34325 | https://github.com/nodejs/node/pull/34325 |
| MylesBorins | https://github.com/MylesBorins |
|
Jul 27, 2020
| https://github.com/nodejs/node/pull/34325#ref-commit-aef41e5 |
|
| https://github.com/tniessen |
|
| https://github.com/MylesBorins |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/commit/aef41e5b52692c846b47d00288b4a3aa1e1301db |
| aef41e5 | https://github.com/nodejs/node/commit/aef41e5b52692c846b47d00288b4a3aa1e1301db |
| #34325 | https://github.com/nodejs/node/pull/34325 |
| https://github.com/ruyadorno |
| ruyadorno | https://github.com/ruyadorno |
|
Jul 28, 2020
| https://github.com/nodejs/node/pull/34325#ref-pullrequest-667312866 |
|
v14.7.0 proposal
#34542
| https://github.com/nodejs/node/pull/34542 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34325#ref-commit-883f92b |
|
| https://github.com/tniessen |
|
| https://github.com/addaleax |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/commit/883f92b145de462b154692fc143fa12f1deef80f |
| 883f92b | https://github.com/nodejs/node/commit/883f92b145de462b154692fc143fa12f1deef80f |
| #34325 | https://github.com/nodejs/node/pull/34325 |
| addaleax | https://github.com/addaleax |
|
Sep 22, 2020
| https://github.com/nodejs/node/pull/34325#ref-commit-007b4c1 |
|
| https://github.com/tniessen |
|
| https://github.com/addaleax |
| src: refactor CertCbDone to avoid goto statement | https://github.com/nodejs/node/commit/007b4c1ac945a6a9a717b81a5d2ff5f1b3af3b34 |
| 007b4c1 | https://github.com/nodejs/node/commit/007b4c1ac945a6a9a717b81a5d2ff5f1b3af3b34 |
| #34325 | https://github.com/nodejs/node/pull/34325 |
| https://github.com/codebytere |
| codebytere | https://github.com/codebytere |
|
Sep 28, 2020
| https://github.com/nodejs/node/pull/34325#ref-pullrequest-710478439 |
|
v12.19.0 proposal
#35401
| https://github.com/nodejs/node/pull/35401 |
| https://github.com/mhdawson |
| mhdawson | https://github.com/mhdawson |
|
Jan 18, 2022
| https://github.com/nodejs/node/pull/34325#ref-issue-1082574196 |
|
pummel/test-worker-take-heapsnapshot - crash in debug mode on arm
#41204
| https://github.com/nodejs/node/issues/41204 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34325 |
|
| https://github.com/bnoordhuis |
|
bnoordhuis
| https://github.com/bnoordhuis |
|
| https://github.com/nodejs/node/pull/34325/files/b4b208bb64326f989ee132504fabc5e4881e7001 |
|
| https://github.com/jasnell |
|
jasnell
| https://github.com/jasnell |
|
| https://github.com/nodejs/node/pull/34325/files/b4b208bb64326f989ee132504fabc5e4881e7001 |
|
c++
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Ac%2B%2B |
|
crypto
| https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Acrypto |
| Please reload this page | https://github.com/nodejs/node/pull/34325 |
|
| https://github.com/tniessen |
|
| https://github.com/nodejs-github-bot |
|
| https://github.com/bnoordhuis |
|
| https://github.com/jasnell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |