René's URL Explorer Experiment


Title: test: fix flaky test-http2-reset-flood by Trott · Pull Request #34318 · nodejs/node · GitHub

Open Graph Title: test: fix flaky test-http2-reset-flood by Trott · Pull Request #34318 · nodejs/node

X Title: test: fix flaky test-http2-reset-flood by Trott · Pull Request #34318 · nodejs/node

Description: Set allowHalfOpen: true in the client. Fixes: #29802 Refs: #31806 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Open Graph Description: Set allowHalfOpen: true in the client. Fixes: #29802 Refs: #31806 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

X Description: Set allowHalfOpen: true in the client. Fixes: #29802 Refs: #31806 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines

Opengraph URL: https://github.com/nodejs/node/pull/34318

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5cfa0c3b-146d-0fb0-6812-57fce8ee3c38
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD18:21FEDA:E35011:139FF93:696A91A9
html-safe-nonce6910b4c6000389b1c5dc48d0344a70ba6f96c6c376e8d636913aa65834e5ff61
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDE4OjIxRkVEQTpFMzUwMTE6MTM5RkY5Mzo2OTZBOTFBOSIsInZpc2l0b3JfaWQiOiI0MDE0MjgzNDY5OTUxMTg1MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9666b21ebcea4b10e6b99cea8fcb1ea647b9f9b335bc908898569a8606c872be
hovercard-subject-tagpull_request:447838481
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34318/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2e07c8fc705a810707d038ce08c948f997773b216236f501aa524cab0cdff55a/nodejs/node/pull/34318
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e07c8fc705a810707d038ce08c948f997773b216236f501aa524cab0cdff55a/nodejs/node/pull/34318
og:image:altSet allowHalfOpen: true in the client. Fixes: #29802 Refs: #31806 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes commit message follows commit guidelines
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTrott
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34318#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34318
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34318
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34318
Reloadhttps://github.com/nodejs/node/pull/34318
Reloadhttps://github.com/nodejs/node/pull/34318
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34318
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 693 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34318
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34318#issue-comment-box
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-29802https://github.com/Trott/io.js/tree/fix-29802
test: fix flaky test-http2-reset-flood https://github.com/nodejs/node/pull/34318#top
Trotthttps://github.com/Trott
nodejs:masterhttps://github.com/nodejs/node/tree/master
Trott:fix-29802https://github.com/Trott/io.js/tree/fix-29802
Conversation 7 https://github.com/nodejs/node/pull/34318
Commits 2 https://github.com/nodejs/node/pull/34318/commits
Checks 0 https://github.com/nodejs/node/pull/34318/checks
Files changed https://github.com/nodejs/node/pull/34318/files
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 12, 2020https://github.com/nodejs/node/pull/34318#issue-655311563
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/Trott
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/pull/34318/commits/9e95a46aaa5838e33a916fd3ccc88a902dcc9019
9e95a46https://github.com/nodejs/node/pull/34318/commits/9e95a46aaa5838e33a916fd3ccc88a902dcc9019
nodejs#29802https://github.com/nodejs/node/issues/29802
nodejs#31806https://github.com/nodejs/node/pull/31806
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
Jul 12, 2020https://github.com/nodejs/node/pull/34318#event-3536733496
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 12, 2020https://github.com/nodejs/node/pull/34318#issuecomment-657160402
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://ci.nodejs.org/job/node-test-pull-request/32292/https://ci.nodejs.org/job/node-test-pull-request/32292/
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 12, 2020 https://github.com/nodejs/node/pull/34318#pullrequestreview-446839849
View reviewed changes https://github.com/nodejs/node/pull/34318/files/9e95a46aaa5838e33a916fd3ccc88a902dcc9019
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 12, 2020https://github.com/nodejs/node/pull/34318#issuecomment-657163842
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://ci.nodejs.org/job/node-stress-single-test/111/https://ci.nodejs.org/job/node-stress-single-test/111/
https://ci.nodejs.org/job/node-stress-single-test/112/https://ci.nodejs.org/job/node-stress-single-test/112/
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/Trott
fixup! test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/pull/34318/commits/a2457fecf482d7d420ef4f30c09856fc66d014ec
a2457fehttps://github.com/nodejs/node/pull/34318/commits/a2457fecf482d7d420ef4f30c09856fc66d014ec
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 12, 2020https://github.com/nodejs/node/pull/34318#issuecomment-657166006
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://ci.nodejs.org/job/node-test-pull-request/32295/https://ci.nodejs.org/job/node-test-pull-request/32295/
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/Trott
Trotthttps://github.com/Trott
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 12, 2020https://github.com/nodejs/node/pull/34318#event-3536804003
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 12, 2020https://github.com/nodejs/node/pull/34318#issuecomment-657204429
Please reload this pagehttps://github.com/nodejs/node/pull/34318
#31806https://github.com/nodejs/node/pull/31806
#31806https://github.com/nodejs/node/pull/31806
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/Trott
Trotthttps://github.com/Trott
Jul 14, 2020https://github.com/nodejs/node/pull/34318#issuecomment-657973475
#31806https://github.com/nodejs/node/pull/31806
#31806https://github.com/nodejs/node/pull/31806
@addaleaxhttps://github.com/addaleax
#31806 (comment)https://github.com/nodejs/node/pull/31806#discussion_r402431502
@ronaghttps://github.com/ronag
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 14, 2020https://github.com/nodejs/node/pull/34318#issuecomment-658043395
Please reload this pagehttps://github.com/nodejs/node/pull/34318
#31806https://github.com/nodejs/node/pull/31806
https://github.com/nodejs/node/pull/31806/files#r386140400https://github.com/nodejs/node/pull/31806/files#r386140400
#33137https://github.com/nodejs/node/pull/33137
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/ronag
ronaghttps://github.com/ronag
Jul 14, 2020 https://github.com/nodejs/node/pull/34318#pullrequestreview-447912233
View reviewed changes https://github.com/nodejs/node/pull/34318/files/a2457fecf482d7d420ef4f30c09856fc66d014ec
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2020https://github.com/nodejs/node/pull/34318#issuecomment-658172491
4195c31https://github.com/nodejs/node/commit/4195c31ecbb83f07d5a8bda579f13e139aface1a
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2020https://github.com/nodejs/node/pull/34318#event-3544109690
addaleaxhttps://github.com/addaleax
Jul 14, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-4195c31
https://github.com/Trott
https://github.com/addaleax
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/4195c31ecbb83f07d5a8bda579f13e139aface1a
4195c31https://github.com/nodejs/node/commit/4195c31ecbb83f07d5a8bda579f13e139aface1a
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-c72585b
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/c72585bdb812ebc84333662648fb85382e870cdc
c72585bhttps://github.com/nodejs/node/commit/c72585bdb812ebc84333662648fb85382e870cdc
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34318#ref-pullrequest-656877627
v14.6.0 proposal #34371 https://github.com/nodejs/node/pull/34371
MylesBorinshttps://github.com/MylesBorins
Jul 16, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-28ce378
https://github.com/Trott
https://github.com/MylesBorins
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/28ce378e176790f26a121cd72f8f37f50866132e
28ce378https://github.com/nodejs/node/commit/28ce378e176790f26a121cd72f8f37f50866132e
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
cjihrighttps://github.com/cjihrig
Jul 23, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-9fa53b3
https://github.com/Trott
https://github.com/cjihrig
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/9fa53b37ecbcec823f88b49e03228d97500a1b70
9fa53b3https://github.com/nodejs/node/commit/9fa53b37ecbcec823f88b49e03228d97500a1b70
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-de83997
https://github.com/Trott
https://github.com/addaleax
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/de83997716c3f18221cba58b77e68f125ab58d72
de83997https://github.com/nodejs/node/commit/de83997716c3f18221cba58b77e68f125ab58d72
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34318#ref-commit-9741510
https://github.com/Trott
https://github.com/addaleax
test: fix flaky test-http2-reset-floodhttps://github.com/nodejs/node/commit/97415103366a36e30bc50704ef98218f274b9afe
9741510https://github.com/nodejs/node/commit/97415103366a36e30bc50704ef98218f274b9afe
#29802https://github.com/nodejs/node/issues/29802
#31806https://github.com/nodejs/node/pull/31806
#34318https://github.com/nodejs/node/pull/34318
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34318#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/Trott
Trotthttps://github.com/Trott
April 14, 2022 11:29https://github.com/nodejs/node/pull/34318#event-6433877997
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34318
https://github.com/addaleax
addaleax https://github.com/addaleax
https://github.com/nodejs/node/pull/34318/files/9e95a46aaa5838e33a916fd3ccc88a902dcc9019
https://github.com/ronag
ronag https://github.com/ronag
https://github.com/nodejs/node/pull/34318/files/a2457fecf482d7d420ef4f30c09856fc66d014ec
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
test https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Atest
flaky test-http2-reset-flood https://github.com/nodejs/node/issues/29802
Please reload this pagehttps://github.com/nodejs/node/pull/34318
https://github.com/Trott
https://github.com/nodejs-github-bot
https://github.com/lpinca
https://github.com/ronag
https://github.com/addaleax
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.