René's URL Explorer Experiment


Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node · GitHub

Open Graph Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node

X Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node

Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [Symbol.toStringTag] manually, to make sure that multiple serialize-and-deserialize cycles keep giving the same result. Fixes: #34309 Checklist make -j4 test (UNIX), or vcbuild test (Windows) passes tests and/or benchmarks are included commit message follows commit guidelines

Open Graph Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...

X Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...

Opengraph URL: https://github.com/nodejs/node/pull/34310

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits/:range(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:c20e5d64-41ef-7160-cbdc-f520d681db30
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBAF6:23AEEA:69671:91165:6997673B
html-safe-nonce6e0fa8d38e647335c8079edfea9bd380ad604e1272862183e056d5b05fdbd701
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUY2OjIzQUVFQTo2OTY3MTo5MTE2NTo2OTk3NjczQiIsInZpc2l0b3JfaWQiOiI0NzcyMTAyMDc4MDQxOTA5MDUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac09ef37a2ab3485d4b849f56edbaf810c319d12d7f5497a4f00cbbf3f73ce5dc8
hovercard-subject-tagpull_request:447761697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
twitter:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/899444?s=400&v=4
og:image:altWe are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f6df5422af98e8455c055522f48ada1a19fab299cf47471bdd590f8b7291770
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9b5cbb0725d622d54f9a26cbf0adbfbe35459c44
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34310%2Fcommits%2Fa07959033ea9fce98a1d907108d448a841987421
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34310%2Fcommits%2Fa07959033ea9fce98a1d907108d448a841987421
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
Reloadhttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
Reloadhttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.8k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 116k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.8k https://github.com/nodejs/node/issues
Pull requests 712 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security 0 https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-nested-errorhttps://github.com/addaleax/node/tree/worker-nested-error
Conversation 2 https://github.com/nodejs/node/pull/34310
Commits 2 https://github.com/nodejs/node/pull/34310/commits
Checks 0 https://github.com/nodejs/node/pull/34310/checks
Files changed https://github.com/nodejs/node/pull/34310/files
Please reload this pagehttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
worker: fix nested uncaught exception handling https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#top
Show all changes 2 commits https://github.com/nodejs/node/pull/34310/files
a079590 worker: fix nested uncaught exception handling addaleax Jul 11, 2020 https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
ee7775a fixup! worker: fix nested uncaught exception handling addaleax Jul 11, 2020 https://github.com/nodejs/node/pull/34310/commits/ee7775abbf3500a7c519db588e59432e8e750091
Clear filters https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
Please reload this pagehttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
Please reload this pagehttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
error_serdes.js https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-422862af8223760a3284d136c6157a148262e34e8c3974e5a4dc61ff25cf32e8
test-error-serdes.js https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-454fa7fd092af38e05ffff8274d0388f3d9cf7cd9809fb47db4b0a73e11ecf31
test-worker-nested-uncaught.js https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-591a0c5e03e1cdc9745fa35ff45e8c936bf042d9248cbf5bedef511a55ea2b3d
Next https://github.com/nodejs/node/pull/34310/commits/ee7775abbf3500a7c519db588e59432e8e750091
#34309https://github.com/nodejs/node/issues/34309
Please reload this pagehttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
https://github.com/addaleax
addaleaxhttps://github.com/nodejs/node/commits?author=addaleax
lib/internal/error_serdes.jshttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-422862af8223760a3284d136c6157a148262e34e8c3974e5a4dc61ff25cf32e8
View file https://github.com/addaleax/node/blob/a07959033ea9fce98a1d907108d448a841987421/lib/internal/error_serdes.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34310/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-422862af8223760a3284d136c6157a148262e34e8c3974e5a4dc61ff25cf32e8
https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-422862af8223760a3284d136c6157a148262e34e8c3974e5a4dc61ff25cf32e8
test/parallel/test-error-serdes.jshttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-454fa7fd092af38e05ffff8274d0388f3d9cf7cd9809fb47db4b0a73e11ecf31
View file https://github.com/addaleax/node/blob/a07959033ea9fce98a1d907108d448a841987421/test/parallel/test-error-serdes.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34310/commits/{{ revealButtonHref }}
https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-454fa7fd092af38e05ffff8274d0388f3d9cf7cd9809fb47db4b0a73e11ecf31
https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-454fa7fd092af38e05ffff8274d0388f3d9cf7cd9809fb47db4b0a73e11ecf31
test/parallel/test-worker-nested-uncaught.jshttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421#diff-591a0c5e03e1cdc9745fa35ff45e8c936bf042d9248cbf5bedef511a55ea2b3d
View file https://github.com/addaleax/node/blob/a07959033ea9fce98a1d907108d448a841987421/test/parallel/test-worker-nested-uncaught.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/34310/commits/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.