René's URL Explorer Experiment


Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node · GitHub

Open Graph Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node

X Title: worker: fix nested uncaught exception handling by addaleax · Pull Request #34310 · nodejs/node

Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...

Open Graph Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...

X Description: We are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...

Opengraph URL: https://github.com/nodejs/node/pull/34310

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6654ec6f-eaed-8950-127c-1a6b4e5a8eb6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC680:220088:3DE7C3:5666A7:696A729C
html-safe-nonce4cacb64ca146f307ccdaf75f42fba14d97ac1394272c6c6b660c755d988a5d89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjgwOjIyMDA4ODozREU3QzM6NTY2NkE3OjY5NkE3MjlDIiwidmlzaXRvcl9pZCI6IjU0OTU3NjgxNDMwNDU4ODQ0NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbbbf76885f67422a4d4a70b43f66894725cb92be814ead841e7cca4f4d2bccb3
hovercard-subject-tagpull_request:447761697
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/nodejs/node/34310/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2b861be082d63c355df8f9673e3c772ccd1e4d005e3153724026774d1e285245/nodejs/node/pull/34310
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2b861be082d63c355df8f9673e3c772ccd1e4d005e3153724026774d1e285245/nodejs/node/pull/34310
og:image:altWe are using ObjectPrototypeToString() as a cross-context brand check for built-in errors, but weren’t making sure to set that when deserializing errors back into JS objects. Fix that by setting [S...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaddaleax
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
go-importgithub.com/nodejs/node git https://github.com/nodejs/node.git
octolytics-dimension-user_id9950313
octolytics-dimension-user_loginnodejs
octolytics-dimension-repository_id27193779
octolytics-dimension-repository_nwonodejs/node
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id27193779
octolytics-dimension-repository_network_root_nwonodejs/node
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/nodejs/node/pull/34310#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34310
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34310
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=nodejs%2Fnode
Reloadhttps://github.com/nodejs/node/pull/34310
Reloadhttps://github.com/nodejs/node/pull/34310
Reloadhttps://github.com/nodejs/node/pull/34310
nodejs https://github.com/nodejs
nodehttps://github.com/nodejs/node
Please reload this pagehttps://github.com/nodejs/node/pull/34310
Notifications https://github.com/login?return_to=%2Fnodejs%2Fnode
Fork 34.4k https://github.com/login?return_to=%2Fnodejs%2Fnode
Star 115k https://github.com/login?return_to=%2Fnodejs%2Fnode
Code https://github.com/nodejs/node
Issues 1.7k https://github.com/nodejs/node/issues
Pull requests 695 https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects 3 https://github.com/nodejs/node/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/nodejs/node/security
Please reload this pagehttps://github.com/nodejs/node/pull/34310
Insights https://github.com/nodejs/node/pulse
Code https://github.com/nodejs/node
Issues https://github.com/nodejs/node/issues
Pull requests https://github.com/nodejs/node/pulls
Actions https://github.com/nodejs/node/actions
Projects https://github.com/nodejs/node/projects
Security https://github.com/nodejs/node/security
Insights https://github.com/nodejs/node/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fnodejs%2Fnode%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/nodejs/node/pull/34310#issue-comment-box
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-nested-errorhttps://github.com/addaleax/node/tree/worker-nested-error
worker: fix nested uncaught exception handling https://github.com/nodejs/node/pull/34310#top
addaleaxhttps://github.com/addaleax
nodejs:masterhttps://github.com/nodejs/node/tree/master
addaleax:worker-nested-errorhttps://github.com/addaleax/node/tree/worker-nested-error
Conversation 2 https://github.com/nodejs/node/pull/34310
Commits 2 https://github.com/nodejs/node/pull/34310/commits
Checks 0 https://github.com/nodejs/node/pull/34310/checks
Files changed https://github.com/nodejs/node/pull/34310/files
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://github.co/hiddenchars
https://github.com/nodejs/node/pull/{{ revealButtonHref }}
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 11, 2020https://github.com/nodejs/node/pull/34310#issue-655199323
#34309https://github.com/nodejs/node/issues/34309
commit guidelineshttps://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://github.com/addaleax
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
a079590https://github.com/nodejs/node/pull/34310/commits/a07959033ea9fce98a1d907108d448a841987421
nodejs#34309https://github.com/nodejs/node/issues/34309
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Jul 11, 2020https://github.com/nodejs/node/pull/34310#event-3536252257
https://github.com/addaleax
fixup! worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/pull/34310/commits/ee7775abbf3500a7c519db588e59432e8e750091
ee7775ahttps://github.com/nodejs/node/pull/34310/commits/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/nodejs-github-bot
nodejs-github-bothttps://github.com/nodejs-github-bot
Jul 11, 2020https://github.com/nodejs/node/pull/34310#issuecomment-657056250
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://ci.nodejs.org/job/node-test-pull-request/32280/https://ci.nodejs.org/job/node-test-pull-request/32280/
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://github.com/lpinca
lpincahttps://github.com/lpinca
Jul 11, 2020 https://github.com/nodejs/node/pull/34310#pullrequestreview-446824980
View reviewed changes https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
Jul 12, 2020 https://github.com/nodejs/node/pull/34310#pullrequestreview-446851334
View reviewed changes https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/ZYSzys
ZYSzyshttps://github.com/ZYSzys
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
Jul 12, 2020https://github.com/nodejs/node/pull/34310#event-3536865818
https://github.com/targos
targoshttps://github.com/targos
Jul 12, 2020 https://github.com/nodejs/node/pull/34310#pullrequestreview-446852673
View reviewed changes https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/jasnell
jasnellhttps://github.com/jasnell
Jul 12, 2020 https://github.com/nodejs/node/pull/34310#pullrequestreview-446905522
View reviewed changes https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
addaleaxhttps://github.com/addaleax
Jul 14, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-1274f89
https://github.com/addaleax
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/1274f89b8c51c64fb6e8ac25d2498dd540fab472
1274f89https://github.com/nodejs/node/commit/1274f89b8c51c64fb6e8ac25d2498dd540fab472
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2020https://github.com/nodejs/node/pull/34310#issuecomment-658169254
1274f89https://github.com/nodejs/node/commit/1274f89b8c51c64fb6e8ac25d2498dd540fab472
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
Jul 14, 2020https://github.com/nodejs/node/pull/34310#event-3544084469
https://github.com/addaleax
addaleaxhttps://github.com/addaleax
July 14, 2020 13:09https://github.com/nodejs/node/pull/34310#event-3544085140
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-e1e277e
https://github.com/addaleax
https://github.com/MylesBorins
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/e1e277e93f383a2104253ef67a0c359ea72c461f
e1e277ehttps://github.com/nodejs/node/commit/e1e277e93f383a2104253ef67a0c359ea72c461f
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
Jul 14, 2020 https://github.com/nodejs/node/pull/34310#ref-pullrequest-656877627
v14.6.0 proposal #34371 https://github.com/nodejs/node/pull/34371
MylesBorinshttps://github.com/MylesBorins
Jul 16, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-1bc4def
https://github.com/addaleax
https://github.com/MylesBorins
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/1bc4def18ff7a3f7607a82c0193294382238b85c
1bc4defhttps://github.com/nodejs/node/commit/1bc4def18ff7a3f7607a82c0193294382238b85c
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
cjihrighttps://github.com/cjihrig
Jul 23, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-4d1b24e
https://github.com/addaleax
https://github.com/cjihrig
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/4d1b24e160b3b89e13fa8a31617559f08a1566e0
4d1b24ehttps://github.com/nodejs/node/commit/4d1b24e160b3b89e13fa8a31617559f08a1566e0
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-6150e3d
https://github.com/addaleax
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/6150e3d74a37b2b5191e1e632467b81c35822488
6150e3dhttps://github.com/nodejs/node/commit/6150e3d74a37b2b5191e1e632467b81c35822488
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
addaleaxhttps://github.com/addaleax
Sep 22, 2020 https://github.com/nodejs/node/pull/34310#ref-commit-c31b6bf
https://github.com/addaleax
worker: fix nested uncaught exception handlinghttps://github.com/nodejs/node/commit/c31b6bff3474756a952851fef710a88ce8d5311b
c31b6bfhttps://github.com/nodejs/node/commit/c31b6bff3474756a952851fef710a88ce8d5311b
#34309https://github.com/nodejs/node/issues/34309
#34310https://github.com/nodejs/node/pull/34310
https://github.com/codebytere
codebyterehttps://github.com/codebytere
Sep 28, 2020 https://github.com/nodejs/node/pull/34310#ref-pullrequest-710478439
v12.19.0 proposal #35401 https://github.com/nodejs/node/pull/35401
https://github.com/MylesBorins
MylesBorinshttps://github.com/MylesBorins
lts-watch-v12.x https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Alts-watch-v12.x
Nov 16, 2020https://github.com/nodejs/node/pull/34310#event-4000031116
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fnodejs%2Fnode%2Fpull%2F34310
https://github.com/jasnell
jasnell https://github.com/jasnell
https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/lpinca
lpinca https://github.com/lpinca
https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/targos
targos https://github.com/targos
https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
https://github.com/ZYSzys
ZYSzys https://github.com/ZYSzys
https://github.com/nodejs/node/pull/34310/files/ee7775abbf3500a7c519db588e59432e8e750091
author ready https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3A%22author%20ready%22
worker https://github.com/nodejs/node/issues?q=state%3Aopen%20label%3Aworker
Nested worker threads fail to produce meaningful error messages https://github.com/nodejs/node/issues/34309
Please reload this pagehttps://github.com/nodejs/node/pull/34310
https://github.com/addaleax
https://github.com/nodejs-github-bot
https://github.com/jasnell
https://github.com/lpinca
https://github.com/targos
https://github.com/ZYSzys
https://github.com/MylesBorins
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.